From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF8E5C7EE23 for ; Wed, 1 Mar 2023 23:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F0976B007B; Wed, 1 Mar 2023 18:40:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A04E6B007D; Wed, 1 Mar 2023 18:40:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A6E6B007E; Wed, 1 Mar 2023 18:40:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 237CE6B007B for ; Wed, 1 Mar 2023 18:40:03 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0282808E5 for ; Wed, 1 Mar 2023 23:40:02 +0000 (UTC) X-FDA: 80521949844.12.8D67672 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf21.hostedemail.com (Postfix) with ESMTP id 66D911C0007 for ; Wed, 1 Mar 2023 23:39:59 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xu31sNJq; spf=pass (imf21.hostedemail.com: domain of fenghua.yu@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=fenghua.yu@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677713999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5VYHiSI+fnpVDRUQ0LtVb5bZzNb69PcFBdseJiJ2Yso=; b=KZgYrA0ZGhxvTsVBptn/KMUuxDOSqJECwGF78IUUU9IHtZCtfsOW7BHdg4ezGzZqzBVlNa nB0fw2qc9AnlGUEzr1H5YRJLm8NTG+n5vvEp/X7qYe6On93jh9oPogF8cMnI8moq+J/Wcd /qybUP/m4+HBrz+uqjd6wK5S+3pgCv4= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xu31sNJq; spf=pass (imf21.hostedemail.com: domain of fenghua.yu@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=fenghua.yu@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677713999; a=rsa-sha256; cv=fail; b=Mgy4QKzXCM00fLJxZVr5MyqwitwA4yNdTwUiN2NCOuLNGjb95LN66sMAsvxIIy8AdR7joG LSMv0qoxh9rZaHug8JQjHRVgW7h60x3LzCp/w+3W4T3PKQs9dqjjHRwYcVJl55L/SZq5fS Tve8lzeo6giNYsoCBFLg+MUcTwPNR+Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677713999; x=1709249999; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=jQMbcOOczaimldzv0bgP1g0ikzQhDBIVGPrxh2EkH/o=; b=Xu31sNJqvj1rFExe0cvec/dQZ7EmylfgfB5SM4omPwTNmtf2SEKm9i00 owP3fwgz8kYczwSzvxoPW4eqQmEw4AtV8YxuNY2aeFeTPilRKTpjtYyeg NqkU3sYcg8F6sfYQeVg06pzpE5oabAXjRV7MCHVVyIhJmQnPRHfyX7qzR zIIFcm1sWtymv5wokPL6oeeIjLU8tpx2alFACiCtoYM106Ju6Kx3vd86n bHOThoFPU286g924sFOHQIk7IuFP09UoVy43ApnXqmCb4Wkpd8IrnrRvu bMQs9rDwoXXe2EdfIvsuIj5XWdIfYXr+ohrMFwPD7DfR781WZ6DgKfU5L w==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="333282723" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="333282723" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2023 15:39:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="784557786" X-IronPort-AV: E=Sophos;i="5.98,225,1673942400"; d="scan'208";a="784557786" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 01 Mar 2023 15:39:56 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 1 Mar 2023 15:39:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 1 Mar 2023 15:39:55 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Mar 2023 15:39:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQ5R5Ss33nrP+UtgyP15ov4hQ8wY9IMFVKBvs5cmDAQdXQZD3aEoctadP4tBnnIso8dPhkoLbM/GYqBpTM0vM96GKSQQAyMyvW0XmWd8csv7V4m/ZvzeKSaWIh2w7NQH8ChQ8cUBuJzhcLzAVo0RCDeYfsz2kchG7SGhHVBepV61KAzmIfkG94OTCzCCxPJ8LanX/dFygUBWog02XUV+GNNZ4vKYanlGDEyIOMgVxro1CXcstDGZ+x3gLLgencH3MnOt+CtFY6WD2wcooMeGgx6qNp+qP3XJtLOZnEJiFNhvQL4bVLv7LF9SzqiFWYcqNETMOQqKfqNcSlss3qA7wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5VYHiSI+fnpVDRUQ0LtVb5bZzNb69PcFBdseJiJ2Yso=; b=V0oCNLqnLxLgpWLnnUqXyEsgiVeB+w4Rxdto8+uDV8r9o6hsq5bxGqjiLltj9/7jE1y5Z/z9VjB5VwwlenzbqGq9Ik5y/BhNe+uJc3F3UCVCl7+enxJYRu9i+phOuGS9lLrCpAXFxZP96kUO6Dj51k8N2zblmPfiya6a8mZOuAVfTwFJqEjx3HJ9yvhqhEaByXDOXcOF3Ni7wdcNjaTIvHoZ3wXePFDfr0jv1JaNR9UEkWc0B+/G6TPW2R49P8zfnX3GwfkMWrQlunag+/sI/wXbCJyICak7KGjGle4IN4MAtilA7cnGkMbKx0RGhTruEpnHPwUteFpgo7TD/joryg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) by DM4PR11MB8227.namprd11.prod.outlook.com (2603:10b6:8:184::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17; Wed, 1 Mar 2023 23:39:53 +0000 Received: from IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::726b:a43a:2100:7171]) by IA1PR11MB6097.namprd11.prod.outlook.com ([fe80::726b:a43a:2100:7171%9]) with mapi id 15.20.6156.017; Wed, 1 Mar 2023 23:39:53 +0000 Message-ID: Date: Wed, 1 Mar 2023 15:39:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH 09/17] mm: export access_remote_vm() symbol Content-Language: en-US To: Christoph Hellwig , Lorenzo Stoakes CC: Vinod Koul , Dave Jiang , , Tony Zhu , Andrew Morton , References: <20230103163505.1569356-1-fenghua.yu@intel.com> <20230103163505.1569356-10-fenghua.yu@intel.com> From: Fenghua Yu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR06CA0003.namprd06.prod.outlook.com (2603:10b6:a03:d4::16) To IA1PR11MB6097.namprd11.prod.outlook.com (2603:10b6:208:3d7::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR11MB6097:EE_|DM4PR11MB8227:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fe3ef2d-a8af-4e88-7e84-08db1aae41d6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gIL99ogjHscR08sm01Se/ga3PLX7xXF7MGIhCs7XDTL1YihemldRyHDqpBnovwuvK205+1cvvG/v7DjgsPkaf8aiU2JrxFC9UTOXZZks94ACkS1o4q3n7hEMnnzFxB4UxzAc14rWsEtdoJPoXL8XBEdWvs5z6IBxfzIvK+tNQs7/ARZ6CBLRdZB79DIWE0m5N7QEWM8ofOpe5c8YKpb4wFgie9Ys4eiDzZlFOBGjGJBxncDy3hYyRsJG+NA1gitg8r2MtzynSAjIeoHFMuY5H/OzWRc3W9CnwuZiDdDc5YXrVKCW67+cP43n8S3tNrGo99gvTcpvPjWN5IneJszv6sW4FReOTAPoWb/Zfm1hYwrKZA593IBv546cK9kT4ok4CkMwuYx960ubz0Xo16LyJWeWHaZqrOA096N9nNf4c5rgSyfRrbjM/wDCmT/asSR2XdFS1R2j1vhoLlEiQjShkGgXEw5HMaiPmZ3e51sN5r5eP8t16Ny+OxljSaKgcLql73ywT1Nwoctm3ZcaejLnF9rxiTquW75mL4AEXa5tF9pM50xSeDFGUVx0R8bI0iTAuUCRtoXlETtoGDh9FNRagwkKAJxrLYQAbRi25+24hzbgUavmq9IXYPq6eTvoFvEWR5P6pYkoO+d790UPTP28FTWiNvoxn+RK5NTqmZ8nL/l292bloQD6hzmd/qDrYKCIWWboZIJ9PtZQvY6OqeQBDbEdxBjeaFZThu3/TxfwRoE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6097.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(376002)(346002)(39860400002)(366004)(396003)(451199018)(36756003)(31686004)(478600001)(5660300002)(186003)(26005)(6506007)(38100700002)(6512007)(53546011)(83380400001)(8936002)(6486002)(2906002)(54906003)(110136005)(44832011)(86362001)(41300700001)(316002)(31696002)(2616005)(66556008)(82960400001)(8676002)(66476007)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlNpVXg0djdtSmt6eG1QeG5VZXVQM3gxSzZKMExFQlMrRUU0WnhxN3lTSzll?= =?utf-8?B?eFZuK0hqUFgzNXcvUGpibHV6WC9EUWlxMDNjYk40bkF6QVd3K0Z4YWRpdnc4?= =?utf-8?B?anVSSDNibGhvM25OVkJyRlJKRjNVejU1OVB4ZTNPY3ZlZlkrWWQ3czFDa1R4?= =?utf-8?B?VWp4eFdPQ3AxK1FydjIrZUgrWVBoWTFpeWVWUlV3MGovc2RZWkUrV0t5Vjgw?= =?utf-8?B?UitoUm85WXkzM1VqN3prWVkySDBwZENYQW1ubVRPN0o0eFYrMGdCOWRiS3Jy?= =?utf-8?B?SGRrVmdGazcrSjdmQUNTWUUyT0MyVE9UWDNUcE52eWtjUUdzSTZSOWFpRlZo?= =?utf-8?B?UTl0Z3ZTcVN5ZjIvbmdrbEREaDFsLzFBR2RqTDg4VDRGOG1BSXUyT2hvQzFk?= =?utf-8?B?bUw0U0pPaHRCV2JpbjNGMGFUOXk1ak1FNHIyMitxeWFncUZQSTV1MnIvOVF3?= =?utf-8?B?WkJPdnA0S3FsaitJMFAyRXU3ZkdwOVBORFl5cHY3a1ZCK2tIcWRSczhQMm9w?= =?utf-8?B?clN3cWJpenkrc2VVZm9VM3NXRVU1SE5lQ1dQQWE0YnJaQkEwZERxSmwvd3pR?= =?utf-8?B?cEp3RGJuM0Nwc3VXTWU5b2Z4aFV2aTZIenhud2YvTE1LNG5UQ2RlMzBlZHpS?= =?utf-8?B?cWxHdlh6dW9nVWZCd1dlV0tDa0FDekE1cS9MK25acGxMT3F5cHJMOW5mNW03?= =?utf-8?B?NmFIUHl4L2VZUlBaSGVBdDc0K3QwOEFmbWF0ZlFFZG80dS9iM0JUNEJqc0pl?= =?utf-8?B?NFJ6UjRLam13cVVJaTdqYmc1US83NFhEZndUK1dNZXQ5elNHei9pZ1ZvVy9P?= =?utf-8?B?cjRwTlllb0tEZ1pSU1NoUWx1bi9jbE1DRHg4Nnd2U2REYXp1YWNPOWhUbVg2?= =?utf-8?B?cnhBSDhzTWthR1RzUFZTZEhSNHU4eVl4b1hHYmFTalR2RG9oTWY1dXAveU9u?= =?utf-8?B?ekIwRGJpNFlWVG9aUVFPOWQvL1doU01oK0ZNbXVSR3VZeHJVdkVTRUprVFk0?= =?utf-8?B?MVZpam9VL1hJSVlwd0w1bitjaTVjYU4rS0NGYUJpOEdHVTRZQUtXRWYzUTdX?= =?utf-8?B?ck4vVU5ja2kxRWJUZXg5amwyOXlrOGw4SFQxenZnSHE1c1I4KzF5eUl4TE9P?= =?utf-8?B?TEdMNGJoUTRJREc0bkNSNVVXS0ZTZHBjbVNsZ1dtd1lDaFpIMG9BdkppRUV5?= =?utf-8?B?ZE01UGJGWktlUzJlNEZHVjM1c2pqMjNUVUhKS2FvK1hPa2tNWUlxbmtQa2RT?= =?utf-8?B?MzhiOWJzN0IrU0lQTEZ6UWlkR3BNdmlZbStZb2xxZTEzWldyN3VwbG5JeFcz?= =?utf-8?B?YmtKazZ5MDZBTVNtWCtkdUJOQXJvdHdlVmUyZXRnQk5CZVBmZFJ2cmFZYzVr?= =?utf-8?B?Zk93R3VqVUZ5Y1ZmRDNQTE5HU05SalRUTC8rMGozcEs3UmdZdWpQYTdzZXlC?= =?utf-8?B?S3YyV3ZoU2NlQUhMWlpWTzFoRlo5TzJMRDcvY3dUZVNjSWdDdGx3Rk12S1ZR?= =?utf-8?B?dkVHbWl1YU1Vdy90Sms4ZiswaUpjR01UcVA4ZFRhcThTODJKUnNKTFJwNFhT?= =?utf-8?B?OTd3SWtGZVgvbnFNYW5FWnRqNHdvL0c4Vk9vd0FsYU1Xdmc3YVlHalVBMjdM?= =?utf-8?B?NzNKSkltOG94NmtTUU85S0ovSVJ2RVFWK1k2dnFYdHBFMHJEaGM3bnB4RCtH?= =?utf-8?B?b0xlUTRBUEN0SzAwTlhMTzVVTWhLb1kyUDA0TC9PNlMvL2orR0FMa2YvNjZT?= =?utf-8?B?MXNOZGwzWDRUNlBFM2ZYblNlTVV5R1lpZTRTTGxiREI5RlVYZzIremRyMVJ0?= =?utf-8?B?VVdJR2k5L3RmWEtZbHJqY2RTVE9hMDdITEdHTHdYV2FzRmc1ZmFWZ2drMy8y?= =?utf-8?B?WjJ2TXlMUGIwa2FtWnBoeVRmVmx0V01sMmtLVmhobDg3dy9vU0o1NU8zZjcy?= =?utf-8?B?RHFtaCs1c0FJYnZWSFN2L21ERGJRczFETUtYQ2JlQndzTlVFWHp1aDY3MVNu?= =?utf-8?B?UWt0RVNGZWk1bms0VnB4ckYyYVlwbDN6a0hBWEowc3NKVlBwV2JjdHE1RXVs?= =?utf-8?B?SndqRWhQanh0UlpCNEhKSnl3b2dZTk5zdE0vZWtSK1RlUk9wWUxNSHFhaVA3?= =?utf-8?Q?E1HN5jlaHnydqlBlI6rH3q6tv?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5fe3ef2d-a8af-4e88-7e84-08db1aae41d6 X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2023 23:39:53.6295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fKlgog1s+ngflLW0L9UvVHHLN8E70UGzLKNIn5GD+2wgCmOjkNuRVMLcipNAD5wZUcskD10o8aY+JVSHdhV6Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8227 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 66D911C0007 X-Stat-Signature: qjfr6cyb7expymh8qi5sb5f33ukka5ps X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677713999-824994 X-HE-Meta: U2FsdGVkX1+sa277nklL3PLuqvb1ja/9aRXoWr3t9lqlWUAgARKCnNoeINvp7i2cVpDLKipeIVBav5hX6CJyqBgnMn8Wbpk7hWDC21LfP0DclsNbhQEG7lEvrJrMNtbCXPhOkhnwDmMDXvKrTdvuitL2haS7+9Rle7bhKt6c6+xKMB9remb6P7N4t+KYb8C6kr4SncXnAa9W1fE1RBZ/9xypyIBibrIQo58AijqGrJ6+FC9/k9MhO8YAqQ70Fpdm7LBS7AFRdgubbFwS0gL0FI+QJh1sF9FXZ9R9veFPnJtQuzS9zlKaR/OpXcpDX1dfSWG++ONsSFFFxsR6hlJ+MYPamkFdcu4TwaQIdKSk1uQxgrq9p5k1Zykar4qnX+14xz2By/BPAwOaCDysPcG6Cw/wWADVIo0l2bVlJ7rPXNU2rTUCDY52IxNlpJ6tIzhLqIGb8GtR2/n3oB4NTjGQHpP9hnpwNzV47jLXBwmWRqfZbd7HDsJ7dS5HJUmGQ238sc9QWiJ3VpbGKeioBAT8Ov7OYu3p+jTsDP2d2xBwfYqQmsU+uSml00ALbGdeCgsLXk+ROcRZ1nhvYblQW+FCmLBVFjpPYzYDC/vrR+xe8IA0dlVjh8c+um3josBEFBhAXUI/JiTfxNxZ6pN4bnlqlq7vok0JDe+ALVbFnmtAbQ3PlqryCWYpKA3K7QnvLxtlm2MEAZbIdvTjGBMh9IYoH2JoGJMiN2k7wU3KSPksWd//Kwnpl008Hz9PPqAhOMWlijBvOo8+o8olnPr2++YBbJsY/b3kMPOvhUJpWuuV0eyRLGZeG08KQWP9+HLUZnri/lwZarwnf8APQ/tMAhkgdFyXNzh2FGGyfIf9S7wSWsr9LG9UcAeQl1eZ0Gg6Txf0ZsAINvRdDnnkQCPSbGteUIjBDmzbR9HjOh+gjd1q4LZ28ZLn5p1JLNE4+ISO1BCSDp+ZpIz2C1+h9GxQP3C VV9/V0ps RxbRdi0sgtPaCyiamuKANOCm4zxMcz9xzJ5agU/PDEUAyz3Jbo7nkTKxnPqo5OrDC4/MycrzszzvLUeEJbw/UY8w1bTl61NDSZuDh7azyykRg0Pbui2o2d8WCsBd3vYJHq8i5a/YTkRQwzV92Wj/9d2FLMnIUvWRk1ZVMdxQ6cuyC3oUqwYSt3k5hqfX75lZ4X0P0sGWkFQkCKKtRkncidwWf90xrRAXUcps99/CMRY+aPGkyZo9RaSVb5wqDhJ/MXkEHQjGjcFmxPZXeXvWnaxkTnlY+XIZ8w0stj9cXv1S0/vV98oEtdL0wAuHAL+OJtOpbhTDMKUBrYuBABukMh6mPUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Christoph, On 1/8/23 09:36, Christoph Hellwig wrote: > Exporting access_remote_vm just seems like a horrible idea. > > If a driver needs to access a different VM from a completion path > in some thread or workqueue (which I assume this does, if not please > explain the use case), it should use kthread_use_mm to associate the > mm struct and then just use all the normal uaccess helpers. To trigger fault by IDXD device, user app frees the fault_addr pages. After kthread_use_mm(), the IDXD driver cannot directly call copy_to_user() to copy data to fault_addr because the pages are freed by the app. If the IDXD driver tries to copy to the app's fault_addr, it needs to get all the pages, kmap, copy_to_user_page() etc, basically majority of the __access_remote_vm() code. Without exporting access_remote_vm(), the driver has to re-implement the function for the copy to work in IDXD driver. Maybe a simple exported IOMMU wrapper in iommu-sva.c can help here? CONFIG_IOMMU_SVA is bool and needs to be set for Event Log to work. So the wrapper is exported and can be called the IDXD driver or any driver that is on top of IOMMU SVA. No need to export access_remote_vm() any more. Plus with this wrapper, no need to export iommu_sva_find() (in an earlier patch). So the code will be more clean and concise. Is this OK for you? struct mm_struct *iommu_access_remote_vm(ioasid_t pasid, unsigned long addr, void *buf, int len, unsigned int gup_flags, int *copied) { struct mm_struct *mm; mm = iommu_sva_find(pasid); if (!IS_ERR_OR_NULL(mm)) { /* A reference on @mm has been held. */ *copied = access_remote_vm(mm, addr, buf, len, gup_flags); } return mm; } EXPORT_SYMBOL_GPL(iommu_access_remote_vm); Thanks. -Fenghua