From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72139C0219B for ; Tue, 11 Feb 2025 21:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0681E6B0089; Tue, 11 Feb 2025 16:05:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0181C6B008A; Tue, 11 Feb 2025 16:05:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD3936B008C; Tue, 11 Feb 2025 16:05:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BFC576B0089 for ; Tue, 11 Feb 2025 16:05:40 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0C7A3160B90 for ; Tue, 11 Feb 2025 21:05:40 +0000 (UTC) X-FDA: 83108895240.21.D432313 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 4BC244000F for ; Tue, 11 Feb 2025 21:05:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZvH5TVfW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GiUZr91; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZvH5TVfW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GiUZr91; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739307937; a=rsa-sha256; cv=none; b=thhWWL++HZAeGl7SEAcSR/IGwiXkE2MPy42dSCq5kYIq/+5na0IxO7wi3F1sc+/0ICHAgR oZVDEzwU3eic7gqXzbAqWcq0KzkxW3jlb0k1F98XwAYDSLN7DUybeArkLfyyaDPZYqyR2u poRKJ19eq+dBZ8mF8vOZG+ZfdAH7ll4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZvH5TVfW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GiUZr91; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZvH5TVfW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7GiUZr91; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739307937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eGkjhN3MBwTx2StxmE6SGYiolZAAi7amt0Bxrm1itoU=; b=f+jthrmQMnnhqn5ydmN8+C+rx3+yWWLFtdw1QDZ3r+nJttkUvfFcQuBcbztpb83gy+8v3P gF4QovA3psahWWEypX8aPNkQhcuhKb/MFjL3GWnmo1xhJBjIc0+6zF5xz6eDkUkCGE9ZsX A9uETDTev+/6kLQsiVm3RLjYmLhzF40= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3C61A1F74C; Tue, 11 Feb 2025 21:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739307935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eGkjhN3MBwTx2StxmE6SGYiolZAAi7amt0Bxrm1itoU=; b=ZvH5TVfWFD9cA4gl2oQ/vr0/J9akUU0jpG8YLOMjdfu5dj0ca/w5UP2CnpjIzR9pwQmHGB FUANT/OS9b0pSIEjtMWYVGoaLd03P2Xy0yK9HQd3z+6IfxaWNdeIPcB/VVMjXw+HJCqh/p Fhb9xP7vQxQEKFVhuP/KBo6dk757i+E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739307935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eGkjhN3MBwTx2StxmE6SGYiolZAAi7amt0Bxrm1itoU=; b=7GiUZr91fPEu8+TEf4hJrCqmzNmK3Ip1iiwuYKWDdVtrPNaryyu51LKKQYyLfnXsF/SBLY 9GMUqNaJSsBff5Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1739307935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eGkjhN3MBwTx2StxmE6SGYiolZAAi7amt0Bxrm1itoU=; b=ZvH5TVfWFD9cA4gl2oQ/vr0/J9akUU0jpG8YLOMjdfu5dj0ca/w5UP2CnpjIzR9pwQmHGB FUANT/OS9b0pSIEjtMWYVGoaLd03P2Xy0yK9HQd3z+6IfxaWNdeIPcB/VVMjXw+HJCqh/p Fhb9xP7vQxQEKFVhuP/KBo6dk757i+E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1739307935; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eGkjhN3MBwTx2StxmE6SGYiolZAAi7amt0Bxrm1itoU=; b=7GiUZr91fPEu8+TEf4hJrCqmzNmK3Ip1iiwuYKWDdVtrPNaryyu51LKKQYyLfnXsF/SBLY 9GMUqNaJSsBff5Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29F6D13782; Tue, 11 Feb 2025 21:05:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TfnuCZ+7q2fmTAAAD6G6ig (envelope-from ); Tue, 11 Feb 2025 21:05:35 +0000 Message-ID: Date: Tue, 11 Feb 2025 22:05:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmstat: Revert "fix a W=1 clang compiler warning" Content-Language: en-US To: Bart Van Assche , Andrew Morton Cc: linux-mm@kvack.org, Matthew Wilcox , Ivan Shapovalov , David Laight , Nathan Chancellor References: <20250211205911.1707684-1-bvanassche@acm.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250211205911.1707684-1-bvanassche@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 4BC244000F X-Rspamd-Server: rspam12 X-Stat-Signature: q3uquuhze7fssz1wxkfqjg3cucn7cyq5 X-HE-Tag: 1739307937-573672 X-HE-Meta: U2FsdGVkX18quFESnIAhBVgtAuKKZNNaqH5PIMnHSMbNqSfHKtUw1+p/pL8+h/EyfgngkPi1YlY5J7HYNL1zIuvzHkr+N+vnwZjYm+VrIkhmN3E0ks039IpeMV0fmoOpDvx4wQKY1SsY002lmqCWrfUEf3WkKUnxVHUbl+OCVv7L4WFwHvP9rEgzv4x2jnXtEALtvXVjTdo6mwxSYos/X3KK3Yju/UrgYySo0r78Fmei/5Sy/a1HfDf9TSzKoEoigubw4Q9oHQd5KTX4Qzz+L13gCRG5zcbIfo7JZJFvAaXlGVVkWMEZdp0WnIMv1DdbppaLRxUwCzGw/ZuphKFFztbzsKhKhtwBGIzDDIUDoRmp6cAFTSoyCpKS+jPotddA3jiSAEgezKY0Qaf18awSMi5o5+EdHNQAaJ3ohVnoDffnRq1XFVI1ipqohthD76T0iH9V4VFZq1R5dWkaE1HIUSMkCsR0pmQ9N289wlQkWBn5pNkDif7hdPijINeFBYbUoo5SLe3f1xyjwuKUHGUVEdFgLQmTU9caBK6/D6nWFIZKA2M8wBvy9jkzHg6zE/IcsC0sC/eBlXmfjAkBj//RUAArlxcLNw/ryIBDV8vC2oUTiZvuT7bjOA7mov/sfIBmjAZlG+ixwUAsDXioV/VON+wrs1n5DIphn8jZ1zMG4klFsM/nlzbEP2zqZv66JHIcYfmTsfPZyqHl0bak6MDqqK+ugpauzFySvaqFNx6hpH9+5u20ziBsWKsBcvhZrd9TQ8FMaQLvO97XEfLIrA4dDsF0NNxc/o4XewqrGm07uucGvFisMsp+t7EMhlv0/nfcZEoYtSpWQpRtmT0NeSKDnz6bnHCyoHD5TTlnJsT03yft4/WFqIClKlzqPzmELid7UuUV1jxaa2QP+pFxmgBdAW7gS33My7+BS0TxlpRdYZpVUGC/J50iCZO5xlUx4Az4q/yCPQeJ7T+SHHUhUwz m6OKoXmX qJwTKs5lbk7NNVCyI5N2aQ0NopoPNRm9cf/1x5txrKGADiQygS+lRzbamwJE/vFeSn824IYZD/ZXH9DB6YnaJHov789ut2UMMNdlTY8g4T+0a/LVbw0ESWtQKffC9xa2hEfu7ho9nynT7xAnlZODLXOshgsaGJqSre9GZpmI1mw+wF2LfgsIYaGyt0e5uCuBIZsF3XgoYWyKUl/7BZlrTTr2eP9ZOUzr49GX5BKtQIHnvV0iLHmDbZ/VbDg8QRGu2nvuMbO8Nv3CmqaBGzMHXsAWEhjziKZtPKNSOVf5ob7brKqL77LaQTBtByXPZIjeVRi620np6ECrLVq2B7zQYy2JXg280W4lzh11JPrac6d8h+ue5kV8jt4/t5B+C3Xsav0+Ek11Dnmk1JUZ+HgSxKPzhym2M91Vfgg48VZmEizpeYc1PigALLArAUtk3v1n1nALhgFi8nKKmkWONl5+9mwICncwHE26NZLQ3Tg1PXimp5UdE99fiDkKLHy2n21aVn482FYFZASuWVeCQ24w2MJQqhYaVdonsYCnqsS21qsN2BiMu7U4cIa2h5H0WppSbsHKm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/11/25 21:59, Bart Van Assche wrote: > Commit 75b5ab134bb5 enabled -Wenum-enum-conversion in W=1 builds. Commit > 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") fixed a > -Wenum-enum-conversion warning. We could expand? ... warning related to enum node_stat_item, but not all of them. > Commit 8f6629c004b1 removed the > -Wenum-enum-conversion option again from W=1 builds. Since the W=1 compiler > warning fix is no longer necessary, revert it. no longer necessary and incomplete anyway, > Cc: Vlastimil Babka > Cc: Matthew Wilcox > CC: Andrew Morton > Cc: linux-mm@kvack.org > Cc: Ivan Shapovalov > Cc: David Laight > Cc: Nathan Chancellor > Signed-off-by: Bart Van Assche Acked-by: Vlastimil Babka Thanks! > --- > include/linux/vmstat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 9f3a04345b86..d2761bf8ff32 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -515,7 +515,7 @@ static inline const char *node_stat_name(enum node_stat_item item) > > static inline const char *lru_list_name(enum lru_list lru) > { > - return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_" > + return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" > } > > #if defined(CONFIG_VM_EVENT_COUNTERS) || defined(CONFIG_MEMCG)