From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FEDCD1288 for ; Sat, 30 Mar 2024 21:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E1DB6B0088; Sat, 30 Mar 2024 17:31:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66B9E6B0089; Sat, 30 Mar 2024 17:31:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BD036B008A; Sat, 30 Mar 2024 17:31:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2D0E86B0088 for ; Sat, 30 Mar 2024 17:31:57 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C04951201F3 for ; Sat, 30 Mar 2024 21:31:56 +0000 (UTC) X-FDA: 81955003032.13.45852CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 91E2214000A for ; Sat, 30 Mar 2024 21:31:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=edl35z9B; spf=pass (imf26.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711834314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Lxl+j+xR8FWVtx6+a/UxVWMhMmDhnJi8YYlIddCdSo=; b=hqvQR09ViPdbYwgthCrEGrVyywJb/3tPDMedOkpnBxH/mdrlOyIhuL/dPlMDGjVDyTk+I6 0DScS6xLuVDtxCLDRsPFs73mGV2XrADJ6yt8JJ6uYKmdPThp0SioykvplyacDGzHYooSIh iyBO6VPYb+Az08WQTg+Aijf3zgPMMIA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711834314; a=rsa-sha256; cv=none; b=Z8f+J6UgZiDubBCFElxFmpLcY+5jMhCUwYoT2Sib+JTNTV4M2vQlbvpx3aA2IMtLs89LTM mGGl9IIvLu3G9L1VK+pbFo3RuwumDqu5VHeBSuRxwBhCcn7wsFckPymndcxMsVfC4pDGdq P8LjBfXQRUlPMMv7zTfH7zZyRNLTMcU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=edl35z9B; spf=pass (imf26.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711834313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2Lxl+j+xR8FWVtx6+a/UxVWMhMmDhnJi8YYlIddCdSo=; b=edl35z9BPmJeVyfZue1DBgASBuJwOLiOFe38iSAg3czBXAE1pMtMh9BlYE5AQtD6STQIS0 wok+P2jmy3CzbzdFwx1Zv4ThEy1G1K7H9WTPFgpvl6jLovXeYj89p6/1Y9IOqUWPyaSkpR QPqnhGKuj4lhUTNKIWo2ftLdwiMmoso= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-204-9ldLO4j-PKq3oPC1l4flDw-1; Sat, 30 Mar 2024 17:31:52 -0400 X-MC-Unique: 9ldLO4j-PKq3oPC1l4flDw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a4747f29e19so79026566b.1 for ; Sat, 30 Mar 2024 14:31:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711834311; x=1712439111; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Lxl+j+xR8FWVtx6+a/UxVWMhMmDhnJi8YYlIddCdSo=; b=IL2Eqbn08qGCsuTu4nPb47veTUziXiv66p4Zt0fk/S5Gp1Tq3PuHbwlBJUu2iWQ33/ F2BjwYoA/Kgd2VxteW9vIvFDGTAsTEw74FGex5siJd6LLWpF9KxIIJXHTRuzJgmlaFDZ oZQcC2U54421pJj9Z2AtmiVM7FPdVS2yWUHCoUGz0//yP8zJd7hiyiVUso4jOenxU++0 jzkPx1YfWyzXDZRC5BoVpfzO/OFdt/xEjq7nttFYMlIpJnpTlPrTXmefXjNDTJaJ9id/ uIkjcN926BdDCAgdNSGSIKY6XDGWj7MA2YSu7e7D25VWqvoDNH+aL+J/BhqXvaF1/9K1 +M6Q== X-Forwarded-Encrypted: i=1; AJvYcCX/CSdSKpPq0uDmYD7kAeu7k2j0nCZeOdGVQeQ9iAU2Di7pW4omCCoYCBFU/rsluSiGBf3qGUH9du1ap6tpeWPRG4E= X-Gm-Message-State: AOJu0YxTzxALuFVe3j3JvN8IBUGJ78Qv3PMXkAUgz9wGc0uoWdYsSKbU Kqafffa4OpAMGBOFVvKfBa5BaxBJ/qqDX5VgvH2ui7HS30/doadN1JP/HDVuTcUFIuMUmpTJrmy RZoq0C+Nu1IBEY7S7UbidaTVREkti9LAS9WshB49dv4f8I6zn X-Received: by 2002:a17:907:9693:b0:a4e:17c5:9944 with SMTP id hd19-20020a170907969300b00a4e17c59944mr4619541ejc.61.1711834311171; Sat, 30 Mar 2024 14:31:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH4ZTkjUa1qAw9ZLrLn5Cmk/KIYm4xouooLm1o+DG2vC/bIdk1gQWLiRdSLYKS8JVSoO2kgWw== X-Received: by 2002:a17:907:9693:b0:a4e:17c5:9944 with SMTP id hd19-20020a170907969300b00a4e17c59944mr4619522ejc.61.1711834310761; Sat, 30 Mar 2024 14:31:50 -0700 (PDT) Received: from [192.168.10.4] ([151.95.49.219]) by smtp.googlemail.com with ESMTPSA id h19-20020a1709060f5300b00a4e30ff4cbcsm2438004ejj.194.2024.03.30.14.31.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 14:31:50 -0700 (PDT) Message-ID: Date: Sat, 30 Mar 2024 22:31:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 22/29] KVM: SEV: Implement gmem hook for invalidating private pages To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com References: <20240329225835.400662-1-michael.roth@amd.com> <20240329225835.400662-23-michael.roth@amd.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20240329225835.400662-23-michael.roth@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 91E2214000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: iudxzmsj1y3yo7gwfzyhw8b5qtg8oytz X-HE-Tag: 1711834314-142027 X-HE-Meta: U2FsdGVkX1/58bSo0CWGDv47ERqKl7gSKtAbGNsPxvJm9FkbpWO0pmRqxed3LLLq57Es78h6sl7WbJMZBIsAcrOCpssBizghswlB6JQz8hzAC9ZO2VFR3rc/txJaWEorvauZe1p/oVx6GVi0X3U6Ursqslx0JuQxe6yBe4bWEteOf0oTFUy5o99l8Lc7LIZzjOGY1WzPOT02garZr5CgzVtH1gOKYE45D8Qa+Pix9bvhwSAEirYpdGpxRTa4oYj3LUZo4h3pbB6jzHWiPTK35w6k6mb6RM1FOJMaMba+SbC7Q9Gx0cfDsRvgS/ZXyB0cYTLLcRLeYKL1uzAh2e++4m3/LmoZm5F+GAgzJkT4JJcphEsUsRDJ9Rh1fa4K1qlKpb5xw+RwbImrJrfuA6VIDyOsW8RqsHJy1xm+CoOxrxlab+TblXKMtqgYm9JmLqp5V8XAtweHdEbiqz9kLFmJV/NVx6AbsUu8OPi/9lHYaK6MRwDNzvHmdVjPR3w1K+G7LVQ7m73kl76212gvkovwWv8Mx4zUJA/AqEsG3clAaSzHorRQVFnb93SA7aW2SKsDG4yZbX+wf9yQN+XFXuXtTm/y1hTj5usweKTJyrqHc7qJVOgqD/Ynw5fAQr1RnpaNuhbli8PKXW1C74Fw5jWeWldWEYqQ830y8RfVFj8vG12LRCMZWrsCEj9MuubdWF1kmRoXpEpsG4j5Wly6jtJ/+UWGOvrzYKUp2tzRvJI1EH9u4oJMIzAvtKpzgtX/47/gKg+JpXFEp8JuiIw+Qrx+NJPz+Q/qy9ppac6bSIlFSgo/YNbnVkBpU92/A+JwyUgvPS2QfSytfg/dzyyEHxkvlKbm2iiEmuXAbmi4+BL+iJVFvSfikHpO55GaTCIExQCwlJKfyk1gfRMWy4A08N5VowanGFOjGRyN53UawdkBwruvCnl876NU93sISYgiUcZscpQJEUv1/LZu20DOX2l QophcKCE xke2sjpnrsSgX/ClCw+z2VI9wUkxFPrWaasLJEwfI0zN2JV3p0lov6AHJLgehiEOz9CacyuMwTWgprCqedXGdRRe324sh+o5UVN+xHV8TBGDP0Ae2dHJbw2Tlye5OZ8ekfxNuvbld695+UDVzUfEa0erHozYCoycLCWKg92k+fcB3dMXkuYp8JM+S0z8GcHUa7Sqg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/29/24 23:58, Michael Roth wrote: > + /* > + * If an unaligned PFN corresponds to a 2M region assigned as a > + * large page in he RMP table, PSMASH the region into individual > + * 4K RMP entries before attempting to convert a 4K sub-page. > + */ > + if (!use_2m_update && rmp_level > PG_LEVEL_4K) { > + rc = snp_rmptable_psmash(pfn); > + if (rc) > + pr_err_ratelimited("SEV: Failed to PSMASH RMP entry for PFN 0x%llx error %d\n", > + pfn, rc); > + } Ignoring the PSMASH failure is pretty scary... At this point .free_folio cannot fail, should the psmash part of this patch be done in kvm_gmem_invalidate_begin() before kvm_mmu_unmap_gfn_range()? Also, can you get PSMASH_FAIL_INUSE and if so what's the best way to address it? Should fallocate() return -EBUSY? Thanks, Paolo