From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D307C4167D for ; Wed, 13 Dec 2023 02:14:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF1E26B042B; Tue, 12 Dec 2023 21:14:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA06C6B042C; Tue, 12 Dec 2023 21:14:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF2B76B042D; Tue, 12 Dec 2023 21:14:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9CE536B042B for ; Tue, 12 Dec 2023 21:14:36 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6507D80B8C for ; Wed, 13 Dec 2023 02:14:36 +0000 (UTC) X-FDA: 81560176152.26.B87FEBD Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2075.outbound.protection.outlook.com [40.107.237.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 2F190160018 for ; Wed, 13 Dec 2023 02:14:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eq64ppOC; spf=pass (imf08.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702433673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rEUAR/R1eD2OTQSMPCku3hB7cBIZxPvwyTh8bjt5XmM=; b=3+9NdlVK6DkX/8uhhECflvG28L7OIO3ZReZHJ0FE1G3HhVnS/3Jle08muqFBCfK9ttvs5f 03EgvRpbJmCSyod1O+uzDs8RJDOTtCMijthWfxVihWClUMvnNTziLFzTb69T4+pY+kyvjh nqK2vCxConT/C73PuG4xBQDatEfYDSQ= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1702433673; a=rsa-sha256; cv=pass; b=Im5sPW6o9fQqUoO/3HEtrNVE4c6b+D+/Dy/BmoWj/B3814fH86O7lwpZ3QOg/TRya4/+Ix 0Ezhse424Bj6gFY5MMDM1YhH2bdp++RfHlI0YmfqqMMLGLYAUOhjRzKZ175qd/Y2Q09Bhw AdafEKG6dwc3qE7xb2E7fAzmwTGeYyU= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=eq64ppOC; spf=pass (imf08.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.75 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJ9f/44iY1+3MO/EoIviRDVp+wkgBpRat4LKnSrSwalOHX2phV7q236Ypn6Pgig6GFNy3hKkh9Lk92/MJ47nYgUhx+f/PuH+Qhdur1sXy8DOshBHhmtrtYgCCNHV01+/AY/tMx3Piwn1/+1UqQDkU7B+JMlQg40AxXCqNS9blgYFTczVxMX75twv8ZRlhRSVlZdaZ+WKRkwN6/tu4+Gt1JcupL5I6icq9CZNKIAwDpK3LCZpnvqNjJ+XnQ/Hq0qFHqIH4RHORJ7bR6DqaWNiwtLuWyVn1JY/EG6/WQyHF5ODGBE/uy3PBJ+ADS5cuejh52aq4ccccijptNZbpjSS8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rEUAR/R1eD2OTQSMPCku3hB7cBIZxPvwyTh8bjt5XmM=; b=OWwzpDCbN+69t6cwmmdZ8iYTQuVJrHLW/Wos3/uuKeuGcnKXHXt4GER6Ukze48orF2oehx5Bgv8i7/icjDzUx1wO+TAmv4VoItykvEtruzGqpddzn4l4qKkXNLiUX5RPqysioZYUOvCEJKSy3J67dOX6G9ZGbVG8Dd4hMWPigcQ4rHgObp3tRQLUEdsiqf36O1bEgtuZjYUtevg4euzR0tCD9G2M/TkzNnjqCsEW3a5CArQw+1wUIKTJ88hXMGJt4HZNWr0Qn6WAoE7SQZAXqxVOsajPYar7O93nJcq6w3LGHC5vDlMu1HJDDbOYrin6lDNtRT515Aea6+ZGTj9Ymw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rEUAR/R1eD2OTQSMPCku3hB7cBIZxPvwyTh8bjt5XmM=; b=eq64ppOC95QzON0WOKLYvB3sYOKHR+XsvGPcqG8pNkxtEsw82wdDstHtGPcTrgdWUNX82cDgLKpeuYYcuzgaMRTqLwh4eY0m5fbmjBFvWu75i0EqMsVA5yE6m1Pgwi7E73T4HTlcAX1Wpe7O8RjB0jZEP1uX07HJ3+xL6OPuYx+oJDkHb+wfwsgDlHHsF/e4b+zGgDZA/KSiPMIj+MbbILsXvdYDS0cZ4e4w37hnr79u4wtLgeLJAuPvpW4ly+6N73DmyD3RwWcRg/Lt6mVIulGIGU3KP5T3+KxACne2b4L49Qax9yaON9oZ9YadEP3rr64PT0HgcyEt/uOYslb2aw== Received: from CH2PR07CA0034.namprd07.prod.outlook.com (2603:10b6:610:20::47) by MN2PR12MB4224.namprd12.prod.outlook.com (2603:10b6:208:1dd::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26; Wed, 13 Dec 2023 02:14:30 +0000 Received: from DS2PEPF0000343F.namprd02.prod.outlook.com (2603:10b6:610:20:cafe::ff) by CH2PR07CA0034.outlook.office365.com (2603:10b6:610:20::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33 via Frontend Transport; Wed, 13 Dec 2023 02:14:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS2PEPF0000343F.mail.protection.outlook.com (10.167.18.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.26 via Frontend Transport; Wed, 13 Dec 2023 02:14:30 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 12 Dec 2023 18:14:13 -0800 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 12 Dec 2023 18:14:12 -0800 Message-ID: Date: Tue, 12 Dec 2023 18:14:12 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Content-Language: en-US To: Mark Brown CC: David Hildenbrand , Suren Baghdasaryan , , , , , , , , , , , , , , , , , , , , , , , , , , Peter Zijlstra , "Muhammad Usama Anjum" References: <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk> From: John Hubbard In-Reply-To: <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343F:EE_|MN2PR12MB4224:EE_ X-MS-Office365-Filtering-Correlation-Id: 54919fed-33f2-4c68-3146-08dbfb813d57 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b0ffl4x29HzecnMRawxjLlfI3HUHJVvQQzi+2saXku2HYc7DkNGtMd4dQHPsVSEY2rCbE2uOZMryP+BGuRK1Yt3jcRRg+QpiBmYdJPPjQOHVTMdE5ki10hUFOk2nWKPSmdP1TYLPRLRHCKsA94rqkLgnZiRdCcgUsCjkgShvWxK4ttWQpO4zINBwmL0dR2d05fneW4rfC6pStrgNm3hJSfREN4F1SD7NbGEXn2KcvuhP1fnTxIdfxUZ6OaPFHTZ0ZwFI0y4EUhS6/+nD7uSJFmHh5PGzEYCnkWJixMZFAJZHfj3BBc4D+sgA1VUPfi82pasZvG6aILNAnNj27j/aQDxOXpTJSejegKd6mhN1krdcVIYVjCX5ImfMU9SsiveG8go+BkQYKowTY79zMAp8GWk0QauIQ2tw5unDKg+9VcXHw8kAEdnASYTQrbpaRPG3C91Smt1ln/Nl2s+AFA26h6l9gaPtDngiie3DO97XIYBNR1rqS/3FG2zLseMV4ulsydjIbnkpkhSSL8J8QspBGUmKI73uP94g0+9WsqsTYqxkewoX7cqLKHAPjY1n/3w4henNcjlLf2PpX9mLFPtktWld+3OW9u2RBHWlXDdq4xaZMAHCfJcGWbTbfRyNeRrcL0HPyfEoLYT3NaiSPDbp1zGADReMQ6yvfglODsgS1gBLNBpSgA4s+tyUFxssNswz/pIRmlaJRC56VUMmcb3+upr80wyaJY48BAaQwoRrZhGzXeZlHeJoawjwv0IR9FLYighZmJ7ySDT2bf3nGzb5dA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(376002)(39860400002)(136003)(346002)(230922051799003)(64100799003)(186009)(451199024)(82310400011)(1800799012)(36840700001)(46966006)(40470700004)(53546011)(31686004)(36756003)(478600001)(2616005)(70586007)(70206006)(26005)(16526019)(54906003)(6916009)(316002)(16576012)(336012)(426003)(40480700001)(36860700001)(47076005)(4326008)(8936002)(8676002)(2906002)(40460700003)(7636003)(5660300002)(7416002)(7406005)(82740400003)(356005)(41300700001)(86362001)(31696002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2023 02:14:30.0283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54919fed-33f2-4c68-3146-08dbfb813d57 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4224 X-Rspamd-Queue-Id: 2F190160018 X-Rspam-User: X-Stat-Signature: rjhbsu4dig1mubrghusebx7pif6styj6 X-Rspamd-Server: rspam03 X-HE-Tag: 1702433672-935962 X-HE-Meta: U2FsdGVkX19jze+iNcnX2gPA8wRp/1by8FvDpEFKO5cn9nduqH0pVgNfdc7oCgpAxqYjYLMCtBVDpTUTX9mmUJyv2oRsP/PAgdgPPvtNwKBcD6TGlLQ3RDJv1mydl/myxaoGX8aICS4QK3OI70sNhq1vDb2KWIyhFk97+Lbaz5v3NuwXkJOSF3d9APeydxu7tEn0HH++WDoe1yEUJ4IIsv+0rwO5k0d1VYiyUP/Y5g1LF3ev6ErkwSRvlazVZi1hB/fXasfWvZbVZMnGpI9yV1MJEPV4Fr0PBMQm4CUhhGPykYxHVaL1C3p2wridd7+etTwos2kDX2+3cHIkM7fyp3z4IlavQCAlJpKq/dARq2eF3pQDrpleFavt+o8ylh+oDnlV6xKxELxts4inOAPezsbdOVzd7I81NHfV8bFhI6ISAybC5LGGn7+6izwjpek1k7/fxNxTJBQ5HTh3ubJ6dHOiKkt3LQ99XoDBLk8zO+U8sIP4CT0zzBBZXxXzbUhEEcHimD+39h5KPXMbRs0SuoHX6iEVqjlbYr1AgY46c3A3e/XTPGTE9qYnUtkAeBc6vy5e/VOgMcW2omrd8bVNk1BGsFMosgI/SFfnphGPyD2/l/LbvqRFsqyejomqIEsvd7J7aUjO5m8Q9IO1bOZ4gFlSxOoXbDdrqAS+Lg8tEkIsXzKLcrMPiIERyYSqH0jtQfpW7ho6YZN/ybtISqbGZtx+1YxIeztEd9OR7nN1Ik8oxeZpPw0TslrtFlpC0vR23qRjAs4dgPI9dy0bEkCH2Gt2xuFUIL5n8hcqNURCmx0p1ovUYUrMiFcU9GmS7uEBudx48q9aq4mmPbzXgo1/I2EQSTHMNBIYYA1JA/lP7MCwPiZ8WKlwRX43U8wiT1XGYNGU/rEMWG5pPD1woPdnljFtdRPy+ux2rfyDtrMUITcpMgFPPuFUvSJudxmLZnQiIQH8+C6YwoTbgmhjgeR Vt94mS1g LO4hxnyz86rd8IpcMOkJujLVFRPOvZzkbpS1gRHKQUlYta8oWEUQqsqlsy0CaAP5uwI5SF3RXteszVZaQpFdE37mjoIQTRIBI5qO3q4fYnherZzjZNU9zrA7toOjBBvEuOTI/F6a4MJhqpBRY3J4uI6NakpuWJ3YIMh663FMon7V5JnRSSVPvTMMNBiCw/qqexvaHu/wMl38jDchcAK5mHXEUTByB6mkRN1MfvhjZR4+dGcjwq5iGmkqff3HNizXX1sdRoN2xwWvg6RvHhgFpdFN0B1aUrcCNI9tzYtfzS3+ViOyQrcDEOHjPlKMYeGl+MzuPFBiBa53Uo4PH9MjtskWMb6EKav4fiLeK4+BoLMXC6+x/KQz8E83mGzm9m6xrBch3+YI6cUDdIVl4k4NhwNcMwzPyv4+qHwx7taUwGTCmh/eC/MvCPeU+KnaTi3ROF3QQ/ajWIcTQk59M/t4eN3VLPPCJ+Zw+8aE8c52d0Ooi5/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/12/23 07:12, Mark Brown wrote: > On Mon, Dec 11, 2023 at 12:29:58PM -0800, John Hubbard wrote: >> On 12/11/23 12:21, Mark Brown wrote: ... >> Or maybe there is an innovative way to do all of this, that we have >> yet to think of. > > We do copy files into tools/include at random times which makes sense > for things that aren't uapi, and we are putting bits of uapi there > already so we could just expand the set of files copied there. AFAICT > the only reason we're copying the uapi files at all is that they're > directly in the same include/ directories as everything else and are > always referenced with their uapi/ prefix. Oh, this sounds like it would work nicely. No more "make headers" required (hooray!). Instead, the new approach would be "selftests are allowed to include from tools/include", and then we can just start copying the files that we need to that location, and gradually fix up all the selftests. I really like this, at first reading anyway. Muhammad, Shuah, others, what do you think? +Cc: Muhammad Usama Anjum thanks, -- John Hubbard NVIDIA