From: John Hubbard <jhubbard@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
<akpm@linux-foundation.org>, <viro@zeniv.linux.org.uk>,
<brauner@kernel.org>, <shuah@kernel.org>, <aarcange@redhat.com>,
<lokeshgidra@google.com>, <peterx@redhat.com>,
<ryan.roberts@arm.com>, <hughd@google.com>, <mhocko@suse.com>,
<axelrasmussen@google.com>, <rppt@kernel.org>,
<willy@infradead.org>, <Liam.Howlett@oracle.com>,
<jannh@google.com>, <zhangpeng362@huawei.com>,
<bgeffon@google.com>, <kaleshsingh@google.com>,
<ngeoffray@google.com>, <jdduke@google.com>, <linux-mm@kvack.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <kernel-team@android.com>,
Peter Zijlstra <peterz@infradead.org>,
"Muhammad Usama Anjum" <usama.anjum@collabora.com>
Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Date: Tue, 12 Dec 2023 18:14:12 -0800 [thread overview]
Message-ID: <f1b0b80a-1cc6-48c4-8a53-0222b3e59c7f@nvidia.com> (raw)
In-Reply-To: <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk>
On 12/12/23 07:12, Mark Brown wrote:
> On Mon, Dec 11, 2023 at 12:29:58PM -0800, John Hubbard wrote:
>> On 12/11/23 12:21, Mark Brown wrote:
...
>> Or maybe there is an innovative way to do all of this, that we have
>> yet to think of.
>
> We do copy files into tools/include at random times which makes sense
> for things that aren't uapi, and we are putting bits of uapi there
> already so we could just expand the set of files copied there. AFAICT
> the only reason we're copying the uapi files at all is that they're
> directly in the same include/ directories as everything else and are
> always referenced with their uapi/ prefix.
Oh, this sounds like it would work nicely. No more "make headers"
required (hooray!). Instead, the new approach would be "selftests are
allowed to include from tools/include", and then we can just start
copying the files that we need to that location, and gradually fix up
all the selftests.
I really like this, at first reading anyway.
Muhammad, Shuah, others, what do you think?
+Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2023-12-13 2:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 10:36 [PATCH v6 0/5] userfaultfd move option Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 1/5] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 2/5] userfaultfd: UFFDIO_MOVE uABI Suren Baghdasaryan
2025-04-19 18:57 ` Lorenzo Stoakes
2025-04-19 19:25 ` Alejandro Colomar
2025-04-21 17:16 ` Suren Baghdasaryan
2025-04-22 3:58 ` Suren Baghdasaryan
2025-04-22 7:19 ` Alejandro Colomar
2025-04-23 1:15 ` Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 4/5] selftests/mm: add uffd_test_case_ops to allow test case-specific operations Suren Baghdasaryan
2023-12-06 10:36 ` [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Suren Baghdasaryan
2023-12-10 14:23 ` Mark Brown
2023-12-11 1:01 ` Suren Baghdasaryan
2023-12-11 3:04 ` Suren Baghdasaryan
2023-12-11 11:15 ` Mark Brown
2023-12-11 12:03 ` David Hildenbrand
2023-12-11 12:24 ` Mark Brown
2023-12-11 16:15 ` Suren Baghdasaryan
2023-12-11 16:25 ` Mark Brown
2023-12-11 16:29 ` Suren Baghdasaryan
2023-12-11 16:34 ` Mark Brown
2023-12-11 16:43 ` Suren Baghdasaryan
2023-12-11 16:32 ` David Hildenbrand
2023-12-11 16:41 ` Mark Brown
2023-12-11 16:53 ` David Hildenbrand
2023-12-11 17:32 ` Mark Brown
2023-12-11 18:00 ` David Hildenbrand
2023-12-11 20:01 ` Mark Brown
2023-12-11 20:11 ` John Hubbard
2023-12-12 15:27 ` David Hildenbrand
2023-12-12 19:39 ` Mark Brown
2023-12-11 18:46 ` John Hubbard
2023-12-11 20:21 ` Mark Brown
2023-12-11 20:29 ` John Hubbard
2023-12-12 15:12 ` Mark Brown
2023-12-13 2:14 ` John Hubbard [this message]
2023-12-13 3:58 ` Muhammad Usama Anjum
2023-12-13 5:52 ` John Hubbard
2023-12-13 5:55 ` John Hubbard
2023-12-13 9:59 ` David Hildenbrand
2023-12-13 22:01 ` John Hubbard
2023-12-14 9:02 ` David Hildenbrand
2023-12-13 14:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1b0b80a-1cc6-48c4-8a53-0222b3e59c7f@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bgeffon@google.com \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jdduke@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=mhocko@suse.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@collabora.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox