From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B78C25B75 for ; Thu, 23 May 2024 22:48:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4459D6B0095; Thu, 23 May 2024 18:48:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EA956B0096; Thu, 23 May 2024 18:48:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2642C6B0098; Thu, 23 May 2024 18:48:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 088A86B0095 for ; Thu, 23 May 2024 18:48:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9FE0FC0743 for ; Thu, 23 May 2024 22:48:37 +0000 (UTC) X-FDA: 82151151474.25.42D764D Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf15.hostedemail.com (Postfix) with ESMTP id 9E5B9A0006 for ; Thu, 23 May 2024 22:48:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DLwlbxNB; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716504515; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TPr3aG1MtplD+AxrlL7bPoel3bwYFIv+2atj6R7Nirs=; b=01SOOjO1tFcYDQzt6TsREEQbssK9HtbIxwgs+3IhLviCyYVfyKJkal3geWkVkidT19oVHX yCoOhVEDLHhAXvCMFHp0NTHUDsDovbrmXbhTrEwmptiSm7UNCQLvLR4SQKLQo6UU2V9kDv yUFbUCM6VdnBoe/WogbfSYk+y90876s= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DLwlbxNB; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716504515; a=rsa-sha256; cv=none; b=LXUDzMMqh/hfXXSg0+76fkbmkOkTKYIDmayuZH41fCLUZoad94DtFGby3+e3vSbJldgwDN lX+0bEschT5GUl+hersn26dZ38nRzsRNnzqyhVw1u7qMqtCxfnWbR5dBwYeJAVOK1JLXnc RgLYZGqDrnGBov5/aRSA5UlsY/bfkbo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716504514; x=1748040514; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FVjf8wrlV7NMGMbPBklu5L3+XCMuQXEvjmuSJKVs8nA=; b=DLwlbxNBNA0Un0oQv3ok8NoIwD1Pa36HzjWqa5D4WZV5qHTHjNfgUgYJ +DLCzlBeh+jHh7XNyyMtL0+bCRY+cK+35gEQEiqnr6aio1ecvyQ1yUZG0 DUWvva2mzpmD+q6EO/zJ92rPSmixKtuRQylW+6pAXtJEaYZHEGWeMM9gM FyVQ3L8E3cUOlZyQE/NgqKhr/GZwBgw2hB04fuLCWaFTYNe9pa1lUCzzX Hx29v1Cndves7fq/NIMTVDDSdpU1l6vJ76ax8XM+h8iMuNiDIP8oCXO70 NbiuMVOk/2W63BiNMPTqw6rPIsfdIezgYdii+UB2zU78DJDcpc45TlSH8 A==; X-CSE-ConnectionGUID: g1M0qmbFQG+F9iGHkjZV2Q== X-CSE-MsgGUID: c4IIfLnRTReoyLXNU/FXYQ== X-IronPort-AV: E=McAfee;i="6600,9927,11081"; a="23467784" X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="23467784" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 15:48:24 -0700 X-CSE-ConnectionGUID: MoVaye90TUGa3MBDutcPlw== X-CSE-MsgGUID: u7aNR404Qpmcpe3YXuvdyw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,183,1712646000"; d="scan'208";a="38390291" Received: from unknown (HELO [10.125.110.91]) ([10.125.110.91]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2024 15:48:23 -0700 Message-ID: Date: Thu, 23 May 2024 15:48:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/2] mm/x86/pat: Do proper PAT bit shift for large mappings To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Jason Gunthorpe , Andrew Morton , Al Viro , Dave Hansen , Andy Lutomirski , Matthew Wilcox , Dan Williams , "Kirill A . Shutemov" , Mike Rapoport , Ingo Molnar , Michal Hocko , Alex Williamson , Peter Zijlstra , Suren Baghdasaryan , Borislav Petkov , x86@kernel.org References: <20240523223745.395337-1-peterx@redhat.com> <20240523223745.395337-3-peterx@redhat.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240523223745.395337-3-peterx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9E5B9A0006 X-Stat-Signature: 6q6omp4uah9thbj44ga1k6h3iyidjztg X-Rspam-User: X-HE-Tag: 1716504514-854289 X-HE-Meta: U2FsdGVkX18ZQSyyLN4h5vVyqTaLIBwMNjA4reomLLOFnVjBCjfA8O16Q6+CIwl83ua2G3r7wet/RhQPvhorPt90SDIkkqjMSH5oHE+kOsKIsxIHM8RfK8kWDbdDFF3w7gxG/potjRgyFLdz32N9ZJZvSlXDtz7d+cKZai6bgj3gmTyiXWdl4HJl+otXr4DjhjR+aM37VA1OhdynUDPuPf+GtEgCPzBBungHhUWRi3Vpj+dItrUNv6PWbx6TPoB62wSVJKpy4OtCs3L6NcFvEX8hwAAzjmhcD7yhyvO/hD7vsnKG6ngrdAUulUlyBQuKSNO9ApgXy7n0yml62wlF4ivRaVsKt525MZrmbUzs0B9PP+FZvALdl0ZaEFp34G8Sj3pO7ZBvOhwQ9yRCGrVIgjK25VaS53FwcVgjHBkcuiNyW5wpDD6WFGqVwWnTkDAJONmQ4wSZ+Q9JCbQcOuRyf/8e4v3XeGH5AOz1ryzXfBaMEE1P3kv/sHa/IyeRk63ddVx2G+fszdco6eFsxvIJdIyiYP1ZC4hLaE09XQm2lNGJN0NkNDOdKQ0O3DOK2jSXO4HLnAuPC0P9mWPepEue1O0Mh9woHIZA3A27TFOTPYrCSUKpsr6GoswvJ/rufCuxsT5znkgACiA8mTBaP3D2DQ0Nfo4yQuYuEJ7nOgbFQJgNn3cMIb606Dx8QNaEO105MdxL01LxbyPhxJHNXhj9s8ND5s/fdQYEPVe/y5ca4/xeZGDc6qbkAQRvDKpUd5+DANeEbA9vKmBdHGi75yOH2J82GKPgq3rDKQrzRDYpNI6Nrp1K/iCzCa2o96Y7A+1k1POsJuf5kR7hpcC4MxFR8avaLm1blQa7+I/Wev3uptSyaQreQhFf8phHowVHJizOnr/K3kPwAwseUuruuhvyC673k9wqjVelFmuSIc40mcYCauTQwZ2Fcs+vONqNvA589zQvAyb7XJNFv4/PfWh kYDf6Rvq 2flfSkIhnPEZQAo2UjbRBpNtTbeYa0sWk2u8aQTPURLBqdC2wIzMm7B7X8RWn0xReJBaiPrCLRigSDiDIZfBWHIDJ0c7fOGULReCiWkxkMPvRw66KKZavpYYObWfiQl996NDXzZhBXOxe/0GMkQU9vtr3vvHHrA+itkm7b+1aL9B4h4ner4GgpMuBdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/24 15:37, Peter Xu wrote: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 317de2afd371..c4a2356b1a54 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1135,7 +1135,7 @@ static void insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > goto out_unlock; > } > > - entry = pmd_mkhuge(pfn_t_pmd(pfn, prot)); > + entry = pmd_mkhuge(pfn_t_pmd(pfn, pgprot_4k_2_large(prot))); > if (pfn_t_devmap(pfn)) > entry = pmd_mkdevmap(entry); > if (write) { Does this even compile on non-x86 architectures?