linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 124/394] mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared; did you mean 'shrinker_list'?
Date: Fri, 10 Aug 2018 10:01:01 +0300	[thread overview]
Message-ID: <f19e7e62-1146-da99-edb3-ee1f3c632fa9@virtuozzo.com> (raw)
In-Reply-To: <201808101327.UMjeeNfi%fengguang.wu@intel.com>

There is v3 with #ifdef, it fixes the problem.

Thanks,
Kirill

On 10.08.2018 08:54, kbuild test robot wrote:
> tree:   git://git.cmpxchg.org/linux-mmotm.git master
> head:   b1da01df1aa700864692a49a7007fc96cc1da7d9
> commit: f9ee2a2d698cd64d8032d56649e960a91bb98416 [124/394] mm: use special value SHRINKER_REGISTERING instead list_empty() check
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         git checkout f9ee2a2d698cd64d8032d56649e960a91bb98416
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> Note: the mmotm/master HEAD b1da01df1aa700864692a49a7007fc96cc1da7d9 builds fine.
>       It only hurts bisectibility.
> 
> All errors (new ones prefixed by >>):
> 
>    mm/vmscan.c: In function 'register_shrinker_prepared':
>>> mm/vmscan.c:410:15: error: 'shrinker_idr' undeclared (first use in this function); did you mean 'shrinker_list'?
>      idr_replace(&shrinker_idr, shrinker, shrinker->id);
>                   ^~~~~~~~~~~~
>                   shrinker_list
>    mm/vmscan.c:410:15: note: each undeclared identifier is reported only once for each function it appears in
>>> mm/vmscan.c:410:47: error: 'struct shrinker' has no member named 'id'
>      idr_replace(&shrinker_idr, shrinker, shrinker->id);
>                                                   ^~
> 
> vim +410 mm/vmscan.c
> 
>    405	
>    406	void register_shrinker_prepared(struct shrinker *shrinker)
>    407	{
>    408		down_write(&shrinker_rwsem);
>    409		list_add_tail(&shrinker->list, &shrinker_list);
>  > 410		idr_replace(&shrinker_idr, shrinker, shrinker->id);
>    411		up_write(&shrinker_rwsem);
>    412	}
>    413	
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

      reply	other threads:[~2018-08-10  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10  5:54 kbuild test robot
2018-08-10  7:01 ` Kirill Tkhai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f19e7e62-1146-da99-edb3-ee1f3c632fa9@virtuozzo.com \
    --to=ktkhai@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox