From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEC2C369DC for ; Tue, 29 Apr 2025 17:23:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 629E56B0006; Tue, 29 Apr 2025 13:23:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8AB6B0007; Tue, 29 Apr 2025 13:23:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47AEC6B000E; Tue, 29 Apr 2025 13:23:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 223416B0006 for ; Tue, 29 Apr 2025 13:23:30 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7B0FB140C73 for ; Tue, 29 Apr 2025 17:23:30 +0000 (UTC) X-FDA: 83387752980.18.863E248 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 17F9018000F for ; Tue, 29 Apr 2025 17:23:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VppyhLU5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745947408; a=rsa-sha256; cv=none; b=Uy9izNqOz8Sqj9WtHdrKJvsrXC0UlHV6kVjj1aNIjJKTtDOo5mJ7gU66NX7Z35wKsFrr8y UzqB98kT+rUecHFg2z5nXXS5w9tQaqzPYJ3M2RfQ9se43LUtXwqY/cZC34vpyLHnfrczP5 o0PI6AjWhK1s9ZAwew9Xe8JefEJApMc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745947408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mejufdpGoxe4mxva5kvPFm+VySXa27d3Wo1WQ6UneQU=; b=pdx+QUj14CQOsWvXs7uaUUpzaxJrDtWyTvgiqjZzQaBMeu4Ax6zMo2RfIUfzRrJsipV+/g 9YMI6kfHi2FAgt2rrY9qOnboIHBcQtvwfJTpXkLSYDCX/aZfaPye0IXtnHiahY3OzWvw3o f+L6msvsQ73jkHuwFhMvVCTkG8GYqN8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VppyhLU5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745947407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mejufdpGoxe4mxva5kvPFm+VySXa27d3Wo1WQ6UneQU=; b=VppyhLU5oVzroTx3o68xJ4rai3AG/4i5GHB+OLTnxouBmpdt2QnHGR+4RgaTh/EXsj15NN yuV1ApZ3BjFSSybkNtcwu7Y2y3X9kPkDKxdNiaFRZySuZm62RU1IQ/0qaAVkY7w9niemrX x0TcO78dMGHryDKk+d1aKvlOvrue+IA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-zkFJv2NjNuWbYaNTEsBKuQ-1; Tue, 29 Apr 2025 13:23:23 -0400 X-MC-Unique: zkFJv2NjNuWbYaNTEsBKuQ-1 X-Mimecast-MFC-AGG-ID: zkFJv2NjNuWbYaNTEsBKuQ_1745947403 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf172ff63so26032895e9.3 for ; Tue, 29 Apr 2025 10:23:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745947402; x=1746552202; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mejufdpGoxe4mxva5kvPFm+VySXa27d3Wo1WQ6UneQU=; b=OOHyWjc81yoNNdoG8FMy0eXc73HVVfZmYtorf2R3vcbmF97UNjtLICdXSUXeTNBl2c IHbCS1yo69E5XKz6+Z+ruJXaqSlAhTFK16uvgbo/x4BaWPrUAs0S8SIEBzTm1xBrjgIe ywy5c4bMTsqcAbwdVqWgJjnh2PyWlRpAb5xNTLbmczvp7Vh3lteoFPD4M5qHi0qbvSbP VKD9GN4FjzphWWCNnh7mPd4mHKj1xrJyw/yqTd7VDGwfdmmanHPqWcdDH+NsydV7Lj38 a12aA571nOj+TkBzYyc54+O9weJ3UnZpqp4XwF7pToIig5oi8egvgRS/DgMRfUlrvsfB YJzA== X-Forwarded-Encrypted: i=1; AJvYcCUZtlQ0tNrcGwwwec5xLVZeOhVmfCuFn1ABgTsYrNRl6eKPScLstLQJ067xL3+9I6foJMTv6e4F0g==@kvack.org X-Gm-Message-State: AOJu0YxIR78yxkWpqdkTUEYBa4yeBN7V6xu73/vFwW1p1LAj7jWq747v LgaGDu/2FX08AVZltvRabknF3Xc07AtaywzYhbqCdUaxVMGouPtjWxVUKK1juMJKYUy73ttTbDc 9lJWbF1yokm7wD4ELukxF3SYghF7SszyXqCrv0nku7HJXIZNa X-Gm-Gg: ASbGnct87D36NFTBKCpZb6WjdHlREkm+qm0DnM/G21puAw755AAoQRGT1ZTc8INyp9L HY4hIqy0hMLJP6QW8bIEn7+06EVsTkdV5EA+QZLeOQU1SiEspF6vyHAZGQrVDT7yg+1FbfG20pm IPJ4buKsNMFtPNfdrpPCExGIrOcMX8Du5A91VMT2SzFoKa7G9Mwy+F0/Zl+Fu+GgGyA3PBHM1Qf 8707dBkH7Ub9fH4dLZ1/3NdAor1CYcqHNE1g3Gwfd/fIqcQFOKtgljY2IO0A2PByl9gDQtoxj6X 2HGzeY7nF8aOs5SqP5Ll3hW3FtqfPNDR83YUb84lDOPW31W6NPkT7HYd/0MHWTeEMRX/HeRVDRD ZtbSGGYj33j/d4ZH6YwyEHUgVLm6n0BNXcTlPmcw= X-Received: by 2002:a05:600c:c86:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-441b1f35e4emr1438955e9.10.1745947402652; Tue, 29 Apr 2025 10:23:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNmnRHxTJDC6Sf1Feg9BZAcb7lU9XtPRhls0zLu4URvGAHP8TbMwuFoVKc6PogHibLfiWHcA== X-Received: by 2002:a05:600c:c86:b0:43c:ec4c:25b4 with SMTP id 5b1f17b1804b1-441b1f35e4emr1438655e9.10.1745947402323; Tue, 29 Apr 2025 10:23:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2d8976sm194918965e9.27.2025.04.29.10.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 10:23:21 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 19:23:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: move dup_mmap() to mm To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JnHra7Nbtlu_pUlZIWN_IVPlM3jC2JFRZB5KYj6RinA_1745947403 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 17F9018000F X-Stat-Signature: 4orp1pogppe7xr8u8nqunbaru7fahfk5 X-Rspam-User: X-HE-Tag: 1745947407-843588 X-HE-Meta: U2FsdGVkX19AEyMs3Fha5DEtucMYBhKqBQ5vdnFno9IlkMMCrjSnmMXLpRDUyRwSZE25MwZM8bRZiIufiPG1HE6aOcImbbf/LuAb2Z5yEhkTnxy9rc1JHLwBdxtREBOoA9MSUvx/vKo8ONLt6UIyzjMBLYY7tfGdcW9Fx6VmWfQ1jbtHtaZHFdgUXQH0IHg3R9ToGcc4DTu9yTmWqt+z9eHAYDVGPM2euMGcpZedW+HBVOiTuz8SSzdurc1g6hYOt1hFiCZDmpSDjwrApAGD4mnQa6yQyJT/yZidRSWra092lr5eSQnT0S+ctFNcX24N62nlc9g5RhYVrBxKo9VE2lWR1ar7Wxs6xwc3kOYGuDnD5/2XMIJx79TtvmPU5T4ZU+EXpX5peE/drjrsmsR9m23dXKt4NVm+sJ/Oz/5uuGNmtmoPvcTc5hbdjvuWr3UdQugVHYLxTDcV6rE6t4w61Ou3ImnRAG6IRE+SNaZ5LsftCXINKdaTVL+8WkTK49x3s0Cu5CLJ/zfC3YgDzKbUE8xdWDatLh3bZNvyjvJmTFkPgoTl/bsoDGoeS4h2GSR33I6hLEACecZl3n1Fv/TFCpQCSvQBnLLivPZyd/6Nn5hxyf7Kq1N+mNJO6V7HqtbgX9LTqfGR9TsyxKdkebGxnJqqWcfCyTTk5WNHNbie2u07jrH/19RTJVy8dkcG67MeAllMXXP+Bf1XzyKCgwAxiTUgJv3bkJ1FuwrGxb8AYHUkk4BELbOdDvYCdWD/dsxpC6ki4DZF/ABO8rWVyy76MNHBVH+aUcTdFwg1Kwt5UpT7nYXrN/kJ5erH653gkcr3zO3KmdFGNJF+cw44LnbUPfXAjBsWU2sp/nflrs6N4LifnMJbYLAPZz/jwsFY3O5sBkBCZe+NGdyoqJCanUGeUFBfyon0n1e5PKGN1cp2cXvqTlUM59Ynsbi2UQcM4FSUSgCD4GWXsbZ2j1fahoG zotMQWjG 3cv0jDyOebGvxinaShRmqDKraE9o2qz/Ih50w2XY72otUKip3poGedj5AlKpeOyUoezAiXLbKmCO8iEhUz5IT9oo7EbOVwLyfFA3/pyCUSSd2yNWtX+zkbHeddv5VWJCJEEl3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 17:28, Lorenzo Stoakes wrote: > This is a key step in our being able to abstract and isolate VMA allocation > and destruction logic. > > This function is the last one where vm_area_free() and vm_area_dup() are > directly referenced outside of mmap, so having this in mm allows us to > isolate these. > > We do the same for the nommu version which is substantially simpler. > > We place the declaration for dup_mmap() in mm/internal.h and have > kernel/fork.c import this in order to prevent improper use of this > functionality elsewhere in the kernel. > > While we're here, we remove the useless #ifdef CONFIG_MMU check around > mmap_read_lock_maybe_expand() in mmap.c, mmap.c is compiled only if > CONFIG_MMU is set. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Pedro Falcato > Reviewed-by: Pedro Falcato > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb