From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4913D13570 for ; Mon, 28 Oct 2024 10:22:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 657876B007B; Mon, 28 Oct 2024 06:22:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E0F56B0083; Mon, 28 Oct 2024 06:22:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C9D6B0085; Mon, 28 Oct 2024 06:22:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 206416B007B for ; Mon, 28 Oct 2024 06:22:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 306971A04E3 for ; Mon, 28 Oct 2024 10:21:34 +0000 (UTC) X-FDA: 82722620148.25.B13AF0E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 2ECF01C0018 for ; Mon, 28 Oct 2024 10:21:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hgksZgbD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730110758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fuiFSGsUISRZ4rT4df5tv8vlp7keS7frwhZev7086vY=; b=kpXX5pGQhRIBKl+yWxedOb/I/oLHhuPYeDLDstSA8k/HIhOOspNJUs3kWbRF7PGXltpWXB nEzO/XSex/b82YFDVcxfCHzKLaHS/AhzYRHNukNIii7nNPc0+8FUs4K/zHUGftmiwZE57w ClYauaKFEMts8nQEdE427sxmby8nZj0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730110758; a=rsa-sha256; cv=none; b=iT9nOQyL4qQ8Dem6c0PWaHqrzZN3q1qB9CgUs7t7C6foqFyXi9SleogxteJ0XBzShE8MXJ w7dvfRfeYDfj3qatenwfRGgh5Gz57jvdOUjez6EkST4PhTE8qduU6OkiwxyraQViX+Bq1+ Z5iwjgN5UJgj7dVCqpUTzjt49jLz1hw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hgksZgbD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730110931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fuiFSGsUISRZ4rT4df5tv8vlp7keS7frwhZev7086vY=; b=hgksZgbDO6KIpZYh8EkW79SQV9W5yLJilz74Cp39FGuVQbaVysriC+61pGkADMBiTAlyvf QTnlQDFjvTChxhof0deaWbZzvgbz0cNNXvdiKkmfXI5+D6HeGiUhjChLOe/5ktMOBU9LK7 hxU5Jcns08WtDUOCdlZdFj/VjSp5ZVA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-7dz5qzTMMgaxB3W9lMNxaQ-1; Mon, 28 Oct 2024 06:22:08 -0400 X-MC-Unique: 7dz5qzTMMgaxB3W9lMNxaQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37d45f1e935so2330188f8f.0 for ; Mon, 28 Oct 2024 03:22:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730110927; x=1730715727; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fuiFSGsUISRZ4rT4df5tv8vlp7keS7frwhZev7086vY=; b=I/Ao+0UhBNduVZdVNJGHGPcxGbK3aA0WpIym7VqxsVaBbqda59X2/zd2qCwQ7InyFk I13ulgT8AuXJdmRxIk3cEBoUuoaeINe1VuI95Kt1JvB1Hxt5uAq3X+qvIH1pVVl+M+4w 0VSLaK2zB+EJa5Gd0ZmsXKtvWTtYFaF2EBIamcoz/9mhf5qViBWciDFRyF/5dhHV4hyu e28Me437b0pbsEfAafTaAQY20Lnn8UggdJIRqfmA8FGPeXYd5D+2Xxp4/N+JW/683qV4 BiiErs8u3f2qn/9C9lzfkkSbaSD8gU+7jJWCfG23mTmk6FhRDegMND4i7pJjUPs3pBqz Zj8A== X-Forwarded-Encrypted: i=1; AJvYcCVdpM5PKFQU0H2MfoP2S9Pi4DiHFuyOPXMd8HvOfq/blWhjT8E53yM53vPpRylGUwfT1XRZd1lfew==@kvack.org X-Gm-Message-State: AOJu0YzWPWkgbKB3S3zQA+r5urYUl61XiqWcPoqlAl2Uxi0QnOchCzO+ mIWoVFTEI5PjdxGYbKOtG44GWZCf7WrVXqi6ZgCNtP0sxspZ6RR+f7ArtsJ/pbHl37trtg9HQMV nZS1wpslDHE5ZfXhlWIhNNwMVzUUucQMyq8UkQZqH7gTGs/4w X-Received: by 2002:adf:fbc4:0:b0:37d:461d:b1ea with SMTP id ffacd0b85a97d-380611ef3dbmr5454988f8f.48.1730110927295; Mon, 28 Oct 2024 03:22:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqHGN/n0Yj5v745GS9Jlm3ZDkDldCmmWyAXcowgeCBzN/fu8QX7Ognj41PjRQlj2fQuwJDiQ== X-Received: by 2002:adf:fbc4:0:b0:37d:461d:b1ea with SMTP id ffacd0b85a97d-380611ef3dbmr5454972f8f.48.1730110926867; Mon, 28 Oct 2024 03:22:06 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b92f11sm9041515f8f.101.2024.10.28.03.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 03:22:06 -0700 (PDT) Message-ID: Date: Mon, 28 Oct 2024 11:22:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/6] memcg-v1: remove charge move code To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Meta kernel team , Michal Hocko References: <20241025012304.2473312-1-shakeel.butt@linux.dev> <20241025012304.2473312-3-shakeel.butt@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241025012304.2473312-3-shakeel.butt@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2ECF01C0018 X-Stat-Signature: 1efyrpatpbwnthopwkitrdj7g5speamm X-Rspam-User: X-HE-Tag: 1730110888-693189 X-HE-Meta: U2FsdGVkX1+ggcZgE9MTrf2qaggBNp0JBsJ8iyA6cyW0W4dTN0d2W3tgYuYIshyjJESbj9HM27mRcsUg6jgJALdSjwaJeKTRuF1z81coqkflBjRyUKDee0Y9i9FhaMdjMYEcqTw8djnSEBKQwKj3+xqVmwfyWtH3w8tCW6uvTJ8b//pY2eYUHgxwx2h+V3VyiD1sYPFTRUsklKexLJde80ioIfT6CesIyNO9NKh/EP7RRFFFtUKKYEAq0nSslZdM32fa7cWB7RdrCN0G87pK5RpnWrdrAomDOwbJKHHUB8QmtFOrwOhKWQw3e+ijzayM2MWCXJZYXqR0ezTKC52OmyfuPxDHKTmCyVd2EXYJ+4yFHpc6A7dIcgr9N7ihnkJY6yR5EBoUxvZ5zhTfppaC732FwG1BVISSBPIt1dcL1fad9iGObqWbVTr7NB5wBPe65WFE/Pk1QdisUopO0n8v9uZjiXBQ5lfwJP8kOTrE4M8Zpp55QiHxgGevx4UR0rHpWRXVbN9/LnPCmwoP+/eQPluuJgHHTRc/+5MN41zfEdEsxItAvrwAgIYImu7NyDe+bzXsMTASuR2OKAIdQUm8aKTW1WxmXHV7p/nQ+3kv1si2vjUT0MmEE+ORY20S5wD5xqTSF/+V28en7zteSaRtc/Z+HQ8fH5MvOqRHTteknhtej2EHemWY8ZQWOVGxQLVeJFWYHLNfMFCheDnPuBPMUGaBmmVlPRA5qQfLbAeK+NGi3lWDLj48zMTQVgIkyOMw9FgCubnA89z/Mm5sVHPaijWRT8+qLxnb7o35TLvm1CN0pjpeyfLT/Bl0o1GXhh0fB20VxMvlS3x8eEJ6hRdtIsjIUsh+80rGWMFKk6kxR/e4jBCZ0wllqcMUuKha0vT5ybJVYNigCH62gXHde3RUgEWUWfkfH0i0xh2hN8GPVP4+YyIzDBgfrDlNibtWiWzFP9LM6Nl0tQ2khauslfW NfZzkJwg Hyd0MDSFZ/lGzGteNH1ibYh/8ML4KIS56mu/Tnk+RGF17oTIGyngkUhsldm8/ie/Eepv/5ZaCGc4Vg57mM6kEZy2QxuqThXwyXvGQlH+apCCEJhsTb+//yE5A22sHZW7y7xwW1CmdgUJja4HehYlGU09g03kONf5KPa3mDWtpwZf1C6pZhmSkLjPvV7y4WqZl40THdDq2TiZPET8krEXJ1H8431QHyAOw3aeBMmOQdfAZzuHE4b8DN+jU2fOVrhb7COH9Q4a6hAnB7CZOMe5M9DkUKVOxTTATzeh6oM+COSll66t4DXirNeE7irRJBb9Rhw4qvKTGDvHadugSEEXDazLO7hGsS+b6RP3rr2iv0K4VNOVB6LXwBhFwCISBqmsv6ePDkpcNBpdpJeEJv7zeVMw+gK8PjYsbfWNQmpVQqdVeYwTzspAgmPK4mLIw4eWbXL4KfOWXEdYZK6E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > - > - pgdat = folio_pgdat(folio); > - from_vec = mem_cgroup_lruvec(from, pgdat); > - to_vec = mem_cgroup_lruvec(to, pgdat); > - > - folio_memcg_lock(folio); > - > - if (folio_test_anon(folio)) { > - if (folio_mapped(folio)) { > - __mod_lruvec_state(from_vec, NR_ANON_MAPPED, -nr_pages); > - __mod_lruvec_state(to_vec, NR_ANON_MAPPED, nr_pages); Good, because this code was likely wrong :) (-> partially mapped anon folios) -- Cheers, David / dhildenb