From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC4DC74A5B for ; Mon, 27 Mar 2023 01:29:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2BFE6B0071; Sun, 26 Mar 2023 21:29:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDA206B007D; Sun, 26 Mar 2023 21:29:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA1DA6B007E; Sun, 26 Mar 2023 21:29:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C9D1A6B0071 for ; Sun, 26 Mar 2023 21:29:45 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8D25912055B for ; Mon, 27 Mar 2023 01:29:45 +0000 (UTC) X-FDA: 80612946330.02.42E4E70 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf19.hostedemail.com (Postfix) with ESMTP id 5ECCB1A0012 for ; Mon, 27 Mar 2023 01:29:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of caixinchen1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=caixinchen1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679880583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PhH1U2eS/ZpvUDyAHR3x/qIfATM1irCQcsgIv/bHOls=; b=tCs7eOEKQxD8R54Po0CqvLHlL1LJtsmCHYrCXE71ZdrssX2ZAGeMEaqlbDZJRcc2a6p4Fe NxfRxzwKPTP691FWCVvUX3GkoRkjvW2puD6c66Drk491uTWocwI8getMkgMZOkmaFfy8sL P63/p/JXAq02VJmBfcqMb9vWHYM9HGc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of caixinchen1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=caixinchen1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679880583; a=rsa-sha256; cv=none; b=MljB0N5DaGbLu9JND8jYDMOgD0utzK1iPKZ3+pM/PiWImKnvACmXL/II1biKQR+X+B6qCo 8k6NVvVjaQSHH+4lZGfA39oj9z95YBdiE83ZoV1O4U5LS9eISyf9z7n7nlbq3HsXXmPjI+ UDSPj0wT9EsLBDt9xXZEvkPB05MqI30= Received: from kwepemi500024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PlFZT0mWszrX6N; Mon, 27 Mar 2023 09:28:33 +0800 (CST) Received: from [10.67.109.31] (10.67.109.31) by kwepemi500024.china.huawei.com (7.221.188.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 27 Mar 2023 09:29:38 +0800 Message-ID: Date: Mon, 27 Mar 2023 09:29:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/1] mm: memcontrol: fix vmstats_percpu state incorrect subtraction after reparent References: <20230320030648.50663-1-caixinchen1@huawei.com> <20230320030648.50663-2-caixinchen1@huawei.com> <20230324171114.32oru5sdubfsfvgi@blackpad> To: From: Cai Xinchen CC: , , , , , , , , , , , , In-Reply-To: <20230324171114.32oru5sdubfsfvgi@blackpad> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.31] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500024.china.huawei.com (7.221.188.100) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5ECCB1A0012 X-Stat-Signature: dm5onagdoxnk95pruj678mobuwcjinmh X-HE-Tag: 1679880582-715472 X-HE-Meta: U2FsdGVkX18N06XLAMb6BNG5LzH6QYY0XRo3FIoy7lSYqLlRRud/8faJ/XnayU2SiQ8hSQYa+aw4pVaMNZY7o+KbbfsT4JIr6pq+lSdJIApftn1OsSmiuytben14Eq3txYnfKOUzV1w+yQMfzxHyT2zg9hCPHE+VWx6jbGXqrDlM99Xl/9riMyKxOnVS7l1zbweaIx9/HXaof+mG+cFBBxCMK55yMpcSr7hBRevpsP8x6Nb38TxhyL8cgfDIpG5zoKq5BQY96FTmllsMvkcHLjWI/6XS+xtudxvhO9C/jz8U72lZsvrDfIBsdF9yn7iGLhPUiZ+XKOIgn3hW7vs7aCsrHDdDBRm0DPc0YOKSUb5Pa59SrkmopaKepaF94gpuGkt4flBQrXJDDWpxYw2THnhKeoB6Prb8VBj3r5ncxaPevKeUMMcH9gjk+Utvvp+fSpkbq5gLA056dHM16fz6QnUzp3NhXOoQp+eAK2wJQDWG43UwmnliouppXu/3SEMRghJuA3Eq7IwttM2t1I8vPz+fg25krqiHDPf74uBgvQJzqbZ52V8CtVNhHPP6sQYN1Fv0Srs8GklgdO6fB0frzAqraQfeu8a7zI9KZyrWyezPwwGCgysYzoCDchYCa+iLHev7KYslOsLGCQzQXGeVo0zw7MSaUWMU53rSFZ2ySTWgVp+jbwjyirVgr6fv19IPwHDeuSb9iBAthXuNNmY3wHhrM8vKG4txQVj8tF4MRV7Igfxr/1wi3yR9ZlN/MvDp/WS8xsXfgycJQMyFboP/sslbn29BqhIZpmFZ15RP1Ohb5r7GoKQEWf5Zew8ZghkC35epwjZcWEg6Y7h976NEvzpjkggLp3Ci5p4VI8IW9MDBUN2Eb8oEfolep+u6oKmTdhoBSXltR9DM8ljbgflg/VC7TpO6R/C5nTheLOBElb1RQwU6zxOcJMbGj4z4CAV0E8pYluJet3Kf5ptllBM SEA6X/Rr uBlYZTPgvSFwAvXEzx+Y7VnTkGJtVMdD5gRyuqRpWaLutQn4lo/5mHwL/S4hucf1idDM2VE3GLtWcAfk6+H0yO2pfO7ZHEbeMysuTn+RWiEgNFBcJtLXOzvQNvH/XgwIwj3x9VG4AHmyGJ8Lsb6xzveDxwNuekwgiWgzOeSCAhyw5At97Dl+Cp8C9a3xPHN7yGS9Lm1QEEOwS0MrwXeM5HITL9ghBwgw4su5U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Yes, only cgroup v1. On 2023/3/25 1:11, Michal Koutný wrote: > Hello. > > On Mon, Mar 20, 2023 at 03:06:48AM +0000, Cai Xinchen wrote: >> When memcg C is offllined, its pages are reparented to memcg P, >> so far P->vmstats (hierarchical) have those pages, and >> P->vmstats_percpu (non-hierarchical) don't. When those pages get >> uncharged, P->vmstats (hierachical) decreases, which is correct, >> but P->vmstats_percpu (non-hierarchical) also decreases, which >> is wrong, as those stats were never added to P->vmstats_percpu to >> begin with. > I was wondering why ->vmstats_percpu matters (in the end all is summed > in ->vmstats) -- do you mean this is a cgroup v1 only issue? As only > that exposes the non-hieararchical stats. > > Thanks, > Michal