From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E925C27C4F for ; Fri, 31 May 2024 21:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2C5A6B00AB; Fri, 31 May 2024 17:46:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDC5F6B00AD; Fri, 31 May 2024 17:46:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7CAC6B00AE; Fri, 31 May 2024 17:46:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 898A26B00AB for ; Fri, 31 May 2024 17:46:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 32B1B1C24E7 for ; Fri, 31 May 2024 21:46:29 +0000 (UTC) X-FDA: 82180025298.10.C5C1B86 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf15.hostedemail.com (Postfix) with ESMTP id 75889A000B for ; Fri, 31 May 2024 21:46:26 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V1vnWMUN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717191987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rtHYcIIANaNmP7Pcq8fEZ6w/9yj5+j/VSiFZL5pfXNU=; b=XdzwjlGHH85NDQSeqHPy6GN4Is4IUN0PRmawsvwHdNF3xgS+gYuf6IX/x1qTmcljwC9eGK Lxz9F90esMgPBRRyQrUKec/ANNxhL/m3k6qfm4whvBG4YvSTumms/w4R3hEd3saDFacBE1 hq0L6Wp1U6Pobm3BkueDBDz1+5j2TLU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V1vnWMUN; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717191987; a=rsa-sha256; cv=none; b=BbVTOo1J90vLB+N10RPJT9p6hl66b2bploT6NvBd8/8+br9Lrn/nnRYINw53VJ4Fn9QwAw LcZHgzDvTMDVF909c4KDvwhBSWFRFngl5RIWe9iFPNIURBPMjrvzGzg/B4OgyroUWFrZXb Efo3r3GeWwESmPP6XpARQPLHrCKgoAM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717191986; x=1748727986; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=l9l3FqC9dknDCtsJMKp0h5MAOYBbJfIqVGQU5aZNZEg=; b=V1vnWMUNufJgCipq9kGkAtNF294H7RpzTllCY5GYa/30QDZhT7pqLeJm ao+83xpEfI1Mj/yA3Tp3fHW669oJMryRXchxXduxshSJJ/mm48xm2ZQOk MFOhNT6eMYFV46C+aEGb1ggvlSgv2WnBh/tSSJYxchqSItmYRsFH0ru16 72bmIJTe6yNs83b7odKtCgkOMi2I9LAqmfJJkRtwrdMDCRKsnALvL7QlW hyRjnogKHXYyQ9hXyh0gNkt0F/7dwgyfgxfBVsp3LLZ4lMuEzd2HngU2n CBDP5Hs0VoffKMaLpJMlkP2TZ2wFGjQKD8qV5NvHXml/yNQR9GmxU4/nY Q==; X-CSE-ConnectionGUID: eR6IRPv6SeiFh/GcIvEL1Q== X-CSE-MsgGUID: dhfKEGYpRJazl9HaiMjOHw== X-IronPort-AV: E=McAfee;i="6600,9927,11089"; a="25158618" X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="25158618" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 14:46:24 -0700 X-CSE-ConnectionGUID: vQR7QD4/TY2g2Hysghvfjw== X-CSE-MsgGUID: 4IdUVHs4R8G1i4VFHNMhug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,205,1712646000"; d="scan'208";a="36297654" Received: from uaeoff-desk1.amr.corp.intel.com (HELO [10.125.108.48]) ([10.125.108.48]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 May 2024 14:46:24 -0700 Message-ID: Date: Fri, 31 May 2024 14:46:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 09/12] mm: implement LUF(Lazy Unmap Flush) defering tlb flush when folios get unmapped To: Byungchul Park Cc: Byungchul Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <20240531092001.30428-1-byungchul@sk.com> <20240531092001.30428-10-byungchul@sk.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 75889A000B X-Stat-Signature: ctzhwdr6zxw4ur3rt9om6kuj6brof6rw X-HE-Tag: 1717191986-327589 X-HE-Meta: U2FsdGVkX1+Is2WH0WfC+BKOQHmCJuEsjJ5kUWCMOux1PLXQX1gRk3WgdCLktGia5Vv5xqUJFqhYtCdAficgQR+zhS0jZ69M+SVmxVerjSlkvPWfVyOocbMh1aex6oHPeonTQ/Ck2e2IWVCKXLtcI+K+bY15CD6lGI7N1UCqjDOuI2qXBJPFL+8gBtFeWcXnI0Zt60cF5rPmmumxCA7JYTYArc5VDCMdPH9U5MilQpyIphm4Hn2so7O1PW+UVH7V/frF2rKU1fPrmsTaiWn1Moboa0yatwbQapx0v4ys3bHFtuBO0V/v95UirRSM7XVN419OE70zOAGaM3xGo3/aZRBrGKh02J6fz1mRL0UmLJrBqu5cqyLWEl7Uuw7KwaSeUio5BxxzZFybOIVozV+JyVc9VPLm0HZx/kTAyUnULTXVpSiccfbeuxV3FXgeh6J8JPxye0XkGKKT2Eob0snQzV6tbggrDucUwsyh08s0gI35V5l9mh+D1d10OthFRSy0v90nRi7g7d/dzjQq26Yix3EXZ4JsrWGEqQJizCVDd8AhGTErZ62OEpf/67sDlCacSgvZ34OBeTTLOxSH1qHKbMSYlyGxIIKcLZlmGMwOT+DbiXR6nni6eEeSCLwmVKoXXSww/OPC2Ialw0YWCQF/rC6hqp+LhcAvYfmi6JPIiNohaDaKyxZwG5yEUgpN5c5U4K2Od+EpRrIgTNrLAfhfNGJCngO2/mtKqKF9r3zkLmiMDawOK98XEAA+goETjqZTtwkP3k6KS57X2JPAi/d2yjzmZXpx3NnJhjLDfk8iXe+0Nvmgv+06weQKd9gSPv5E9MGfLUWf/yQO1ZoQB1Bt82nsi/oJSzDcf4NGHs1xSnxLoV8aq/5OksiQWxaY80rpCRC9WSaakNHFSltZmsdDLjPfqEGorcAUwDjlTrkgRaPdySEX8Ow3QiEB42hqsoHhpreSPLuUdbyQGNbFIrF 6oQm2sYX M8Nv5Gmbclp1JQ5MY7jOu+K09SfzeThZ+uG4nNm756pH1Dl9muZDjVvHh02Ujdu+qr7zEMvP+cP7Q96EG85635pYMMRk8r1wzx0xgMF+zK/2BLZV6MZ4X6hAYzt6el1NcfA1Fi1t1PDOZHTOshL+tj8H0PvYZ9q0ZmwXJ9et9iHTDSmzOxbPUCzsYRh1Ye4ql19wZn8gy8gJf9aOtcBsiPxSmSRcVPPh//m+eW5fYJK7C88clignl7RONauX3D7NyInwdXc+CF2GzbB4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/31/24 11:04, Byungchul Park wrote: ... > I don't believe you do not agree with the concept itself. Thing is > the current version is not good enough. I will do my best by doing > what I can do. More performance is good. I agree with that. But it has to be weighed against the risk and the complexity. The more I look at this approach, the more I think this is not a good trade off. There's a lot of risk and a lot of complexity and we haven't seen the full complexity picture. The gaps are being fixed by adding complexity in new subsystems (the VFS in this case). There are going to be winners and losers, and this version for example makes file writes lose performance. Just to be crystal clear: I disagree with the concept of leaving stale TLB entries in place in an attempt to gain performance.