From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E5DAC77B7C for ; Wed, 25 Jun 2025 07:20:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD78C6B009B; Wed, 25 Jun 2025 03:20:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAF6E6B00B7; Wed, 25 Jun 2025 03:20:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A76FC6B00B8; Wed, 25 Jun 2025 03:20:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 917476B009B for ; Wed, 25 Jun 2025 03:20:33 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 40EAE1D9A32 for ; Wed, 25 Jun 2025 07:20:33 +0000 (UTC) X-FDA: 83593075146.09.54C26D9 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 8CACE40015 for ; Wed, 25 Jun 2025 07:20:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=BTR6kSeo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=CowIg02W; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750836029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4KrpQSsnHPH7dYr+lA0S88izy4e3AoYeLAon8jWYb70=; b=y6gVrR95xA+0sDI9l3X2n0cHVBR9ZxqcpKofz6srG9+UNNVmTvjkvjrBg8q00gxdDJRosp AHSPzvj2Scj1/cCA1vGwnX59UYFGfU+5WVAh8YKlAwzVokgTj49Rygmb38WnMig80y0bIS XGERGHDD6x8kVns7F7oXRcwB6JJQm0Q= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2025-04-25 header.b=BTR6kSeo; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=CowIg02W; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750836029; a=rsa-sha256; cv=pass; b=vmgc+L6726HEWJ19vjOHe5/cbSbAxrIT/PA4WnMh7zTLF35Zz1op6f7f0rQuXpvS97mi5b stpVAKEoOF7FkeXsqJvRu0w49jX4Clltd6Dxc3aydJMW1R8qdCk8OetuZ1gKkayv28Zi6N jW0q1s7nXsavaY4TPGHPHG9A///fMyE= Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55OMid0D018836; Wed, 25 Jun 2025 07:20:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=4KrpQSsnHPH7dYr+lA 0S88izy4e3AoYeLAon8jWYb70=; b=BTR6kSeoNPhy8vgzIc4v+omWUTlSOZ/mOi IVzdrFFKR4M/B/oElCztb79hVmTTR1SoQqL+guyyYzbelQfWIbzhFvcVLMhY590I VWvR1FBW8Ut6v4LbiuWx56Bl7KlNWHM4VL90Ip2acJPAnxCgoE38XAbT6FkNS7sz QIzd0eKA7JNxzmsA3B7Bf+aKHDqjpfi/DKs+4XDAWP60ye6mlPrtn6wwO1G8nswE bHx8h6QWsP8naeCmSKFdoSgJUvI/AdNsBci2ZfSz63t/JLziipGHwkN4eJ+v09H7 C0jOt4a3/SREJpgZXpQwtE/MoxU3JpcmbovDWqSAkajIhB1Zv1rg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 47ds7uxtm6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 07:20:21 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 55P5UOT3039936; Wed, 25 Jun 2025 07:20:19 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12on2078.outbound.protection.outlook.com [40.107.243.78]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 47ehr5pcw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jun 2025 07:20:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SOVc7kasea/SnSeAJ+ew9UV0FwNXkD206qdnhp6LUwLPJPK5btMLwpfsuiFyc5PdakBSiLh6HkNr/Dls2/c8kBZVcdaIKzV7AWCLOYBXgQNqrMu0NgiOrPGLunAK2WIK/PunhhKoKPl61M/D178XqNLs211fJsvq3C+ttNVronaqO2LaeFI2ivh2E+24iDUFKpWkGl74jBSzAuSVeA9e1flKA/RH290oDp1zLEmBdT0oCKxVj7T3G1Co/ZZ6JedLaEvcyIFssZDwZoE90k3DW7vAYH7A6gUTyjjlFM5mQ//nE8j8X9mKVeYVHsjosZTyQBivrSEqOFaUjZVHW8Sz3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4KrpQSsnHPH7dYr+lA0S88izy4e3AoYeLAon8jWYb70=; b=lDOss/KOu4Fd7AANFGqKyLSsf2Lj96y6Lt6yMVFO4miMXKGvXwQNiJ+b7dt95TibKF38Fka+qkeb3Z2+5/D/fXWzh0h66/y7M4liyRIv1V/GM2XbGpMkKoC6JWzrLOruGUbZNNALjXl3WI7Zez5BMQgnM/7Ame++TKtS3HQHZXraWdMNepc9II+EnN0rJVYwl9P5njarVXzY03BmeR7d4XA1APUCGkC6EzAxo9mbQNFxyhZDdwIxeca8Agah0bln2b0B+MSfgSQ/ygdZ4sNiuvvSJlnrsLgNkXElTiXD8ewYD98cq9IQrOQfvaU74+tD5BGj8tmkeX0RFlYTUoLwLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4KrpQSsnHPH7dYr+lA0S88izy4e3AoYeLAon8jWYb70=; b=CowIg02WBNln17q0s1pcwJPuntRaWeBh4aDfhxITO9j3LgJwMRNvHbqw2bWUV5uAk7udh5ldXTAjHziCvt3ba1hz+ISshczMVX4dL9rIjFutCccC94LWZYhFwCW/ueze6yLXy4Pn2Z+CD10bvUO5PPGeUk72zzH6a1eFWQzIdZs= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by DM4PR10MB8217.namprd10.prod.outlook.com (2603:10b6:8:1cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.27; Wed, 25 Jun 2025 07:20:17 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%6]) with mapi id 15.20.8857.026; Wed, 25 Jun 2025 07:20:17 +0000 Date: Wed, 25 Jun 2025 08:20:15 +0100 From: Lorenzo Stoakes To: Hugh Dickins Cc: Baolin Wang , akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, zokeefe@google.com, shy828301@gmail.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] fix MADV_COLLAPSE issue if THP settings are disabled Message-ID: References: <75c02dbf-4189-958d-515e-fa80bb2187fc@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75c02dbf-4189-958d-515e-fa80bb2187fc@google.com> X-ClientProxiedBy: LO4P265CA0056.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::23) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|DM4PR10MB8217:EE_ X-MS-Office365-Filtering-Correlation-Id: 3689a71c-b7a6-4b1a-625e-08ddb3b8bc52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?nmEbGqiiSbKmySY1K8RPfv7cHti2HUlJ9y6s2qTmexnCH0+XoRQMZpukb2Yu?= =?us-ascii?Q?MizLlQP4ZJ1jxRTjkXM4GoFV1cVw+6SGPtuFAe9e49B3lu/iXIvEHRUXYk2M?= =?us-ascii?Q?22bKHKK38Xxpyr6D2MYGApvDYwL92OMj9SChizKxx2BLM/JymUdJ3wY2gdCD?= =?us-ascii?Q?rNtwptf7BUd9dRSNoZhh27hpytmvDHV7eFLkn1T8byn+XKMa3PTQOWmgp2nB?= =?us-ascii?Q?x04HnSxZVvU7KY1L21JqW/Vj55jTov6eKaOCtds/JHyNiGUhmoaZAzkE+rJT?= =?us-ascii?Q?oeIFDjTCng9wthCGkrbXYhLZ9PGjNeok1P2MkXLrPMtqr6h/tBRG83Jj4Ln3?= =?us-ascii?Q?L1pZPQEq1yyvvGQjg6ZrzxLu2YJsazJRl/9akuQS7937gAWfKwnJxRJ2divY?= =?us-ascii?Q?BMdOYwomM7hYL7sWn4KmgiKz34+F4dr1paYOyU4HEvWGas0Ihw+Mz4Ifkn7j?= =?us-ascii?Q?JCXqDBoPsH/Hd+foRrx4pMubfxKOTiw0c0FrQxcgcOe9dL3Dbb0M7U1whsRt?= =?us-ascii?Q?fWb47uBl1q771181Yr5v6x+/narWW9C2E/UThAyQ00lHx3MwN7bDVIEPhe96?= =?us-ascii?Q?nqiLX5R6m6b76AjPcxNT/DH+xVkFOsGToNvKm49M/LvP1OSvqzT8nT9VfEr9?= =?us-ascii?Q?B/TfhXIMv4A4vdq3o99Y+oWhf6fWxZw43efWTUlll/M770LbiPCcgypt3ytM?= =?us-ascii?Q?E1dc1oyd2LpfLST4Fvd/yixPdmQT95du2C92WBXE6xIZSTza9wpD2oiYb2Dg?= =?us-ascii?Q?0Tk7zoS1HjJdHe+vPa0e4mrGUt1k2XnheTaPLm/OggeVPiKQOwd090aWmZ0q?= =?us-ascii?Q?icTXSaGPxhgYEa6nshr0za2UlmYXGfsfHz0yvigmFZqYpISXx5XHBZrt0KY0?= =?us-ascii?Q?jEUqq7bU0Q8O76H/kxkgDWKmEbKNWKmj5ogJKEnWwIL2cOUR0shWCgkQMsrQ?= =?us-ascii?Q?hbeBccc5TpmnUbtI0N+fY/T005EhMM0ZinBIMscZMvYzqzoD6QEAywKyh06D?= =?us-ascii?Q?w1nkK9PNRQV3wLc0F35FiiEb42k7w8yfilxO5IE3EFtA05sXOIdH72PbBQnk?= =?us-ascii?Q?Nc9iNs7MzSlknoDDUMv9MpbNL9H9ISRU19p2FNa7ELFXTeHxGbRYiYEOGmOk?= =?us-ascii?Q?m8L1H/bsz+2Yl4aXhEWkrU6nFrDI3Xu+D2HJ04PBJ3zLbW2/3LjV+64WkfcL?= =?us-ascii?Q?/iQXRDMCcIvYpoG1mUVL96F+0z5T10gwnu2o6mxR8Tf9dgGaAugocITbxOSL?= =?us-ascii?Q?vy+Ol4HazDKN/DxPepj1EZfAK3HEX7m0JmDD29H3ewm2f0mh0p2ZjoDV7qsY?= =?us-ascii?Q?n9gmpWzAfg68CeCntgGVusxZ1umiqNyDZ6G8hElADvKe07XDmURTHidMZuvt?= =?us-ascii?Q?I2NC9YfwnPNPhqYyA6VMjZ9bLvbK8T0a6TwHyEY81iU9OgOc58Al7xcd8uby?= =?us-ascii?Q?ePvhFFgeQbs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rchhGJZPzMcg9NNDWD9bduC9fMSW3JsoGHgLVlJiDMkFz16N93gCsEZ3lOa9?= =?us-ascii?Q?nsC8WMjxR6Kx8hbQlCiS8u4vYWtkB/v+0Rm7K6G9PIuO9Ve/Qn6kV3vEuaMo?= =?us-ascii?Q?9CpMQf/SuoXwyDjhcedMiHSE1NY/E/goaJtDUmgFvcOELdL6Uvx+zNT+WBbw?= =?us-ascii?Q?U6cF4ZbqcQJEMTt25PDNRf9BQMhow33zDsBrKbD79WH89gubaTY4fMNVsjis?= =?us-ascii?Q?LGmplIj1W1+5Fz2YDErimoXgjlLtgZPsP/NXtcJgzvtlxm6bIefJluwr1/Ib?= =?us-ascii?Q?gTNmb9y7ZovFw6cH/XWtPMuaqYB36Vx90yntrL56LinnY+jx8gofR43PAwbJ?= =?us-ascii?Q?TJQKvC326H0I/caApUMTsazvXQ18O4F0NN3kB5mmajjbfg+5r9Z6e8Rgf9hN?= =?us-ascii?Q?HCaZttHzvUKwyCv11FCHtehxjEgpp7iyjgG6YyaopQ7iPnsjVi6MeX1UBM28?= =?us-ascii?Q?NOjHXqa/FwRZ+V6s/bM+u1oG6QW3TGRwLOiivypCnp6ra04Ko2XotKt5xruJ?= =?us-ascii?Q?3yLXxjrywlYfyzZSeECLSmsa+DcQ+iDlVhlR3D27ga+QzttsrroHZvpS+d58?= =?us-ascii?Q?8U/+meMDhyryvN/Rk9oeZMiqyNensgG/XmapFz0Ghq3MURbxrW1LPtMqFf3w?= =?us-ascii?Q?iP2ujnxTpWADIuNLa3WfgLiT5wBqHAMdKJtcmfsytW7IiJJMKyQDm5hG+puC?= =?us-ascii?Q?4iXYXYI3dwMIqfXBmKqFcDHYGLLMXo+A8+hzSs5ntiZsvPyjv6i335Ms8mhG?= =?us-ascii?Q?4H/ieI71eMiBp2mIdUq4rrE2lOx6Yo3ASQKEUQvXBMqkb9QOybgSePPvVNrx?= =?us-ascii?Q?yJsiRw5eTwep0uQeBE6DBnjKs+QZ7ywLWX46SH2DCvIQTIZ+UfoWQjp5oMCk?= =?us-ascii?Q?yQ0q9nM9b0BMpXGDyJNtHpojYhqFiG8ScqzrtxaXqbFZjjJBefSSWXVeeGW8?= =?us-ascii?Q?uhIUAZa6n+S6SbG8YL7kkLHpZd7/80AyoqtmunZOrCW2H9n3S0yi0BwmFhmB?= =?us-ascii?Q?++L87CjH1kOFRsHd2o0aR+lPnjoG1FUSx7zbO3mPjecYabkNU5fymgiDtVxP?= =?us-ascii?Q?MvSHSJIEeaSsgNUXweg7+pdc1PRMnC9MSqpYwjtebEKpCT44zV5J5Hg3hYGs?= =?us-ascii?Q?4WOzRja6pgFNQyZILq7SoqpwPqNtMXK6A3WkfxyOcuvAQVi7aa+jIfey3mNt?= =?us-ascii?Q?TMSH6kI9wOFiMkBErlN6Pn4tkfwqeCqBfbS34hn52siaaSTGfSsmlQ0Dx40b?= =?us-ascii?Q?7O026HPtwJBFUOld67cShQ/DUwOefyprCi0CA6gVIq9pbxYpgZ3y6b0RUZu1?= =?us-ascii?Q?nka7NWQAWH4eA16WMOkj6mHPzpoedY+qyAc7EJ9l6AwRAnZwF9s+SnXnDLmr?= =?us-ascii?Q?AVCUHZbW54Alu4wkvl0VkUW9GgiVCXGNyNDi34HjYXliSoC7xTkoboLfRqLw?= =?us-ascii?Q?+U6RH8hUsP2FWW1X1gwZXv0fdCh6XdtemSoh9XubyBhfziHAxkoRKjfOkJcu?= =?us-ascii?Q?F1BUnfjTa6hEhST9LhbfPpIZveTKjLU99yYVootMnELdrUuq4CFpUpLjSKrS?= =?us-ascii?Q?xP62QQzUusjFpLxT7M41c8ege2+iRCoc/WE51FPshYXp9hlk667MsuWj6VWJ?= =?us-ascii?Q?jw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Mm+COuH4avWyXZXO6aRl7NBRe99YjRdJdjrNEH4Lus3NLFhA2KtJdSTNyAnVQBoM9MzVe0OTlpzIYNiIcJPAIMElBqrQZuqtv9EW0JUMWSBbBS7Zhw+OoeWBd2/k9azfMkusCXiBgG3vkvAKGwVBhgIObM23BSbsrzDLw40AgvCowlR77VtiRfyEZWqvKnefjMYbgwDNaLHiMg1S2RKnMlqIR+kWl7xVTRvF+MD/yXEL9s4DBBFb0gyxZoE6Wp/3tW9mSTuTIIuDH6XUFkXrhaJvyVk6htHz5BdNYvYcMh9KxEuo51yuMWtkxWS1EuuOaGpCwyppqaoSt+L2Y2ugJQ9NdaVuiSGT39TIy6C6IUQ/sjV33Xh5lVM+FZ36DZxff5Re0ym3jp/UURK8oKjfV7OUerkW1b07khY9OVkPKvECVA2HgdK273cQjrOrvXBiX7tpaJjbWAAeDoaOGPZXsELxQ13q14Gso1/M8DKL9meq2grOx9kxe7N/7Drsx3rYmwibhR5vnOErTeRtAGG2nCXz5kVTsA2nCrwyyJP3J6obc720JqjMMzRrU2oVt1v/iV5pVnh2pX6WAiyl1JDmVsBHS4crQ3IXh+OVPgARKP8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3689a71c-b7a6-4b1a-625e-08ddb3b8bc52 X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2025 07:20:17.2260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VHf6clCGBb20RvpKH625d/tTnfoNLRuRwVuc/ctFxrgPGxqwsZo2oNmFX8boUbVv/ZdeABaNOlRuobTEdppgbtHgWetbGz98CXqSJ0L90h8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB8217 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-25_01,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506250053 X-Proofpoint-GUID: dZkPUQoWP9KzjzXrip2x_5QZtynJvXlo X-Authority-Analysis: v=2.4 cv=CeII5Krl c=1 sm=1 tr=0 ts=685ba335 b=1 cx=c_pps a=zPCbziy225d3KhSqZt3L1A==:117 a=zPCbziy225d3KhSqZt3L1A==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=6IFa9wvqVegA:10 a=GoEa3M9JfhUA:10 a=cGEsiFLpUp03pL3Tm84A:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13206 X-Proofpoint-ORIG-GUID: dZkPUQoWP9KzjzXrip2x_5QZtynJvXlo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjI1MDA1MyBTYWx0ZWRfXxn8ITJdyjdrK wpYERWQatjb33sHZsgJxfSQBSrVESayKwvnr++T4hYhTKGYhkyS9VC/yGqGta8e2tsMVEtY66bR 7bOkfZhSJq13/wqAMl+4Pgf3qPOI26swn+5Tb/gF08dqbdQbuZA1hR6dHdfnjSxQX9IrpINQ6tX iCdVIeMF/HvKA1GiC8BTvexiq1k6FXXiDV/COfiW8gtUFudNfb2LzJ4AF13eIToJpHn9G3JJ7Q1 hVUF5VepPw2LdGT59f1VajKPUYhzL7/V9+lJt5TV8yUw2k4yPlL/89Htn1xTa8Wxj0J/XOUVH2y lwpJW0d8zZOvyrfA9+16Bct6eZrv7XSKEWGuKUOnCFnzhkseNzC048rtziZ6rAv9BLHiVsl8uHZ 4NcJMaiyS2f8gahAR4mh0lL0z0vFRAnd/ARI8LqNBiruZc+y2ibS/fQDwq8JaBvzO90vEecF X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8CACE40015 X-Stat-Signature: inckwg7rmjppyd5eqgg5nx5sjj1nwqjm X-Rspam-User: X-HE-Tag: 1750836029-39048 X-HE-Meta: U2FsdGVkX18fSxgCHer6BtdWaxLvB2VlmdBQqlvctlaByuw41dLrMXrxOllc9E3j9Tr2o/RZmRU4uk/NY8grUo6q9FUJNDod8PiSrpbF7uT8I+0G8IKPYfFu/h0cGMhKdGu3cZ6HDew5WPL4L/VkZpCm+wXA7QLBh+ipbmLsqCGL8bmcheNxEw8nmpv47Mdamn8ElaK+PRBhtLz5ITDldeUvqBO3JG5Hm6n1pjJUPjYMj4QzGJxefkN5qWTJF8o+oAIZ7Wh/kW4mM9bCEPz46vjqiqdJLa8adkbH9kps7R6uTwi84F4qdTjv7JTsaEWtYYemyrYANCoqM67HDjrPWKVFUjf34nYakZqID40XoFsW52Qa1icz0265CY5DhZcBlN238um/bzKo51TeiBapKVlVPH/K53X+OB3endBX36eQKLwbRalscoluvdR8wbFhJpdg+2K6tn4Z3ngQt7zR2M9C78BcYLqebQQ6D8IWKL/AzgaMSkrAmX+4PjFBDzwk1+Aj1QZLDUyzbYEI8FMqeAOWzTcHODOolvOofb8mYptkGM6jyRbd9n/Kk7a2Zojar+elLCUld/IDhPKLLjXxzLyrRcRJ1JtYyYSqKkwU0O3A4UBDEZEOkMDhllrpymgD6fLTE4HN+DmBFvEyKh8/z0WhriW0N3vYHwQHWC7ya4Mid3hFLOia4WRneY6e5BBrLRxPO2gY0qUHlmg0vTyuxmuAbrFwU0SlI2kd0B2gQ3vX2QX8dycc1enJjwNOtcwKY5M3HlTc5H8TB+JQlXR+BUWqWKnMTJnSgPGPA2VjvaCUZgTpS5Nke5p1ZIe/DnDk0BUE4FZUi2gcW7RQzWBgPHhwR5GWFV1bE7l9ZedaXcZtE5yl+qFnwdEvRv90wmks+oNC8vnG55L16QjfOr4pf2Bw5iK1rDkYl/grQRPFRTleSNCNcI1s6SfMih3xj9u5IdlbG9w9AfrT+01gy9F RzwT4+Wg ZpqopSPDiGR/syVs2Jc9f2zh1ANIfZcw37AEqlbEYsyGrdKw8Ne4os7vVKqAS02gLTdf1nvZ7bN4/Q0n4W4qlZub21aYHfYpic9WX49wxlGPpnlCFidpor03I5q0Zlo6X57A6pxuaLN7KOwzbaZ4jsS/93Zy/SH6/uyCtysE2W7h+GASx9FWPlq+2ub2b1/Xc/PK8quN0H6XKOH+b4a/pckPyq9+262AVsf9rcAWUsRDc8zQMr/KxQDK6AnIw0g5/czfqFDpEZTNiu0GIskYXhIUA24wXhZClBDbY+9LX89MtkV8i3XNQeAcBFD4hR7rhQ8p6BOPDlxV+NDj3FK2CY2B65aBEbdeV7QdlEGw3SneVC+Weo/KegSShoulULC+9675tcIBMLDlA9w+AKHAor6o4/pFTZXMwPX0KDK4MXOGB0rGtM1MP1bBjyv/BV+ensjszN33rHH0eOjjY/nP49lBsfWUOHiKmCANpyPkaxPl+aaxmfQxlqBmla9Y2H7DENwtI5GK0Aa8Bd3KFkBV4ZJgm3bbWXPLGWt3bdIe9Y9bLb9wy+r3Jf6oYFPIlqWE58asq2xKeRGXliYMISYZOYopvHuZNoZY1mIMe0LzD7EAAe0ifAy9z99On+aTkpEJjm2O3dP2cMYDnQsv0z2qKwSnbo1z5L+KGzexv7k8o4ycs5vDrpqZULlK5vDXmZuUPBPb/j4IF5EPivSo26nAH56s8nONN9kGD7AHk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 10:53:28PM -0700, Hugh Dickins wrote: > On Wed, 25 Jun 2025, Baolin Wang wrote: > Sorry for chiming in so late, after so much effort: but I beg you, > please drop these. > > I did not want to get into a fight, and had been hoping a voice of > reason would come from others, before I got around to responding. There'll be no fighting :>) I for one (and I'm absolutely confident others in this thread) very much respect your opinion - so some civil disagreement is perfectly natural and healthy. This is how we get the best outcomes... > > And indeed Ryan understood correctly at the start; and he, Usama > and Barry, perhaps others I've missed, have raised appropriate > concerns but not prevailed. > > If we're sloganeering, I much prefer "never break userspace" to > "never means never", attractive though that over-simplification is. It would have been useful to have this discussion earlier indeed... :) I disagree we're breaking userspace. See below. > > Seldom has a feature been so thorougly documented as MADV_COLLAPSE, > in its 6.1 commits and in the "man 2 madvise" page: which are > explicit about MADV_COLLAPSE providing a way to get THPs where the > sysfs setting governing automatic behaviour does not insert them. I disagree, I feel like the unfortunately poorly named 'never' toggle in sysfs makes everything uncertain. One can easily read 'is independent of any sysfs setting... both in terms of determining THP eligibility, and allocation semantics' as meaning that it ignores things such as madvise vs. inherit etc. But it's not clear that it means you ignore 'never' - yes a very poorly chosen name. I think a reasonable person would interpret 'never' to mean literally 'never'. But if we go further, note that the man page points to the Documentation/admin-guide/mm/transhuge.rst document which states: Global THP controls ------------------- Transparent Hugepage Support for anonymous memory can be entirely disabled (mostly for debugging purposes)... "Entirely disabled". So I disagree that 'seldom has feature been so thoroughly documented', I mean in a sense - yes! But also unfortunately, and unintentionally, vaguely. This really does come down to some poor choices made early as to wording and names. But I'd argue that as a result of this, absolutely the expectation of system administrators is that never means never. So we're sort of arguing de jure vs de facto here. > > We would all prefer a less messy world of THP tunables. I certainly > find plenty to dislike there too; and wish that a less assertive name > than "never" had been chosen originally for the default off position. > > But please don't break the accepted and documented behaviour of > MADV_COLLAPSE now. Again see above, I absolutely disagree this is documented _clearly_. And that's the underlying issue here. I feel like if you polled 100 system administrators (assuming they knew about THP) as to how you globally disable THP, probably all 100 would say you do it via: # echo never > /sys/kernel/mm/transparent_hugepage/enabled So shouldn't 'never break userspace' be based on practical reality rather than a theorised interpretation of documents that sadly are not clear enough? > > If you want to exclude all possibility of THPs, then please use the > prctl(PR_SET_THP_DISABLE); or shmem_enabled=deny (I think it was me > who insisted that be respected by MADV_COLLAPSE back then). While it's useful to have this, prctl() is where APIs go to die. It's a hidden wasteland that nobody knows about, it may as well not exist. We have a whole sysctl directory for configuring this stuff. It's sort of crazy to have that then to have a special prctl() hidden away also... > > Add a "deny" option to /sys/kernel/mm/transparent_hugepage/enabled > if you like. (But in these days of filesystem large folios, adding > new protections against them seems a few years late.) Based on a reasonable interpretation of 'never' I would say we retain this series as-is, and 'deny' could be what 'never' was intended to be before. > > If Andrew decides that these patches should go in, then I'll have to > scrutinize them more carefully than I've done so far: but currently > I'm hoping to avoid that. Sure and that'd be hugely appreciated! > > Hugh Thanks for your feedback, it's much appreciated! I hope we can figure this out sensibly. Also note Baolin's point about mTHP which rather complicates matters. I think we all feel the THP interfaces are... not perfectly ideal. /sys/kernel/mm/transparent_hugepage_2 anyone? :P Cheers, Lorenzo