From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F12C3ABC9 for ; Thu, 15 May 2025 09:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA8C56B00BC; Thu, 15 May 2025 05:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E302D6B00BD; Thu, 15 May 2025 05:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF78D6B00BE; Thu, 15 May 2025 05:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ACBE46B00BC for ; Thu, 15 May 2025 05:31:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8B18E1CC6EB for ; Thu, 15 May 2025 09:31:06 +0000 (UTC) X-FDA: 83444623332.10.2F1FA13 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 83BB514001B for ; Thu, 15 May 2025 09:31:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747301465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zqcfPSTfI0E8GIpxzqM1syu/46bj50R1fgPlcam6mCM=; b=Ls6uRxQcc35GRZfk1AomuW7VO3PUeufHAcQ61HOT+mnDRi3gn/DFh+lB7umMYxg/UlVnjF K4vmntRP/beZuxmWwVGS/p6lOb1n7HvpMGzdo1ya/4ec/wKaTz2IkWPCudFT0b4r9VFFug sRC0Qbhk/Fua+Cba8Oi5nfMs1jYNdzk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747301465; a=rsa-sha256; cv=none; b=Y3kWsXpR5WwZHaf3o/Ge6Rsas+MTFn1WThji9eIgOZpG+dX0X9rov6aAVcMKQj7yZPKosu 29fP3XPNCk3wkxXRIKvB5KBFsV/Q+bvi/7fqtP1wHsF4Y/4czbzN3f8AJz4jaPcV/cvRab 8vlXN++D0D5L9lZSvDFTspULraaDx9o= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04A4614BF; Thu, 15 May 2025 02:30:52 -0700 (PDT) Received: from [10.162.40.26] (K4MQJ0H1H2.blr.arm.com [10.162.40.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B50B73F5A1; Thu, 15 May 2025 02:31:01 -0700 (PDT) Message-ID: Date: Thu, 15 May 2025 15:00:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Deduplicate test logging in test_mlock_lock() To: Mark Brown , Andrew Morton , Shuah Khan Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250515-selftest-mm-mlock2-dup-v1-1-963d5d7d243a@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20250515-selftest-mm-mlock2-dup-v1-1-963d5d7d243a@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 83BB514001B X-Rspamd-Server: rspam09 X-Stat-Signature: gztxhnpwa61qqse4qwmtbeuzwwzti8q5 X-HE-Tag: 1747301464-829364 X-HE-Meta: U2FsdGVkX18JEdJGONMiYcz8hb4UHpEi4RWJXTkFJaTEQyKN4lmRQF/V+MtwaH81IzBDh9CdnX+kfDgJVyBW9X+FIGHU2s92Boq2CiPy0qWKPGPV+4M0hySu+zmh8SHki3LE9t98GCslBsxLCMrCdOCcH+bClKupWKEQsNufm1oDsnI6qdGZ0MHkyvJBek9W4EZ5sR7p3Z60PmVCTTZiIBs12glAPEoQ88W57/ZKmL23GmYR8ZLUD00YLSAozLjF3muj1KbdWNYiP7o5PhoRwW2a+eJiH78WBIR3LGdkFwi7Sohgw/y9HyQBVgOrfOdajSzKImEQAeysijAjh+dAvE7etMHXHQ6hkjk7VX2wOKzxO7A4EvgSPQVKygn7rixe5GYvTE1oCN2LeI7qba5SpBWAsOmZ2yM5/rT5VxT/NihCMHGB09oMmNJWCV9JcyBWEN2zX3TowDiEBYV+5pmOeL9Ef67Io2Gbv08Kt6CZcIHXgZTW6at7xZXp4GZ0s/WngbcQMou9iYz9xfACTreP3bwk9/AThXVBc5JuQSzlvn1eN+sPS487BxTgdUWMxypS16FhbkdhojFqkcK4HtxA+hBLsksyxlYfmyd+XaQjliZI+8Zka3p022o0ogR11kEw9dhuvcjmxcOOhJDUakO+3iNAXYj8Tl2nutoHDTmgVkyj1zC8XpH3EDUlksWBYCV0gmZBEYDhaPgiP4xf0ItSYILh/9FDlS7Da+Xc7q9YlU+Az6iCdcCo0V/8WlsRNBCa8AUYMaqM7Gl8Oo7XlXit73nz+bmw5Wj1a4K+3PH317e2/CUdcXgAbW88886ImN7l2g62iu9h0HGehrzBcmO+a1ML3axyFPvkA4L7nTePC7pVtAsFIrBrDUoCeZo1lrjoi7ejRXoUo+cRSgbJY4/Bmy9fiNG2dJvnkoBkGTwz/iDSbVwzDdVaetUtbr1c5SglKAuPbRGd8+v4i63W7mo GnuYrV3+ MCr352RK0vUaqamCdotcNmcQinM18JL0VygeBLg0hsqdEmT8xCciVo+qNIypXLJdSDaf64jXtf6/lSWK/uVTwnvbK0lipib+wmQJQIHZ61QM2HNRFlgZASN7Idqa4F1fbiIQIGMl1qcZuRwBiLR6/mkHhQHS9+uevmT2UfVpz9SvgznnfASwr3+3Od1Uh/dtPxIan3W8xgfFMOIotDvErcQKVDZ2TloOdbKui/sqVneSBQvPhJ+HDdo1rP5QP0/488qK2qyDzP+c/x7Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/05/25 2:57 pm, Mark Brown wrote: > The mlock2-tests test_mlock_lock() test reports two test results with > an identical string, one reporitng if it successfully locked a block of > memory and another reporting if the lock is still present after doing an > unlock (following a similar pattern to other tests in the same program). > This confuses test automation since the test string is used to deduplicate > tests, change the post unlock test to report "Unlocked" instead like the > other tests to fix this. > > Signed-off-by: Mark Brown > --- > tools/testing/selftests/mm/mlock2-tests.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/mlock2-tests.c b/tools/testing/selftests/mm/mlock2-tests.c > index 7f0d50fa361d..3e90ff37e336 100644 > --- a/tools/testing/selftests/mm/mlock2-tests.c > +++ b/tools/testing/selftests/mm/mlock2-tests.c > @@ -196,7 +196,7 @@ static void test_mlock_lock(void) > ksft_exit_fail_msg("munlock(): %s\n", strerror(errno)); > } > > - ksft_test_result(!unlock_lock_check(map), "%s: Locked\n", __func__); > + ksft_test_result(!unlock_lock_check(map), "%s: Unlocked\n", __func__); > munmap(map, 2 * page_size); > } > Acked-by: Dev Jain > > --- > base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 > change-id: 20250514-selftest-mm-mlock2-dup-277d586bb29d > > Best regards,