From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E07C7619A for ; Tue, 11 Apr 2023 03:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DED3280052; Mon, 10 Apr 2023 23:50:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68F0028004B; Mon, 10 Apr 2023 23:50:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55668280052; Mon, 10 Apr 2023 23:50:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 416B428004B for ; Mon, 10 Apr 2023 23:50:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F39ADABCAB for ; Tue, 11 Apr 2023 03:50:05 +0000 (UTC) X-FDA: 80667731970.28.C7F00FA Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf15.hostedemail.com (Postfix) with ESMTP id 92735A0002 for ; Tue, 11 Apr 2023 03:50:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LYKP57Cz; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681185004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CjEAid20/hS5TioSfuhZ2hRVRcGGbWFkXT5AztmUYLU=; b=x6pxERoemTq6jP0fKEGd8xOyagui4ALGHU6WMHOymWRO08tMZw0N61V/mgw5yBTT0rNjY9 qxswNXK0gJkoEsby+f+tKukjrJuYAYBApsVGLtipnasUyPyP74dZgUyg7BIZuoMa18tVnd nb6XBe/wuomHhxKvc6IKSKaHRx/gQS8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LYKP57Cz; spf=pass (imf15.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681185004; a=rsa-sha256; cv=none; b=wRurUQ145XzJhe9qshTfccrFK/45uFc9kw8qxJU/I+sl5JwR3z6P4iogB3x76ow3F/JCPn nQV0i+ZiNqo2ZQ/wbDomH6OPw53wCdrEEDO81ww7cos1QYGjuI7yt0gAXeswAinko/B67Z XrxcpEFLAnlqg3CzhLSn7UnY2xe2yeE= Received: by mail-pj1-f51.google.com with SMTP id 60-20020a17090a09c200b0023fcc8ce113so9549070pjo.4 for ; Mon, 10 Apr 2023 20:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681185002; x=1683777002; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=CjEAid20/hS5TioSfuhZ2hRVRcGGbWFkXT5AztmUYLU=; b=LYKP57CzAcxQ5gab4YwR9v6vaxhR/4P+GionA8yCWLZ/9hlqmF6jK2Rc7Hkr+pYJ4k VXiDq5ZX5hi4on79vEZq0YxeTPOC7e3+GHpqMEQGRRqjd/zSf+X9k2tX9OYO0Nnc7Uqu 1RusCPGRGIRm768m7eDnzYpfYH4RFQ1dLFZa//rUISjWoXkzVJWR/E6DmSvq+jgunVk0 GlgTAFS9vuG8ltgVdj6Uplw53WEfZZRY9R6/w0AJoTurl+/cvfqFcOH7MZoaiSEGKgsQ unrBv6AgheR1VbEjJIccmEaHodDAELANBNqlpkS6ySpkAEfP43TmwlinKsO/rKzEUpYo a03A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681185002; x=1683777002; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CjEAid20/hS5TioSfuhZ2hRVRcGGbWFkXT5AztmUYLU=; b=L/MJ2bESUZe6Pu3okKbm+SkcNyhs8bhqiQ7xHFsNXYyfQc7xWDGTwO0TeO04Th9Ybr kEUwkG15AeYFFS0Ii/w4weaTh0cWBif0SxGaw6mnVQN7435yHm1fdlqQAjQmGEZKB5j+ as61g9V2MIu8D5grP7OGS2L3xX29iTTTBtAJBPm5elooH/G+rYzPgA6uqzHdVXoQE7ba nkaBeXf6onZdP3heIqgscpjHdqzCdiy4W60yW6x1L+Utzx3YSEZOZ5kdIu0svtDY/TW6 I7zBRQlfzZsXjVXISp1tEk8Qdj14wvtAyZxPxp2u3DOoltWQ3DOvPYn3Fu69qdkIRBkW p0nw== X-Gm-Message-State: AAQBX9eEQVrx5Va+6cxo+YmtZTLjmrc+/H89rliHFyyadeP883cwp6qs imwiVBGJitjkAsKSd/jpGtEqQQ== X-Google-Smtp-Source: AKy350YTCKN8pXK1GPOoitNCP80wKJNKIMZKz3O+cK/gOeA1J9898z6qCW9KcqZVIWDDqcWSHJd/hg== X-Received: by 2002:a17:90b:1644:b0:23f:7ff6:eb8 with SMTP id il4-20020a17090b164400b0023f7ff60eb8mr1994829pjb.31.1681185002391; Mon, 10 Apr 2023 20:50:02 -0700 (PDT) Received: from [10.200.10.217] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id t7-20020a6549c7000000b005136b93f8e9sm7579138pgs.14.2023.04.10.20.49.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 20:50:02 -0700 (PDT) Message-ID: Date: Tue, 11 Apr 2023 11:49:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2] maple_tree: Use correct variable type in sizeof To: Matthew Wilcox , Andrew Morton Cc: Peng Zhang , Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, David Binderman , stable@vger.kernel.org References: <20230411023513.15227-1-zhangpeng.00@bytedance.com> <20230410202935.d1abf62f386eefb1efa36ce4@linux-foundation.org> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 92735A0002 X-Stat-Signature: db381z77m89587k9nf3fz6jysqctzaex X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681185003-765308 X-HE-Meta: U2FsdGVkX19f2hS/vgp9B83+wsfZch53zD9qCQlcEHWXPqHHy0Vdvu9sn/Djxn7Ws5pYu1WKzxAHg0xL0ofR1DDEErazSTjy/BvHXBRyWJNNAfmw8RQlP99jRrYDH9kvG0lxWC96Y4eRwZnrklh9W/r0rlsoGN29+EUzVnAfmly+Q+P3+Vo+hC6mt3DjewHGc1qqroT6BZN1PrrMqHn+7PbwfgzycOiCBoI1WAL9bvGyaC+cxkPj/ZZko2xkctql7z18IX7gHNjuOk1u0sFHyl0oktImVVXlLY6vIQ6O9eQWogmgEU7Rwqbi5/byPStRXgrd9iFQQsiOLiwe/wNZIrF/ZtOxjWbMK+E91U1sPVvy/E3Ab/7/OG5wfSpAJ5LFRr71mNXwQMl/SsCxUP0yBc0XR/ttvprhCYrn2GFOYnK2ZRf/5WgVKiZv63in1vuoIVGsPXLWfAgOliVk/z0AOZSDlSVB7FoEv5qEtYsbGz0wpsCYTpjAe+1IPKps8v6L7bp0ofex8+v5Z4myPp27oGcGe7xpaBlz2wXa3yVDDUWJyYBlbR0bIIpLvX4kcjDOsxZT7gxl2NQH/bZiN+EDbzt9u4Up7K0J1I4NN2YuuhPDWvNQwGOtxjeBtnYlM3XvqYMJ6LJNLJHOgWtYhLirMCnt8ew8XeRgjkAps7R5LT5v0BC/VKSvTja4U9+QH4BxhoQ0BLT2WOLBNFDTqjmu17NKbmcMr22O3Mrp5erLEP5K5qXKmkM47q3qho4nbbOHjbraHEmMU3aabPZJ8+T9Th9ZxZzF8on3gzioBMsJa7PC+zfsWlXwzdEsRmHJtTEnwv0Q2kWEKubAX9pLAAXSDiXdHEpC3Oh0MrjTEjEOiaTrckGUIsgJjyTyA7IBqvr1nRH9GDBDjYmu0dfnv5rgH3gGpbX4qgA6+CJR39SVSZPHWRgQgvSkrK+OAkVyML35Pc05jr6I6ALq+1Yltep Zwjh8j/c 5Wi6qpa0fFgyDCyOCHT9xiUIEo5Gz3n/stXObBNoOb727uL8XqycvtohD4YmT4qmsJXoLDTtmKswW+ojfK7PH9h0ivDsJC4Ay5vmxxlPnTEK41um3u9MiL5qhpEe2936FqalrnHGS05Q3/Wd3kywvyL31DssekFGj15ngDbc9dn/daDRhGyATY5ErFjg+skXQgXCTMGeQGWkwoPcmCZpfIb4MgfGJALBQ/cElXy7vzFw111pacOB6sk6iiA4eWqdp4QvyhJilYGdZo4pGhYbUbl97N4PBU6H2ZyIvaN/ucWIwb/b2/FGSkmEgtsJwbYDVtqOBht7qihKpS7XOdSnlfx0EHv0U4xUtgqK8Ti3EHnS3DMiRt4bpD41u2diuRy7Vb903vAxuaozcqH/5SEY6tQ4gbxrzihN7vlnVq1FQW36zspSYY4z48ySerG2cfC0ni6g2sQ4Rko5P0Uiyn5XufWrO4aMiRbM57PtLk0oExnLsnB8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/11 11:42, Matthew Wilcox 写道: > On Mon, Apr 10, 2023 at 08:29:35PM -0700, Andrew Morton wrote: >> On Tue, 11 Apr 2023 10:35:13 +0800 Peng Zhang wrote: >> >>> The type of variable pointed to by pivs is unsigned long, but the type >>> used in sizeof is a pointer type. Change it to unsigned long. >> Thanks, but there's nothing in this changelog which explains why a >> -stable backport is being proposed. When fixing a bug, please always >> describe the user-visible effects of that bug. > There is no user-visible effect of this bug as the assembly code > generated will be identical. Therefore, if this has always been the case, cc stable is also unnecessary. > >>> --- a/lib/maple_tree.c >>> +++ b/lib/maple_tree.c >>> @@ -3255,7 +3255,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end >>> >>> if (tmp < max_p) >>> memset(pivs + tmp, 0, >>> - sizeof(unsigned long *) * (max_p - tmp)); >>> + sizeof(unsigned long) * (max_p - tmp)); >>> >>> if (tmp < mt_slots[mt]) >>> memset(slots + tmp, 0, sizeof(void *) * (max_s - tmp)); >> Is there any situation in which >> sizeof(unsigned long *) != sizeof(unsigned long)? > Windows 64-bit (pointer 64-bit, unsigned long is 32 bit) is the only > one I know. Linux is all ILP32 or LP64. There may be some embedded > environments which are different, but I have no idea what they might be. >