linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "paulmck@kernel.org" <paulmck@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Shanker Donthineni <sdonthineni@nvidia.com>
Subject: Re: [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible
Date: Tue, 12 Sep 2023 17:02:23 +0000	[thread overview]
Message-ID: <f12ba12c-4625-1b13-a0c8-376138d94b45@csgroup.eu> (raw)
In-Reply-To: <1189edca-9029-4c2e-ba71-b3a1c15b61dc@paulmck-laptop>



Le 12/09/2023 à 18:49, Paul E. McKenney a écrit :
> On Tue, Sep 12, 2023 at 11:44:23AM -0400, Liam R. Howlett wrote:
>>> So my question is why is it useful to setup interrupts that early, given
>>> that interrupts cannot possibly happen until the boot CPU enables them?
>>
>> I don't know for sure, but there are 'preallocated IRQs' which end up
>> grouped 0-15, then I see another one added at 55 after the mpic console
>> output.  I suspect it's so that they can be added as they are discovered
>> during early boot?
> 
> Christophe argues that the interrupt stacks must be allocated early
> on, and that this acquires a mutex.
> 

Well, we can probably allocate them later than it is today.

In commit 547db12fd8a0 ("powerpc/32: Use vmapped stacks for interrupts") 
I already pushed the allocation at a later stage than it initialy was.

We can probably do it later if it helps, however it definitely needs to 
be done before enabling IRQs for obvious reasons, so it is a problem 
that alloc_vm_stack() calling __vmalloc_node() enables IRQs.

Christophe

  reply	other threads:[~2023-09-12 17:02 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19  0:43 [PATCH v2 0/2] maple_tree: mas_wr_append() fix ups Liam R. Howlett
2023-08-19  0:43 ` [PATCH v2 1/2] maple_tree: Disable mas_wr_append() when other readers are possible Liam R. Howlett
2023-08-29 16:42   ` Geert Uytterhoeven
2023-08-31  5:39     ` Michael Ellerman
2023-08-31  8:25       ` Geert Uytterhoeven
2023-08-31  8:45         ` Peng Zhang
2023-08-31  9:43           ` Geert Uytterhoeven
2023-09-06 15:23     ` Liam R. Howlett
2023-09-06 17:23       ` Paul E. McKenney
2023-09-06 17:29         ` Liam R. Howlett
2023-09-06 18:02           ` Paul E. McKenney
2023-09-11 23:54             ` Liam R. Howlett
2023-09-12  8:14               ` Paul E. McKenney
2023-09-12  8:23                 ` Geert Uytterhoeven
2023-09-12  8:30                   ` Paul E. McKenney
2023-09-12  8:34                     ` Geert Uytterhoeven
2023-09-12 10:00                       ` Paul E. McKenney
2023-09-12 13:56                         ` Liam R. Howlett
2023-09-12 14:29                           ` Liam R. Howlett
2023-09-12 15:08                             ` Paul E. McKenney
2023-09-12 15:27                               ` Christophe Leroy
2023-09-12 15:49                                 ` Liam R. Howlett
2023-09-12 15:07                           ` Paul E. McKenney
2023-09-12 15:44                             ` Liam R. Howlett
2023-09-12 16:49                               ` Paul E. McKenney
2023-09-12 17:02                                 ` Christophe Leroy [this message]
2023-09-12 17:09                               ` Christophe Leroy
2023-09-12 17:38                                 ` Liam R. Howlett
2023-09-13 13:14                         ` Geert Uytterhoeven
2023-09-13 13:24                           ` Liam R. Howlett
2023-09-13 13:26                             ` Geert Uytterhoeven
2023-09-12 14:37                 ` Christophe Leroy
2023-09-12 14:10               ` Matthew Wilcox
2023-09-12 14:17                 ` Liam R. Howlett
2023-09-06 19:06       ` Geert Uytterhoeven
2023-09-11 12:27     ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-10-16  8:29       ` Linux regression tracking #update (Thorsten Leemhuis)
2023-08-30 19:49   ` Andreas Schwab
2023-08-31  5:37     ` Michael Ellerman
2023-08-31 19:01       ` Andreas Schwab
2023-09-12 18:15     ` Andreas Schwab
2023-09-12 19:09       ` Liam R. Howlett
2023-09-12 20:01         ` Andreas Schwab
2023-08-19  0:43 ` [PATCH v2 2/2] maple_tree: Clean up mas_wr_append() Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f12ba12c-4625-1b13-a0c8-376138d94b45@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=paulmck@kernel.org \
    --cc=sdonthineni@nvidia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox