From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE2FE7717D for ; Fri, 13 Dec 2024 15:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7FEC6B0085; Fri, 13 Dec 2024 10:15:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F9F6B0089; Fri, 13 Dec 2024 10:15:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CFC56B008A; Fri, 13 Dec 2024 10:15:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 709DB6B0085 for ; Fri, 13 Dec 2024 10:15:16 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DED19AF493 for ; Fri, 13 Dec 2024 15:15:15 +0000 (UTC) X-FDA: 82890283602.15.B13F421 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id D12E4A0004 for ; Fri, 13 Dec 2024 15:14:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L8z7kvt8; spf=pass (imf25.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734102896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+bc0VEUVGJvQF/ApL/kzgdgidEHyZEFRuTt1fwptRzI=; b=zhzSznmOgXg7xkVgniYTlUcoJBbSA6G6rMaXzOZ0oRCHn/C7csnu4O8dA9gDCpQ7UZO4/5 MfKrpyOZejGuyDopntxgqhM16Fh1nXaPXs5xlvcB/8Ty8A9OwZQRPTMhRYMBPVoCdTtNye Ocy/ZW4YAjmjoCR3JFTVOLlQ2zzY574= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734102896; a=rsa-sha256; cv=none; b=P659SupJw5IPoTOl6uMQWRyK/J5ewTJZGy4P1qWH+QdM/YRFzYttNWDf5p8d2tfgjTKuZ9 EQtsIUg4/xMh4Z14a4Wibg7nvk2fD6K1jYXJI8XPZxcxa1q8SoP74v1ooZ2MqdBAg+TgMz dl3yWPPUSKO8LKBO5N9RkgZOYIAjjm8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L8z7kvt8; spf=pass (imf25.hostedemail.com: domain of gmonaco@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=gmonaco@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734102912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+bc0VEUVGJvQF/ApL/kzgdgidEHyZEFRuTt1fwptRzI=; b=L8z7kvt83ZHGjahd/KrNRKUbl3wwWNOLr6BVx6YLyUqZ7C9E2/YcK0NvOujiJp98SqtuU7 YHKtM3agD0Juu//FqODPwu8vwAKgXzSfJZqgZ+lGi7DnHAwVV6ygVvmtOmQ4q8n8eKYwp3 E/Bsafl8W3b7ejw0EnGe5OYuIkY6KGg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-JrPxCyFdPCiu9fsAB3-VSA-1; Fri, 13 Dec 2024 10:15:11 -0500 X-MC-Unique: JrPxCyFdPCiu9fsAB3-VSA-1 X-Mimecast-MFC-AGG-ID: JrPxCyFdPCiu9fsAB3-VSA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385dc37cb3eso1062902f8f.0 for ; Fri, 13 Dec 2024 07:15:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734102910; x=1734707710; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+bc0VEUVGJvQF/ApL/kzgdgidEHyZEFRuTt1fwptRzI=; b=NJe8LrCxfkNP6ldzcp/VPQJjWjdVnWEj6I8D1oGrWcfy5TbC/uo+i+A1SxK2+EScH9 5fKjsh35sMS9NXIHyV4q2TzHaVvY6CXNADsvr0uS9pT573P30dRk3+GOGhRQlYOYLVYy Hsz7tQ+zGRXT3oVDM9oRDGOiDNuRQ5hQWZHSMyefb0HVyrm9sPQhhW6NQM7xutdLErY9 zlGVI/W49SzPPy2W+XDiTmp+I1oZjmxZhqLIdv9/AB42HzFCga3t9oWkbP3X+d3YLFx8 rkW6EqqGyeGl32QtzTyMt3zN0VJI2Gm+vwbcBsLlhOTm/kxMMF85IltsuZ47Rc/CmbSP xVLg== X-Forwarded-Encrypted: i=1; AJvYcCVKBJle1GtH8CFfsyiY0CYc/5xQUDJRIS6e8wO1g5wvaluTl1XSNr0Pyjh1fIhXb8Ye/Fyn39gl3w==@kvack.org X-Gm-Message-State: AOJu0YyS9Z4UJNyedDxHEHtXfj5C7CIJV2iG69jiAgJNXHR3jJTyBfp6 88Yn7xzQD528e5pZpRUE6BOzvpCNYeLsMIC2v5i5l4Y+Eo5exA6mPMz6RO8XYQwWaFoKVSUeDzg +74D69+HbeXtFx9tB5OT0MZvMVV40cn4e9ezaoPK3SEEO7rnk X-Gm-Gg: ASbGncvK3xl4Ypvllv1CkUOOU+NaROgP/vRUNO/khCDJEe8iNIC2tm6STMLZ3QU8OzJ KOxJYXr+hD0MRENCOq3Dms2LDZs2xrRIizAZqQkT/rys0yQg5Vf4jwfF8BJIozr1pk8FOnksjDv jYQFPTvyszh1xxVzr4TNl3Y+nDNIkkbJsQSkze4NPX19p1auhCyPMSoIr93t68Xd3GXlWyYOGDT Fx9FCsvJFc5IYP47OSmtZm0btmBPb0jvR9qholWtksvzBHBokG7DJgdK3IdhFua/+ybfVyj48d6 mAl7RMY= X-Received: by 2002:a05:6000:4026:b0:385:f07b:93da with SMTP id ffacd0b85a97d-3888e0ac2f9mr2575180f8f.47.1734102909847; Fri, 13 Dec 2024 07:15:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYWIrgfbDW5IkfdnLaPWCCW62trF4hAEdP0hve6M/+WtZExSw9QG/CI8XTusgIUMybdrIfrw== X-Received: by 2002:a05:6000:4026:b0:385:f07b:93da with SMTP id ffacd0b85a97d-3888e0ac2f9mr2575156f8f.47.1734102909483; Fri, 13 Dec 2024 07:15:09 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.107.56.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4362559ea75sm52049805e9.19.2024.12.13.07.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 07:15:09 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 1/4] sched: Move task_mm_cid_work to mm delayed work From: Gabriele Monaco To: Mathieu Desnoyers , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Juri Lelli , Vincent Guittot , Mel Gorman , Shuah Khan , linux-kselftest@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Andrew Morton Date: Fri, 13 Dec 2024 16:15:06 +0100 In-Reply-To: <5fe473bd-600e-447a-a321-cae3d838268f@efficios.com> References: <20241213095407.271357-1-gmonaco@redhat.com> <20241213095407.271357-2-gmonaco@redhat.com> <5fe473bd-600e-447a-a321-cae3d838268f@efficios.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0ByZWRoYXQuY29tPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmbiuWMCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfJzZgD/TXjnqCyqaZH/Y2w+YVbvm93WX2eqBqiVZ6VEjTuGNs8A/iPrKbzdWC7AicnK xyhmqeUWOzFx5P43S1E1dhsrLWgP User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e8K8dC1Iy7PROc3qmvtZfePKEttx2AFVSH1L3F45tcE_1734102910 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D12E4A0004 X-Stat-Signature: 5mwbjod8w8dixthjqkcpastfm4ubaou8 X-Rspam-User: X-HE-Tag: 1734102894-730350 X-HE-Meta: U2FsdGVkX18p4wAu8s7lYLLhppQScHBC/h0JZaGJThJfESKUOgfVTFu8KJp+zRKkK5+KZ+d5JmmATYAsXO9nUQQV2C0OfAl9UIdl5JNu5faEnXuBFT12yq72LGVXkE6NUnoqs5s1YeZ2gNB7RTukisjMEgbBv22VcHZjviY357QHO8HOiFeR3ni7iRgELiBdKEdyyrSa0KpTtDrutzdYzyBOpGwsfUJULrgNOnAxuVEjL9tCfHpXxqfIWaNfD9FnNwF/5qrE7X/cPRvqKaX3wHordo0RvZHZ68CtVMCJ4jN8lqGwo0yLrL42ReMwXyPrFuHDGy1+u47FPWlxq/8O/qFRBlAqS/CyWBb0IW6hTey9UgChMZEu5f5i5zrxynhAJpEqJYATHt0xDHdQjb7o2pCgBWvkbOm0jLuF7HgNsYz225PXWoOCAQTAAypoc3B2DaDxQO8rVA0S21iZ3XWcOJZmOypsxPaz+uoCXwr+hGtrIQefKQvvDI8u1cwYbk8RKAHBuJL9IsrV1RpLdw7Bw6zR9152qzVkqpMPSgUHBIbbgZR+3Rj0j/5GC11AYKhNCSAge4a/FAuGCwQ2ajo1+zuLu/PlgqrA9vi+/XDNq5O6N+W8OgVdsRWrai8fKql4dvKUCcCO27Gw1V8U/y2JNbrWmPh8XrKg8D21hSJVTr3Fl6ajyMZIURMOHBKoL1HaWoEvs+KjBSGA5jxvV3/4cUuF6EpUKBBsJPsiJDG441CjWHHZOmaW41wcOzCRj5l3i0peU7IX9iJeTLNCUk/P9Oi86wNE/g59DYDNQrcQnvHlvDTqelL0CoEbAp+jkT6ndQgTj025OAgWrtb4ujuyxrmQeldiqQ11hfqY/vxRqRMSCKMM+cGxTxjrwlJnCWWLz9awc62O4slnvZb7fF5SuZd9Gv8/ZdwuqrZTEG8TmtMFKLYKKqo5RPf2Ief+ul0bDpGkdHI8QL7aqLdmGvn JEfjXK4r nrfO3DkzP5Zu1sluJ4x4Ej7wIfq/uHY2lGr+Z/nUg16EOTmYYkrSaD4iGyqvRvysNfe9ih95T8NXDg1ebVT3vgZ8xmGOYi9uG8HTT3/PlMiE+a14TUDrLFghUjJZp/O+fMzAQEYnScU90wgvllkNWVrMxF7xhn5sxIW7T7JLpZF/qmntVFpunFSfLluzSlf7L5f3o56vUihbR4NlFsJtpLEC4kdAZRmApQiVzmiydJ7xrqJGLdNfzPdx/Hi6kUpVZrdRMogJMjJ7ByCx8RJh5Gv7HD+euiiTq5ZVBfK4E9KiDgJzTKC37LdTxGR03rqN8xAz3VsHtAywLRUPd87DQQsBTbpvFbyEPQR/yqFEogzDwe35PpToFPiPTIAGotAYrB0GU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-12-13 at 09:14 -0500, Mathieu Desnoyers wrote: > On 2024-12-13 04:54, Gabriele Monaco wrote: > > Currently, the task_mm_cid_work function is called in a task work > > triggered by a scheduler tick. This can delay the execution of the > > task > > for the entire duration of the function, negatively affecting the > > response of real time tasks. > >=20 > > This patch runs the task_mm_cid_work in a new delayed work > > connected to > > the mm_struct rather than in the task context before returning to > > userspace. > >=20 > > This delayed work is initialised while allocating the mm and > > disabled > > before freeing it, its execution is no longer triggered by > > scheduler > > ticks but run periodically based on the defined MM_CID_SCAN_DELAY. > >=20 > > The main advantage of this change is that the function can be > > offloaded > > to a different CPU and even preempted by RT tasks. > >=20 > > Moreover, this new behaviour could be more predictable in some > > situations since the delayed work is always scheduled with the same > > periodicity for each mm. >=20 > This last paragraph could be clarified. AFAIR, the problem with > the preexisting approach based on the scheduler tick is with a mm > consisting of a set of periodic threads, where none happen to run > while the scheduler tick is running. >=20 > This would skip mm_cid compaction. So it's not a bug per se, because > the mm_cid allocation will just be slightly less compact than it > should > be in that case. >=20 > The underlying question here is whether eventual convergence of > mm_cid > towards 0 when the number of threads or the allowed CPU mask are > reduced > in a mm should be guaranteed or only best effort. >=20 > If best effort, then this corner-case is not worthy of a "Fix" tag. > Otherwise, we should identify which commit it fixes and introduce a > "Fix" tag. >=20 I will definitely make it clearer, but I'm also not sure if the patch is actually a fix for that. I wanted to mention it rather as a nice consequence of the change. The main purpose for us is that it solves latency issues in isolated environments. >From that point of view, it's still /fixing/ the latency spikes introduced by that commit, so perhaps it deserves the Fix tag anyway. Let me know what you think about that. I'm going to merge this patch with 2/4 and pull yours first in V3. Thanks for the review Gabriele