* [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark
@ 2023-08-09 9:49 Kemeng Shi
2023-08-09 8:45 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kemeng Shi @ 2023-08-09 9:49 UTC (permalink / raw)
To: linux-mm, linux-kernel, akpm, baolin.wang, mgorman, david, willy
Cc: shikemeng
Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
mm/compaction.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index ea61922a1619..38c8d216c6a3 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
return score;
}
-static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
+static unsigned int fragmentation_score_wmark(bool low)
{
unsigned int wmark_low;
@@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat)
if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
return false;
- wmark_high = fragmentation_score_wmark(pgdat, false);
+ wmark_high = fragmentation_score_wmark(false);
return fragmentation_score_node(pgdat) > wmark_high;
}
@@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc)
return COMPACT_PARTIAL_SKIPPED;
score = fragmentation_score_zone(cc->zone);
- wmark_low = fragmentation_score_wmark(pgdat, true);
+ wmark_low = fragmentation_score_wmark(true);
if (score > wmark_low)
ret = COMPACT_CONTINUE;
--
2.30.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark
2023-08-09 9:49 [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark Kemeng Shi
@ 2023-08-09 8:45 ` David Hildenbrand
2023-08-09 12:35 ` Mel Gorman
2023-08-15 2:57 ` Baolin Wang
2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2023-08-09 8:45 UTC (permalink / raw)
To: Kemeng Shi, linux-mm, linux-kernel, akpm, baolin.wang, mgorman, willy
On 09.08.23 11:49, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark
2023-08-09 9:49 [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark Kemeng Shi
2023-08-09 8:45 ` David Hildenbrand
@ 2023-08-09 12:35 ` Mel Gorman
2023-08-15 2:57 ` Baolin Wang
2 siblings, 0 replies; 4+ messages in thread
From: Mel Gorman @ 2023-08-09 12:35 UTC (permalink / raw)
To: Kemeng Shi; +Cc: linux-mm, linux-kernel, akpm, baolin.wang, david, willy
On Wed, Aug 09, 2023 at 05:49:10PM +0800, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark
2023-08-09 9:49 [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark Kemeng Shi
2023-08-09 8:45 ` David Hildenbrand
2023-08-09 12:35 ` Mel Gorman
@ 2023-08-15 2:57 ` Baolin Wang
2 siblings, 0 replies; 4+ messages in thread
From: Baolin Wang @ 2023-08-15 2:57 UTC (permalink / raw)
To: Kemeng Shi, linux-mm, linux-kernel, akpm, mgorman, david, willy
On 8/9/2023 5:49 PM, Kemeng Shi wrote:
> Parameter pgdat is not used in fragmentation_score_wmark. Just remove it.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/compaction.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index ea61922a1619..38c8d216c6a3 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2142,7 +2142,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat)
> return score;
> }
>
> -static unsigned int fragmentation_score_wmark(pg_data_t *pgdat, bool low)
> +static unsigned int fragmentation_score_wmark(bool low)
> {
> unsigned int wmark_low;
>
> @@ -2162,7 +2162,7 @@ static bool should_proactive_compact_node(pg_data_t *pgdat)
> if (!sysctl_compaction_proactiveness || kswapd_is_running(pgdat))
> return false;
>
> - wmark_high = fragmentation_score_wmark(pgdat, false);
> + wmark_high = fragmentation_score_wmark(false);
> return fragmentation_score_node(pgdat) > wmark_high;
> }
>
> @@ -2201,7 +2201,7 @@ static enum compact_result __compact_finished(struct compact_control *cc)
> return COMPACT_PARTIAL_SKIPPED;
>
> score = fragmentation_score_zone(cc->zone);
> - wmark_low = fragmentation_score_wmark(pgdat, true);
> + wmark_low = fragmentation_score_wmark(true);
>
> if (score > wmark_low)
> ret = COMPACT_CONTINUE;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-15 2:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-09 9:49 [PATCH] mm/compaction: remove unused parameter pgdata of fragmentation_score_wmark Kemeng Shi
2023-08-09 8:45 ` David Hildenbrand
2023-08-09 12:35 ` Mel Gorman
2023-08-15 2:57 ` Baolin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox