From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A4BEC369DC for ; Tue, 29 Apr 2025 12:24:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8981D6B0007; Tue, 29 Apr 2025 08:24:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 847876B0008; Tue, 29 Apr 2025 08:24:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E98E6B000A; Tue, 29 Apr 2025 08:24:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CB2A6B0007 for ; Tue, 29 Apr 2025 08:24:36 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7865A1402F6 for ; Tue, 29 Apr 2025 12:24:37 +0000 (UTC) X-FDA: 83386999794.27.A8CE58C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 17343140010 for ; Tue, 29 Apr 2025 12:24:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KTmdC/Z4"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745929475; a=rsa-sha256; cv=none; b=agC2Ao+8EqleTV1TulFcwQltpMzAuMSuxCzJMRDaM0YXvykOo4b8HmDv1IrYigRANodtF6 qAjz0Lq0vNIUE4A43T0NVaR/pyJ3hD9z6lHLzbL4UCaMWwoCgZejd4MXPc+8cDnLukRPKr F4EuEVbgO0kh8Pb7diAbhf2hKihAxbA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="KTmdC/Z4"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745929475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kyBZvHqk9hrp0G96QmgOzfE/FegiKBDztUxLRGGDstI=; b=ppfzxXRi9obFNk2oPy24mhlxiLY/3QKtMeTsIPCQ/fs/FBkljhhOdi2GPG+vsu88jXlstj 3rM/7yCRwUaaWLR3lK1qcddmb1i+Ev5B2x2NX35su6dwVBvGXLM7N9uZj2nKw1+CvUJYE7 /J5vNE0C5LvsN1BdVYjIKrywbuMDAtM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745929474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kyBZvHqk9hrp0G96QmgOzfE/FegiKBDztUxLRGGDstI=; b=KTmdC/Z4MyPSZcMu71S/afXM9gGBNgbS+IFhKOIk0b0UHeAW4LqwYlSxv8OfpBUDMxlEuX plDWJOxFpwEHPju6CgNODKCVay/GFu3fP+QUxZmWJJE/MVNePDPwq6MUwfxo00Gp4uaMWN ifFKlH7HebC+1Qlo/Ad7IVZUTD596tk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-N8_-e3OZPoGarnEDaNzqIw-1; Tue, 29 Apr 2025 08:24:32 -0400 X-MC-Unique: N8_-e3OZPoGarnEDaNzqIw-1 X-Mimecast-MFC-AGG-ID: N8_-e3OZPoGarnEDaNzqIw_1745929471 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d733063cdso38032895e9.0 for ; Tue, 29 Apr 2025 05:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745929471; x=1746534271; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kyBZvHqk9hrp0G96QmgOzfE/FegiKBDztUxLRGGDstI=; b=vixdn95j/L4NoBmDtUnxCrx105lnDxKLZWoGvQoPusq+ybfZ8/ef5tEdlJ2GGe1j/y Dc3Ahb4WGeV9zte0TtTnhq643vGm9Uh98Z6dVyFXhLdCYhX9FLhShkxaLQCjwXbhExeA pEZEdwFWAcewvlAcxePTwv8+T7K1jOCqGzyHHpxdDjUncDVpA89dPuxx+M1CAPMZRuBh n9JJUfSgmDKQAkqlCj4puCnBtpPgzPc6v7OvOfNY/+XUWjxMPptVlxE8ntgO4yoW++Ff hivygX1ICDUBIbUWGsWWejF2/L0dvfCtiGdCKAiUUu/aTvDZ2Vcd5IrSo7TOEWev/YX8 xTfA== X-Forwarded-Encrypted: i=1; AJvYcCWRO6GAQXydehOE6A8dcZdPVpeX3OcX/2B7hwNr+l53SOPVsJzZTVQNX5/U/kt/vlkv3c9QGG+kMA==@kvack.org X-Gm-Message-State: AOJu0YyOCvRIJ4coMY5Sm14LdZQTUNxeo4HGM3gd+O2dPvVevFrJc5gz sX/nSlSff9uR0PPPmLduQ5Kxbcan5pH982AwdFY/bV1fijLeW+VwiHLSeE5YjgyW+cFlQvxe5tz PG2Ud4+pC0Km7d3S3ikVCR+YfxrWP90IQasI2GrUW6v5a6NyB X-Gm-Gg: ASbGncuWAyqYZi0MS+kiGPcxK/FVs/nkxCUSiNExhJZCDzPgONVygnZmmRkC2feaTG+ xq+Tgoh3dbnH0X+fkQH8biJrnYEgshsSND6+6ZSnWrlX/ZxbVnbKGH4KU+6aM/RYu5gpEtDL+AK zpg+S2NVNhr2ZfNbnV9qn9dDcUcpq/QGdfrdRig26v0zqtn73HGGH51fVzEDdeZTU5+03nUeMbX XeN4Xw2ul0nWmrl67/HBBnVjut34Faeit3207AMhnKo+x0jY6XRFQ+hyb09/HbpY8IEuGIw/FgZ JsD+ZgjjiExsfIaua1B7N032XXQrStbqs+8o8GDrlBjOvD4agrCSdH6mXxWj7o0152+6yOfSSvH p2dmy9jI5mq++lEIPN6u6lZTIkegmtja9g4ctHCQ= X-Received: by 2002:a05:6000:1448:b0:39f:4d62:c5fc with SMTP id ffacd0b85a97d-3a08ad47291mr2221560f8f.35.1745929471421; Tue, 29 Apr 2025 05:24:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTFfgPx330EBAU8jvIkA4dn665GTM1w8EZRC6C3R+O9Z4AxC1QxMSXFpEzud78UlgYKo/CBw== X-Received: by 2002:a05:6000:1448:b0:39f:4d62:c5fc with SMTP id ffacd0b85a97d-3a08ad47291mr2221544f8f.35.1745929471082; Tue, 29 Apr 2025 05:24:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5e345sm14003848f8f.94.2025.04.29.05.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 05:24:30 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 14:24:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/6] mm, swap: remove no longer used swap mapping helper To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org References: <20250429114949.41124-1-ryncsn@gmail.com> <20250429114949.41124-7-ryncsn@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250429114949.41124-7-ryncsn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q3-zQCr-Q9UooXEmx7oE6Xoc8P20ygmJPF8zkDJjd-k_1745929471 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 17343140010 X-Stat-Signature: j9gzd9yy4im6qab9qs9w4ds5af8y3hpz X-Rspam-User: X-HE-Tag: 1745929474-962458 X-HE-Meta: U2FsdGVkX18MHKal//pXLZYyRtbcpYoPDG4STtO9xtVD1NDAFpv/Ry8+cCp2SMHzR7L9/AgevLkAJlsZadH4TZD6BduYwSt9cej0g7ZAyoZUlWr7uaTED8mmwIIuTKaRF7DcmCsGWYj02GAyvqMEL8miYD23cNeHNjkckl1tgaA3liEa0Uri0LjyZEzX0bB1OBcsCcRdnOFdjAB6uPD+hlcZTI7M5P1SDqhLWzasM8JAXDHEwpQhOKrxALjtFkPGMpTH6lUtbVZqJ3pB6wPcbyZ9dCkK5h8d7AtsIGqW2epIg9fquvHQ4lDNd25m+uZQQ2wqgoQTsrT05EUByQE+W4ZncTbp88alpDxeWIgaZc7I0REKI+Ix+nZ2frnBSxKFF/W3D02aZQl0mMdeSlHKEhoDKe/WNm3Ae+n2wLSSkm7kSk3p5UEsauiUOCx4nFlQTbTwPLjKjCBcGcIciVbxlpmjhcXVarETacgnHHCal6gobLGiqi2u6oO9hMPZWq3G72L9pgyC3B/51h1p29AOJJlgBe/UamyL+BQLiuHRozbmWfSy0qyBvW4O5CKUSnFufrilnAeMqxP3fyYnRiXy/f52+zBFSYu8f/UCxdBbhDHe2Y9ajGhfqF/74fNd1oohNNZsvPUQpCqS1+hjrCDDh5wGqTm3aTMovc9kOXN/zRlAUuKhzcg25fkSIAbx+lPbgR/6a6UBirJWXhJx6asiR2rCMeozR8EWoFVaKlu0koehGlwK/sK7yez5l6z2x5Jxk4aXFa0PVR7g9h/YhGIz9UGW06tajKu+cm1TerkV3UT6L6lkmSaMfX70b/SP1gkLorobvj9BkEUBrzXeo/l9t/cJ6EWAH8PE6PyAuK8GZU/QFLzPeErC54CzHggditcCAouBvPfJrsYPc8ctKTRR2U14+EwXQEJhqHIPM43PbQCsUIsMtih7/xIUOD6eURuYK5dIfdxpWiY56H9tLPV CsFm890Q 4Jns8AtFZJvEiMR12sLbwlr3H2QeZ+Z0xgorw5HK1ViEV0+DeYHGcRouwIE3Ipn1bAH9LF6xeEoSL4vsHQKBBEKn+w3jjnnzYKIDkjhT8eeTp0m8E0FD7/bxv+x6jvGID4i6WmhMYLraE2RSVgzQmzcuONNsfxCl7N7aKX0BQkwW72YkVnZbsUF08ZgPODwhNdlZwTbasmXNd7IcP+WgLDjsbQYn1Gvnp8n+nqKPrjC+4fIA7vAhM4GEE1+JRYD1JNDDl/JTI2ubAW9LDywQPMHoJeAdxwySmDfGGhPl5C2sR7QBylB8ynwwnpOHExbC1q74AZZpD5NLTi35ew9O7Uhgjoj1MpFVgHDLs2W+WSc6lE4hYNpxeO1LfXQ0X70lfmha058UR2wrt9NOkse/1D+e5MOH4AL4FJM+iPeOt8tuYTgnXZoyvAb4onBsH1eDQgYbtGvlY1+NPGOQEsUyn3eJCuGZhT23gtUit5EOIuTylBCBoGYeuFHa2h3EPxpT+0HRu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 13:49, Kairui Song wrote: > From: Kairui Song > > This helper existed to fix the circular header dependency issue > but it is no longer used since commit 0d40cfe63a2f ("fs: remove > folio_file_mapping()"), remove it. > > Signed-off-by: Kairui Song > Reviewed-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 1 - > mm/swapfile.c | 9 --------- > 2 files changed, 10 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 47b5746d5a65..a071cdc8f902 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -533,7 +533,6 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping) > } > > struct address_space *folio_mapping(struct folio *); > -struct address_space *swapcache_mapping(struct folio *); > > /** > * folio_flush_mapping - Find the file mapping this folio belongs to. > diff --git a/mm/swapfile.c b/mm/swapfile.c > index bf6c98009909..1a36e1f4f198 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -3653,15 +3653,6 @@ struct swap_info_struct *swp_swap_info(swp_entry_t entry) > return swap_type_to_swap_info(swp_type(entry)); > } > > -/* > - * out-of-line methods to avoid include hell. > - */ > -struct address_space *swapcache_mapping(struct folio *folio) > -{ > - return swp_swap_info(folio->swap)->swap_file->f_mapping; > -} > -EXPORT_SYMBOL_GPL(swapcache_mapping); > - > /* > * add_swap_count_continuation - called when a swap count is duplicated > * beyond SWAP_MAP_MAX, it allocates a new page and links that to the entry's Acked-by: David Hildenbrand -- Cheers, David / dhildenb