From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B048C433F5 for ; Wed, 24 Nov 2021 11:11:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756286B0075; Wed, 24 Nov 2021 06:11:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 706D06B0078; Wed, 24 Nov 2021 06:11:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CF5E6B007B; Wed, 24 Nov 2021 06:11:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 4EDF66B0075 for ; Wed, 24 Nov 2021 06:11:04 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 132C78A3D9 for ; Wed, 24 Nov 2021 11:10:54 +0000 (UTC) X-FDA: 78843556428.29.B154A5B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf31.hostedemail.com (Postfix) with ESMTP id 07FA61046314 for ; Wed, 24 Nov 2021 11:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637752253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpE3uP5Ts9fATTGHNvJfdwKZOAJEcAEIb3v/zQVqyQU=; b=MdpBtRAW5mWXHzpVz8cj+0Z82KQbTs6cvmen6FjsjNcj+jPIHHQOU5jc1dZ0hoI4v9b+f8 eA5ugGH/QDfvQuLJkIC5NCAZwg5uFzWLTT6wQFGg/MTmNjRlPCqfAC1WI22L1q6DBOp5TP EqDkTzDwORyxYlPvLZF7I5sE/xKB5n0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-TZkQn1B7MzajFOnFyRxrgg-1; Wed, 24 Nov 2021 06:10:51 -0500 X-MC-Unique: TZkQn1B7MzajFOnFyRxrgg-1 Received: by mail-wm1-f72.google.com with SMTP id i131-20020a1c3b89000000b00337f92384e0so2819139wma.5 for ; Wed, 24 Nov 2021 03:10:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=vpE3uP5Ts9fATTGHNvJfdwKZOAJEcAEIb3v/zQVqyQU=; b=oX4pH3czTQMyGJrtkgNdhuSoNsYxGIkBDr59MtIyHQOxfB4wzFF1lJVvUoWqoDA5Cd x41rtDfqGTDSaEIPbj/QyzF8SlV053n9L1jABIwlSAS7D6OmRnhflyp+8pHmlkJLKICM 7UiKzkNVmVa6a6qP4wocI59cBuIHCsEgsdsUmPokDwvLINIkKMGkpW+5krfEgE3YSyRq MceKMCfEP83R28A699qwWIm+DDqVHhVA9BAk2QtBiUAVUyUlfM0vTLpWKPfg4+PKYoqw csa5+kr2GDpvtZGrzPPHwC0MtMIQ2w6ow7xSGOuTiGZlt4+fy10sKGfRa/BaDqS0o7Gq qs6g== X-Gm-Message-State: AOAM533Zi6/yQcwc2rN0ZcA0OUY2+Tm+mtPs8ArjSADRwmiYAFxL5/Kx 3WQuYaea1vlHYzAGuxTx5QfS9gjZ6y3JR2Vc9GbQFDTsk7/d375M6UT/mp49BrLk/x4I9HOmMDM cwBOo47of35w= X-Received: by 2002:a5d:4107:: with SMTP id l7mr17164665wrp.209.1637752250460; Wed, 24 Nov 2021 03:10:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/35pNqxIt/3x1nXEuvBK3BdN1xHIMOgL0EuPUrA8pSNn6Wr5VuEfMwehTjz1oqeOxyanzyw== X-Received: by 2002:a5d:4107:: with SMTP id l7mr17164617wrp.209.1637752250154; Wed, 24 Nov 2021 03:10:50 -0800 (PST) Received: from [192.168.3.132] (p5b0c6380.dip0.t-ipconnect.de. [91.12.99.128]) by smtp.gmail.com with ESMTPSA id 9sm19103331wry.0.2021.11.24.03.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 03:10:49 -0800 (PST) Message-ID: Date: Wed, 24 Nov 2021 12:10:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] mm: Use BUG_ON instead of if condition followed by BUG To: cgel.zte@gmail.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, chiminghao , Zeal Robot References: <20211124030849.34998-1-chi.minghao@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211124030849.34998-1-chi.minghao@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 07FA61046314 X-Stat-Signature: kzsa4g1zccdwa5k6n1dadnxk7egyzk59 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MdpBtRAW; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf31.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1637752246-790535 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.11.21 04:08, cgel.zte@gmail.com wrote: > From: chiminghao "mm/memory_hotplug: Use BUG_ON instead of if condition followed by BUG" Would be better > > Fix the following coccinelle report: > ./mm/memory_hotplug.c:2210:2-5: > WARNING Use BUG_ON instead of if condition followed by BUG. > > Reported-by: Zeal Robot > Signed-off-by: chiminghao > --- > mm/memory_hotplug.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 3de7933e5302..aecb12bb7513 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2212,8 +2212,7 @@ void __remove_memory(u64 start, u64 size) > * trigger BUG() if some memory is not offlined prior to calling this > * function > */ > - if (try_remove_memory(start, size)) > - BUG(); > + BUG_ON(try_remove_memory(start, size)); > } > > /* > Acked-by: David Hildenbrand -- Thanks, David / dhildenb