From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35253C7EE2E for ; Fri, 9 Jun 2023 09:06:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B56B68E0003; Fri, 9 Jun 2023 05:06:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADEC68E0001; Fri, 9 Jun 2023 05:06:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 980248E0003; Fri, 9 Jun 2023 05:06:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87C238E0001 for ; Fri, 9 Jun 2023 05:06:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 574C3C01A2 for ; Fri, 9 Jun 2023 09:06:10 +0000 (UTC) X-FDA: 80882627700.07.0BDE1F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 2294A100018 for ; Fri, 9 Jun 2023 09:06:07 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpEzYbuF; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686301568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eyj9qAaMTXhV0BDBMXgw3bkhoC43Djt8OMEq06UECOo=; b=3veFhZWyC26GH3aCIL1YJJp5Oo6e2SEIIBtKUa4qFlgBP9oayVfHYA250XpLjUH9Gyjhup AQkV43gXkN92zArbFVEc5yGb8XuAzpfN9+Mqbxf1wR8r7KOAwJIjU1+IZTcDJMDqxsqGoQ B5Jqy134KvKXtte2jUOosDA98jepSNM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686301568; a=rsa-sha256; cv=none; b=hKRLeWbuG7XqDIbvcLpL66Mm2J49ZKYOl+Ij6KKwF+PDg1c0GpLQoGSM8plzJAvP1kr7zl yU6zxrWbGipXQ8TDAwcXIYz3bovA7h9/IZJyPTlX/YXv0x11D3o5axgP4OcgH4J7TFDLzp 1zpNdnb9iRp1T48na9u99sN2fBtwhiY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EpEzYbuF; spf=pass (imf14.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyj9qAaMTXhV0BDBMXgw3bkhoC43Djt8OMEq06UECOo=; b=EpEzYbuFJzJ16t3cdUerq6nBDlvoivWJ3MML+Iyfnbd9IV1J+lbRAWAGTC/WE/nnuDkpl6 tmgga0QiW/vgwKCuBiGxXIdelZsc6ZbDhUQFR4otrSRuKhUIV059Ykvp0/WPBjZhMP/X8X lxRNrnwMOi2/nlWxG1ZLVtp2G0u1jZM= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-WEwXm1xMO5y8l195apg8Hw-1; Fri, 09 Jun 2023 05:06:06 -0400 X-MC-Unique: WEwXm1xMO5y8l195apg8Hw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-51566dc6066so1498207a12.3 for ; Fri, 09 Jun 2023 02:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301565; x=1688893565; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eyj9qAaMTXhV0BDBMXgw3bkhoC43Djt8OMEq06UECOo=; b=IqNquNmy7gbCKiF12NXQE80tAA/h+AT7/g6lrsrCT0Ngq7f2ccXQ7B/oiVRI0F6FYd OSqJfPQkwePiwflwHgkIT9yy4VURIYeiegxQCajevnkgKlKmjiI+iMq9b9ZN0yWssg6E 1g9u187jo/fU4ux+RGXXtbrs911uQ0n+xRrCtvFlI+ug9YG5voTPJx+0FWU+soRRyxJp 45dIzIZsrHHzzyvO7r+qiz5lX17r+ul3jeM7FXoSCkLhM5j277a+C3FMJb1z5hiYF/3J dCUySpQ+bJr89BzXYuCyIzFNCToLTvG971rW9zSt9kEGlOAHo/QUvGNn2+cWG7NtY8Cp xiGA== X-Gm-Message-State: AC+VfDzfBLzlGsGKOJsW79VhhrHdGBJt3cl0QcL5h34Qi0c2zV3NKm4o LY2Oz7+tzcp8sB6qfPQlz87ExH2xoufi40Jshce9FQ+ddYN0/zidZCYRI1pDGtPoUGETdczEC3I tAdFQmGLUIE0= X-Received: by 2002:a05:6402:643:b0:510:82b4:844d with SMTP id u3-20020a056402064300b0051082b4844dmr902467edx.2.1686301565420; Fri, 09 Jun 2023 02:06:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Eo2fL8sg8ZAFF9ExDb1hoz+RWsXilNiiceAqQ1jh6YF+h+q2Lb+V5P8mQdJn5E/+DPP6p2g== X-Received: by 2002:a05:6402:643:b0:510:82b4:844d with SMTP id u3-20020a056402064300b0051082b4844dmr902445edx.2.1686301565157; Fri, 09 Jun 2023 02:06:05 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id f9-20020a056402068900b0051495ce23absm1517006edy.10.2023.06.09.02.06.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:06:04 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:06:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH mm-unstable v2 09/10] kvm/x86: add kvm_arch_test_clear_young() To: Yu Zhao , Andrew Morton Cc: Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-10-yuzhao@google.com> From: Paolo Bonzini In-Reply-To: <20230526234435.662652-10-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2294A100018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6r97cstyiq4j9pqcuu3bqtgk13apnbf1 X-HE-Tag: 1686301567-792911 X-HE-Meta: U2FsdGVkX195yQJWo6gALR/c0cXnlLE6ahI6blh1yKV0r8/fHqCSdH7WngMT3wZn6FOyNP1AygycYiLT+Jkdz3+xRdKdjqjOYji1Aif9aWik+6IWo/Iz6pcD1AuKttaYwCXLlGXDkAqyJeI8dn24pAIpzWZIIseXsPzZIk+kbNYC2kWZn5JpdSd8XSvs7cA23m07WdYtrtmD2yiSc0cpHJT4Lemxv09RXrIGLJUKiScjWD41JNDSShMty4Fh0bW5wJeCVtWkfmhGxEn6mdZ8ZeKuhJ4aQlRa4Q17k6OnJnsGyvQWKduXytuJMTLcw9oMIEcvuJ6u/Y2/5V/iL82CNHXGo2LqW+/kj/aT9zM7p04kvnqHzlTXMsiD/Wmr2MQdsEeP+zSMUtaIp1zYC+bjn3iv8CWYtHlW230A0NytfzhhHHHyqeQ+o74WCUoZp4auZWKK+mg0wNKXjSDx5NhP7p4Cy0Z59nbzNX1b6HZYS0LlQjk9NkF9EUu5upsHYrXXQIy/75PSfHz2aAhIMNaV1a7y3h8jWJp1qNAwZiHv0TUsNQoB2DQ48Y25FLPmK5W9DE2g1PpKAzfbLdQ4gKGcj5RCwcVvOJXnP3IIhvAfBgW5jUd/MeJrb50NMhTRGqrxBmiPw8Y3XpDVnaIc0XVhTRQrhDZOATp4721gK5cQ4E+Bdcd7lgd5mHGcByhqQDxoVBQjNF87SLlUCB/zbmiQ5ym3CEVgLH5bl7ERnmy+bleByTq9Uk/nqOTWh8CCsqyJigC4irrE2afjR70bmbKjAVcFxGbEZ3Cfw2zUQooNGLSAHAm3npk8W27SteoKT6dq/6hp+DozXEmlAhiJWUzf76q6qt92NerolsiYTgzdBcM4d36Emre5nEphPsfzdi4Ekk6rRqBZxqdhBARKYzkBUXPRihWVj3Rc4LZ9VY1gnxx6P+poObaoiecZnixLPkW3O0DX+r7KLVdP8wHvQqa BmWlXOql 9hbqtoLChQGjx1MyL5F3ttiaTchLDXvhPoThG67Esxrb3Ifa/AFARstW/qw4vismE6vAHZ1Mxg2QaBqJh3U7nUTfkhBvNBwK7EymPJAsNifMynm7WDQxDe7fkoDHzLDXloxI24vLAjLbfWvqYD5qCNmH+HymP955wIk4WyRk/UbszSbQGE33EuHrRPjcuuF1orBqkkWc2E6BulrUC59RZYxVVeZTIsaiNydwObWGUfiqHbQoJBjCGiF3bCnB43IVevtITwuGJAi37wl+rWnE1S8grmdZLjxmXWVMPJEuJhEu01n5wa9GVs3m9BHrv5zBt7qJ7ywZ74IszzcC8dRXLfupkKJFElgKFbdQ9+BZT/mITxqmIgpK105ZY6Ymlyvy0U9zq2esDIpWxSJo+87oBCcqWV/vOOPSprkuwLw0yyPZ+U0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/27/23 01:44, Yu Zhao wrote: > +#define kvm_arch_has_test_clear_young kvm_arch_has_test_clear_young > +static inline bool kvm_arch_has_test_clear_young(void) > +{ > + return IS_ENABLED(CONFIG_X86_64) && > + (!IS_REACHABLE(CONFIG_KVM) || (tdp_mmu_enabled && shadow_accessed_mask)); > +} I don't think you need IS_REACHABLE(CONFIG_KVM) here, it would be a bug if this is called from outside KVM code. Maybe make it a BUILD_BUG_ON? Paolo