From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037C5C0218B for ; Fri, 24 Jan 2025 15:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69A07280076; Fri, 24 Jan 2025 10:41:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64A01280070; Fri, 24 Jan 2025 10:41:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C3A5280076; Fri, 24 Jan 2025 10:41:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2CEEB280070 for ; Fri, 24 Jan 2025 10:41:43 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D63721411C9 for ; Fri, 24 Jan 2025 15:41:42 +0000 (UTC) X-FDA: 83042760444.21.BF72C8D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id 6B10640002 for ; Fri, 24 Jan 2025 15:41:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNdSw4hD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GcE12sTR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNdSw4hD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GcE12sTR; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737733300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P5/3qI25kpySc06m3d15iUs/ab3VRSW9FnFnw3hIeMQ=; b=K4sgBzj/mKRrfKYbZW06flmJhMod4LQBdH7kztnWag9ND+6Xf/Yz5r+TsUvne8OSsR60qW pKKIVVMUrWRxfR2kbXLVn2BFoNLocsYYTM46lm6vG5Jz4jvjiIsNVuAENxk/CubOGkSm0D WU2n8jI6+Ciy5uTT0h8tb1aB7K8uQFY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737733300; a=rsa-sha256; cv=none; b=WSFMtQL47h70xwf4wEuiiJAbwmboDl4ay9c0WtDT9pRoKI46iGw+YP+qH4VEIyuX8CwwES 4m5A4GFpEgVn3V53adcPsDQ+KCZlQTz1SrIS3aqa/kW9OvHS7oF2eK+p7HREibOlVsw4wc YuVJTlzh3e0jRGEBrRJRRq7VoKo2sR4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNdSw4hD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GcE12sTR; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HNdSw4hD; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GcE12sTR; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8A68D21164; Fri, 24 Jan 2025 15:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737733298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P5/3qI25kpySc06m3d15iUs/ab3VRSW9FnFnw3hIeMQ=; b=HNdSw4hDBfka9WWb83NG7E7gjM3IOHwEPgR+HMJ/IOBaHLoQmGd2LVcwli0p6VMFaA/75R AuHNEdejKGF5RQyNkqIqI3xL/pFx6Cjf2dNi7W15ZV/UHqoGPtrXBXduRlVu7bwkEedGrT bGhtaPl7jyWklYwZKil0SmoKj68Es98= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737733298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P5/3qI25kpySc06m3d15iUs/ab3VRSW9FnFnw3hIeMQ=; b=GcE12sTR+hRuo+YcT5pvWYk7BV5+eF7R0S+A01LDDJ7SMkE1u9tnadf6HQ9z5RlWm/gPsf OGvqGSekO5kF52BQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737733298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P5/3qI25kpySc06m3d15iUs/ab3VRSW9FnFnw3hIeMQ=; b=HNdSw4hDBfka9WWb83NG7E7gjM3IOHwEPgR+HMJ/IOBaHLoQmGd2LVcwli0p6VMFaA/75R AuHNEdejKGF5RQyNkqIqI3xL/pFx6Cjf2dNi7W15ZV/UHqoGPtrXBXduRlVu7bwkEedGrT bGhtaPl7jyWklYwZKil0SmoKj68Es98= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737733298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=P5/3qI25kpySc06m3d15iUs/ab3VRSW9FnFnw3hIeMQ=; b=GcE12sTR+hRuo+YcT5pvWYk7BV5+eF7R0S+A01LDDJ7SMkE1u9tnadf6HQ9z5RlWm/gPsf OGvqGSekO5kF52BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 72107139CB; Fri, 24 Jan 2025 15:41:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +xiGG7K0k2cTJQAAD6G6ig (envelope-from ); Fri, 24 Jan 2025 15:41:38 +0000 Message-ID: Date: Fri, 24 Jan 2025 16:41:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: simplify SLAB_* flag handling Content-Language: en-US To: Kevin Brodsky , "Christoph Lameter (Ampere)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20250117113226.3484784-1-kevin.brodsky@arm.com> <0fa27da8-d523-77f7-0473-bb317ec9d83e@gentwo.org> <8ee3efbd-e24d-4e7b-ab3b-6b0efd62296b@arm.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <8ee3efbd-e24d-4e7b-ab3b-6b0efd62296b@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 6B10640002 X-Stat-Signature: nx6wx13y41kxdhgndi78nscp5ka4rh5n X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737733300-68524 X-HE-Meta: U2FsdGVkX1+v4fCMgWpjNqR7Rxp9Z7EZKjWErhmXtOq5+dztRDPUAtM1DcwNYKExqRSkCnmzN43rw8EuJ50m3HnATKr2vYYfpE0H1UnJzi/3ECQ+lak11lcJ5X2S/YSdOV6Vw9o4Wm+R/DX9Bc0PbmEBhHUBYO7eWjpFtOUCyCGtU3RctAD/aio4enEI1Pa4RvJ4LMzAT7gj0sTiXWRJcP4D078X/rY9Cy0gbz3HtacMZpLIlTeI7KBlAUVy6mfQzAMD3HWPkNGkc6kMtx3tlnR9otTrOOOzbWh5i5kEtZljdoMMvuEYJZYxdDICsLqtzyl+EyEo9CKtOEddcCgreF7hHEHNJHH9toPtUGWIYAYBiVWTJdkQMSFNpjIceMLEuLB5HsA147IR2eU/E3M2iBoCgDbOIRnCcgUS22Kqj6WMs9/bAz3uu6EyH8wK0PHxZaZ3s36td34sFK4FOjSKNxhffbJMv7PdYTCzomgE0e7Z9r3QMqPwXiuEjRS0sieZFpGMJ1K1r+mDhe1l/x/ikAsff/xLJuU9l80nONuKXGA1CUrg/gglUVmVX8O9Ng+jNN8btANL05gAvfTUVqUf55jes9fphfZPXZZU9LAwW0BxTkVW8BZW6K0cO3ap9cG7u7TnK3lltv8YqRM1ZMcqsumG+MKlo4HqYpoMfbgL9yRbgUeOCzCOw3z/GwMVZhSjWOd2eWZD5psjySiswvfIm6Sou2/Bta7lpV6kS7Iq96rtL49eyhIsU2rIzPPzNkQTYH3P1mcb1gjFoDTvlNW4LRN3Cg++q/I+W6xO6q/4FSPcZIu1T3AEramPaAbTchJ0M8Pau1vQh6UtcvUH68WpEvk9FVxbVBixse7jyeO9QTqXMLELjE+tb3qWt3mMg2uq7ljXZpO0rw81AiKjCev/RNoychdj3OEuspe/X35lbMMnyfThbSGB8QXmnKZ5DSOh2eXNPbIjCvM2q6xGZJ2 1vcQO7u1 SlRfzxwe9gS2Kwi+J9mq7nRMU8eNYnIeKAfAZpvclHP2sDWk8EeUA7H5AvoXSKKnQmUpq5H+ZjGiGNN+EZJBWh2U2agI5+Pm8/9FXZeilbObe/KwMe1wSx5DAFB3xlaNg0S9f67uCKI9Ql91GzQtTtpiychASLKR5oN43jsb8AK/gddp2G0OlqBLQuea6szWh0sDT14VXy3rXuAeuOpMkwTMCx2WVWGsOO9Sxa0xT6VobbBn78I59GolO5YfCzgtn5So01uLYHWXwC03rL0NOwrdwmPBuZi7fY7yBYYxQ1LjKxBYnjARXcaCK+rCDnCBQOLfLx3FOx3vKoQiNVrLJZ/fFgPaPeXYe3+PiuLgWTaFlIoBcmnc6JgRxV8k3CyT6LgAlynn11JC+Q5nOuwCoFdUsQKE8eePekUMEUUNEjB1z9W+jfiZWJhYSS3v/viKboxIqIkjFgX+Zv5Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/21/25 11:46, Kevin Brodsky wrote: > On 17/01/2025 23:13, Christoph Lameter (Ampere) wrote: >> On Fri, 17 Jan 2025, Kevin Brodsky wrote: >> >>> index a29457bef626..3b07cdaac3ae 100644 >>> --- a/mm/slab_common.c >>> +++ b/mm/slab_common.c >>> @@ -305,18 +305,6 @@ struct kmem_cache *__kmem_cache_create_args(const char *name, >>> goto out_unlock; >>> } >>> >>> - /* Refuse requests with allocator specific flags */ >>> - if (flags & ~SLAB_FLAGS_PERMITTED) { >>> - err = -EINVAL; >>> - goto out_unlock; >>> - } >> I think we should keep checking for invalid flags. > > The commit that introduced this check [1] aimed to ensure that no > allocator-specific flag is passed to kmem_cache_create(), so it seemed > to me it was no longer needed now that allocator-specific flags are gone. > > Having said that, we could keep it in order to reject flags that are not > supposed to be passed to kmem_cache_create() (e.g. SLAB_SKIP_KFENCE). > With that approach we'd just need to clear SLAB_DEBUG_FLAGS below if > !CONFIG_SLUB_DEBUG (and get rid of CACHE_CREATE_MASK). Sounds like a good plan to me, thanks! > - Kevin > > [1] > https://lore.kernel.org/all/1478553075-120242-2-git-send-email-thgarnie@google.com/ > >>> - /* >>> - * Some allocators will constraint the set of valid flags to a subset >>> - * of all flags. We expect them to define CACHE_CREATE_MASK in this >>> - * case, and we'll just provide them with a sanitized version of the >>> - * passed flags. >>> - */ >>> flags &= CACHE_CREATE_MASK; >> This would silently clear some flags instead of creating an error. > > >