From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D119C433EF for ; Tue, 14 Dec 2021 17:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4D646B0071; Tue, 14 Dec 2021 12:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFBA66B0073; Tue, 14 Dec 2021 12:19:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EA836B0074; Tue, 14 Dec 2021 12:19:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 8FF426B0071 for ; Tue, 14 Dec 2021 12:19:30 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4E8048771F for ; Tue, 14 Dec 2021 17:19:20 +0000 (UTC) X-FDA: 78917060880.17.8228669 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf28.hostedemail.com (Postfix) with ESMTP id C8E34C0017 for ; Tue, 14 Dec 2021 17:19:19 +0000 (UTC) Received: from fraeml706-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JD4kR2flTz67xBm; Wed, 15 Dec 2021 01:14:55 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml706-chm.china.huawei.com (10.206.15.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Tue, 14 Dec 2021 18:19:17 +0100 Received: from [10.47.83.94] (10.47.83.94) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 17:19:16 +0000 Subject: Re: [PATCH v2 10/11] iommu/iova: Move flush queue code to iommu-dma To: Robin Murphy , , CC: , , , , , References: <0752bfc207b974e76eab7564058b5a7b9e8d5e6e.1639157090.git.robin.murphy@arm.com> From: John Garry Message-ID: Date: Tue, 14 Dec 2021 17:18:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <0752bfc207b974e76eab7564058b5a7b9e8d5e6e.1639157090.git.robin.murphy@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.83.94] X-ClientProxiedBy: lhreml701-chm.china.huawei.com (10.201.108.50) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C8E34C0017 X-Stat-Signature: jncmzbrrmcchaeqe3ng1qquddkjqw6bd Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of john.garry@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=john.garry@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1639502359-769229 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/12/2021 17:54, Robin Murphy wrote: > + iovad->fq_domain = fq_domain; > + iovad->fq = queue; > + > + timer_setup(&iovad->fq_timer, fq_flush_timeout, 0); > + atomic_set(&iovad->fq_timer_on, 0); > + > + return 0; > +} > + > + nit: a single blank line is standard, I think Cheers > static inline size_t cookie_msi_granule(struct iommu_dma_cookie *cookie) > {