From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Roman Gushchin <guro@fb.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH RESEND] mm: show number of vmalloc pages in /proc/meminfo
Date: Wed, 15 May 2019 12:44:16 +0530 [thread overview]
Message-ID: <f0e640c9-2eff-ffc5-8558-4bc1b374eb2a@arm.com> (raw)
In-Reply-To: <20190514235111.2817276-2-guro@fb.com>
On 05/15/2019 05:21 AM, Roman Gushchin wrote:
> Vmalloc() is getting more and more used these days (kernel stacks,
> bpf and percpu allocator are new top users), and the total %
> of memory consumed by vmalloc() can be pretty significant
> and changes dynamically.
>
> /proc/meminfo is the best place to display this information:
> its top goal is to show top consumers of the memory.
>
> Since the VmallocUsed field in /proc/meminfo is not in use
> for quite a long time (it has been defined to 0 by the
> commit a5ad88ce8c7f ("mm: get rid of 'vmalloc_info' from
> /proc/meminfo")), let's reuse it for showing the actual
> physical memory consumption of vmalloc().
The primary concern which got addressed with a5ad88ce8c7f was that computing
get_vmalloc_info() was taking long time. But here its reads an already updated
value which gets added or subtracted during __vmalloc_area_node/__vunmap cycle.
Hence this should not cost much (like get_vmalloc_info). But is not this similar
to the caching solution Linus mentioned.
next prev parent reply other threads:[~2019-05-15 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 23:51 [PATCH] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Roman Gushchin
2019-05-14 23:51 ` [PATCH RESEND] mm: show number of vmalloc pages in /proc/meminfo Roman Gushchin
2019-05-15 7:14 ` Anshuman Khandual [this message]
2019-07-09 5:59 ` Minchan Kim
2019-07-10 1:31 ` Roman Gushchin
2019-05-15 4:27 ` [PATCH] mm: refactor __vunmap() to avoid duplicated call to find_vm_area() Anshuman Khandual
2019-05-15 17:18 ` Roman Gushchin
2019-05-15 7:41 ` Anshuman Khandual
2019-05-15 17:17 ` Roman Gushchin
2019-05-15 17:35 ` Ira Weiny
2019-05-15 17:45 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0e640c9-2eff-ffc5-8558-4bc1b374eb2a@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox