From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3142C00140 for ; Fri, 5 Aug 2022 18:22:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D9BE6B0071; Fri, 5 Aug 2022 14:22:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 562226B0072; Fri, 5 Aug 2022 14:22:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DC678E0001; Fri, 5 Aug 2022 14:22:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2AF1F6B0071 for ; Fri, 5 Aug 2022 14:22:52 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9332FAC4E3 for ; Fri, 5 Aug 2022 18:22:51 +0000 (UTC) X-FDA: 79766360142.29.335D019 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 116A740150 for ; Fri, 5 Aug 2022 18:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659723770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5p3/E3MKKChtQ+yJPQTq5w0X3LO2YWBfr+q1/W8OCSg=; b=fj+lO4Pgh2WtMTt9Tf9uiN0svBSKvcSiTNIjFeJFKbj7w6bS5ePgS8TgO3RNHpgxKoYyoo 7NACRvXCWSXvT026BfYjF3bwirH5XCl9MbGnDWhx6H295qg67VF43Q5ja5j8lO3vMyTcFE MdZ2qDvN+euytw6lnnLx8VatVLRK2OE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-ouQNbPb8O6uQLJdRMEtGew-1; Fri, 05 Aug 2022 14:22:49 -0400 X-MC-Unique: ouQNbPb8O6uQLJdRMEtGew-1 Received: by mail-wm1-f70.google.com with SMTP id n19-20020a05600c3b9300b003a314062cf4so3724775wms.0 for ; Fri, 05 Aug 2022 11:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=5p3/E3MKKChtQ+yJPQTq5w0X3LO2YWBfr+q1/W8OCSg=; b=Nz/9OS9O5+kWE6i1KCvTuZ+abTnp8/HbaIxsshAo5H32S4YOfGBMnZHMFzO8YB2oj3 LgLowmQtroNc2RljPXp2jw7kbaYETqWg827FjAzshj5lUMWz8UAE1vRxVJAUwiHXqaF8 1XV1qpT6ur5c5BIIYxRkD4P/AP60ivPliZ2Z29FvU5vlDyfyiEYfyg0odnHQk+hOtvd6 T4nD4x+Y8oE506BEKTGcTLmLPIu1/zmhkgJ9deWNQ3boyVnoi/kYLYoH9an7rgSBIb0v 2TPCYadnPOQ6u2FlaVb/o5WawwB6j1hKiTkqm1OFDO8mNIFQXZAfSrShDRYtpRsEGljE yQkw== X-Gm-Message-State: ACgBeo0P8YuMROyFxDVFEbuuGlc6ipMa/vsne0A1IuWcS0ZPY2bXO//P gdo2hMTX2KGE6NHaWNYxDt2DGznNO2NnCC4rV79rCTBoDw5LjKyEGDF3dzkpaPlMfz1+3yVt5cM 8I7L4VG214Rg= X-Received: by 2002:a05:600c:22d8:b0:3a5:1450:669e with SMTP id 24-20020a05600c22d800b003a51450669emr5040806wmg.102.1659723768160; Fri, 05 Aug 2022 11:22:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR4pH623NdL7leuNH6oZdmjVJRAOBVTCO95WffXCQlv2dho7acCWovQ4knC3wfTsvFK8io5zOQ== X-Received: by 2002:a05:600c:22d8:b0:3a5:1450:669e with SMTP id 24-20020a05600c22d800b003a51450669emr5040793wmg.102.1659723767924; Fri, 05 Aug 2022 11:22:47 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:fb00:f5c3:24b2:3d03:9d52? (p200300cbc706fb00f5c324b23d039d52.dip0.t-ipconnect.de. [2003:cb:c706:fb00:f5c3:24b2:3d03:9d52]) by smtp.gmail.com with ESMTPSA id g6-20020a05600c4ec600b003a3199c243bsm14398006wmq.0.2022.08.05.11.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 11:22:47 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 20:22:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song , Peter Feiner , "Kirill A . Shutemov" , stable@vger.kernel.org References: <20220805110329.80540-1-david@redhat.com> <20220805110329.80540-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659723771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5p3/E3MKKChtQ+yJPQTq5w0X3LO2YWBfr+q1/W8OCSg=; b=x8w9WH30f1ndXBdwAIC7iI7AKQfZ/hVKyMWevKEib9H+EhX+yNpFsGB0S0hFkdPlJWjpVL tATywSjwDEsGV3ddCaw6T+eN2MkvKfcxa0BgsNS/Ss8pFGLFUdf0Thl+zCX6rtMOXXvpdS mrl2wOfOwq1Fc3EUOlm+Ut5GN9HUYL8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fj+lO4Pg; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659723771; a=rsa-sha256; cv=none; b=CkaJ4FVcVLDZfQJswgxcNKIL7thAd4i82yE27/COY86N2I+uBhDUqYOOjtoNHiWc0oSf3M yt8FjJ5sJk4bodl0tuuV9F9ASWnIrUw0EKvUfebDQHm674yg3WF9OCz4ja66vbxVdHg67N cV4Uj41gX66RCUCtwalDpMb17xtmQ1M= X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fj+lO4Pg; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 116A740150 X-Stat-Signature: psofbuyb3138stj6nzwuwkgfe7ywwpfh X-HE-Tag: 1659723770-987351 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.08.22 20:14, Peter Xu wrote: > On Fri, Aug 05, 2022 at 01:03:28PM +0200, David Hildenbrand wrote: >> diff --git a/mm/mmap.c b/mm/mmap.c >> index 61e6135c54ef..462a6b0344ac 100644 >> --- a/mm/mmap.c >> +++ b/mm/mmap.c >> @@ -1683,6 +1683,13 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot) >> if ((vm_flags & (VM_WRITE|VM_SHARED)) != ((VM_WRITE|VM_SHARED))) >> return 0; >> >> + /* >> + * Hugetlb does not require/support writenotify; especially, it does not >> + * support softdirty tracking. >> + */ >> + if (is_vm_hugetlb_page(vma)) >> + return 0; > > I'm kind of confused here.. you seems to be fixing up soft-dirty for > hugetlb but here it's explicitly forbidden. > > Could you explain a bit more on why this patch is needed if (assume > there'll be a working) patch 2 being provided? I want something simple to backport. And even with patch #2 in place, as long as we don't support softdirty tracking, it doesn't make sense to enable it here as of now. -- Thanks, David / dhildenb