From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749B1C76194 for ; Thu, 25 Jul 2019 16:48:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B70321951 for ; Thu, 25 Jul 2019 16:48:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B70321951 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD5B76B0005; Thu, 25 Jul 2019 12:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B86A86B0006; Thu, 25 Jul 2019 12:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4E4F6B0007; Thu, 25 Jul 2019 12:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by kanga.kvack.org (Postfix) with ESMTP id 80CA16B0005 for ; Thu, 25 Jul 2019 12:48:50 -0400 (EDT) Received: by mail-ua1-f71.google.com with SMTP id p13so5391815uad.11 for ; Thu, 25 Jul 2019 09:48:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=leMWAIfWTXj1mqExvS/NRtgwNRKENxY7ZLNM3HUR38A=; b=oItFZFDliiYNGGji86TF+Y9ypzH4yM6rJ7SjNCq1fLj3Cfcrfivmip+28JzEHLxMP3 Lw9Vqo8CkWdFKlnYGYgAMGZAfZgoE/J9vnd3BKf0M4TFTD0uHibgE+UsuDJPTGxVuRSc gjZpavn6QCCfTqXCCHV+VBvZNdjhV7sOPL0nq8irqhJjDAFQMfiTay9d66jPgTzI5vj+ VAbRb4CXfGKa+UMNzgGiql+4UsMyCXgvlGnpRcBDEBpM7X9YTLq57j0M+dGvXKgJnxXu lkx3yIzM56kw1fVruU+pS7HaLzFtoHhm26AZ36Bof7+9lwIhwJ1UFj4+dbNmx8+isDVo UnYw== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAVDUdnoX36716kPQP3MAI1LcGnu2vaBExd2NobWJiRboSqrEsLh k6VmIJy7jE7JpzxDvNWdvj/wdkQTp0EeyibIFXOI91EbmiVx6ZQdkaach+vHDjCxTZsyU3dLh6v MPkaeY74Ptp/pxcu490D1SIt5UTCOISGN0LByP2U9AGGMXEeqILYOxn1ylXFa9jmBHA== X-Received: by 2002:a67:ead3:: with SMTP id s19mr39193926vso.147.1564073330253; Thu, 25 Jul 2019 09:48:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyY17l+c9bM5zJgNnT99R+RouPjc7kXV/f9jNbbBRQ7GBWugS8mDb+u2dNYIzE9e//I5vLF X-Received: by 2002:a67:ead3:: with SMTP id s19mr39193861vso.147.1564073329653; Thu, 25 Jul 2019 09:48:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564073329; cv=none; d=google.com; s=arc-20160816; b=XOLDaHGHE62Xsvzy9rdxiU1JC4gZ/EuoonKqPhhh7Ub/4CrvuA/PWYYaXnFHVN/94M h4dVZoV9/0vyKEysDfTzfqX8QQ9Ot4vfIoMwlAr+iAE+o6pkiuSiiRyRg7I0oq4aG9Lu NF/KDkouUoAQwVTyAgGfzvPmr76f0Ydua+MBZnU5FEbxQxJINMZcn5ct/pb3IAzilAk0 J4mykYvOrl4x2d+2KUANjWYvyzZ7OhJxCKS+npJt1eg82FnbIA90ewAKeD7ZOLzhWmCv KYURKbyGALDFT0F+diRNttj+hgedXS8+7mG0mAy/WlYqh+9qQWsBmk0Q8NdcfibZVZHB QRjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=leMWAIfWTXj1mqExvS/NRtgwNRKENxY7ZLNM3HUR38A=; b=juQZoO7WdSUD66g6vrQ+w9VBVW4JXYYBatobqcYuop4xwWYSOyenR+9CxHusydAd2Z ZNJNNgszkYMs9O+RAJHOzzH4IMdZOd6gXQZciaoLbdueIBj86gZYUOpl7bXlNtn6e51e D44O/Nmw50Zksuc7O1dgub2fpf6YwbxHQy6++6NWc8BbJPOFo6k1N4mOZRkWbg0CIQQq P2u9d7LdhHomiUSvisBv/hj7rSSymmMWRLEh4T8Vp10j31KlSKZVLFnIVhmeBuk22BSU JWEdXblNr3NX+6xXyEU2Bl/qPvXiTolTToLoOCanjU6u3g9vuTWI7MtAL6itUoGyscgj AYRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id y3si12695121vsi.28.2019.07.25.09.48.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 09:48:49 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 934C430821F4; Thu, 25 Jul 2019 16:48:48 +0000 (UTC) Received: from [10.36.116.67] (ovpn-116-67.ams2.redhat.com [10.36.116.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA17D5E1B0; Thu, 25 Jul 2019 16:48:36 +0000 (UTC) Subject: Re: [PATCH v2 4/5] mm: Introduce Hinted pages To: Alexander Duyck Cc: Nitesh Narayan Lal , kvm list , "Michael S. Tsirkin" , Dave Hansen , LKML , linux-mm , Andrew Morton , Yang Zhang , pagupta@redhat.com, Rik van Riel , Konrad Rzeszutek Wilk , lcapitulino@redhat.com, wei.w.wang@intel.com, Andrea Arcangeli , Paolo Bonzini , dan.j.williams@intel.com, Matthew Wilcox , Alexander Duyck References: <20190724165158.6685.87228.stgit@localhost.localdomain> <20190724170259.6685.18028.stgit@localhost.localdomain> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Thu, 25 Jul 2019 18:48:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 25 Jul 2019 16:48:48 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.07.19 17:59, Alexander Duyck wrote: > On Thu, Jul 25, 2019 at 1:53 AM David Hildenbrand wrote: >> >> On 24.07.19 19:03, Alexander Duyck wrote: >>> From: Alexander Duyck > > > >>> /* >>> + * PageHinted() is an alias for Offline, however it is not meant to be an >>> + * exclusive value. It should be combined with PageBuddy() when seen as it >>> + * is meant to indicate that the page has been scrubbed while waiting in >>> + * the buddy system. >>> + */ >>> +PAGE_TYPE_OPS(Hinted, offline) >> >> >> CCing Matthew >> >> I am still not sure if I like the idea of having two page types at a time. >> >> 1. Once we run out of page type bits (which can happen easily looking at >> it getting more and more user - e.g., maybe for vmmap pages soon), we >> might want to convert again back to a value-based, not bit-based type >> detection. This will certainly make this switch harder. > > Shouldn't we wait to cross that bridge until we get there? It wouldn't > take much to look at either defining the buddy as 2 types for such a > case, or if needed we could then look at the option of moving over to > another bit. I'd rather clarify this now. I am not yet convinced that having multiple page types at a is a good idea. > >> 2. It will complicate the kexec/kdump handling. I assume it can be fixed >> some way - e.g., making the elf interface aware of the exact notion of >> page type bits compared to mapcount values we have right now (e.g., >> PAGE_BUDDY_MAPCOUNT_VALUE). Not addressed in this series yet. > > It does, but not by much. We were already exposing both the buddy and > offline values. The cahnge could probably be in the executable that > are accessing the interface to allow the combination of buddy and > offline. We are exposing mapcount values, not bit values. So you would > That is one of the advantages of using the "offline" value to > also mean hinted since then "hinted" is just a combination of the two > known values. We are exposing mapcount values right now, not individual bits. Either expose the bits manually (and thereby the whole page type scheme) or a new mapcount value PAGE_BUDDY_OFFLINE_MAPCOUNT_VALUE. > >> Can't we reuse one of the traditional page flags for that, not used >> along with buddy pages? E.g., PG_dirty: Pages that were not hinted yet >> are dirty. > > Reusing something like the dirty bit would just be confusing in my > opinion. In addition it looks like Xen has also re-purposed PG_dirty > already for another purpose. You brought up waste page management. A dirty bit for unprocessed pages fits perfectly in this context. Regarding XEN, as long as it's not used along with buddy pages, no issue. FWIW, I don't even thing PG_offline matches to what you are using it here for. The pages are not logically offline. They were simply buddy pages that were hinted. (I'd even prefer a separate page type for that instead - if we cannot simply reuse one of the other flags) "Offline pages" that are not actually offline in the context of the buddy is way more confusing. > > If anything I could probably look at seeing if the PG_private flags > are available when a page is in the buddy allocator which I suspect > they probably are since the only users I currently see appear to be > SLOB and compound pages. Either that or maybe something like PG_head > might make sense since once we start allocating them we are popping > the head off of the boundary list. Would also be fine with me. -- Thanks, David / dhildenb