From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA534EB64D9 for ; Fri, 16 Jun 2023 01:48:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23BFE6B0074; Thu, 15 Jun 2023 21:48:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EBA76B0075; Thu, 15 Jun 2023 21:48:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 102468E0002; Thu, 15 Jun 2023 21:48:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 01E806B0074 for ; Thu, 15 Jun 2023 21:48:40 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C057280AC2 for ; Fri, 16 Jun 2023 01:48:40 +0000 (UTC) X-FDA: 80906926800.15.C8BB03F Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf05.hostedemail.com (Postfix) with ESMTP id 52280100003 for ; Fri, 16 Jun 2023 01:48:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686880118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t2Ve/PpOJHQp4FxOtiV7yTCoDVu1ggT+AxaMMRCn5qQ=; b=PsD3HU6/75i+a5Q+zLsBkTPcN0ekJ6qWzmxelvmE7vrOl7b25gWQX4HprxhUsMJS3Nvse4 YXEjfrbBSqb1ZhP9aOPbiAAG/W2D8DNtA57E1mLDNDJqpmKxn96vc2RSmY0eI2zbLQea4p D4stz0umWS42CzqfnlqrPwSj2U5p6iU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686880118; a=rsa-sha256; cv=none; b=B5UlvreESUbD+9iMrDHZ8Yq6ddrBIBOv47lzTA6D3fA1AjKYEIAHx7G3mjHDLXc0sUlmnx bXkK7ol6xWZH8d2mybkwy8iw8TC2HNq29Re8Ndwa0PIxPSQDqwXupNAkbRkTioZ1JCnrLc DupsSRgv5Xr0mi9pLjzGzX96To4a+PQ= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qj29T20dRzTkqW; Fri, 16 Jun 2023 09:47:57 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 16 Jun 2023 09:48:30 +0800 Message-ID: Date: Fri, 16 Jun 2023 09:48:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] mm/damon/core-test: add a test for damon_set_attrs() Content-Language: en-US To: SeongJae Park , CC: , , References: <20230615183323.87561-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20230615183323.87561-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 52280100003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bye4nruw6pw491tnyzd4ufjumk4i1sk3 X-HE-Tag: 1686880116-783890 X-HE-Meta: U2FsdGVkX1//Y5y15P0t5nFm1M/8zKbagOE0dzWrGjLKPfx9lHcHpsgTJdb/1vWa7TP+a2HajvLz7Q9euVHZEQsu4cBDErLofXa88zVVJ3hInZz7SMODvuJ8YqY0R6N7Wk3JPxlNFXdAGR4GAxJbhaQJ7fyrWSU3db7/kR0GaCL1T9jZLAYoOLtwULWgus8lOVCuM2RF9vHuO5E+BlfKEZ55ZUb9R968A1W89l05cW/H0xvGZI9VReFU03++HHelFu+4yv777Ee28iDdSuOY9Cm92FWypFNMwq5nxXH0xJDy1sMuo4iTGB1FjFnBjP6bFtd/0AsByZUYweLzb07FPfOHzzkDb4zLXqYr6+801913wKeQbB5VRRKE0hs8cWjtyAOko9ihmjrU2khaYKwwmtUHFSXbdhh8RMcCvaGQNj8niumn6mt45g6wI1UPQtTbAdAkBThN8K2/s/CXE7SraS5C9f1KuMfc2vZMBgPVPWEHP/YGuyHDCdq1J+ayttYelSRvBxsY+5q7VXz9nCCHfuBTLTjZrA8fITruwamL3y2a1i0ATNSPdZpCv/EQe4oYgzaenXpn3UPkjoTQmxhXh7q+sj9HJDCGFZ1ZK7ZGH8Pw06eq3IagnoTIBNLCmctfdKShvZWGLFiw4xbHeCV9PMxb5PU9pqCXcNtMGgl9bV7cXmvrovnhKucco6BToVioV/ZenzkGP/J1cUtywm9zUX1V9a5QghUF/yhtUrqfguz5h1qWbB9isjhJZZBKOsxfsQqwh8MmTocM7VEaS8JiHgDzamJQnAcNeR2L/UmBD5bQtVJLoJvjhULmFRjnRXGABtJPCQ0NTcGtzSIy4C+zonXAzOiOzBeqm5VOO8dPWPRq4xZPBeaTpI1HgQXMO6G6s7SdITbaEYKoWjvMUJiMpWzJhbF6BMDNXN35ABWBWfmhxgxqPRyRP9jHngy4UIIByXR3voE36gqR4a5cl1b gspS/TTN NFCk99uYQOPfLQbM8ST6tcQkGwq3NWjd6Q040q4h3l1V6s4p8HaUVQKKtUuaisK5VAlPScBq3o6t7qNHt2972E2xbhk/2hb4F6YCUMRR3ZQ7x1bz7Xi7uOKyivvqgG6OTY3B2+MTNIyl2FRQtYhZwtbXLCwazFlfmcCeQlkHR6NCqwKuZ8uqLzhYyEwWpVm+eY6Qh8uZ98IUzkI7TpBLnBc7IesOZ0Q4qDrDt9kLx6cn4SNrt0g2PSrBPeCjgmVJsbi3raCJXgqQVXXw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/16 2:33, SeongJae Park wrote: > Commit 5ff6e2fff88e ("mm/damon/core: fix divide error in > damon_nr_accesses_to_accesses_bp()") fixed a bug by adding arguments > validation in damon_set_attrs(). Add a unit test for the added > validation to ensure the bug cannot occur again. > > Signed-off-by: SeongJae Park Reviewed-by: Kefeng Wang > --- > mm/damon/core-test.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h > index fae64d32b925..c11210124344 100644 > --- a/mm/damon/core-test.h > +++ b/mm/damon/core-test.h > @@ -318,6 +318,29 @@ static void damon_test_update_monitoring_result(struct kunit *test) > KUNIT_EXPECT_EQ(test, r->age, 20); > } > > +static void damon_test_set_attrs(struct kunit *test) > +{ > + struct damon_ctx ctx; > + struct damon_attrs valid_attrs = { > + .min_nr_regions = 10, .max_nr_regions = 1000, > + .sample_interval = 5000, .aggr_interval = 100000,}; > + struct damon_attrs invalid_attrs; > + > + KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &valid_attrs), 0); > + > + invalid_attrs = valid_attrs; > + invalid_attrs.min_nr_regions = 1; > + KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > + > + invalid_attrs = valid_attrs; > + invalid_attrs.max_nr_regions = 9; > + KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > + > + invalid_attrs = valid_attrs; > + invalid_attrs.aggr_interval = 4999; > + KUNIT_EXPECT_EQ(test, damon_set_attrs(&ctx, &invalid_attrs), -EINVAL); > +} > + > static struct kunit_case damon_test_cases[] = { > KUNIT_CASE(damon_test_target), > KUNIT_CASE(damon_test_regions), > @@ -329,6 +352,7 @@ static struct kunit_case damon_test_cases[] = { > KUNIT_CASE(damon_test_ops_registration), > KUNIT_CASE(damon_test_set_regions), > KUNIT_CASE(damon_test_update_monitoring_result), > + KUNIT_CASE(damon_test_set_attrs), > {}, > }; >