From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CAF5C27C52 for ; Thu, 6 Jun 2024 22:31:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D78B36B00A7; Thu, 6 Jun 2024 18:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D012E6B00A8; Thu, 6 Jun 2024 18:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B050A6B00AA; Thu, 6 Jun 2024 18:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8E4836B00A7 for ; Thu, 6 Jun 2024 18:31:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3C99CC0E3F for ; Thu, 6 Jun 2024 22:31:48 +0000 (UTC) X-FDA: 82201912296.28.4B3E79C Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf22.hostedemail.com (Postfix) with ESMTP id D1868C0002 for ; Thu, 6 Jun 2024 22:31:44 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=LSBWqEVc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Q4YtNi4l; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717713105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fducqmzsUaqWCgIAyarKczWhgKMxS3CWERNY8igKhbM=; b=7No+Ad42jHLdE+loPDMB0xdfePxl7H3mYt8uM7FQPjgMVoAsfEoFyYEo0i5FwK904GSw+3 HyDWC8c2eTEbQVV/NQTijvPpslQ4FwUJEiSE9KvqyEULJavA++VHdy0OjzPyhBEQ3HCw7u MriYGo7tuyhkG5+Uh7/jNFf78jUoK18= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=LSBWqEVc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Q4YtNi4l; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717713105; a=rsa-sha256; cv=pass; b=XldrGgWMHWRHhhaf2UHIoDIE4k1esaQQ6KztUwzcV2S0ZQHjmcJdNR4Pe+/vqGMwjLNIuD 4v+nobCVdIZs81YOEILLRT4ahmdieeMDYDo8kwmXU8oZn5xhzn5s5f3Mfy8X5VIT152yvS YJLv1DM8uy+KHlMJMlalItX55Xl0PWA= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 456HxVJi011804; Thu, 6 Jun 2024 22:31:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=corp-2023-11-20; bh=fducqmzsUaqWCgIAyarKczWhgKMxS3CWERNY8igKhbM=; b=LSBWqEVcHsTSvoDDYH2lXMVP24OGzRiiM2gvfDttUezdjRsjut2LIma5kVH1gYjz/U49 mhgqKN12vEaog3+r3OIFaudmeJWm6a5REW3/ve5EPcMnovkvLecgZ5UF37m70pAo586j 0D09m6mp0Em3HIblsqycnNOEi8w480jW/oiMtbP6WszigLxT16eWOSaevaCCnSv6wg14 8rbYnspx7+uOpIzF4IZV6g/xONEaGY/K6oyieyF4luN2dtHkPV3viNDkPunNHzTh82Yi Q0yOCbjhZB7VHwu5EwLO7S5NbGvYa8vkzi9G/7XMIRQNAfeiZT/W4EIBOTyrnhe851yH OA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yjbrhcjf5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2024 22:31:35 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 456LOLrp020581; Thu, 6 Jun 2024 22:31:34 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2046.outbound.protection.outlook.com [104.47.51.46]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrj5su21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Jun 2024 22:31:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBTBfQXsJmy2GZH9Nu8Qq1zRjSSenDJTukRZ2XSDkYEZVy0Te8j0IzrRklRDwl/SK3MQ5Swj3f6ZsehqPqi3yuIwew8iwiNiEcuAaKEnWHTCYTZPjp9RajeZiFYLe807XRxGTMtnvi3XYcCywKPeiw2u3pdwtWnRfnTAU386hEV49qJ6BL+oW5BA3tsNE1wrUPPaeqAO2q4JqQpXEnbD3hEAU+2d6SRGVoUCuHvO4VpQdzahFbwZFKnpO/SQixln32Itr955n5V08DHrb27aMgu3zFwhEpu/pd0G9DUdUVWz8ERNAcXbMHbn403rf5Bpe6F3lTjnpisMmY6s4Hxkiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fducqmzsUaqWCgIAyarKczWhgKMxS3CWERNY8igKhbM=; b=O1XBmr+zAMxU7hE5Jre1o+i6ip4vEpQb3zErSgUGuetgl3DBgr40sP6aMWAd+KaUyGnJpuh/Gyxsy+g3QXVjTuGJczbx+ruX6wi7n/plpxHfURkU6zmQQjOdur4YtwmRQ4kziTq6/mWw2L1iQS/bHcwWjbvhBp74eZfuDmGB9eK1thgmY3Noo4P7+PpR1PL8uNZbXquO227WV68F0iejcvsqz2cWWDEP1OaUY2e+kqUuivoh9RyYgQ2rX7dMOeX3YONq2QA+e1gjLUzBULgN1NWry4WD9yHNzMfGrj/PuEmcgrjvQ3Gg0s8Cd9/MQUr/7OcS0Wdq2/oquTUTQbKr4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fducqmzsUaqWCgIAyarKczWhgKMxS3CWERNY8igKhbM=; b=Q4YtNi4loOpLnTqJ0QlSBI21mUjes9oh315Um6PONiMTF+4Ls2omc1VNkzzew4ns6+vmtt0VxfR76TSR5B4mqghyJYRL+BzgEaj/gDkf5ZQ1+ogV1sCw9uH/FBxiOvpoMX2GUgZY+DTt/uqyW+pYrRuOZ5dOsolYoubl2e5Dx+0= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by SA3PR10MB6997.namprd10.prod.outlook.com (2603:10b6:806:31a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.25; Thu, 6 Jun 2024 22:31:31 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::3db0:ec21:1957:f1b3%6]) with mapi id 15.20.7633.021; Thu, 6 Jun 2024 22:31:31 +0000 Message-ID: Date: Thu, 6 Jun 2024 15:31:28 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm: migrate: support poisoned recover from migrate folio From: Jane Chu To: Kefeng Wang , akpm@linux-foundation.org, linux-mm@kvack.org References: <20240603092439.3360652-1-wangkefeng.wang@huawei.com> <20240603092439.3360652-5-wangkefeng.wang@huawei.com> <0290a474-39f4-4549-9fc8-06ccd6321d5d@oracle.com> Content-Language: en-US In-Reply-To: <0290a474-39f4-4549-9fc8-06ccd6321d5d@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR19CA0026.namprd19.prod.outlook.com (2603:10b6:208:178::39) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|SA3PR10MB6997:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b01d8cf-4dac-4b1f-eb83-08dc86786a2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q1E0TDU0bFFXaHlrMHFPMmVPT0QzTm5vVGlKN3N1L0kzMmxSTmpheXJGR2xX?= =?utf-8?B?M2xSTkxWSk43TUJ0UGljOUdkOXY5QTZFTE0rQzUxT1dQYmJNWXZXM1FBUjRP?= =?utf-8?B?NUFoc1QrcUhpVjdqRmVWRnlyWWoyc1I1aytNNlFWNG9sRXdqQ2paa3VxNmM3?= =?utf-8?B?dThiamR0S1l2NVhEaEs0Ymd4MGM1QXhtVnlxS1J6STArd0loTlVaVjVrZzJm?= =?utf-8?B?NC9TOEhSaUR4V1pvdkJQaWRkTTY1clI4WDRVTXFpaVQ2MERnNks5Z1FXZXJ0?= =?utf-8?B?aGlSRGZDY3BadWFUYmJIWjh4VlY0aGhTNjd4TzF1VHRQUzgyLzZZb08wREZo?= =?utf-8?B?ejFCWWxyTE1uUC9wbUpiZWFwQWJ0RmJTajUzMzJUZFRJYUkrbWVodmJsWVc4?= =?utf-8?B?ODFLTC90ejVLbXF4WDBTWFM4L1F1K0VPUG1uYXdMTnlMRjdMcHZyRitUeHBZ?= =?utf-8?B?YXU5WnpYaHcrekhzSHh2QkdLSThuWFB0WWFueHpTbW8rMlZnQzNCUVNJamdn?= =?utf-8?B?WFg5ZTIrRU9udXNKRVAyME95NTF6VkVKMWdCSXpVUmJDNmRtRnRwLzFIRlZi?= =?utf-8?B?RGw2Q2grUGVkbFIzR3k5aTV2c2h6RkxRRVhDM3RSdmVDN3RkN3R2aUZLbVM0?= =?utf-8?B?ZkQxMmdKaHVCYUtHRE5YNTVxMWoxbXJPQW9GUEREMThHTUlNUlNvWkpCWW42?= =?utf-8?B?VzJRaTBySm14RzkrMEJ4RUo3NktWOVpVaUtKcFJwZ0cyV2Zkb01TZzJqbnEr?= =?utf-8?B?VG8wSWc2MjRsQkRXS0pCbGlFVzYyY2Vtb1VWVFhUSnJ2ajRiU1I2QmlIQUVs?= =?utf-8?B?ak5FS2VnWVRCWFR5Y0FYQXdoaXlUSThnY3lESW9VM0VpSW9aZ0ZuSEFSaDI3?= =?utf-8?B?d0FQMzJkd215UXN1MEZ4QTRRLzZ6WTEzZjNtTFQyVk8xMzFjbFdnMEZFb0Fu?= =?utf-8?B?TzArN0FUdzdCMDY3UmpiYVFuVU01a2NaUGdZSzZUUlVHZ01ScktjcG5lMDlv?= =?utf-8?B?ZmhuaExMMWFWQnpzaEh4ZzE2b0RXQ21FcG02N0dBelYycUxFRHZEekd1Y003?= =?utf-8?B?N0JQQ1BjM1JwQnJ2VUNuN0ROSFU0QXJraGpqbTFRWTZueEtlVFJtQjQyYW5G?= =?utf-8?B?ZHlqZHM0UzBBdS81MVZhWFhpRGk0N3JwQndFbkoxY0E5elMvNGtNTVF4UVlw?= =?utf-8?B?UjU3NjhUSVJ1YVdQTGh1bk4zWVZraklJMmNCaE1GTmZvaXYyUDRyZlY0V3FH?= =?utf-8?B?YmtPdVkxQTZaeVFsU2hFeC9QT1prYm85S052cEFGdXRzQ2orT290WDhtQVdE?= =?utf-8?B?VGZ0UjBHNnZvV1RpbmZ1YW5NNGRwQmhVdU1BRFdwRVpXUEpBbExVU2YrbExw?= =?utf-8?B?Q09WQXJGZlAvWmFGY1paSnoraDg5V2c0dURMWHNLNXJ0WVpFMlpOdEc2Q2Ru?= =?utf-8?B?Z3gzMjUyWVVZZnMwNjJLbDBCeGF4WUowclRGeEdCT2EwcTZHaWx3Z1NyQ2pH?= =?utf-8?B?bVU0NDhCQ01kcmRzT1RmeGNOVVBlT0pUZDZ4cEhtVjhzbTFBSGZFdG9TTm1F?= =?utf-8?B?RWlBWTVnMkdObkkzbHJ5TzRNS0I2UFJqL2o1Z1hEWU14dWdPeFlUTlBzcFp5?= =?utf-8?B?ZVZwRHQxRUs2VmNrbGRLcWptSVVXQWVjWlBpbW5wajlXK3hXcmthMVNoU3E5?= =?utf-8?B?NVBza3pzeXE5V1YyVWpldy8yU01PRzVLR3VmenB2Z1llQ2xCU0l6L1FVd0Fn?= =?utf-8?Q?50QGlB80SrT9b8pQcYV/xcEh4EGKx/Q/k1X30M5?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEVFcy9VK21EVGtLcWgxanNRUVVzUU04WXJzV09lMVVNeVpGdkVHOHFPNUxo?= =?utf-8?B?NXpSQ2lMUFcyWUdDRFBnMk1wV2FNMFNzTDN5dnlxQ05aUmZ0OXFEYVJVOFRv?= =?utf-8?B?TFoyMHQrb0RmM0JWYW1rU0plWHF6NzRXZzVNVFgrQ1lUL05LeFdiRktIODBF?= =?utf-8?B?cGJyTzNyNTB6cElqMGx1OWhyajZsT1ZNcEczSmRPNW9yUWN1akVQZHhFVm04?= =?utf-8?B?V1F2azhhZmpvaXlrMTFXbHpQMjNpb3NiUktoWkpncjlxaHdrOEVsRFdTdml0?= =?utf-8?B?dWw2QkcxY0x5T2g3a1AwNU1FMUxFVnJLOUNlV1ViSXkxdE1teUZkOGRhZGdk?= =?utf-8?B?aGlub211UkEvTVpnb2czcml0eFA1YkJVZUQ4ZGdsK3I0R3JYMzdxN0JCa28v?= =?utf-8?B?QVJPZXlyVTlzMjVGUldQZFB3U1Boak81dlBSd01wQ2dmNldLWjBJbTZxVVZw?= =?utf-8?B?NkpqSm1QY2dJNnZ5cWZobzBQZk4rbzBJTjdWNCtOME1ObU80QjdXRC82aG4w?= =?utf-8?B?UE9GdWgvdnAySXhBelhpSUlYYlRGM2gwSXBrUG1EUjFzWkRzdlZVc29Ga0dM?= =?utf-8?B?M0tmS0tLQmZnQ0FMUk44ZWNJeEdXMGVId0ZzWS9tNGtkUlU5WU5HOG0zcWMy?= =?utf-8?B?Tk5DRVMrNWdQL2xoV0NHM0NFK0lTeGJiYjBBZktsQ0VseHBpNy9UNk5kUzJC?= =?utf-8?B?SEhQWm03MHJwbytQQ1BjbDIvTDRBVDNCVjZVNTNRdytkM3dWazRYWXpOcUtS?= =?utf-8?B?dDVWc1g2b01seVMwKzErRENiMDZ5eGVMeUc1WThFbjM4MWxOdjZsTmErdnJo?= =?utf-8?B?MlppMGFFby90VmFoZXZ1dVBSZjlMd1A1dlhlT1hnVk1mVkVXUlB0NUplN2wy?= =?utf-8?B?TlprOHF1YUtWS2NmM2JQT1kvRExIc05FSFR3MjUvZkNsdGRGNmp2T1dqTHF1?= =?utf-8?B?dXlyUXJTQ1NGZXVHdm1TWVBpZmFLWFpnTWpuV24zZHFoVW5OY09VSVg2NWo0?= =?utf-8?B?NFNaUWFvbk9jUEhGSFZTQkdsZkpRM0ZHZGdXOS9jZEFKTmhjNmxhQy9mSStC?= =?utf-8?B?cXBjRkcxVVJ5eVZOSmUrUVYyZ29obUc3Ym1rZkY3VDBUVlZNTXQwZVhIMGJ4?= =?utf-8?B?SHI5dU5IS2czdk9HZDkvTjhVNTFGNEhoWG4zTDF3K05EVlphaHFLOUpMbUNZ?= =?utf-8?B?MUpqS2xHdHR6UXhjd0xDTnJaWnpxb1hFUzE0amh1ZFFBYXo1eU1nZHc4clFC?= =?utf-8?B?bXFhK3ZiMEJnTG9GYzkwbE5MNVg3Y1Q3dnMwWUF0SklsVTEvOU1tVERKUDQw?= =?utf-8?B?b2FRTnZCOHU4NlFvWU03dFoyVnkvR2ZTUzNjaGZYbHhWbnZZSTI0VDVkZlhm?= =?utf-8?B?RFZRL2VOTXJuZmJwbmdkd0RCQTMxU3ppem1hdWRhTFBTeHZkV0hsTjJIWEhv?= =?utf-8?B?YklPc0IwTmViRkxoY1VzUU00OFVSbkpWZWt5TmZxdEV5ZTRFOUpic1p0dW1I?= =?utf-8?B?eHV3cjc2OHplVTcySmtpbG5JbG0rOFZXYmhpQTd5Q3phQ0l2MzlRZ0hpSmtq?= =?utf-8?B?dm1DV291MG9HZ0hsNjdwa1g3WGIrako0cFJrOFlvUGtMSGwvYXl1UEVNSmpo?= =?utf-8?B?SjA0bjMvMVc4UCtrRXRSRXRVZ1Jsa1dDNXNYS3NrTVNnTWdhdm5uWCtaeTBQ?= =?utf-8?B?ZkI3cWNVbWcyRGovNndubDlHT2lPMFMxNnlkVUFsUkNwd2dvR0haaHhNQThQ?= =?utf-8?B?MzhjZVpZZEZHQzNNUmZpQ1dVRjl6UWRSTVNpMkhRMitsMnRETVpHeEhiZkM0?= =?utf-8?B?Qll6cFhVNGRTWmhsZ3hOcFZIZ3ROU3dYbGNvMm0ySEVROGlmTmpNL29yMnJi?= =?utf-8?B?NmRMTyt0bEF5VDlXOThITVhEdDVYZEwyamNHdERwK0lJQ3czMjYrakxBY1c5?= =?utf-8?B?azh2aXdLNWU2ZmVFRDFLZmdOZ0FFK2Vjc3JUZ1VHNDRPeHpQaDZSMUxJam9m?= =?utf-8?B?UUdTamw3TkswL0Eyc1RoaEdtQjRwUERudndBT3RKTFBra1JIUFJOMFI0cGk0?= =?utf-8?B?TlFGM0p6VnhRZHBFeDZENmhQc05yV3VBYnZyNE5odFU1eU1pTkhDWExjNGdp?= =?utf-8?Q?YZMa15Xr0U6xrM2umiIFDPSvs?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oIf/Zaj9EY+TbWJgsVzJJNk2NrdZQSka98/yk3KU5PEkCYZCUXr6HEoj6yOHwdFHqTEPk6i4i1AtH9pVggo1Hd15l/lbvswV3bJfYY7hSAmCZEy2lG4YrcIKulU6NvKrSkBY+ClBWa4IDC59J5phy7K6rPZ3X/XTcBLgW9Ksk7QkDxEm1LmfnNH8O4jmNbvQg9OxR4n6QuCIeuhEOaRACAW1EacyxT3anEwZyrt5RdeVBr1gUWfHhhBIZHGcLAcnDC/3x4+xwcYmmfSZNrZaFrPbPIHHNtw1ui0vGVe+uqZ+vLMwG5WcMVU4hsLKc9CCpDPwKxkpskKZszjqCWSup1PX4ddjSdJMfJ68EtO7fYVzA1ww8hEUzqyXTmrRqL80NcaHp6K8BRGV5E233q7MlAZxVgHRk6/XP/mI+hODN2DcisB+c+BXdiIKH4b3h3rKBhJIaEnfU3/BmLLdn1euo1z8ZvDL1xWVasmQtXCq+cBT5sbvwCDcUrBQ5t4lL4DdsX6Afy4QMIa5ecTxNrNFGcj2oN+t1ZaoTGyawAAdNOXCYyPDGwIGhYEWnhjRmelbfHTnxBTjl/ALopAjejh+1FwvnYQAiLCOxO4a/12cVXA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b01d8cf-4dac-4b1f-eb83-08dc86786a2d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 22:31:31.6552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqQ/K74CBw9BJgHLwUxLcYlGV55zKiiPC8G47T1w37qGh67v4l5cSKHOzFxqhEZ3cRPFGkPJWy99UuGtqUJ9Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB6997 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-06_18,2024-06-06_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406060155 X-Proofpoint-GUID: -T2p7sRubc8iXg-ktIK34IdQpmOVLaht X-Proofpoint-ORIG-GUID: -T2p7sRubc8iXg-ktIK34IdQpmOVLaht X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D1868C0002 X-Stat-Signature: fp13f5wcoxttuncfz5q7wpga1hcioue9 X-HE-Tag: 1717713104-773174 X-HE-Meta: U2FsdGVkX1/2uebOf6vX+2YWWFGvYqB0C5Pban9+INbnvjU/LHbwAMMhdfeNajsRl2Tw4vxGn9arBKZkgEQFbO5dpZsIumx1wUh9Rs7PEe5CQopvAdMkbgZL4gOiPcLcKDUHlqM2UfxsKn248CDEAu4v8o0IEEGX51xUfXLJQGmcYc9RoQPTLUMKPvWmLf8w7sUc048z17pQZHl8lKXHWdVsnv5tIq1dErjbN4Nk5Ah0xFB5bsWiicpPdcjBJY6g67DndtTSwJ+vyRDhzwlXXr4tGS0YJTZ9s9N5/H3VmiXuMxS3/Bx5ZEG1HZahjILHsJft8POzF7lt2r5kdp1DR8bDZe2kNQ4ge7NjIHTElxHGI5nZxyFtlUpi0mFFmxy4wVmiYErQ19yHEHidEfWiDn9BlKFEaF/4XL71DuPrsMgwl3T7WVACL49qflx/hKICJduz/+F2bfMjeHOncpuXgItClDdCCW9WQJ2x99hlj3a6YwTWNEi5HGPTTO41ryv3mDcSYiUTjeV99QAM4Dl6QK0ZxN33z8XukAaSVDX/PxKs6S7FEgCAfwrw1pK2Hnmg26HGdxrEc/V9mfvFIkft8yQ+WPwhAsKf2h3gmRjeJL11D3ZOe4sME2C6L1x9D4TdB3gRSyTtOFB+rW6YUaMuGVZUilexpGYh3Xyj5QVajCavFFANwncF/toBwI9IvbmGMD70RPeodqvoYnq6w2GNoEyJvi7N1LXfrnRfCmmWLXsc1sVbXLUk0hUa+gi6S2iSyL65804EMtkNPbuCd6/ZkJ49xOutIj3wB69DGouqMcXXE0sxjR9BABBosFoT2CzIAhpf846JsnbcCM33HX1GPs2eF9xU56QNElDaBArIjcGP9Po8znWTvn1mWQK6d5I4TcBcsIuC8cJgV8jOkvADwLsUrd7MkNGWgPBt3eo28WFQ2JEGSKWQ8NLNQn23EE7qjNfrdxASpC1J6u+t/Lp 5djPFxqG 3bm8uAS0nW+IEmxpedTERqvGWIKeuhd1IBgOCfHq+CWVJswqOz1jkMIdQ4Q4HrgOCjfIxg5oYHahZJvVAQumtulugAc3bmv2Pwp93AoI56LjGBx/1DjkVwVdDqSC/wbDXoMZs8y2Dh45UGMRm67p6imPBR6XcUAzvDIdNpJnm/RYgiuTUVZ49R89JcXERwJVWOslwgNHbzhndvBRntJe1+7CHtGjNgfDTTCK/UG//2eQ46SQTvfXfeP0ZXQBmVDgwG4t7dQwns9V+74u8pZj0zRtgA7rRUk4Ij2vjKn2cWpj35n6r58vZdAWZPDF5L9luWmETma9QyUOPEZI5qphbskLHHGD++zQ6JC4pkHqax4o+78nTRnIiGnFjHCw5rl/WCD/WWFVUx12D5pAbSy2LbUchIvcLXViehPcxgtj5XrS0xbFXbM6Bd5lDTTrspM1mMvGb3z/FuTvLbksECRf4bbssgJvs8KRQvaE1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000271, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/6/2024 3:28 PM, Jane Chu wrote: > On 6/6/2024 2:27 PM, Jane Chu wrote: > >> On 6/3/2024 2:24 AM, Kefeng Wang wrote: >>> diff --git a/mm/migrate.c b/mm/migrate.c >>> index e930376c261a..28aa9da95781 100644 >>> --- a/mm/migrate.c >>> +++ b/mm/migrate.c >>> @@ -663,16 +663,29 @@ static int __migrate_folio(struct >>> address_space *mapping, struct folio *dst, >>>                  struct folio *src, void *src_private, >>>                  enum migrate_mode mode) >>>   { >>> -    int rc; >>> +    int ret, expected_cnt = folio_expected_refs(mapping, src); >>>   -    rc = folio_migrate_mapping(mapping, dst, src, 0); >>> -    if (rc != MIGRATEPAGE_SUCCESS) >>> -        return rc; >>> +    if (!mapping) { >>> +        if (folio_ref_count(src) != expected_cnt) >>> +            return -EAGAIN; >>> +    } else { >>> +        if (!folio_ref_freeze(src, expected_cnt)) >>> +            return -EAGAIN; >>> +    } >>> + >> >> Let me take a guess, the reason you split up folio_migrate_copy() is >> that >> >> folio_mc_copy() should be done before the 'src' folio's ->flags is >> changed, right? >> >> Is there any other reason?  Could you add a comment please? > > I see, both the clearing of the 'dirty' bit in the source folio, and > the xas_store of the > > new folio to the mapping, these need to be done after folio_mc_copy > considering in the > > event of UE, memory_failure() is called to handle the poison in the > source page. > > That said, since the poisoned page was queued up and handling is > asynchronous, so in > > theory, there is an extremely unlikely chance that memory_failure() is > invoked after > > folio_migrate_mapping(), do you think things would still be cool? Hmm, perhaps after xas_store, the source folio->mapping should be set to NULL. thanks, -jane > > > thanks, > > -jane > >> >>> +    ret = folio_mc_copy(dst, src); >>> +    if (unlikely(ret)) { >>> +        if (mapping) >>> +            folio_ref_unfreeze(src, expected_cnt); >>> +        return ret; >>> +    } >>> + >>> +    __folio_migrate_mapping(mapping, dst, src, expected_cnt); >>>         if (src_private) >>>           folio_attach_private(dst, folio_detach_private(src)); >>>   -    folio_migrate_copy(dst, src); >>> +    folio_migrate_flags(dst, src); >>>       return MIGRATEPAGE_SUCCESS; >>>   } >> >> thanks, >> >> -jane >> >> >