From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEAD5C4332F for ; Wed, 13 Dec 2023 13:31:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F15C6B0332; Wed, 13 Dec 2023 08:31:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59FBF6B0338; Wed, 13 Dec 2023 08:31:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42E7C6B033A; Wed, 13 Dec 2023 08:31:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A5126B0332 for ; Wed, 13 Dec 2023 08:31:50 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E918A140BB2 for ; Wed, 13 Dec 2023 13:31:49 +0000 (UTC) X-FDA: 81561882738.22.0DC546F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 20DC540020 for ; Wed, 13 Dec 2023 13:31:46 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WUbAju55; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702474307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6ZKsZXAGZPzGdkl/Bds/E/0NRdRFaaRkoaeJez+DeeI=; b=pVH8AfxUFSEVbYxJ4kJeE7q0LgTa9mnDTu2NiYCoGWOurvJmsBeboHkB/rxSqDOmZLKhbk rAwC1RomnmTHlZ8wy4MhVt1rDaRJoE+rqQAle6Nd7aIv55iW70xJRV5ytzSVwzOLqzP0Hs RlQmU5ZpWimYayLPhEZtVWON2RVT8EY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WUbAju55; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702474307; a=rsa-sha256; cv=none; b=2fCM88YtPhzB0N+tkYx8vO1U0O6+fuRN3D7rH16P07zxoaXhaQa0AtKHYfHOWxxAFEen6W 15PGck1EEdTHDkFiJRVQa/y428HLckOGD2CH8kFB+NLveCmXnsHUpE6PkCjsXU96p+Oo4b ++UEB+TlQZYCf+xV8DwxNYQTzE39Kq8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702474306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6ZKsZXAGZPzGdkl/Bds/E/0NRdRFaaRkoaeJez+DeeI=; b=WUbAju55neVpt0AUOTcWy+B33D0HS3h81dzrBJx6jThjeH8kxtwDtwk1Yjoi9Yz+VMujdH V+3/fMUGNIEy+NdO5AaOTU08wvRHZmjVHJ1wwqlqA7ii8qyP9zlCIU9zhEg2QdXy4OG1cy ef5xsQlqCb/gapYNAr+sAwcyY0NqxKI= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-2-bGXP8uPNCqIHQlJrS_6A-1; Wed, 13 Dec 2023 08:31:45 -0500 X-MC-Unique: 2-bGXP8uPNCqIHQlJrS_6A-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a1e88d2d7faso370292266b.1 for ; Wed, 13 Dec 2023 05:31:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702474304; x=1703079104; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6ZKsZXAGZPzGdkl/Bds/E/0NRdRFaaRkoaeJez+DeeI=; b=MbhtVg6t2pL2dbqTdYWbryZEl+ot7pzm8pCYcElhTfXCU8E0OSm/66pMNrAIKcyF3k DDeFZvsRKFutLKugevCMmcNZXtYdrOm+3OlxkufTGGKn0KE3dVqDmxt0CCa1yy1WUIwe fzFuqpDgFsjPoeTatq4Sn/Pi82MQ857DhVQrmBb2syJwz2lZcDQnMIqCBoTqC/YTKdhs s15ncxa6kZ3pi6JRIGQhpDC+5tXCabCVvlCpcm1rv4E0tK6cfj96w5AEsWQ/zz6OjdXy Jb/RQFniISFUTWpK+NVcdjMb39layZgl4iWDIRSpsU9g9Ks3nwT2EVMI2FvIFpiE0mHz qwIg== X-Gm-Message-State: AOJu0YyuBvVGO7CfqQOVIOkeB90j8bjDATtBp6CLmddrx8S5VMQ1EvMN drLVkm7cc7TBD7J9Me3B3BTsJZ0FT6jI0GSHANzTx7jByCSMjedGCemERbnWnFzzybiAC6DVHZP 1I07ob0T0yVo= X-Received: by 2002:a17:906:2:b0:a23:482:ee74 with SMTP id 2-20020a170906000200b00a230482ee74mr251968eja.28.1702474303968; Wed, 13 Dec 2023 05:31:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFPrwg34mR9QL3IK9lbbz36ejShRG3Tw1YL7unA2WVHwsE4ZIHQYfrs0+x2kBoMmIZzjvL3FA== X-Received: by 2002:a17:906:2:b0:a23:482:ee74 with SMTP id 2-20020a170906000200b00a230482ee74mr251933eja.28.1702474303726; Wed, 13 Dec 2023 05:31:43 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id tg10-20020a1709078dca00b00a178b965899sm7819372ejc.100.2023.12.13.05.31.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 05:31:43 -0800 (PST) Message-ID: Date: Wed, 13 Dec 2023 14:31:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 23/50] KVM: SEV: Make AVIC backing, VMSA and VMCB memory allocation SNP safe To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-24-michael.roth@amd.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231016132819.1002933-24-michael.roth@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 20DC540020 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mmchs9b5awktew78j1cwt4kshhdibdd4 X-HE-Tag: 1702474306-234756 X-HE-Meta: U2FsdGVkX1/4cfimCirC8pnKkIKLt+xnAY5uWBzio652Tv+K+rgRbMhTV94ywttadEFX0G9eEp84+uD9ifw69tGB8D6qiSgLEWilJH5ZMBwu5zXQ5gc/SmJg4NLmcLSWNcX5SZO1zRCBP6KGVBh1WDcID1RmGGB0rS7fjoEJyUqsEVhNNcY3z7nyBjbDZrup0Tgdim2bHPNW7MwD10PcPTAKM4DRUSfmma9ExaStirTYkDYW9u2MSxT2NiJtM+ENSVKwaTn2WtgHBe3hOpw7r37ZjQDA+MoBKm1GLJXtIfeGhIpjGZiE7Yjt4lNxguoe+GlTfUNVsK4zucj7C90FUYrPQP4X4pyUo7xjkXyo1K9fk7yC3bBXYsB0cNUpkR9srf2qrIOdipqVYF/eBmeRGjy8vHhjzy+vTgygyHU0xcbr3x7klXTCln28hbpkr4S1IznCNDxmPsy0R4c+pZ9I5RwFR0CBR4XGmxlxD43ggRABIHSsEEhDEVqBj4jhjV3JRLxRsIwmJq3BQoK4CXjCYiGaNMm/YkJJi8zJhrEdGtpc10mi1vOj89scLQLSdeU/0DmhZ1rqNDgPg2JXOS2nQMTIucj6ffGK9hITATCG9rLTL5aizSvRoa7OV0wGvAzLMptuLR2vEyIarr5DjFRBC69U9MhZbbUL9mts227CdK8wbWWQYcjxy3sVOZb5V7B23HZ313dhhbuTwvySIdpCJdzyEXOiayvYpBuRqW4pKTMKZ5DDjjORQGY+OiYzRu/a7t5UJn/zvmnGtF+faZF8iGPYO3nBlONI2u0nVXno5wnsQuHcKb4eH/0bDS20TqBoaW2W4L9QzTTMzKni1B0QD8LhOi453d9a4ibhQiBqtJmfg3G7tQDO/A7luCHacYEwkNYU1tS8YCHjMjE93D6pIA90erMPa4fGLveyAnFREaG/iBEKhvMdFpt49XhVyl2XALJzRTIzfllMdkRetip R91qIMFH +pXYKU7uzXoT7notRzoMS9DNzfeWr5BSkYqnGUG9Kn09ko2uh4RzsfQwO2Af1vQ0EmzNyTwOUCuk/h8buJ3AD8oAFsg1mkZ/Cu9JDMzWxUyQEDCQK8ulys/znVoEZKo1zDI+6a71b9FQvcrT88msJzSaDqre3Omns3mSQTSmAfbmWKMn7iFnt/asooNw3jZPXZmW7fadEdmlQ2iyMLa/lc7712BDjkUba7TvJ/g+uA6nMP2rHF9UpR9WHJr2zbek+AaP23OIPntYlW7ucu+bhwkQ2f7eJZ2Ki+0j3t7vkTHp5PCuhuAeVNUtfLYnaJoHJJy4P417lH1IYPrkOaki8Q0mr3ZIKGDwYmAcSrUxmhdPS53mYlkaJ1qV+k+cXp8KbDixqKYY/iJfpYpmtTE+bF8zehNQThw9ewbR+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/16/23 15:27, Michael Roth wrote: > From: Brijesh Singh > > Implement a workaround for an SNP erratum where the CPU will incorrectly > signal an RMP violation #PF if a hugepage (2mb or 1gb) collides with the > RMP entry of a VMCB, VMSA or AVIC backing page. > > When SEV-SNP is globally enabled, the CPU marks the VMCB, VMSA, and AVIC > backing pages as "in-use" via a reserved bit in the corresponding RMP > entry after a successful VMRUN. This is done for _all_ VMs, not just > SNP-Active VMs. > > If the hypervisor accesses an in-use page through a writable > translation, the CPU will throw an RMP violation #PF. On early SNP > hardware, if an in-use page is 2mb aligned and software accesses any > part of the associated 2mb region with a hupage, the CPU will > incorrectly treat the entire 2mb region as in-use and signal a spurious > RMP violation #PF. I don't understand if this can happen even if SEV-SNP is not in use, just because it is supported on the host? If so, should this be Cc'd to stable? (I can tweak the wording and submit it). Paolo