From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D01C83F15 for ; Thu, 31 Aug 2023 02:57:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C21B98E0007; Wed, 30 Aug 2023 22:57:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD12F8D0001; Wed, 30 Aug 2023 22:57:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A98FE8E0007; Wed, 30 Aug 2023 22:57:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96F688D0001 for ; Wed, 30 Aug 2023 22:57:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6EE4BA0487 for ; Thu, 31 Aug 2023 02:57:51 +0000 (UTC) X-FDA: 81182889942.12.D613A48 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf09.hostedemail.com (Postfix) with ESMTP id 757B3140012 for ; Thu, 31 Aug 2023 02:57:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=none (imf09.hostedemail.com: domain of xiexiuqi@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=xiexiuqi@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693450668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h3F2UtnQPKag1Lf7NjSNA/xQ4Vch5qcyR/9APkJ6wsM=; b=PzBkMekiMCzQqIbwhHy4pbgeONUzpKJElf0VnrvI6pMUSvxvsYRiB7ZhiWnNZDWPkjttC6 LBiR/KeD1JDKSA6K+i3GpW2+MAP3coEH5IXKbr+BOiwPEl7VVRjLp9RNq5J5g3UfQ7Xujz SVt6Ek8nHBmMrlxHLGB+u7bpYorzVhA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693450668; a=rsa-sha256; cv=none; b=DYbGDY+y+2NTiVU23s2s+NeV3u2vMO/6S/uF5jg20IiSPPyL52+2bDssFodLTI1IEzWwN1 bSLoH5KHlPr/SFvDLxuhugD9FHMcf1tIr1XFiGGxEWiGvLPSMTFngm6wP46GxrqahWR+sQ w/HENzDbCqRvj+h2KE0GvN5ML62AtSw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=none (imf09.hostedemail.com: domain of xiexiuqi@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=xiexiuqi@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Rbm6r2RK8z4f3nbD for ; Thu, 31 Aug 2023 10:57:40 +0800 (CST) Received: from [10.174.177.236] (unknown [10.174.177.236]) by APP4 (Coremail) with SMTP id gCh0CgA3x6mjAfBkDnn5Bw--.31629S3; Thu, 31 Aug 2023 10:57:41 +0800 (CST) Subject: Re: [PATCH RESEND] tools/mm: fix undefined reference to pthread_once To: Matthew Wilcox Cc: akpm@linux-foundation.org, irogers@google.com, acme@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yingliang References: <20230828122157.1541087-1-xiexiuqi@huaweicloud.com> From: Xie XiuQi Message-ID: Date: Thu, 31 Aug 2023 10:57:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:gCh0CgA3x6mjAfBkDnn5Bw--.31629S3 X-Coremail-Antispam: 1UD129KBjvJXoW7ZF13Zr1rJrWkGw1kCFWDXFb_yoW8Jw43p3 95Ga4kAF4kJrWrtr1Sq3WrXFWUKr12gr1UXr1kGr1UCa4qqr45Kryxtr429FyxWr1xG3WU ZrW7GFy2qF4DJwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1F6r1fM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UWE__UUUUU= X-CM-SenderInfo: x0lh5xhxtlqx5xdzvxpfor3voofrz/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 757B3140012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bbihwt1n8y6kwi6wp1z1oyu6zrzrkhta X-HE-Tag: 1693450667-786387 X-HE-Meta: U2FsdGVkX18ZS8Rm1PQtNT5CymKqhFCCqx38CG+8HXHKarsJB7dNLbR/iRvTeeof+WgdCqnMCuisA3ZifJxOKzcYjGWzDTvzZvvjFGk1mIq89wxeKul6DyIugvVkayrImv3kTan+42rgcc7JLV1rzLN9/t8bWIR8w7m2MZMf4BrwpT4rtNB9YkLO7Y2hwL4QtH52xiFAC+ZY3z5feoL7SPp5Flu+Bt6TCdD2ZLU0Z1hIiwh7TO/liDFkodl1No+3298+U8Tq+NtV6XmjYXyik5c32hVXOjZqCsE1dtUY15mWF83Uc95pvqhFYjrNqHl/9rud7EGNZtqWnm7OCexpPKUG6kr0NEqEOSow/3mgddAYr9DC9oCErwknGCqm939v6Miqw1vNZoqaJsbN36NzeQFnAyx3RbgG8YSftaYqk+5BswhXYiYadhPn4gLXnQgvnf7jxKh75C1ENdcdaFcEkfjwIocyMeBiVfcnqV+D5T7FJy8N2NdQs8vPL/mjs9w78wetkT4Wzsm84vl+h0jrErr/goS+4fqVloLQQfY2X5BQQzI1Dcfx89yM/P4/AyEfdue7rfwQwri8ew18r9lFxfT0ygL9u85tbpfMzn5nt+t1jbdMs7Ta30pIwX9jiJiRAcySe+XwJOBrCAF2xw+9ugrV15nf2YArwi4kTX/Z6srTI6cAVFqWhzSOVWa+vtXwCF3d4YFp/FNBhPgMIK8urwxm99GDbbu9yjsP7Nzp24sFDXYpRqPDUUUV8NdiAl6u2LXIiHYcSCkFI/ZYK5ZjqMJ3n3NoZNVf2HnRNnVnzAqq/NtrMbZohb85/0rN7QqgN0bL0zxLTNpVvOgqhvPuzGOVBm+3byA7C3W+MyChKJeyWPqRp/Chq93VBwHIX0jhQfuimeqj3ilHPZ5o4MHKbLv/JoHeksqiv57d9G6fYK5rucRC4ksl8Ih54RWQVWBcs7rU7SYrqX+V21134zp 4d3MTGCr tDICRhjPwhMvD2Vp68pjh9yvAWvDPbdcVN2iXJ5Ev3GcP5U6SGbTBnQVkx9O6gLmhiH+aNhTTGj1NrwMsRNM7QEPClXM+aFrcnwOg62ROywFc0UYWbvyjK0b7sVgbdYNFSy6bROzhNf5V4SQU2JiCDC/HiZsP+Ph5dHb4BswWWoPbOv6QH+SoL/Dvqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2023/8/31 10:25, Matthew Wilcox wrote: > On Thu, Aug 31, 2023 at 09:13:24AM +0800, Xie XiuQi wrote: >> Hi, >> >> On 2023/8/28 20:58, Matthew Wilcox wrote: >>> On Mon, Aug 28, 2023 at 08:21:57PM +0800, Xie XiuQi wrote: >>>> diff --git a/tools/mm/Makefile b/tools/mm/Makefile >>>> index 6c1da51f4177..9997b2e401ae 100644 >>>> --- a/tools/mm/Makefile >>>> +++ b/tools/mm/Makefile >>>> @@ -9,7 +9,7 @@ LIB_DIR = ../lib/api >>>> LIBS = $(LIB_DIR)/libapi.a >>>> >>>> CFLAGS += -Wall -Wextra -I../lib/ >>>> -LDFLAGS += $(LIBS) >>>> +LDFLAGS += $(LIBS) -lpthread >>> >>> Is this the right fix? I'm pretty sure you're suppose to use -pthread >>> in CFLAGS in case there are other things the compiler/linker/whatever >>> need. >>> >> >> Thanks for your comment. I'll fix it and send v2. > > You added it to LDFLAGS, not CFLAGS. Sorry, it's my fault. I'll add it to CFALGS: CFLAGS += -Wall -Wextra -I../lib/ -pthread > >>> '-pthread' >>> Define additional macros required for using the POSIX threads >>> library. You should use this option consistently for both > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >>> compilation and linking. This option is supported on GNU/Linux > ^^^^^^^^^^^^^^^^^^^^^^^ >>> targets, most other Unix derivatives, and also on x86 Cygwin and >>> MinGW targets. >>> >> >>