From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719E7C25B75 for ; Fri, 31 May 2024 10:02:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2EF26B0089; Fri, 31 May 2024 06:02:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDF156B0099; Fri, 31 May 2024 06:02:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C34426B0098; Fri, 31 May 2024 06:02:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A28816B0088 for ; Fri, 31 May 2024 06:02:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4A8B01612A4 for ; Fri, 31 May 2024 10:02:23 +0000 (UTC) X-FDA: 82178250966.08.2D8B0A0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id EF1C74000E for ; Fri, 31 May 2024 10:02:20 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="acEsKw/l"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717149741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MJ04lQJ+GBKpWEjJ+VxNTs5PlYqhFbGa0udLArxovdk=; b=lbEIDfpXAvdWBGeX5I6td0NUi2MkAMe1PItVA0tl3+bCoXgqflp2bzeoxY+yVnQa8Dj0BB kgjaHjsUuU6se+sH/XD8cm5YK5EUB8J/a0MD3300uPVcPRMXag8QqRj/DXvhX9u5+qOoHx 0/TeBfuS4oWHynP99ttPczFh5mMND68= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="acEsKw/l"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717149741; a=rsa-sha256; cv=none; b=lMtsNoug37fnL1GmjK3SGMT9yUA1qrtbxE1+w48pcLpDc7jEvrM3sc6hcWAA8AremHeIEK wvt0K+QXyH1EVVje5yVRHXv5JexaBs2coB8RLEg34vn6PKmert0JrrwCNdrWxbGJj2fUh6 D5boRr4KvjiAjfvqJuwPzE+S8xd/K70= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717149740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MJ04lQJ+GBKpWEjJ+VxNTs5PlYqhFbGa0udLArxovdk=; b=acEsKw/lkmZLUmzrU8/nYYXKUHJNxZtha/buUwPxBRdP+t8iohKYGvWjyUUE3T90xSHdGN VMKE7ywwXuNU5JDQvU8cRWI8cLAvHeyO1d1/GtvOO5ci6GSeuOrrENSZxpP4ynvuBzS3g5 MNa9XX1bxU2pBVBEamRwnu2fKFuHjWU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-m2sWlmY4OaKD2I9Mgg2PbQ-1; Fri, 31 May 2024 06:02:15 -0400 X-MC-Unique: m2sWlmY4OaKD2I9Mgg2PbQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35dca4a8f2dso960592f8f.3 for ; Fri, 31 May 2024 03:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717149734; x=1717754534; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MJ04lQJ+GBKpWEjJ+VxNTs5PlYqhFbGa0udLArxovdk=; b=vNd8VumvXnCzmOBfY7Xu1jlSQWWQHsr7lb2pG7Tbuy+rQ6ttU1CLnorkFtJcasTQua mkkNsIGR0ZYA3K+CmHipUtv01keCYFkOGUe7Orn0PVBbsE+OA1E+xEA3fkSl9Ipgcm9u /ZbciYATbCbP/MK0KwnRcINKHtsrS1lZ7cU0iq4x8lIjk72CLkcuQzs8xACLedDx8bG/ tXg4UG6nVuvod8LtSH7wHO/danyxSCB3ipR0sxI8YaVCn8FysjXZyV+hZzkiSwn0NAdZ 0WbJIQs1Co42/eEbY257mwxMj/l0eVlzmJ0KXX265E/YkdLn0PL2GKlJZai+BIcYe+If AZ5g== X-Gm-Message-State: AOJu0YznZlQPUIYPqP3kPdIIPVjkyNYJcJP4p2/ocNV+v/qiWqPz4/+O w1Iz37RxC57Xr/IF6rcJXchDTSPCDyWwnxhfJk4SvYWaOpjmxwzg9wKyjKrQdJqHj72ovWX6Fug r9YxG3F1XwwySnLy0qWuDR8QWSRdEjdie0mDWb7Ihjmba8qGz X-Received: by 2002:adf:f742:0:b0:357:3e5a:6c90 with SMTP id ffacd0b85a97d-35e0f36d84amr1071440f8f.57.1717149734601; Fri, 31 May 2024 03:02:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeS5HZkW4qvB1V7nYN9JjTsjl8P5wxpf8txKd3ben3bh4FQXh41fFVj5GVr3OQUJJT77+d7w== X-Received: by 2002:adf:f742:0:b0:357:3e5a:6c90 with SMTP id ffacd0b85a97d-35e0f36d84amr1071406f8f.57.1717149733967; Fri, 31 May 2024 03:02:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:a000:d4df:4b8f:37d4:59e4? (p200300cbc717a000d4df4b8f37d459e4.dip0.t-ipconnect.de. [2003:cb:c717:a000:d4df:4b8f:37d4:59e4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04d9c68sm1477783f8f.56.2024.05.31.03.02.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 May 2024 03:02:13 -0700 (PDT) Message-ID: Date: Fri, 31 May 2024 12:02:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: userfaultfd: Use swap() in double_pt_lock() To: Jiapeng Chong , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20240531091643.67778-1-jiapeng.chong@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240531091643.67778-1-jiapeng.chong@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EF1C74000E X-Stat-Signature: icaygx68io7u1zqx199dwhax7z8qztct X-HE-Tag: 1717149740-831695 X-HE-Meta: U2FsdGVkX1+Gm0y69341ndGQ9zyofm/vw514MQfBjF5/QLk8ENwVHpek4DoJCPQhUeGt29P4GPiPyFKVwZf91MSq/PjPe8vhoYVPS0J2WAmiBwH/opVESFf2fDnW/u2LIoRHAsEzTbJrERIO4TrpwV+y1fDjghbbzBrNH3uWZwgVfPxvG+mgu4IfLS0tqjqQxIxn3NfiCfhmbx48R7dcS5MbSVAyke/LVt1JJh9IZ8O75o0QQqJfstgrPTreOSYpna7GjoHCDoyB+36sySIP1kK7POwsaUKLfoO661Eyy3sdUvChB0e2hBafpaPAOaj984xU8rJ4wtjgaTxngQVne0i8uPCp2TbAEAvzAB0JUw7pJaYDxjwsOoQiuIesZgIbuFmzD1l6xIyGNh8pxm2BbaYN09IKilMmeT1ScOa9TxqrjhvjOsL5JMyRI1PHKWVRYmyuT9SEQRr++kPzAeg2ctCIaGnZdwMRA4d8z1Nv0D1qPdIKGQxiZ9eklkjhS83nh/jUaoqUuCudO6OECmYYx9Y1Wd9axWniWZw2/f0FkOYaCsIO2x44RHI62k8BlcVEvh4oxJppk3C1mNO2GufIbLPrsV0/azkWGuCXUYWcn/lBfwwCfksyCNHYh5sYG0H5VMJ6ghl+9TCnB1BeYtejcMp7LzYMAS9UJgHsSJBu1enoy5NhCj8YHTBGBfEK4H8mfgN4o8eoVPxHx8k5xv5kvNfM1pTPh6h+49E7zIh+eyA9x6PG2qbSsRJbERuoaE6k+R1PQNsKZhhvy7YwxYLyDf7oFdGS3du9WuM7i/vH/bGCj6R5GA/vx3ByOgPAAqPxFuT4NUiWIX4IwY+De0qKfdG7p4ZdyOOCy33v1vvkliN4j5DW1egBatKxjLdWSrllJpHjZ8N7rNk6rYuDm3dIaduBB0a9C3nlWaAKpg9xCkfgioBTzaR4JhtsfqIk7o4vPyQmZy6ZazS7FJfcePF rB2Dh6C2 VZzFycaWnoQ6DG3Flj224AU45pea0+wjpdp/9tvwTRIekpQ8EOdpW5Fjed9iegBSBgS/Y8nm8/UQx8oFF4NDG8mMLHeThn2dtNCeMFj4rp5H7Ie4JQUtQ4wPuj0IcOgBVJWV/fp3QYA3xctbCQk27n2jRfcvHnU9BTe2FywtudhWm7VozVyGTnIs7z1hsUw3bRoMMy+9WD9wl8J8Ukk4VH7a490ZrarzULqbNADsW+FVTxm2r0/gXSkWJpw3Pm9lX0FAdVgcoCXcTBZzQOcGY1nPxne9ey8nlwz8RABpsD9PaAGiryGKmwjMmcJgt1WQaPqmztXB5v5nBj7hjT6UuXd6knSr7+ZuayNYHnP7k5xhuGf8yOGOqK5zX/pWY+boxgi0jD2UBd8YSCfNIBZcVWp3wnPzGv3dsSt+6NpRHWLy9wKC570CKamE8O6Ygnhz4YX4jfEFG0sKxFX19vm4T58mKjVp+I9lh50n5vB5O+zE7xv+NzTIF3U5ilnmenoFcP0Hcv+hhAw6KlqLkVufWDgRnB7+U7OLZULcp80cPgOEIdPhHEGKdJqzx1cNW4+RHWDEwsYUFxbaLS13L+BEaGzlUW88LMEWKW0TpRzBSveo8vr0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.020525, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.05.24 11:16, Jiapeng Chong wrote: > Use existing swap() function rather than duplicating its implementation. > > ./mm/userfaultfd.c:1006:13-14: WARNING opportunity for swap() > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9266 > Signed-off-by: Jiapeng Chong > --- > mm/userfaultfd.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index defa5109cc62..5e7f2801698a 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -995,14 +995,8 @@ void double_pt_lock(spinlock_t *ptl1, > __acquires(ptl1) > __acquires(ptl2) > { > - spinlock_t *ptl_tmp; > - > - if (ptl1 > ptl2) { > - /* exchange ptl1 and ptl2 */ > - ptl_tmp = ptl1; > - ptl1 = ptl2; > - ptl2 = ptl_tmp; > - } > + if (ptl1 > ptl2) > + swap(ptl1, ptl2); > /* lock in virtual address order to avoid lock inversion */ > spin_lock(ptl1); > if (ptl1 != ptl2) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb