From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29655C3ABA9 for ; Wed, 30 Apr 2025 08:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E20126B009E; Wed, 30 Apr 2025 04:57:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCE9E6B00C3; Wed, 30 Apr 2025 04:57:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6E046B00C4; Wed, 30 Apr 2025 04:57:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A888A6B009E for ; Wed, 30 Apr 2025 04:57:09 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B15D21A0DC2 for ; Wed, 30 Apr 2025 08:57:10 +0000 (UTC) X-FDA: 83390105820.20.F74E2E2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 8E16D40009 for ; Wed, 30 Apr 2025 08:57:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746003428; a=rsa-sha256; cv=none; b=l2unJuIM2WqVQaTtfoo0kntetNBFKs5aU+4l8b0UEQJJ+GBuBJqQlkJpLT03yxJIh2vHtP OOo1+Y9AzriSVieBxS2innYNgWcStqNhej9McRAaTz+lezvsJs+iKlR4eLanXlRogq2Yvn 4zI8azREJxOQBW9A00iOuaOfbPTe8d8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746003428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hLmN8VYggk3mdu/lakoMQ0IWSBXHZGu9K8iGg+qTEX0=; b=1pZEyeh3CR1MxLqNRFWcETzLYBFHtEHWiVNktNYQno2oPzyN23tuhcRQDzJwbZI846TASm H9BQeEAOCkIgo+DFFU2zo85exUgh25CPaBNGIucGnagzf72e2MB9vAo4fZonzv9Jvo8X0e K6AINJHX+fNZV55vZVWnF6CLzR/6KvE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 02D3C2117A; Wed, 30 Apr 2025 08:57:07 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E450C13A25; Wed, 30 Apr 2025 08:57:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qtRuN+LlEWiMGQAAD6G6ig (envelope-from ); Wed, 30 Apr 2025 08:57:06 +0000 Message-ID: Date: Wed, 30 Apr 2025 10:57:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Content-Language: en-US To: Oscar Salvador , David Hildenbrand Cc: Harry Yoo , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jonathan Cameron , linux-cxl@vger.kernel.org References: <20250408084153.255762-1-osalvador@suse.de> <20250408084153.255762-2-osalvador@suse.de> <92ff4f7f-90d2-48ab-8f7d-7fc3485276b5@redhat.com> <60ae4d6b-3ace-482b-9945-1261003f3785@redhat.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8E16D40009 X-Stat-Signature: qm5b3uf63drd6mmmjohp77x88dg7usfb X-Rspam-User: X-HE-Tag: 1746003428-413161 X-HE-Meta: U2FsdGVkX1/bLHz3HxELI9kNxCAIvr3v77jod6lyGYf5mcBgTnCXe9stP/eMX/0s0DXx/FukvgxOd0wq3umU7+ZFXep5wbURutxkij9a+x/MZo/Jfva5dMvvep09POfa7LNqJhNgYoAHNjiptD2M0sSHk5h7BZe/LkcPnIrr8P/NN0//9MupNsryD7q1dRNX0EMG13xMM3Lil7W0PDUYsUMr/e8PHSK0uB6lQXA9fsrs5ubUPei6dapqYvXExMG+7V1DakP+PM85BRVvYoUablPXV7H2dUBXNE90G6gsyvzjrPOPATGJP9ErhfPY1ejY1NjFJjs9StW82+5AAqCxhOZoj76QJh2iK+h/NSEAO8DNtYW3UZiPmrc6xYKW+p2vjvTB4kkCnXS41BrtW4n3lttmwJrZu8RBOUsws4I9296oTlmlQBV/yK9D03WNpiAw3ssaOlHjgTBlTIj48RcCCYavx1PsdGLU9NfaKOX/BKjeQ3pJMFtvSATflg9j5DAkHM7BW0goV/dJJ60mQQjOjdK2KwaxERit5sdXTDZEJ2e3wGQeGQMyU8pJ89yxCUZGvKUNZElWpy9cp2BdeC6I3Z5+Hdgi068McQiAX9ATOzm03D3+4XMSzq9RLiYFPVUHZoD++QuqkBrvpVrLBXM43ayzEHSaJ6h5S5YJDu5EBLimaYaCTCkWaqk+Mw51tSjAk8b1X8cYxfg5Ul9sboh0FGMadF6XdEfUKGDDEXPfYXJiUDScF5q/mri/oQp/FtedN0iBQShF2ZKDm9wvEQn3dsPNbuf27MocYggmPMVVIWJXavCD/MhMkBuFoKAcZqDTVZbYKwyn9vE3SjzEO1ifUk1RxElybZDrC/3nF9MZtRTf7YcSxR1F954Vslfb4o111CnFO5cw7Vd3DIjyM/DWqatphImSppPfLQEnPpbsJvtf2s2OVtgCN347hcJ2zfv3horkXsJs+jaIH77ddfN b9bEX+/G wsGGVZPWN9bHkT3sdCsOezvoLKKOOSXMc3Ht/z1o2w+m8pgY8FDW2h66bAnTRWii/FPbXU18PCL1X5VdV4yDzRCo7DrUPigVVa7bkXjTKTjS1/WZM6y/861mv3cTt09U2tXYIeJ13KbVnFS9h+DXLaFSBv8tCQx4d/cGu9AcupJlF5+etWzhCcVIy3bCG2k7jD4uaVO4GFpQyY03BS/O1PlMuPRsfVjr6vybz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/30/25 10:47, Oscar Salvador wrote: > On Tue, Apr 08, 2025 at 08:18:32PM +0200, David Hildenbrand wrote: >> We could by grabbing the mutex in MEM_GOING_ONLINE and putting it in >> MEM_CANCEL_ONLINE / MEM_ONLINE when a node is going online. > > Hi guys, > > After a few busy days I have been revisiting this. > > I checked the proposal of slab_mutex spanning GOING_ONLINE <-> ONLINE, > and I did not see any issue. > > The only concern I had is that we might be calling some slab function from > {online,offline}_pages() that also takes the mutex. > I am not aware of any though, and quickly checking did not reveal > anything either. > > If there is any will be quickly revealed though :-). > > So, unless there is an opposition, I can move forward and see how it > looks. > > Thoughts? I feel a bit uneasy about it, while maintaining slab_nodes doesn't seem like a huge issue to me, so dunno. Maybe David has a better idea now :)