From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6125EECAAD8 for ; Fri, 16 Sep 2022 17:34:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAE328D0002; Fri, 16 Sep 2022 13:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B36868D0001; Fri, 16 Sep 2022 13:34:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AFD18D0002; Fri, 16 Sep 2022 13:34:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8899B8D0001 for ; Fri, 16 Sep 2022 13:34:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5840C1C688D for ; Fri, 16 Sep 2022 17:34:32 +0000 (UTC) X-FDA: 79918647984.01.4E97E55 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id EE3871C00A1 for ; Fri, 16 Sep 2022 17:34:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FBBC1FEC5; Fri, 16 Sep 2022 17:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663349669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsisgMPvCT3VnHLqKa8pUpcXqHPIsT7c6cznGtgolXM=; b=YbqxfnG7uzxLk9Kk2ojLDXzSXCNuWwxsn+n3/hwlrFjBa6I99ubNz1FAxJyUASjX0gSBV5 fNsl3MRXmx0lLgLiTWymxXpBkLLXdt9dpwj6Bxu3Ln18t4FRLngCF0GbjrgWr8rG1gKEh/ NTnXiqOsp7K0eZpd6+vIIwKyQvMm1hw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663349669; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lsisgMPvCT3VnHLqKa8pUpcXqHPIsT7c6cznGtgolXM=; b=ARwhLTZLiEC5WXth8EDAdV2IFxIrD8+mQv1MT6j67AS2hVWktVIIBbQIaZHLMxQFWcFKXy FFLaJueFKzAwPGCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4AABC1346B; Fri, 16 Sep 2022 17:34:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Cg5tEaWzJGMiGwAAMHmgww (envelope-from ); Fri, 16 Sep 2022 17:34:29 +0000 Message-ID: Date: Fri, 16 Sep 2022 19:32:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] kasan: call kasan_malloc() from __kmalloc_*track_caller() Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Peter Collingbourne Cc: Andrey Konovalov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220914020001.2846018-1-pcc@google.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YbqxfnG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ARwhLTZL; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663349671; a=rsa-sha256; cv=none; b=7WXkGvVjfkvi1gRabaT+DIUDADvBtj9gSHf5040HfSLamGs9DUmprKD0wtfu82dD+JonP9 6M91HsxUpW/p+7aB31p63/3hu8gB6rpF3D/ByR0PoBeet2SBMWWz+tKUodyrpgKuQHxGvu UO/WgtV/vulIjh6uVxvHPyljCH5tBXE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663349671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lsisgMPvCT3VnHLqKa8pUpcXqHPIsT7c6cznGtgolXM=; b=ieGj2lSFUqxfOJOWwT6vsaWvwduGUOQK/pu7DWpgR2dd5z+JflPcryX6c1Vg47e4F0XwQq KmdV/uyCF8FNvZWsCf6r4EaT1e5I0h6D1oeYWFUuT6l/M5FUaty/tPFZ+D0X5nuOh4il7u slugvOw4pkvwMJrWfhNNZmJOlOItmog= X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EE3871C00A1 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YbqxfnG7; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ARwhLTZL; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Stat-Signature: ntfx7ueqe5m1iod8nyiyi9iep7xx4i7z X-HE-Tag: 1663349670-524406 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/14/22 08:52, Hyeonggon Yoo wrote: Thanks for the Cc. > On Tue, Sep 13, 2022 at 07:00:01PM -0700, Peter Collingbourne wrote: >> We were failing to call kasan_malloc() from __kmalloc_*track_caller() >> which was causing us to sometimes fail to produce KASAN error reports >> for allocations made using e.g. devm_kcalloc(), as the KASAN poison was >> not being initialized. Fix it. >> >> Signed-off-by: Peter Collingbourne >> Cc: # 5.15 >> --- >> The same problem is being fixed upstream in: The "upstream" here is now only in -next, not mainline yet, so we still have more options at this point. >> https://lore.kernel.org/all/20220817101826.236819-6-42.hyeyoo@gmail.com/ >> as part of a larger patch series, but this more targeted fix seems >> more suitable for the stable kernel. Hyeonggon, maybe you can add >> this patch to the start of your series and it can be picked up >> by the stable maintainers. ... > > Ah, I should have sent it to stable team ;) > > I think "Option 3" in Documentation/process/stable-kernel-rules.rst will be appropriate, > So will resend this after the series goes to Linus's tree. I'll pick this for sending to Linus after rc6, which means the series in slab.git / -next will afterwards cause a trivial conflict to resolve when merging. AFAIK Linus prefers that over late rebasing. It will also make it simple for stable. > Thank you Peter! >