From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2F2C54EE9 for ; Thu, 22 Sep 2022 17:57:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8CE3940007; Thu, 22 Sep 2022 13:57:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3CF66B0072; Thu, 22 Sep 2022 13:57:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DE24940007; Thu, 22 Sep 2022 13:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D30F6B0071 for ; Thu, 22 Sep 2022 13:57:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6561B80189 for ; Thu, 22 Sep 2022 17:57:01 +0000 (UTC) X-FDA: 79940477442.17.F7286F9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 0EDD9180008 for ; Thu, 22 Sep 2022 17:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663869420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tzpm52sa8CSvL/F/FPIEyeRtTCXujozZJ/MwFvUSN40=; b=T4RNswjMlcYUJtfREq/C4g8T1YBYFvkoKhdk5J0N+E40WTH17RYCEYcuWpFrnBUBSBy7GU bzIsrNOUYKgft3G05uRUVRMnnq0JnSvQvlorNsRf/H+WNX+HeFDcyOxfo1IdaErEgke35f vdcdn5J4h6pP0ge/50ALPZrdCjzwsak= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-15-945z8tcwNqC3LhzGYLanbA-1; Thu, 22 Sep 2022 13:56:59 -0400 X-MC-Unique: 945z8tcwNqC3LhzGYLanbA-1 Received: by mail-wm1-f71.google.com with SMTP id 84-20020a1c0257000000b003b4be28d7e3so1477668wmc.0 for ; Thu, 22 Sep 2022 10:56:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=tzpm52sa8CSvL/F/FPIEyeRtTCXujozZJ/MwFvUSN40=; b=4X7O0qohCoNkUFTUs5lBJvcNzbHDc7aCOKwDEiy0kztPzqQfUlpwQ5d10mQHHOH1jm 9qdyVqzt3RBu3IkB38upAGFr79/rCCFDX6XnzCDnbI21eGSNYTOcjShhEjukEnFNccxe jO9TDC5YZqELiIuKNifxHgFkahwsu9LrrIaP7/EgEH7+CTIncbbggu9q8jo5kUyuTh5h FfrdmS/kbsEuAQsQCXBklYe3mYu+SLLU6ukWaFmFyHPdHi6bLImpKu+Z/CiMehGRBhnd YjhmOje81sPCExQ86A2Ns4q/3UbB82Ax97EqU8N13ClOa1t7aMyY87K885uz+Uar/IYh 3OTA== X-Gm-Message-State: ACrzQf0gmlHUeeZF+r+gIENL47E8zsC/V9fozWUvsHygBoEl2YiSWzR6 tbwv3oAZOZMkRXD2RKX54WLOwT2yt3gNn0haZXsFCF70a0EoeW+/7kR+wXCD03pN0piKCJlIQUa 7WwEo7Wi9UGI= X-Received: by 2002:adf:de0b:0:b0:22a:c7f7:8eb4 with SMTP id b11-20020adfde0b000000b0022ac7f78eb4mr2828730wrm.195.1663869418103; Thu, 22 Sep 2022 10:56:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OGCTJHunJL+DqcDW3fRlbR463/+1YhbnxMqKIz9UcWqkxpEEN923uRrQHr3cvs6ppcOpo+Q== X-Received: by 2002:adf:de0b:0:b0:22a:c7f7:8eb4 with SMTP id b11-20020adfde0b000000b0022ac7f78eb4mr2828722wrm.195.1663869417843; Thu, 22 Sep 2022 10:56:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:2200:d595:cc20:2e3a:fc5f? (p200300cbc7082200d595cc202e3afc5f.dip0.t-ipconnect.de. [2003:cb:c708:2200:d595:cc20:2e3a:fc5f]) by smtp.gmail.com with ESMTPSA id q17-20020a5d61d1000000b00228b3ff1f5dsm6297845wrv.117.2022.09.22.10.56.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 10:56:57 -0700 (PDT) Message-ID: Date: Thu, 22 Sep 2022 19:56:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier() directly To: Liu Shixin , Andrew Morton , Waiman Long , Zefan Li , Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang References: <20220922141904.3245505-1-liushixin2@huawei.com> <20220922141904.3245505-2-liushixin2@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220922141904.3245505-2-liushixin2@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663869421; a=rsa-sha256; cv=none; b=H37AHJTuDx2cn4dge8JhJoM+dO/zTb1WPo1GotMBS9UlSmu727gJcG5Mm2nXb4v00tlrev BvD4UOqD97M9Eq2zdZ9g55+KvSCZ0Lvsd0oq6qHmJw/saTN6ioxRvBok0WElA8USQ0yOqF RufLmE+IwarMZhVshy5GJuW7/dW4NeE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4RNswjM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663869421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tzpm52sa8CSvL/F/FPIEyeRtTCXujozZJ/MwFvUSN40=; b=bQcF8LXKq8jsdfLhqC509M3EbpCZcu5xnvRAzGaU2+JkVa88qU4b+H95V3izFTNYNLmvw8 rFGKBUlUfU1L8CJv+4VA4kZ3Shhq+pFHqcCAmZAa3K3Z5IrbozF8yMoWXo79kAas1Opsx9 emunCcv1hkLc52+edzEicRg3jW4s4mE= X-Stat-Signature: d5g3a3a773carrxfutsux59iomxfuss1 X-Rspamd-Queue-Id: 0EDD9180008 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4RNswjM; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1663869420-46183 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.09.22 16:18, Liu Shixin wrote: > Since patch 316346243be6 has already updated the minimum gcc version to 5.1. > The previous problem mentioned in patch f02c69680088 is not existed. So we > can now revert to use hotplug_memory_notifier() directly rather than > register_hotmemory_notifier(). > > Signed-off-by: Liu Shixin > --- > kernel/cgroup/cpuset.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index b474289c15b8..0c6db6a4f427 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self, > return NOTIFY_OK; > } > > -static struct notifier_block cpuset_track_online_nodes_nb = { > - .notifier_call = cpuset_track_online_nodes, > - .priority = 10, /* ??! */ > -}; > - > /** > * cpuset_init_smp - initialize cpus_allowed > * > @@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void) > cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask); > top_cpuset.effective_mems = node_states[N_MEMORY]; > > - register_hotmemory_notifier(&cpuset_track_online_nodes_nb); > + hotplug_memory_notifier(cpuset_track_online_nodes, 10); > > cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0); > BUG_ON(!cpuset_migrate_mm_wq); Please don't drop Reviewed-by or Acked-by tags. Otherwise reviewers have no clue which patch they already reviewed -- and they always have little time ;) -- Thanks, David / dhildenb