From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7AD5C4360C for ; Fri, 4 Oct 2019 16:43:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54D0320873 for ; Fri, 4 Oct 2019 16:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54D0320873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03D9F6B000D; Fri, 4 Oct 2019 12:43:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F31358E0003; Fri, 4 Oct 2019 12:43:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21C66B0010; Fri, 4 Oct 2019 12:43:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id C155C6B000D for ; Fri, 4 Oct 2019 12:43:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 613D36111 for ; Fri, 4 Oct 2019 16:43:42 +0000 (UTC) X-FDA: 76006673484.22.crowd79_3d32fef5f632e X-HE-Tag: crowd79_3d32fef5f632e X-Filterd-Recvd-Size: 3973 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 16:43:40 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R271e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04391;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Te4gntB_1570207414; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0Te4gntB_1570207414) by smtp.aliyun-inc.com(127.0.0.1); Sat, 05 Oct 2019 00:43:37 +0800 Subject: Re: [PATCH] mm: vmscan: remove unused scan_control parameter from pageout() To: Michal Hocko Cc: mgorman@techsingularity.net, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1570124498-19300-1-git-send-email-yang.shi@linux.alibaba.com> <20191004081612.GB9578@dhcp22.suse.cz> From: Yang Shi Message-ID: Date: Fri, 4 Oct 2019 09:43:32 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20191004081612.GB9578@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/4/19 1:16 AM, Michal Hocko wrote: > On Fri 04-10-19 01:41:38, Yang Shi wrote: >> Since lumpy reclaim was removed in v3.5 scan_control is not used by >> may_write_to_{queue|inode} and pageout() anymore, remove the unused >> parameter. > I haven't really checked whether it was the lumpy reclaim removal but it > is clearly not used these days. It was removed by commit c53919adc045bf803252e912f23028a68525753d ("mm: vmscan: remove lumpy reclaim"). > >> Cc: Mel Gorman >> Cc: Johannes Weiner >> Cc: Michal Hocko >> Signed-off-by: Yang Shi > Acked-by: Michal Hocko > > Thanks! > >> --- >> mm/vmscan.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index e5d52d6..17489b8 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -774,7 +774,7 @@ static inline int is_page_cache_freeable(struct page *page) >> return page_count(page) - page_has_private(page) == 1 + page_cache_pins; >> } >> >> -static int may_write_to_inode(struct inode *inode, struct scan_control *sc) >> +static int may_write_to_inode(struct inode *inode) >> { >> if (current->flags & PF_SWAPWRITE) >> return 1; >> @@ -822,8 +822,7 @@ static void handle_write_error(struct address_space *mapping, >> * pageout is called by shrink_page_list() for each dirty page. >> * Calls ->writepage(). >> */ >> -static pageout_t pageout(struct page *page, struct address_space *mapping, >> - struct scan_control *sc) >> +static pageout_t pageout(struct page *page, struct address_space *mapping) >> { >> /* >> * If the page is dirty, only perform writeback if that write >> @@ -859,7 +858,7 @@ static pageout_t pageout(struct page *page, struct address_space *mapping, >> } >> if (mapping->a_ops->writepage == NULL) >> return PAGE_ACTIVATE; >> - if (!may_write_to_inode(mapping->host, sc)) >> + if (!may_write_to_inode(mapping->host)) >> return PAGE_KEEP; >> >> if (clear_page_dirty_for_io(page)) { >> @@ -1396,7 +1395,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, >> * starts and then write it out here. >> */ >> try_to_unmap_flush_dirty(); >> - switch (pageout(page, mapping, sc)) { >> + switch (pageout(page, mapping)) { >> case PAGE_KEEP: >> goto keep_locked; >> case PAGE_ACTIVATE: >> -- >> 1.8.3.1