From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A3EC432BE for ; Mon, 26 Jul 2021 04:05:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 63E7D60EB2 for ; Mon, 26 Jul 2021 04:05:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63E7D60EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E68408D0001; Mon, 26 Jul 2021 00:05:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E19D56B005D; Mon, 26 Jul 2021 00:05:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D08068D0001; Mon, 26 Jul 2021 00:05:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id B674C6B0033 for ; Mon, 26 Jul 2021 00:05:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5340420BD5 for ; Mon, 26 Jul 2021 04:05:50 +0000 (UTC) X-FDA: 78403400460.25.AA33682 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf02.hostedemail.com (Postfix) with ESMTP id 58F337014093 for ; Mon, 26 Jul 2021 04:05:49 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4GY5nX0b6Sz7x8t; Mon, 26 Jul 2021 12:01:04 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 26 Jul 2021 12:05:45 +0800 Received: from [10.174.179.191] (10.174.179.191) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 26 Jul 2021 12:05:44 +0800 Subject: Re: [PATCH] mm/vmalloc: add missing __GFP_HIGHMEM flag for vmalloc To: Matthew Wilcox CC: , , , , References: <20210726032333.3404164-1-chenwandun@huawei.com> From: Chen Wandun Message-ID: Date: Mon, 26 Jul 2021 12:05:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed X-Originating-IP: [10.174.179.191] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58F337014093 Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of chenwandun@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=chenwandun@huawei.com; dmarc=pass (policy=none) header.from=huawei.com X-Stat-Signature: abook84c8ju1qrd95t5kn9s5w8ci9gab X-HE-Tag: 1627272349-733523 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2021/7/26 11:25, Matthew Wilcox =E5=86=99=E9=81=93: > On Mon, Jul 26, 2021 at 11:23:33AM +0800, Chen Wandun wrote: >> struct page array can also be allocated in highmem during vmalloc, >> that will ease the low memory stress in 32bit system. > Huh? Where does it get kmapped in order to access it? The struct page array contain numbers of pointer of struct page, it is us= ed to save pages that allocated for vmalloc mapping in vmap_pages_range, it does't n= eed to kmap. The main idea of this patch is come from: https://lore.kernel.org/lkml/20170307141020.29107-1-mhocko@kernel.org/ > >> Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_a= rea_node") >> Signed-off-by: Chen Wandun >> --- >> mm/vmalloc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/mm/vmalloc.c b/mm/vmalloc.c >> index 3824dc16ce1c..8d9b0b08a6dc 100644 >> --- a/mm/vmalloc.c >> +++ b/mm/vmalloc.c >> @@ -2885,7 +2885,8 @@ static void *__vmalloc_area_node(struct vm_struc= t *area, gfp_t gfp_mask, >> =20 >> /* Please note that the recursion is strictly bounded. */ >> if (array_size > PAGE_SIZE) { >> - area->pages =3D __vmalloc_node(array_size, 1, nested_gfp, node, >> + area->pages =3D __vmalloc_node(array_size, 1, >> + nested_gfp | __GFP_HIGHMEM, node, >> area->caller); >> } else { >> area->pages =3D kmalloc_node(array_size, nested_gfp, node); >> --=20 >> 2.25.1 >> >> > .