From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70CD3C48286 for ; Sun, 4 Feb 2024 07:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 063B46B0078; Sun, 4 Feb 2024 02:44:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2F5D6B007B; Sun, 4 Feb 2024 02:44:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCFEA6B007D; Sun, 4 Feb 2024 02:44:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CA8B66B0078 for ; Sun, 4 Feb 2024 02:44:39 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9D868C0188 for ; Sun, 4 Feb 2024 07:44:39 +0000 (UTC) X-FDA: 81753334278.05.9DB169C Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf25.hostedemail.com (Postfix) with ESMTP id B529EA0008 for ; Sun, 4 Feb 2024 07:44:37 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kXzeiZnf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707032678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PYmkSyAiI8ZNFZt9h2B5b9tnwLmATn/wLxZOMDo8mKg=; b=NI2jMqqxhGfp+vZ7vE4BZa51pI+N+mRTGHuzHkkAlc62V8s5aGPQNs1LAb/UGhL7nKquxq 5/ToEvSFS7hlr0va1L0nQ6UPKNAHcQQYmw/yXu0zfoMHpbHiZ7qRyhVR/yIAMbQ3PsiZCs NRNQTIlf+hgP7SdveqQNynVww8IdPFI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=kXzeiZnf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707032678; a=rsa-sha256; cv=none; b=dkUI5pxcXKLYRbDZzy0UsUoPY6ZfG0JNpMkx4g1lBxepTLePbhrTGTEz+uIzvL7ZshHGKc IrvHVSfYyNnQVTw7umVoYPVb41Tpm/3oazB5JgLdNVUojPM7YGoLR6kECeW0u9zx4cxZRI 5vyVMf6hAbMNwzEifmt/Z14aFfSd2GM= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707032675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PYmkSyAiI8ZNFZt9h2B5b9tnwLmATn/wLxZOMDo8mKg=; b=kXzeiZnfqHf+rROkc2BSnppq0lJy1pPlYyZFAiXuLA07iCziWLDn0VEFbrUa74a8OrFi8T ZF9xku65yVr5aUqN5rs69O2TpU50pH5zjuRu1SJ70GKaEFMYMfcsPZDIK4y2kh/9W52kgq /cInjIwCZVYdR3kTSIkdujIh7lf8HVI= Date: Sun, 4 Feb 2024 15:44:26 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/1] hugetlb: fix CONFIG_PADATA dependency for non-SMP system To: Gang Li Cc: Gang Li , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap , kernel test robot References: <20240204072525.1986626-1-gang.li@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240204072525.1986626-1-gang.li@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: dotkyck41rqqpdpmszy7o5smiqed41im X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B529EA0008 X-HE-Tag: 1707032677-378828 X-HE-Meta: U2FsdGVkX19lTH1HKVWX6HderCa5uODm2BGYx+iPzVkeQ3HxUP0MNbtAHy08TjaLzBFN/TcBPTFRauK/UR3MGEYqwaisTBmN+LWNQI+l9nehVb0ETdusYtwfRyvf1t0djHhidXCGnYfqR2uVzihKyJ36J6PL57QKM31Cs0y5pUPSwXnXsqMzmT2j+WlcmfHlFxwpcWhmMdNWmerGwLiXTvfppNePZ3Jw1cSCAqpidmk1SEYtmi0mbyE+D9c2k70VbXT599UpXUTTkI4eFLpJWvS6ogb5MJcpDBTwFtBPAVfe0Mka6BF2eun1ftnUlCxxWq471FKVRnr7F74rSsapZsBZDAc3rqzOq3BQJ7eWh2eZP32es9/+lVgL2IKif/Tit/lQLVRAKfneW9roHB4JGX3qHqnkb48b1VXSunXmKKCX10QUfzUelEsQiMQnEFc5JSTTipmUiBO9xxDmcEhBrQ42FZud88uWUf7NHydKdHBHLsWvyoEF+wI+JRa0mAnBsb0b1s2pqbJ/r1/0MY0JktzTMizPKXTWV5UMbfTmf1u3yriTZ0xp1nrl+9uH/svt6WTseYVq17K3Qe4jel235qjLyJ5BahN+cWeRKkk4yy4wzXUpc+AF3Bqir2SNyX0y2dQFF4l3KqaMXusWh6JsiZbRMMBEEGiYsEeRLpx5hRuuRESiNghN9PqucwJeasKUHWzfsp9B2sBBv29mI97X3ssBcT6h8NKT+J73Zw9bYp+66G3Jdywnt2SR9Ew57tgy/KXyYQWreQTemV0zgchcUPBe2ePlzh8a6/Nn7T65CQWJJOFeFvCmuaI3Z5LLCOwIgVyyVfVbDdNQSCgGTnU0SZt9FqcSsGnNuXNT0V1JCUqJ4OIfH9tAg2Ik41jerqTguuxZzph9OGmOF3lbRfU8DpXe73QkbNUv8fBe36EKiJgVTdgWpF35x55TW2LZQjDloXUHZIMTIjr7WTVhlha QEw57G2O SzI1K3i3Vu488XiKGQU6KQXyq8iOiKuQvbuY8+gxG/XrGhL12mp9A/oArygTZgFtFXtnUeZ4Dh+AY+6vI4bmUNHnrgTLJyGw2DaWS8BYl3ZTHlPubxoJFayDupt6YQbP3ln5se3rHjawzgIPSMXgq/NOuW4PAnVy4Upz4HXeMDQ5OQl0gWx8vFEV39RKE3HlDCxVLI3m4FmsqTLCwsArVvSavmyYOSJdgL1NYr1+g3lcD58T48D3+Hx3PRCkjR0KmoRaftarR2hqFyTVxEGt5cxIMmYDiyLyBhUNYkgFaa9ugr/TTr02qTbHim/Q//DopHdS3GJDJY4YmnC5m9wmy0/d2og== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/4 15:25, Gang Li wrote: > Randy Dunlap and kernel test robot reported a warning: > > ``` > WARNING: unmet direct dependencies detected for PADATA > Depends on [n]: SMP [=n] > Selected by [y]: > - HUGETLBFS [=y] && (X86 [=y] || SPARC64 || ARCH_SUPPORTS_HUGETLBFS [=n] || BROKEN [=n]) && (SYSFS [=y] || SYSCTL [=n]) > ``` > > hugetlb parallelization depends on PADATA, and PADATA depends on SMP, so > when the SMP config is disabled, the dependency of hugetlb on padata > should be downgraded to single thread. > > Fixes: f2f635264b98 ("hugetlb: have CONFIG_HUGETLBFS select CONFIG_PADATA") > Reported-by: Randy Dunlap > Closes: https://lore.kernel.org/lkml/ec5dc528-2c3c-4444-9e88-d2c48395b433@infradead.org/ > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202402020454.6EPkP1hi-lkp@intel.com/ > Signed-off-by: Gang Li > ``` > Hi Andrew, this fix patch is based on mm/mm-unstable. > Thanks! > ``` > --- > fs/Kconfig | 2 +- > mm/hugetlb.c | 9 ++++++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index 3abc107ab2fbd..f2bc73fc0417e 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -261,7 +261,7 @@ menuconfig HUGETLBFS > depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN > depends on (SYSFS || SYSCTL) > select MEMFD_CREATE > - select PADATA > + select PADATA if SMP I don't think it is a clear way to fix this. If someone want to use PADATA in a non-SMP system, he should be carefully to handle the non-SMP case himself. I think the better way is to make PADATA handle the non-SMP case, I think it should be easy for it, which could just call ->thread_fn() many times instead of creating many threads in the non-SMP case. Thanks. > help > hugetlbfs is a filesystem backing for HugeTLB pages, based on > ramfs. For architectures that support it, say Y here and read > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index bf3d5dfb921e6..1b01b244fb50b 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3457,6 +3457,7 @@ static void __init gather_bootmem_prealloc_node(unsigned long start, unsigned lo > > static void __init gather_bootmem_prealloc(void) > { > +#ifdef CONFIG_PADATA > struct padata_mt_job job = { > .thread_fn = gather_bootmem_prealloc_node, > .fn_arg = NULL, > @@ -3469,6 +3470,9 @@ static void __init gather_bootmem_prealloc(void) > }; > > padata_do_multithreaded(&job); > +#else > + gather_bootmem_prealloc_node(0, 0, NULL); > +#endif > } > > static void __init hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid) > @@ -3568,6 +3572,7 @@ static unsigned long __init hugetlb_gigantic_pages_alloc_boot(struct hstate *h) > > static unsigned long __init hugetlb_pages_alloc_boot(struct hstate *h) > { > +#ifdef CONFIG_PADATA > struct padata_mt_job job = { > .fn_arg = h, > .align = 1, > @@ -3600,7 +3605,9 @@ static unsigned long __init hugetlb_pages_alloc_boot(struct hstate *h) > job.max_threads = num_node_state(N_MEMORY) * 2; > job.min_chunk = h->max_huge_pages / num_node_state(N_MEMORY) / 2; > padata_do_multithreaded(&job); > - > +#else > + hugetlb_pages_alloc_boot_node(0, h->max_huge_pages, h); > +#endif > return h->nr_huge_pages; > } >