From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF62C6379F for ; Mon, 13 Feb 2023 12:52:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A26286B0078; Mon, 13 Feb 2023 07:52:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6EC6B007B; Mon, 13 Feb 2023 07:52:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89D386B007D; Mon, 13 Feb 2023 07:52:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7D4B06B0078 for ; Mon, 13 Feb 2023 07:52:00 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4DC82140158 for ; Mon, 13 Feb 2023 12:52:00 +0000 (UTC) X-FDA: 80462256000.03.309AF91 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 1FDF140016 for ; Mon, 13 Feb 2023 12:51:57 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ph1RzAIW; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676292718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FoPnuk0eTFB4lwFXHE/o6JfLheTxlR2V4EZJdMaA1oA=; b=1tk7YEnQt+DgfXjGnq1tcmC3wBUL2+UJH76SXvJmz301QlXFRrYQONZRWVsoEiHmAFe2W2 oUhDkIvgjVnciKxX5FMBlUmXLuYglEC+dQgICuCg57vd6V4WHui7A/5VYgayzGX2lbCf3B hMQC2pxj/vEfkFO+7Qr8FPEYUXbf/ho= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ph1RzAIW; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676292718; a=rsa-sha256; cv=none; b=H99B+4OJfRa0c6W0IwX3Z18nPxFLGYCTObWCzc4wJvWAiWXNUbQYOAWaZRPZeZVFCTpI7G b4+GVDwJla11OH/YesrgdsURtuFpL1HB+IPYe9KOs/8VM0249XG33HOq1Loo2tP23WXbOY WjAfUXL140et4EajMectsNei2Dk8tbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676292717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FoPnuk0eTFB4lwFXHE/o6JfLheTxlR2V4EZJdMaA1oA=; b=Ph1RzAIWk+tlTveaI7gjPxT1R7XrN9fBtKKLCJ/D1BVCvzAaPki8R0MXnURYdGUOkuhHqx NZqL7vJfUzgiS4W428dsaaTwG+PtL3ocdGocRQsXmwzChKrdMWK4pg9VlivGSjUQFVz07o Ei2jltpk2hcToETKnPye3Vvi5qssgF8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-227-k5oJmilGMsy1LpXJHF7hwQ-1; Mon, 13 Feb 2023 07:51:56 -0500 X-MC-Unique: k5oJmilGMsy1LpXJHF7hwQ-1 Received: by mail-wm1-f72.google.com with SMTP id j20-20020a05600c1c1400b003dc5dd44c0cso6102287wms.8 for ; Mon, 13 Feb 2023 04:51:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FoPnuk0eTFB4lwFXHE/o6JfLheTxlR2V4EZJdMaA1oA=; b=suBDcXx+5zaGIPpHnEocgwEhY6t5ZIhc+N5hyRLRnb8mdkbOsWIeWIeLdsebKTanB+ jNgTxigg61bmhv5fXEypwHE8jTR8dLYtBzfL1MQqJj9Oh7TJbxuN1wV3UGajhr4t0hqM HxvWzCRPBmAqs8Mp+qEOklTnaokJkfal8ArzdiZWCztS68RYPmNOGAHVibmCWCYM3b+L JTOF9ppOTQMBgmaOSnXzeir+jROz0sTtTb2ncsdXhMuDy3el48djRaWQwir+LKEHuhUD D2STST9EM1Ib7p3HtGbcPU5OiB4D4iM8ljwH3yuc7LORhlxVIdNmvTUdDjgWRaTAqjCz jBig== X-Gm-Message-State: AO0yUKV6yjqYxMeT1E9bWnjNLHbXLe2MHLPgnHbMHU/6poj4FYYFl5Xg L3VjJFv1pmujN1gGmodgOcK4wJ8wRcNC3Xab6hjcNH1S2fjBrURKIZlpR6Ctcjc3TgPjirs8jQc HyUIX/GDJjW8= X-Received: by 2002:adf:e742:0:b0:2c5:53e4:9e53 with SMTP id c2-20020adfe742000000b002c553e49e53mr3751429wrn.65.1676292715360; Mon, 13 Feb 2023 04:51:55 -0800 (PST) X-Google-Smtp-Source: AK7set9smxW49CA0m4KiNwy7Slmijw2D6DfBOMZPymcaM4Suz+DpSuVvrTmBdSFDQlPUXY9CdP98hw== X-Received: by 2002:adf:e742:0:b0:2c5:53e4:9e53 with SMTP id c2-20020adfe742000000b002c553e49e53mr3751415wrn.65.1676292715100; Mon, 13 Feb 2023 04:51:55 -0800 (PST) Received: from ?IPV6:2003:cb:c705:6d00:5870:9639:1c17:8162? (p200300cbc7056d00587096391c178162.dip0.t-ipconnect.de. [2003:cb:c705:6d00:5870:9639:1c17:8162]) by smtp.gmail.com with ESMTPSA id z5-20020a5d4c85000000b002c54d57e846sm6436559wrs.96.2023.02.13.04.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 04:51:54 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 13:51:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: yang.yang29@zte.com.cn Cc: akpm@linux-foundation.org, imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202302041443080696983@zte.com.cn> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v5 1/6] ksm: abstract the function try_to_get_old_rmap_item In-Reply-To: <202302041443080696983@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1FDF140016 X-Rspam-User: X-Stat-Signature: nzt5b61ei8hnwdo75i3aegbt43oujthx X-HE-Tag: 1676292717-455264 X-HE-Meta: U2FsdGVkX1+3YkUtWa2LWyHUd0PQbqGr/jLaVxOdaJLyzfCWevTPkR+9Yf3vCQ0kW67v3JjrvheXFg45AhDeIA+Is5CGIT7/+v0tSPl/pCTsHHa6LabHVSh9iE7FRGw/Mn2Z+fmSvPfJTQKvaACj8RUcbH96x0y3uUx3GRdh/GyfOTvbMNVYTuxefnGs84EGxrUiyHWTKtXM/SIMo8+s0A7kenCc0kfyUmo7c6a9a5Zq1MNnusF+w2+Vtnkh4rgrGMb7Rff5704d+M+Ln3vu7Q+1aRkF7kDyVxWPcszneKWExlrtjd2glltjrQty7COaotGHBZqRJCCqm5EZS6PnvESfW38hN4hKoES/nRLkRw8XKV9G9/LzPCoVK1+wfsIG8F62UYC908IuQmKLfJYNsrJFc6xuccGJvitlt3ZbCp6n+gP8D317AvipoPIGAJaQ8L2xZN7MmpJj4vUo23MGsNDJxxfyxPJjdWbt6k6F4TYZ4ZsHW26asaSmUoJX36o5Bk+2x0ByvCcWjhC2qk4FlUOLeJwx88lbqEnno3BU+kY/wXthvkVhH21FXGbWKxs/enKx43gK3+0Si5tFnu7kLP1qrwVVszESW1J7AjEoLOYRBXSeWtnqlU5r/guyQwRRt/Q6sV3LBHAhwZYFof5vekgPd9CKaFClaBnKq+F7o2YoI+icE1vinUukvh5KJwb/rUKluUw128HkE6cAxDwIgfpDdC/Fxe0yg4vFZyNtUPSRXKWi2+tbVeFrDZtcfqV7owCTmIJCZTH1KmsmsYF3/Aw0ceiavJT9LRyu31xLnNSyMlCyTKKUMiyLa4poGC64uMHSeyL/z26r4fmnh7RDh8Dif2sWpovJkgkRar3yJ3CCeaT98IbRteB7gPyUEOg2p1mJhLl8B1qMt4Jqr4nj/c9Snmuv6qpZn6Uf62Repo8jHUECqvJyQcTm1y7cyaSNOflWC0hLF24DJ6TdPox Fy63UmDH E0+58pmzwcZ9wJ+JQTbRfDjQasIhDGnj8jnN9TdKWa+Ce2nYSPhIdbxwiRjBsl3DZbIU2iW7f3xr+CzA2zNp81Whdg0omob5ZGpDdz6iRPG5bBF/65ifKCuXVLxr2iYa8VtrtKR8ixlE1EB5JF7ZkfsEKxAxX3sr2TE5lxamA6Gxc31xyh2Qxx76dEVCjAh/OaR6xlBWT5ipAJUd0twJaHdYr82A5KdgaEtVV/eF+SdLIMUU5zJ85INAGEpX4I+kjalEjTeE/AKZtjN0pFWBPXYKiFZ46jZPHNdyTO9kWF+DU1yHUoOClRqGTVr8dYGR7vzmAozNXHiKn+mEMaX8BY2k3NYjudi0UuqBHcUtwa4upanJ65tzmDQU3NYQ5/ARJ9rM+umUAndRmBvGZqcIR7JUOnImVLzfMG1vnHLNaxfZPBixchhqkdRwpkiw9uoHQim97sM55oijGh2eSIsM6fEnXTvPV5sOWAE1FpGC7UcRbPVFh2+4Use2tViXiOsEsmtAZaOaT/m3C7YMMz1uL7m/GPIASAZrinOB5g/WXFvBgp8AWDOfn1WRhaJWIWn/XZq720mru6w8BBtBinpPKV6aMpAdgkKduGkGblFv2pLvaQJrIUky3eEgBlZnpqI6UEkmn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.02.23 07:43, yang.yang29@zte.com.cn wrote: > Thanks for these suggestions, we will take them into patch v6. Please don't remove all context from your replies. Makes it really hard to follow-up :) Further, there seems to be an issue with threading and your mails. For example, your cover letter [1] does not link the other patches like [2], for example, because the patches don't have "in-reply-to:" tags. Try using "git send-email", that should take care of threading automatically. [1] https://lore.kernel.org/all/202302100915227721315@zte.com.cn/ [2] https://lore.kernel.org/all/202302100916423431376@zte.com.cn/ -- Thanks, David / dhildenb