From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E95C5321E for ; Mon, 26 Aug 2024 14:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D90F96B0088; Mon, 26 Aug 2024 10:42:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D19B96B0089; Mon, 26 Aug 2024 10:42:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6C5F6B008A; Mon, 26 Aug 2024 10:42:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9467F6B0088 for ; Mon, 26 Aug 2024 10:42:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4C3931210BD for ; Mon, 26 Aug 2024 14:42:39 +0000 (UTC) X-FDA: 82494662838.28.F50C910 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 0296E140022 for ; Mon, 26 Aug 2024 14:42:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XjKuGq+d; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724683314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kM8BWviJHtyUboGf0JYPYrTX+RfLudkVQti7FPlG/9A=; b=UsqfLnrs1s2Ky+JTWgX+SxVflr83hLHC03wZj3OgeTjpua0mPlA+bgpb1L7UTMOflIbAQ/ BxVpvaEudHiZhG8WNlPmeJOpD0c4DSYd4bvEriU/CKOketRNLxZA1jjWwiUAkWd28GoGSg ZirXhNyXbNshH2fFcxmJtLY+pKgJQWY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XjKuGq+d; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724683314; a=rsa-sha256; cv=none; b=Ks+Yw6wVTPD1Ybis6kK6Ar1vMwrO6O3CtY2zykl+DaMCW+lkm8u76FpVt931L0mchDWtEn sq6e79CxcGsk/wsy1+53+Q92jaSaBJiXQ/U4aAji9vtXTJqqCEUhjeXTnso3pvAYpuYllU UDB2zMER5YcWJTsskmZgqtJyqIblXMQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724683356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kM8BWviJHtyUboGf0JYPYrTX+RfLudkVQti7FPlG/9A=; b=XjKuGq+dkbw2cqNbtQI4FsfZZDNtuVxbzzWn2YQ94LjegcMvH/oEoVLsPL30100Og5AS91 K0p4P3FzxtkfKvUdk6VHSXLHgNT3iSVJ7ecELMk1K4jTmZaUNZWEaT95KB6jwV8oZUoWWA kB2bE759NFuaLeU7tkyvF62asPYFaQU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-ulILemzEP2Ku0YxaQk5RBg-1; Mon, 26 Aug 2024 10:42:34 -0400 X-MC-Unique: ulILemzEP2Ku0YxaQk5RBg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42808685ef0so42037445e9.2 for ; Mon, 26 Aug 2024 07:42:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724683353; x=1725288153; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kM8BWviJHtyUboGf0JYPYrTX+RfLudkVQti7FPlG/9A=; b=RPK2W+BfeOhDlbPaTon93IE7/Elv0/H1x0e5XL1NLwGe3kzbuievMNykjAw8g4O1EA wyRgBfprbkptJ4Q75++6kcdH8BDvDhEwNr/manHvVQaOf6ICj7+hT/V8VgbRhK5CryBH yP2o5HASloooKTfhfsBo5i4oC/5rmbU3pb7EFEMVV1qVhWJvM/A9QOXDjaMPSRlc93wy Q1di7DOB5EmT7NjJAyJJvbC0h+XR086wQt90gNDYjsn+B/KLWEBLA2uz0zDqDdsTXL9+ ModEofEcuJvFigmspzfj9ZYhNMwj78Rb9nMxidNOefbnERczUKAbc1883gN3+02MhJRB m/NA== X-Forwarded-Encrypted: i=1; AJvYcCW6oH/t0Ya1O8uqkc5lpq5gCui6i2bnJyrhrwWhBxYxc/6GiGqC94FzstdnfAiZP/pUOMyznYKR3A==@kvack.org X-Gm-Message-State: AOJu0YyG+ZiWRZTOawq0IiJFuTdxDgrlRHkFVbqkRMqWz61b0011EbTV qqAVuFAJcch0IT1lXbYZMuKk81jH/EEDOethb35oHku53lr1V7xEo89EVdE6qa/WzHJ3WuqbU8H ReEpVbVNwn2+jxxa/+2hNAyll8RICViWKkKC6B9ZOTVU65I+t X-Received: by 2002:a05:600c:1f88:b0:428:fb7f:c831 with SMTP id 5b1f17b1804b1-42acca0179fmr82438835e9.32.1724683353625; Mon, 26 Aug 2024 07:42:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzCBuCY4NW2ZxailkpSN31ZdKXte69GPsak6m4BrWtAH5BQCoRsBNLe3//8girG+5Z7JckyA== X-Received: by 2002:a05:600c:1f88:b0:428:fb7f:c831 with SMTP id 5b1f17b1804b1-42acca0179fmr82438555e9.32.1724683352904; Mon, 26 Aug 2024 07:42:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac517a4d4sm155018485e9.29.2024.08.26.07.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 07:42:32 -0700 (PDT) Message-ID: Date: Mon, 26 Aug 2024 16:42:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm: memory_hotplug: remove head variable in do_migrate_range() To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-2-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817084941.2375713-2-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0296E140022 X-Stat-Signature: 6yk5u7ggcygkesxqoi9owshnniaijztr X-HE-Tag: 1724683356-824493 X-HE-Meta: U2FsdGVkX1/rvAJkE4fphsPSfrAomBbixzW5IHTbiaIYRYgqDJM6TtnAhKlgOobOAs5k4f4N8Ez79kbASIrasaZuL+vgudcObBLDLZ7ZUvFkM8CLmt6TUKEDBkdWAT7b10bC5xZCrCfhctAzvCnpp8n4wv37MykLl0rajx1abFVcZ9YmDhsk8zEb7mDilnDI1BljwNTXh4iZrPUZyxiW5xOeW0x+LLwY+7IL3nk/HU1qeErLQyz6RcgfvY0gxOGntVPxRseFsn4p61+6apc+UGjlT82fRSPgafNHlLCTQygQThfFau4Fr9rsHRu/IjVSYjRQDZq6SR6etnDUh9suSY7VtZvZe0qDmUI40kPtTmqe5oGYRYhGtduIjKoSa6aYpK6CL+IfIXPGrVoqc8HJ9CobFTDxeSmMnY2WwXjxtPNMP4ljVepTHfQ5L6rDiYTLVh75+pWsXs7NNLguF01L3YBEVFu+kEqlnGuBHku9uWlTsKtnQIe7D12wFRr+9uoMlNUIH0+1EnE9ooXS90AmMT8u8NUf56Eg2ak1LOKj3vl1QyPwbhp74gUHlEqjcjMaTGErTmezDeAfwun7pJ6RGX9W/xjh++di//sV4GJVnA+DQB3xSDECBZzjNUr6iagCprnUmmM3aNc2bQjaDt8759CgeRGJKtuENT2JxDk0Xy0SCQ34sT6kG14dX8JgYq6QCu5T5IEc4qIJn+1pywdlRkbcge/WXhdlF8d5ZTi467wR8eGUp0LZeqFoUDQY4k/jo8yMUXv5uKeSXt4JJ8REHs09mnPp0Z0Su55yoRwjP5AL/qyHMVu5TM8dANlg9yBoQeDTpthvhTZFyZtxNb18qyK1zhW+wNSzB8NS3RRLqtbKjfgB3whw95+uThubYJ5VIvqCC5J6NMrVaQ6+To/kRAg9fj5ELa3Ir85Ztl8AF0BtRFrrYXw1f3bfXraPn9XnyRRtbhF/OKTVh8QUIM9 25YN/For l3eiahCIw3/yEQOBdY6+EUAnz1xfbzTXR7dqQG1pFQVC7+XmEadFH6cwfTqAYjxveLyIFwp0g3TqsjEN6XvYN1wfrA0zbDZl04qxJx7g8N+6m6Uc6O9oQCA2eNSoIYQiyJJ/SRiphs8kH4ewZ0ueUvid7nOUavUE5ev/9/ByN/7OOzI0A05bSl64cdvGaS+88bwydh1NFeevkduqzZDkglpiAwc0zwOL23vXTz9tZTXlGVHKwCBoTqXHhYMntkkfx3+s6IaUxoFeM6a397yt3c3cL+YG7ZD8tSOQDq2w8qU5jQkfz2lmyW3+QrNqf6+uKMAZUDmCLAIeSgleQsT2OvARuuQmVaHXGm/Xm5sqdjszSzoI76hCz4/G5r5gUvBrcHvM3JDnda/3oo6tS4g13bxuEN72aWyD8jp7ylyMROBlK1ru3EWePGuYfQx+rLHvqFjRhB4DLTSoT0T4QHA6/L4r3OnZppahTEImDFtt+dIHlOpCUfVEUsSoqHHzakUZURmX7m7oPo7mW6pwyWsXBhVELxW30cVzjdtXKIkVCS+X//lkdPifdAMMBZSw9qIOuwDx/4XA1EjlqwqGCR0ItiGIpmdhx5og2tvShH7bMwrhkXsA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 10:49, Kefeng Wang wrote: > Directly use a folio for HugeTLB and THP when calculate the next pfn, > then remove unused head variable. > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index df291f2e509d..dc19b0e28fbc 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1773,7 +1773,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > - struct page *page, *head; > + struct page *page; > LIST_HEAD(source); > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > @@ -1786,14 +1786,20 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > continue; > page = pfn_to_page(pfn); > folio = page_folio(page); > - head = &folio->page; > > - if (PageHuge(page)) { > - pfn = page_to_pfn(head) + compound_nr(head) - 1; > - isolate_hugetlb(folio, &source); > - continue; > - } else if (PageTransHuge(page)) > - pfn = page_to_pfn(head) + thp_nr_pages(page) - 1; > + /* > + * The folio hold no reference or lock, it might be changed > + * concurrently(eg, split), folio_nr_pages() may read garbage, > + * but out loop could handle that as it revisits the split > + * folio later. > + */ > + if (folio_test_large(folio)) { > + pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; > + if (folio_test_hugetlb(folio)) { > + isolate_hugetlb(folio, &source); > + continue; > + } > + } > > /* > * HWPoison pages have elevated reference counts so the migration would With the comment cleanup Acked-by: David Hildenbrand -- Cheers, David / dhildenb