Re: [PATCH v3] smaps: Report PMD page size for pure PMD mappings

["David Hildenbrand (Arm)" <david@kernel.org>]

On 3/4/26 18:29, Vlastimil Babka wrote:
> Why do you keep not CCing people from v1/v2 discussions? David said that
> already on v2. It seems rather rude to me.
> 
> On 3/3/26 9:15 PM, Andi Kleen wrote:
>> When a smaps mapping is only PMD mappings report the
>> PMD page size for MMUPageSize instead of the base page size.
>>
>> This is a revised version of an earlier patch that tried
>> to report multiple page sizes, but there were many objections
>> mainly centered around compatibility for mixed page size
>> reporting. This patch side steps all of this by
>> only handling the non mixed case in the simplest possible way.
>> It also avoids a problem introduced with v2 that page sizes
>> for mappings with no pages were incorrectly reported.
>>
>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> Will this be useful in practice or just confusing? There can be e.g.
> misaligned mappings, or other reasons why there won't be 100% THP
> coverage. This all or nothing value (IIUC) seems inferior to the
> counters we have that say how much is pmd mapped, so I'm not really sure
> it's worth changing this.

My opinion on this remains unchanged.

Not CCing me once more is questionable and makes me want to recommend
Andi to work on different parts of the kernel.

I sent a doc update to clarify this. Won't make everybody happy, but we
can't turn back time.

-- 
Cheers,

David