From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF1DC25B7E for ; Fri, 31 May 2024 12:24:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C32F86B0088; Fri, 31 May 2024 08:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2856B0089; Fri, 31 May 2024 08:24:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD21C6B008A; Fri, 31 May 2024 08:24:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F9F66B0088 for ; Fri, 31 May 2024 08:24:46 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32818A0E4D for ; Fri, 31 May 2024 12:24:46 +0000 (UTC) X-FDA: 82178609772.23.3617AB6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 2FE0820007 for ; Fri, 31 May 2024 12:24:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717158284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M04hKxRLNqWDIvcjUObzazjO47drTmOvQIFEMKh9mZU=; b=CMOxLJrmt3R92w7CLr+VKrdMVZqORE5Au+EG1yWl9+rZOxX9LtcGMYguC3z5rPiFcS8hlv 1nk+t6TI/2Nu2+t4K3knkqIBsdeq2+dJDtdR5a4HIvlKkdcU984dAEa3KiGv1f6Vm2466W QZ+ULl9hV4S3f6a1/G1+epCr750vDNc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717158284; a=rsa-sha256; cv=none; b=GQPv+1zgvDseiRtjFSTrvj1/9gqxUdPgJNBkgVYtrXclR8zLTMKoPuyingcyFa8lN18LAO GhB6Kvk3RJPehHXcKrMcnoS2NkOqmQr+94SPWxeBOHrCEQ85BOi7ac1opLyLy7xbmoz1IU FjBOU7omHSqOZr8GDPbqowjAzL/lZHk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E9561424; Fri, 31 May 2024 05:25:07 -0700 (PDT) Received: from [10.162.41.15] (e116581.arm.com [10.162.41.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 759503F792; Fri, 31 May 2024 05:24:41 -0700 (PDT) Message-ID: Date: Fri, 31 May 2024 17:54:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [QUESTION] mm: Redundant const parameter? To: Matthew Wilcox Cc: zhouchengming@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2FE0820007 X-Rspam-User: X-Stat-Signature: wne4gr1k4scxjim35rsbgje5pdrhhnep X-HE-Tag: 1717158284-316484 X-HE-Meta: U2FsdGVkX18UIkQSzc/XkAoy3Z3J7jaEyA50Gx6t22UvhmPOXqbx9NpeUoP9YmFaoSXrDQkIrE0UCTySfY8Wln7W5QR7FPowPfrLDt/LTNeq08yRN+xhSNnU3fVbkw5jEfA/A9S3EBplpLELJvNJnyLNC4ANCTanFD1XMAQnKOTj6DgM6wxt3fmudAo0fZrRfT0Y1lZ/Z4NhwE8lprE6wKjHhJycZcBVPvid53WlI3sOIkvkkUbPE2ZdWyG1bnvNgMK6AW+RL82hJa0ZeQQ3CpVRinDYPftN8CBRBekOpsF6VyyZSVKi/7pzQcYNB7oARHYviq8lEe/2YlwdDjoxxF1ep/VVAabIsSOpSmsZ2PwVsqXUngTxpWgIEEiGYbKjZFwPjCn4jPIwWaKjJohXSCeCnAvJJ8PN0A5P+jYOL7IEbfP7cWef5bzOZwrydW2kDg3R8AeWgByZtmFMTwBg2EO7d3S/15Gx8W5nh1XTPsrGuLU9nJeyeDpmU0gwrUmc4h4T3mNoYCS7Hmq15sX5iW6mjtdffizN2RP3YnspZd52B5GnMdOONGDk2kWqg07Kv8exR20rDCUUNoEQyba34RHAay6JPl7Wl4zpUgVeciXRU/EnUNtBMypYgmKDFNAgru9zD88s3ut/tZjkefVP6qcEw3GvLQtn/ooMom5o2vGUBOik/JDFOFASY5VeUp3+jPhDmunLdrFbDRmGEyFNqs/GDGUL295d7PfmFR2Bu3SLy4PEDHp2AAi0EIQ2ijsgK6jMxdMAW+a9hlfnJIGsfzVsKNXledlbd1pwKPP0r4W0mq6KBuOMpgDZM8MAcHDqYjSAG4ovuMuB9KZyS/+j2DQ5RBTaAqH5aYDFucErlNKsyfuH6fUnWZcarm2xGntXTjLCMNVgjP27v7VGi8Ef+dq/ckq2TWQklMrHc6n1JLmVZqzOAAX3N9Q2f8WyedHKDlY4nQ89ZktH4rE1oha jGwir6Rj WSCVVpFuwrK68f4j97ttymdFhAnH8N5Mjl8lPav0AE72jj3RenOQ+DArccKDoTLHHM/6kKzt3J/vwUpjADbG5hgjirxeMIYqs2UZUD8iz5FOlziFgc5kb6U7wmH9YRieQ9A4wmAkxejhjoDMGnfz1E9SDqRTTrAyfBdqLn0bz2nPnmvlIQHGIQjQWA9YbjxRQrYkc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I was just about to hit git send-email for a patch-series of 2, I noticed your reply :) On 5/31/24 17:47, Matthew Wilcox wrote: > On Fri, May 31, 2024 at 04:42:59PM +0530, Dev Jain wrote: >> Hi Chengming, >> >> In mm/slub.c, you had defined slab_test_node_partial() to take a const >> parameter. >> >> Is there any point of taking in a const, when you are anyways typecasting it >> to >> >> a (struct folio *) from (const struct folio *) ? In fact, at the place where >> you call >> >> slab_test_node_partial(), the struct slab *slab is not const. > I have a patch to fix this; hang on a second ...