From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C078C3DA64 for ; Wed, 31 Jul 2024 09:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 841E16B0082; Wed, 31 Jul 2024 05:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3B46B0083; Wed, 31 Jul 2024 05:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66C236B0085; Wed, 31 Jul 2024 05:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4166C6B0082 for ; Wed, 31 Jul 2024 05:41:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5853C01FF for ; Wed, 31 Jul 2024 09:41:07 +0000 (UTC) X-FDA: 82399554174.16.247ECA3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7F7CB1C0021 for ; Wed, 31 Jul 2024 09:41:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RxDGCkuT; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722418811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sc8VGtQi6daTpPbdO6OMJM563OU9qA+XG1xjOxfnOrM=; b=O9iHYnZJFVZci2WgLrgSVEhRXP1sfdfa7aumc3ziX7Di9hBa5M5H8V1WGxEANqQn2jLvXs Unq1UkqbyOyALZzZSFhrgVVEU/S8NKOt97rb1Oa4/tJu8TpUg2QsAcJu0rpFcNLcSRDa9T putHM84YNlbN5EYGsR80SW/qKNziMNg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722418811; a=rsa-sha256; cv=none; b=BXr3lQb+OAYpz8aARE74EvTwLp6p3ZL7I9JVwQcekTGxmp4drnkWkPDdGq9nugw2AGHUj8 aNy/fRrbD8F4Ww/baMqYFuBBoqR1N3rk5SGzi1/2fq/NPcTv/b7OyitbNOUIt+rkFO2zxQ LLeX1rX66jYyi359XL2zFsnTfEqeobk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RxDGCkuT; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722418864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sc8VGtQi6daTpPbdO6OMJM563OU9qA+XG1xjOxfnOrM=; b=RxDGCkuTI8rtETnFuzRI4VK6Y01NeiY1VuSqaTkfNbB5cASp70I6wEd1vhE2BspcckMzB3 F1Uxqu1FqGFLYC7wR2OJs5bOgopf2FgNbG0K+QIGlt3jfXCrYQACyoah3AJZxGq5jE2b4b 6PAbYHGldpEmIsMf/FxFfegb/ekCH3A= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-l2gk1DZANgCt-cTBYgjjzQ-1; Wed, 31 Jul 2024 05:41:00 -0400 X-MC-Unique: l2gk1DZANgCt-cTBYgjjzQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3687eca5980so2474347f8f.0 for ; Wed, 31 Jul 2024 02:41:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722418859; x=1723023659; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Sc8VGtQi6daTpPbdO6OMJM563OU9qA+XG1xjOxfnOrM=; b=ZNZb45a7qLUyD8zisGUoTR5n5ol7kdPc7QttX2T6oDPILA4xFq0paO3XOg5/LAtWlx kohTXU90AtVcY4+NM0/8ttfMtxU3oz2vAv9T2nclsJr4/JrTvS7ZqV3zwWK6yTDEQccP ++h3y+vFVR6yhdlC+XoP80qWWNTyCujh4DQaahVegR4aKoNDXkIixQcpn9ZrxW4s0tVP x17fTmQMqvRPAinvUIWTDjGT+hbnENulIsCHzrwD4hpq7kSh+wkQjKcWfaJsCsnuIIrQ LJh8OYQJme0kut9BaRi7ayqnIgGWN+pwVRpNga9Bza+Dgx21o/Zmi7b0mKC8hw+Oz8WK 9rrg== X-Forwarded-Encrypted: i=1; AJvYcCWp40FFDBgQqTramS7fnQMbF4pVROhqCAfvgyy9p8ngcJlt4bzNjplYM12rXP5ilWh6/2Ivh0wpKQo3odjQGpd3ooE= X-Gm-Message-State: AOJu0YzDZCKOSlfh/PK9w0UIGXDRxyoE2N4IVEZoa+5gFBeedqwlWY5G 6pHr78p5O6oGX84F4KbOso27StphPNu7zHgkpsLXlbx1VA+qWPw1a51hLUDE5pyOXj/c+Z+Zy59 6iK898VJOSwEQUOwNxir36/LBCOESeWuaExDxpoZVf+0Fbg8P X-Received: by 2002:a5d:6d09:0:b0:367:9621:6fa with SMTP id ffacd0b85a97d-36b5d2cbd69mr11446912f8f.37.1722418859026; Wed, 31 Jul 2024 02:40:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHc86KKRTCvuOK4uCqwZvQo/ZXoo2yoGfetk8tNIduKiQ1bOrFJImChXOVuZ6DVHQo9MFwDow== X-Received: by 2002:a5d:6d09:0:b0:367:9621:6fa with SMTP id ffacd0b85a97d-36b5d2cbd69mr11446893f8f.37.1722418858599; Wed, 31 Jul 2024 02:40:58 -0700 (PDT) Received: from [192.168.3.141] (p4ff23427.dip0.t-ipconnect.de. [79.242.52.39]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c090dsm16616376f8f.11.2024.07.31.02.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 02:40:58 -0700 (PDT) Message-ID: Date: Wed, 31 Jul 2024 11:40:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:pending-fixes] [mm/hugetlb] d3fe1a0a02: WARNING:at_include/linux/hugetlb.h:#huge_pte_lockptr From: David Hildenbrand To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Peter Xu , Muchun Song , Oscar Salvador References: <202407311421.95f5c759-lkp@intel.com> <30eed7f9-19bb-4b45-a9ce-52acbe10024e@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <30eed7f9-19bb-4b45-a9ce-52acbe10024e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7F7CB1C0021 X-Stat-Signature: 7kppk5rbfb5zzqhsp1mu51ftjhp3g6s4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722418865-436769 X-HE-Meta: U2FsdGVkX1+7WmbdFDlpHb00IYKoJvLAet11u2c0JOcxatyTKpOwWjsT6oojWqj2s5ZqBLI4PjRBCth4B0TszFZ2lHz9GZ52GdtLNNxlG178oMiPmgYGUJ+eMtZLpVuxpPFsn7HRoCMzAv0eTSDyQQNby1XFeWCbUk/EZpbTF9IN51+bbf8MKST6qoCIwM6fkDqf+t2xoNoV0jBT3RUs5l3EcKAJ7b+foQUsPqgj7koXBFmJcy0KJWWMNYo9Y5IWFvCnR3oOMF3OneaTRi3scdFL6BBZE7czjZJ1zVnm6Zt/fsxjrz40PMquj6hqtR+bINjxqYA0tW3RoOayqMdiAeWkVdR0IhAl4Fpg/eZQIRqT95w5dxGk7T/L7CUVHhbOXQ4QJ+qSAg3X/6Ysj+1UqCbxzoR5U89SgZGbfknAL2WmjsFXbnEo+OvlYHro38iE4NmqIjCdJLAIyxVzgeSQj3eB4/7ODuUJMA+ewGDxPxO5jHUm1SIMspzuBA6bdDDN7mFN0gMnsN2KD+b933X7BsqGET8WrNFP+5LRZbwejfsDh7agIEDThPL5MHnoq4slNohFU+m0B7/VcL2Cgf56De7ykXInTFD5MMGUE67DU41vs9K+QKVFBDjwmGg0IFq1N5bfwNQa0KqlO0fat/oobvLy9HUtYJUxRfdTBV8vZET+419Fq1INNWlp2fmt4SiUkSD54JNml6Sz6bDGILh6YBN8EFPKMZdd7OhneuE+OoYeqRB4CrqTSPsJf/YCKFYh8Vym6gRyPTOJYTVW3/NoIW85317TNlbLq0fowliO6YOK0TdavMgfWEtqKMl5mmL4NMHbZCjvDvpto5FoKJ8yU0rkCHysicSLI/6gmV7GDsf/zQMKVGTj5++p6GwrckBMcYqTx+BIziTpTljrOC+/qNt82dA0wNW3dCtFxHMiug3MMF3734SCUYk06TJ1LX4pyJ9wRFN+gvjFgFffQFS Pz17Bb1k H10gX3pPJTy3jMeQtOnIZjc5NyLo72W2Uajj+5JyJmhgZXdrKROYylq8RuTTR6a+bCiwFAS0GUWqG2hdbZnYWAth9ZMqJV/BR2/hT8MmWxPgfZYj/vihUofO/2miOn4yirMSdeVFv2w6rRbL6PBo1aWXlBhmTG7HFDy5F0PEmefOjHJo+hBaz3IWJoGpY3J+P2gRxMhujm/iPqyd+9L0wHEiV7QVrwsgYEYgwFJxnLTvoy+6+vJJR5Ob/GpIj94l4tBOcXjE3M9Wo0QgGX7pU3Re3bRH1XhRBDAZPZeHA+byAwF+Zt6hMZCwFoQ3Sny4FhlNbVLiNMEQGgq9IMljtRj9yRR3LfDdlkNDvkwPCHzeUQLul+HHnEB2PE44NaZAcuaAdujb3ZFzScR8LlL0qHzTemTDZmRn4wSZQUdx2Sgg2ye6SEmbIM3VaYTJWfkK0ZjfggwdI6go5SppafFgRICgPrp7NXC/fAxKKP50A1jG0yQsIb2DQzEq3kdyZY3yowtZpo7hntNobFrM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.07.24 11:28, David Hildenbrand wrote: > On 31.07.24 10:16, David Hildenbrand wrote: >> On 31.07.24 09:20, kernel test robot wrote: >>> >>> >>> Hello, >>> >>> kernel test robot noticed "WARNING:at_include/linux/hugetlb.h:#huge_pte_lockptr" on: >>> >>> commit: d3fe1a0a0272723474056e3000717d69923ad901 ("mm/hugetlb: fix hugetlb vs. core-mm PT locking") >>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git pending-fixes >>> >>> [test failed on linux-next/master cd19ac2f903276b820f5d0d89de0c896c27036ed] >>> >>> in testcase: trinity >>> version: trinity-i386-abe9de86-1_20230429 >>> with following parameters: >>> >>> runtime: 300s >>> group: group-00 >>> nr_groups: 5 >>> >>> >>> >>> compiler: gcc-11 >>> test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G >>> >>> (please refer to attached dmesg/kmsg for entire log/backtrace) >>> >>> >>> +------------------------------------------------------+------------+------------+ >>> | | e98970a1d2 | d3fe1a0a02 | >>> +------------------------------------------------------+------------+------------+ >>> | WARNING:at_include/linux/hugetlb.h:#huge_pte_lockptr | 0 | 12 | >>> | EIP:huge_pte_lockptr | 0 | 12 | >>> +------------------------------------------------------+------------+------------+ >>> >>> >>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>> the same patch/commit), kindly add following tags >>> | Reported-by: kernel test robot >>> | Closes: https://lore.kernel.org/oe-lkp/202407311421.95f5c759-lkp@intel.com >>> >>> >>> [ 39.570466][ T3479] ------------[ cut here ]------------ >>> [ 39.570921][ T3479] WARNING: CPU: 0 PID: 3479 at include/linux/hugetlb.h:948 huge_pte_lockptr (include/linux/hugetlb.h:948 (discriminator 1)) >> >> Helpful! Likely triggers because in that kernel cfg P4D_SIZE is 0. > > Hm, with !CONFIG_X86_5LEVEL we should have > > #define PGDIR_SHIFT 39 > #define P4D_SHIFT PGDIR_SHIFT > #define P4D_SIZE (1UL << P4D_SHIFT) > > ... getting a hugepage size >= P4D_SIZE seems pretty much impossible. > > Anyhow, taking the easy route to be done with his hugetlb crap and live > a happy live, I'll drop the warning and just handle it explicitly. Realizing that this is 32bit with CONFIG_PGTABLE_LEVELS=2: So #define PGDIR_SHIFT 22 and so should be then P4D_SHIFT,PUD_SHIFT,PMD_SHIFT So we would get "hugepage size >= 4 MiB", which really just is the default PMD size and we would want to do pmd_lockptr() with "hugepage size == PMD_SIZE". -- Cheers, David / dhildenb