From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF45D2E02B for ; Wed, 23 Oct 2024 09:13:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DABE6B0088; Wed, 23 Oct 2024 05:13:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 664B76B0089; Wed, 23 Oct 2024 05:13:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B64B6B008A; Wed, 23 Oct 2024 05:13:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C7726B0088 for ; Wed, 23 Oct 2024 05:13:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 50B794061C for ; Wed, 23 Oct 2024 09:13:46 +0000 (UTC) X-FDA: 82704304032.13.08F5786 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0FC0C80014 for ; Wed, 23 Oct 2024 09:13:20 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q9BdDVFI; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729674631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XGmXbEWPuTnEzL7jJo/H+qLlycElc1w9NY5n7oUowQU=; b=lkwEL+wZ/Sr5k6p+uZr3gHmDq6PPr2VLJpzkehUm0FxsSbDc3QMx29tjDWcji6IO/udTvZ 1H/1FQ5Py996O/TgP6IVb90wzMb1I3APvf+ZpNgJ9dSkwGlg4zUB8LZD9eO/q4tDDtX1f4 v7A83qfqTOj+RtiB0Lmoq8kkImlNRnM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Q9BdDVFI; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729674631; a=rsa-sha256; cv=none; b=CNgU5YVgTnIbIMO/RS6u9opl+tyyuK0OmXGlBWn7iA2sCFP9aeZiJbnFZ5JPf1dWJS0nuH pbs006tNjQpppHc+waYQcle5QAYezdzVNQ0QaKQ6kSRLNhhdLFAdR/Hl73S04cEAFzxWdZ sy8FUXCT28RydAPsIsWuBtrSeyAvl84= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729674832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XGmXbEWPuTnEzL7jJo/H+qLlycElc1w9NY5n7oUowQU=; b=Q9BdDVFIBhxO7RH/f/vGrQKDmv3cQg8jeBNw07yehNK0K6V6pk2sthn5lda/nvb2F0Wm6u pPSZkPbpahi0xvh4lrXTNzR8B39Tp2JcHAeR5VLCAyAqgt6N2vyHWa5/9qo7rktns4zusi tgAHKJWji5ihPUwLNeGkXPox4QIjSow= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-dv7ld8dJPECFuV6zQ3uf7A-1; Wed, 23 Oct 2024 05:13:51 -0400 X-MC-Unique: dv7ld8dJPECFuV6zQ3uf7A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43159c07193so59580535e9.0 for ; Wed, 23 Oct 2024 02:13:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729674830; x=1730279630; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XGmXbEWPuTnEzL7jJo/H+qLlycElc1w9NY5n7oUowQU=; b=DTCswkuA5qDsr3ASKwuT4DitwGwcl+dMgY1LkpeN0+F2vJWrpysX/aqVFPpFG0+aK+ aCobBQZEQJmFCqT+v1wFwSI0crbYfOuh6vbOwhHkZ7sTDlw7kIBfgHtAM7txk3uKw0Jq wccbOhAixEXLnNV6D1lUx/hZiLAI2kl9QXIMt2avxR6Lp6A6P2ssJ5WkSYbmysbI/8Pg meSxWPp8oRPtjdSSsHos5ux2hbVWzJyFd4KLr/bYcOB5+MFUiMxf6aPv3XQpvgM4lr3/ MlBCOhlVlOiZlwWy9K5rhIY3HN5nABZicA+KA9+LJEUdUmMB0Z+OW87LymlQfHLvrqkZ gksw== X-Forwarded-Encrypted: i=1; AJvYcCVSz3NQ1sRsudstTWxt2gYYPW9p4WGu67YyGpMHiEY6o3cP6VYHzLF9PYMqdpnjOXkASoC84d+M6Q==@kvack.org X-Gm-Message-State: AOJu0YyR1HiZadhK32c2CQWo3Esf4IorIMYpgAfOJ4a4MhRRZCpuBlkG gVdyxBkPqRBA6Yy0cgVXud3ZxjXEitPT/fL8YdtPz9eoXMxBBDKDU/IiLiaL2X1YK8t/VH/VuU4 4luxklovEsfnpe0WnmIJWBkdPnl8EnosrT0HxNXvS0qDies36 X-Received: by 2002:a05:600c:1e0f:b0:431:518a:6826 with SMTP id 5b1f17b1804b1-43184211ee6mr18252195e9.19.1729674830355; Wed, 23 Oct 2024 02:13:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmKe7DKESkG0ElqhB4mK6OoPTMyk/w1RF7xPQmxYy5kxyW1yn1EExyDb58wNBxJdCNVK/FeA== X-Received: by 2002:a05:600c:1e0f:b0:431:518a:6826 with SMTP id 5b1f17b1804b1-43184211ee6mr18251875e9.19.1729674829869; Wed, 23 Oct 2024 02:13:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:cd00:c139:924e:3595:3b5? (p200300cbc70ccd00c139924e359503b5.dip0.t-ipconnect.de. [2003:cb:c70c:cd00:c139:924e:3595:3b5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b944fbsm8541274f8f.72.2024.10.23.02.13.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2024 02:13:49 -0700 (PDT) Message-ID: Date: Wed, 23 Oct 2024 11:13:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] implement lightweight guard pages To: Vlastimil Babka , Dmitry Vyukov , Lorenzo Stoakes Cc: fw@deneb.enyo.de, James.Bottomley@hansenpartnership.com, Liam.Howlett@oracle.com, akpm@linux-foundation.org, arnd@arndb.de, brauner@kernel.org, chris@zankel.net, deller@gmx.de, hch@infradead.org, ink@jurassic.park.msu.ru, jannh@google.com, jcmvbkbc@gmail.com, jeffxu@chromium.org, jhubbard@nvidia.com, linux-alpha@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, mattst88@gmail.com, muchun.song@linux.dev, paulmck@kernel.org, richard.henderson@linaro.org, shuah@kernel.org, sidhartha.kumar@oracle.com, surenb@google.com, tsbogend@alpha.franken.de, willy@infradead.org, elver@google.com, Linus Torvalds References: <87a5eysmj1.fsf@mid.deneb.enyo.de> <20241023062417.3862170-1-dvyukov@google.com> <8471d7b1-576b-41a6-91fb-1c9baae8c540@redhat.com> <5a3d3bc8-60db-46d0-b689-9aeabcdb8eab@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0FC0C80014 X-Stat-Signature: nybngmkjmdxk1xdnc18e67q5i93sk8na X-Rspam-User: X-HE-Tag: 1729674800-2000 X-HE-Meta: U2FsdGVkX1/sd8kb4MxQZJRcWKXDGhf77CKL6LsPp5SLtly7eDCUjUH9FsEL/Y3zdYQRkNOO0mtWnEJADSDXdMxsjrUDtSKXcdejMbt4GpBBmycIowcA4QjQblAQQTnabTX2LP1Ja5FBQuD83AOkEsnrPGSz2QhkYo8/m9mWf8OJWcOyCFAPvuw2ZPQcPVM5QrtMiGcxke+vdFKil4M2y0xacaKnZtD2w0uHBLYCnD5zomsmt8+jcO0H6LGL5ltahg5hA8ACd2U6Rr9lp6ym8dJ56xmCKNbTq/IyPxLHGH0kTMz5MYBv7i4DxH+noUPlHmu8w5bcxFmhJs5SQ+KnSu/gz9tDmSedM1SBWXSH/1ji7r2oG8Wh4nCrQLOmTFH4m22FRHQF9SwP8o9ueAutE56MWx97lNr8K7hLkCZj8oWmBdXTL44oYEyDs6zMsWzKNhc+vgTDWmr/A3OLp3kRkHtIYI0t/Ydt1NBOSj7XUl2FwS3MGeAI7IwsbSIa0J8KUtKtGXtTBLgeMCly8tFJW0jrJCtzznZAlsX11urgKfkKBq9tvLBVkF1BkCYjLymlh+vzmtm6Zq047DxkOnpto72pzd83O2LwteWObRzGWEoZyk7Ibv26TdR3l8as+Q37Bv76o14gtDfWhWVGc5mYoR5u8Zi1AF0FHjyrqtiBaZLHAKnEgAfOZERhIDV8mSSGWD+aLm1zko0tFploxHY1tzge+C4W5xsPGFS5BlzzMosSSz6dp8Dw7+0+Yi6uBebxykxAZEuB2M0Zr1RyqkVGkX82I4dFHUPRDPkwTQNZUqbygQfliHSV3m5WZ0505DjdQ1/ycOKPqDIWEC+VBBe8lvzgduq1QX0QGACEGXxTNTwjN6qBYTo+ZOgIxv4onN+jZQpWS1wC+FfmoLcDTzoiKmUCxYzWhU8AemPrTbpH5Me3p+6HkncqL87yDdOuuYRmASMwa6Gi9XQY8+aqQzb IpPyoycP jCJOsOARIfb9iEtzh1ZcTkOUW1yq1GlFZIHbaGzDJlzLZ3XM8V89MnCGsWiPpeH0tr550eGA8brbcGDPypG1/5tTFaA/ZBewsg3R+akIVhSMB5ldLn3FF4Meg3o/Ttk40BSQd3IagNZ7dVaY3NWeFkXF8gWEQy06qyON1J0tS8AJGJQzMe1tVWXg4VqD8voyF9C8Nw7YlNbGx34k/0DI83tk2+TVDqcPfOuNdPi/FS6RNaxrlgecQccLJLWmcPHaWuT5pHgvMf0LjiE0+wVVfa/fTJr2AkQIC1X32kl6HXqiJWHhmJR09hxH+y45g4ZofPXTeSo4OAKmVZW+wb8uuM7YV0fxp6a6YIX2ddDtnmMDSWVMCIOKgWatvzSSwbEGEFaxm83koXkWg0NQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.10.24 11:06, Vlastimil Babka wrote: > On 10/23/24 10:56, Dmitry Vyukov wrote: >>> >>> Overall while I sympathise with this, it feels dangerous and a pretty major >>> change, because there'll be something somewhere that will break because it >>> expects faults to be swallowed that we no longer do swallow. >>> >>> So I'd say it'd be something we should defer, but of course it's a highly >>> user-facing change so how easy that would be I don't know. >>> >>> But I definitely don't think a 'introduce the ability to do cheap PROT_NONE >>> guards' series is the place to also fundmentally change how user access >>> page faults are handled within the kernel :) >> >> Will delivering signals on kernel access be a backwards compatible >> change? Or will we need a different API? MADV_GUARD_POISON_KERNEL? >> It's just somewhat painful to detect/update all userspace if we add >> this feature in future. Can we say signal delivery on kernel accesses >> is unspecified? > > Would adding signal delivery to guard PTEs only help enough the ASAN etc > usecase? Wouldn't it be instead possible to add some prctl to opt-in the > whole ASANized process to deliver all existing segfaults as signals instead > of -EFAULT ? Not sure if it is an "instead", you might have to deliver the signal in addition to letting the syscall fail (not that I would be an expert on signal delivery :D ). prctl sounds better, or some way to configure the behavior on VMA ranges; otherwise we would need yet another marker, which is not the end of the world but would make it slightly more confusing. -- Cheers, David / dhildenb