From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821B4C282DE for ; Wed, 5 Mar 2025 20:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 687B6280007; Wed, 5 Mar 2025 15:26:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63652280006; Wed, 5 Mar 2025 15:26:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D869280007; Wed, 5 Mar 2025 15:26:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2DA98280006 for ; Wed, 5 Mar 2025 15:26:00 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7C999140A93 for ; Wed, 5 Mar 2025 20:26:00 +0000 (UTC) X-FDA: 83188628880.03.08D2502 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 02E52140013 for ; Wed, 5 Mar 2025 20:25:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rya/Xoqz"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741206358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwgrm2L/15Tg6ALap1GvUzptrkdyaVeJITaCdfXsz3o=; b=xgmZ0vnV2YwjFwIc6ql4i1wFpPN4f5s5CETbPb+WE4O8MO/x+X4KGvb1NdWuj+wDsvbvGx N3PhbAofYwoeFGlSi5xLxeb1rGaiM6FEWK9UROmsEr/mMop3EkhHiL+PKNpVSB0cFbSExZ UoPV55FXmr8bgEVvAVtBDRYzAUcos6c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741206358; a=rsa-sha256; cv=none; b=cAkYL6xIMLehnjG4YFYlX9eNl3ri97Jq5vhA36fZ311aSKyrIkAhaTep1vuUmsbRBdOg6s /cFIHl7rLBRifWmADpnvoDJIoJp5JbPPaECFZbsOhsg1CtuAqvtAWTKQGyTancUtx+UjTW q0A2age/yq7FTqW1DuGxt/vKRNWlw8E= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="rya/Xoqz"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Wed, 5 Mar 2025 12:25:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741206355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fwgrm2L/15Tg6ALap1GvUzptrkdyaVeJITaCdfXsz3o=; b=rya/Xoqze+07g8TcY+VGyxWhPoUyvkJXnG/JF5LlCx3/Z/QU50WSXxtfpFpqVxGKw9miJg Go8CM6KcoceSQcV5kGqdtYF6cJxqapvikFTVQAw2fydQjgq+Gsfj8D3o8mqp4qdmSM8lWh hpz1NM3MDREt5qVMQN5qJzXu2CPycvY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: SeongJae Park Cc: "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 01/16] mm/madvise: use is_memory_failure() from madvise_do_behavior() Message-ID: References: <20250305181611.54484-1-sj@kernel.org> <20250305181611.54484-2-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250305181611.54484-2-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 02E52140013 X-Stat-Signature: oqje654rk51uu9w4b1bixox87akorckn X-HE-Tag: 1741206357-858886 X-HE-Meta: U2FsdGVkX1953kx55BT7mtMVaVOdogEFKxGSr7xLyO1kCY7XUIa5GdgbZZOAVm5ifHP0J3XI7Lw6LIODFI4MqSPiTgnp5cuFSv0pmX8c4L6brSGY4vBHhmBXy2fCmlOFfpP+7ubxoE8CFQdJaYnmzKiTTz+G+T+batWrPdwoERK3H6w82DZkHc2qfpZDnVMfovKeBfLO5rNGN4vntpuKdwpQoBPwlGyJWxIAvA7zHNsIbTYoNSRVgTFWaEU1/7BdPIgrZdhXUxfiDOGqeH+T3Cy4frrAD/0Fkq8+nFuIqUzoVOV/rkQ9icirfgLUae+3FejWqqktnHh+UAb9UfMsVN0bMUFgd5OQOt+zPGaj7isnXDUeRDj1o9Yf8+C/4v/gDYrL1ERq3M9C+C/FE8u9hOrWTxkwGMhkMlZEto3x6tG3c5hghHcywYTatWACGz3w9W3tbNKyF3CVbU3156jHUgiFoB/hFsv9pwC0xgK/681jhMKYn5sal74di/bYRwdE9QuEZpHna8vq0huNYqejdstsMzyJBdJ8Wa/knAYfaWUwZufvFLbfQgSZ4vMHRP2YYkXhsW+inxICmfILozviK8ToqtwdDI08DbrpQuPET3b0lvdYv7mQkxn9xBjzvU9ydEw9SqbldnHgVoptmZQ+WAjc/7BI/BfWy0S+bFMSFVNtJvpFBXNOJ8Eb+tMk+tIj+TNSfhh9enag67uP2TJc5hLTR66B8RZ69QETA+tCCvw2LV9VMr38VoDf2LLdoD7ZjxvyFC+cL7QyuaJqQrt1xO51j5p5JH2lJ+8FAPpmeK+0G0XGi++ow/IDdcF1gdZjklSv65nuFebRoYMXUvRblfKvOqD2VlJ85CkNV4g+c69ByZPPT4/wR5Qy5GsYv08AHmvm9WhaMw+HLVMPs/qy5+5WRtDsesghVufHl0Qd+9Rhq+smzB1W3d8PWRaJb15oqLi4dV5d3ciHAJvu0hn /jv+EQyP RovPJx5+Wjyf/bpEOfkG7gzM8HNdcFlBIYnHriABoi6S/yqq0i282fNghpDJTcUoa/zolZl7AIReLBBdbt00TNXHsy2F5odEcUyjT0ZNIJJX0IJ8rycG5c9CtfvTEhfkZsrecS37KcMk3951+BreJG/5UgO/bX3CQi+43cEpSnDMOzsdYmgBDDWGvjLrgSQhOIYh7fHuUNJMk1iHN/jBykiWfRUGVOn7PBcRtddmOkg67Sx/NWC0JFOWzavBzoE82eevi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 05, 2025 at 10:15:56AM -0800, SeongJae Park wrote: > To reduce redundant open-coded checks of CONFIG_MEMORY_FAILURE and > MADV_{HWPOISON,SOFT_OFFLINE} in madvise_[un]lock(), is_memory_failure() > has introduced. madvise_do_behavior() is still doing the same > open-coded check, though. Use is_memory_failure() instead. > > Signed-off-by: SeongJae Park > --- > mm/madvise.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 388dc289b5d1..dbc8fec05cc6 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1640,10 +1640,8 @@ static int madvise_do_behavior(struct mm_struct *mm, > unsigned long end; > int error; > > -#ifdef CONFIG_MEMORY_FAILURE > - if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE) > + if (is_memory_failure(behavior)) > return madvise_inject_error(behavior, start, start + len_in); You might want to either define empty madvise_inject_error() for !CONFIG_MEMORY_FAILURE or keep CONFIG_MEMORY_FAILURE here. > -#endif > start = untagged_addr_remote(mm, start); > end = start + len; > > -- > 2.39.5