linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
	linux-mm@kvack.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/3] maple_tree: restart walk on correct status
Date: Mon, 10 Feb 2025 09:20:46 -0500	[thread overview]
Message-ID: <eocka6tfszyzfbokaolwkwp7sxec6r7siuxhjydvwwf7lxxadl@gu6ekt26h4pe> (raw)
In-Reply-To: <20250208011852.31434-3-richard.weiyang@gmail.com>

* Wei Yang <richard.weiyang@gmail.com> [250207 20:26]:
> Commit a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW
> states") adds more status during maple tree walk. But it introduce a
> typo on the status check during walk.
> 
> It expects to mean neither active nor start, we would restart the walk,
> while current code means we would always restart the walk.
> 
> Fixes: a8091f039c1e ("maple_tree: add MAS_UNDERFLOW and MAS_OVERFLOW states")
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
> CC: <stable@vger.kernel.org>

Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>

> ---
>  lib/maple_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index d31f0a2858f7..e64ffa5b9970 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4899,7 +4899,7 @@ void *mas_walk(struct ma_state *mas)
>  {
>  	void *entry;
>  
> -	if (!mas_is_active(mas) || !mas_is_start(mas))
> +	if (!mas_is_active(mas) && !mas_is_start(mas))
>  		mas->status = ma_start;
>  retry:
>  	entry = mas_state_walk(mas);
> -- 
> 2.34.1
> 


  reply	other threads:[~2025-02-10 14:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08  1:18 [PATCH 0/3] may miss to set node dead on destroy Wei Yang
2025-02-08  1:18 ` [PATCH 1/3] maple_tree: " Wei Yang
2025-02-10 14:19   ` Liam R. Howlett
2025-02-11  7:48     ` Wei Yang
2025-02-11 15:23       ` Liam R. Howlett
2025-02-12  0:26         ` Wei Yang
2025-02-08  1:18 ` [PATCH 2/3] maple_tree: restart walk on correct status Wei Yang
2025-02-10 14:20   ` Liam R. Howlett [this message]
2025-02-08  1:18 ` [PATCH 3/3] maple_tree: assert retrieving new value on a tree with only root node Wei Yang
2025-02-10 14:18   ` Liam R. Howlett
2025-02-11  8:02     ` Wei Yang
2025-02-11 15:25       ` Liam R. Howlett
2025-02-12  0:41         ` Wei Yang
2025-02-10 14:31 ` [PATCH 0/3] may miss to set node dead on destroy Liam R. Howlett
2025-02-11  8:11   ` Wei Yang
2025-02-11 15:28     ` Liam R. Howlett
2025-02-12  0:49       ` Wei Yang
2025-02-12  0:55       ` Wei Yang
2025-03-04 12:07         ` Wei Yang
2025-03-04 14:45           ` Liam R. Howlett
2025-03-05  0:32             ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eocka6tfszyzfbokaolwkwp7sxec6r7siuxhjydvwwf7lxxadl@gu6ekt26h4pe \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=richard.weiyang@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox