From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A55E77188 for ; Mon, 6 Jan 2025 11:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D6026B0082; Mon, 6 Jan 2025 06:59:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65C7D6B0088; Mon, 6 Jan 2025 06:59:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D5D16B0089; Mon, 6 Jan 2025 06:59:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2FE386B0082 for ; Mon, 6 Jan 2025 06:59:34 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C03BC4546B for ; Mon, 6 Jan 2025 11:59:33 +0000 (UTC) X-FDA: 82976882226.19.0F54122 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 1A0F114000C for ; Mon, 6 Jan 2025 11:59:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CP4xZKwv; spf=pass (imf23.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736164772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q8CWIvfCbRU2VOC6M53tAcdryQCm0sqO3dF0oY4eudg=; b=cNHfQTZjXK1xCj+pW5aMnNYt8AXT6DVtg5hJHhZompqj2lCdySk0R/iHPOK0GmxpJV/cWp OMdgPLhMM738eENcGKoWHs/qmNBhqkI5gIAcZO3+dtLQNXuGOGjH7mkHP7OlAK+1Xe2TrN VzTvnhr7ElsBH0O8SLzhEkNede3bb/w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CP4xZKwv; spf=pass (imf23.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736164772; a=rsa-sha256; cv=none; b=8QHiir93ydpkF2pUMYzud0QwtOBuaW5s75azMANhF6Ym0A8wd5ct/nY/ReqUSJiX+s8SW5 rQgRljso+8GLIhB/jC8Fb68q/rpYHg7kju9rCj2DSewj9Ze3a5MOUQ2IV9CMdD9I5lAIgM 6ZpQPh1+zi/+RTULTRcFfjwn3tScgIY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BD2565C5E51; Mon, 6 Jan 2025 11:58:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19F5AC4CED2; Mon, 6 Jan 2025 11:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736164770; bh=V3UI3pxRy5iNtJCoL0NaOG5gDruTQVT2IoIJ4kD3Q/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CP4xZKwvSKPXpdL6WQezLv7buO14myH/Eg7GLBppcd4uhHRyU1mMf25JQAGreU7pC 72P1c9I14dcTxUG8mOh/zkeKchsfITBN8xqL0vPnRDfglHsQB7VpmVelun4FEnHFhB ijta7qDDHZndv7aRnY70jpQowzNTI5Hq5maxG4HdN2dKPthAMSf/5Hc5C48ndnIxpz AhEFvkqePFmebeQC4XnT+gOiQNSyq376QkqleqbJCkM5c6nfU7xirOJpp75RJuhhp7 VyXIpvQtJOL7b7gcy4zGToM+KklyqrjYBXljZzOuy9mbniKSrhYLP2PdBSjh0nbtZS Tcoyda4SzZedg== Date: Mon, 6 Jan 2025 12:59:25 +0100 From: Joel Granados To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v4 -next 14/15] sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c Message-ID: References: <20241228145746.2783627-1-yukaixiong@huawei.com> <20241228145746.2783627-15-yukaixiong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241228145746.2783627-15-yukaixiong@huawei.com> X-Rspamd-Queue-Id: 1A0F114000C X-Rspamd-Server: rspam12 X-Stat-Signature: x1efy5bkf8n85dxyn8sheet6rhb4dtey X-Rspam-User: X-HE-Tag: 1736164771-406794 X-HE-Meta: U2FsdGVkX196ALId/4lvoPeUfq1+srqLylQlREKD1BGbQ2Y5IIsO6ujvjK3fx3yja7+XKh/fbmsdk6k+gdGugGvi827Ok1voDd/o+RbCM4E01AYgE1ENfQ/TKm6AjZlrDIifsEi8qRIpnRjw+7s6spjr1ffUrMRBOwtnK17E5bmlEIvZnpf+6lHWN80pxLDEHrqSpwUel1d9ZX0pvqED5UIGlvsDwZdWSTVtJZbRrUXWlF+RTLyJ7sZP3BFKPLxs9guBBfrRyMDwJmeLwigfFpdmzyTW+7zCCUmv3DwjB0n0CdW/lP6pcvVIIVJgU6uMxeo7WZr5G6obSfxTDWLb9VP23PfVhWpJA//HtRmDzzgmoL0/uywZpQoRrmeLlvRXSSV7nqknxYszW0PeSH9LPOkHUl8qDyDG96pI5Bd30SBnCbNjcqyLX8+brWSB+vcRud19IF9R3ahQ7vQoS65XvJqWrHYKO4IzsxFzhFA9lX/jB7m7wqDT7xOzjfm+14FRog9SqIwVR6o4LyLItXOR+LqfnFTUYfh3OUJCrO3s7+3CpSZJibHmgBDPBcMg64XelPKaKGi7YC9h5uMRpJSJe9xuNzY+GUhPjW4VBN1544LW1L8ceGbU1f6ABVTkITJhwy+WByS8wMZnmizAV5f8/FedaHABgjPifZMcLItSH1aBDESfW1Q5iz/DA17Ae0HVaDx5EXsad5YWmayaScODONghGHPWj9BOIbBGwJpOvqIBU2G4KEu/7GOfo4sO5fuDMX/GTmCpcUqFovCFKUyn3H9ytQDLKpv56OUCMFEYbsycwwyMRK3qaRkbxvo4hL8o1lq8pCSlbbo1HHJl+ETy+rFBIgQQW04GCP/JJJm4hWa+DssH+JGxdU4GFjOSkbJ4MRiZIRbPs0fStHrROZb3woMb+rinI5BatM3cbfyzb0UA1R3CHF12lsbB6bXokFCv936xm3j3y2ddJS8QQKP ms4YNjCp oYf3Nc/Zi2fKTdAsahqfAM2f91ZFsUCcWjeRBc6hVe7ZkglxGyc80OEtpd0lJT8VKLQi8/FU9ktklm9y1sWoD2wPJWzln7uXcebF54P2aSDAR6qP/nwn83rEifI55A5ybDa+CNKuoKJh3wjBUOyl4caUJFoJJzHuhfv/lx34PsQyJC3CoViQAcOpQf3vYIsJngnMVMn+6jp5OlRhm8w2MhsLQBDIqGI0qN4yRu1pnIncxQmLZoAaAXp9Q/ohRzUU3maa6u+JuJK6E5KSLAUvba37gbUgrz9cfDPTCGTHnpDxDs0U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 28, 2024 at 10:57:45PM +0800, Kaixiong Yu wrote: > When CONFIG_SUPERH and CONFIG_VSYSCALL are defined, > vdso_enabled belongs to arch/sh/kernel/vsyscall/vsyscall.c. > So, move it into its own file. After this patch is applied, > all sysctls of vm_table would be moved. So, delete vm_table. > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook > --- > v4: > - const qualify struct ctl_table vdso_table > v3: > - change the title > --- > --- > arch/sh/kernel/vsyscall/vsyscall.c | 14 ++++++++++++++ > kernel/sysctl.c | 14 -------------- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/arch/sh/kernel/vsyscall/vsyscall.c b/arch/sh/kernel/vsyscall/vsyscall.c > index add35c51e017..898132f34e6a 100644 > --- a/arch/sh/kernel/vsyscall/vsyscall.c > +++ b/arch/sh/kernel/vsyscall/vsyscall.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include > > /* > @@ -30,6 +31,17 @@ static int __init vdso_setup(char *s) > } > __setup("vdso=", vdso_setup); > > +static const struct ctl_table vdso_table[] = { > + { > + .procname = "vdso_enabled", > + .data = &vdso_enabled, > + .maxlen = sizeof(vdso_enabled), > + .mode = 0644, > + .proc_handler = proc_dointvec, > + .extra1 = SYSCTL_ZERO, > + }, > +}; > + > /* > * These symbols are defined by vsyscall.o to mark the bounds > * of the ELF DSO images included therein. > @@ -55,6 +67,8 @@ int __init vsyscall_init(void) > &vsyscall_trapa_start, > &vsyscall_trapa_end - &vsyscall_trapa_start); > > + register_sysctl_init("vm", vdso_table); > + > return 0; > } > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 7ff07b7560b4..cebd0ef5d19d 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2012,23 +2012,9 @@ static struct ctl_table kern_table[] = { > #endif > }; > As you mentioned in the commit message, this patch has two objectives. 1. It moves the vdso_enabled table and 2. It removes the vm_table. Please separate these two in such a way that the second (removal of vm_table) can be done at the end and is not related to any particular table under vm_table. I prefer it that way so that the removal of vm_table does not block the upstreaming of a move that is already reviewed and ready. > -static struct ctl_table vm_table[] = { > -#if defined(CONFIG_SUPERH) && defined(CONFIG_VSYSCALL) > - { > - .procname = "vdso_enabled", > - .data = &vdso_enabled, > - .maxlen = sizeof(vdso_enabled), > - .mode = 0644, > - .proc_handler = proc_dointvec, > - .extra1 = SYSCTL_ZERO, > - }, > -#endif > -}; > - > int __init sysctl_init_bases(void) > { > register_sysctl_init("kernel", kern_table); > - register_sysctl_init("vm", vm_table); > > return 0; > } > -- > 2.34.1 > -- Joel Granados