From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B91BC5321D for ; Mon, 26 Aug 2024 06:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23B256B042C; Mon, 26 Aug 2024 02:49:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C52C6B042D; Mon, 26 Aug 2024 02:49:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 016EB6B042E; Mon, 26 Aug 2024 02:49:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D2F276B042C for ; Mon, 26 Aug 2024 02:49:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4ED7F1A0CA2 for ; Mon, 26 Aug 2024 06:49:07 +0000 (UTC) X-FDA: 82493469534.03.326826E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 09AD8A0005 for ; Mon, 26 Aug 2024 06:49:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dmRdLM65; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724654882; a=rsa-sha256; cv=none; b=U8Fymh0bAr7oWtvcCPqHftQOlMFaov2yK0ybLcO6/OQfFzf9I2UcNKWAk8imJbctk2ERIv K9Nl5c8/JnyS/RJ4Ko9YzlU/mHIxr8nQKKrYdhLA5z3LaCcbfjgyszF1YSSOoQQJR1iKSE CNHLmNfxFSxgtkdSVYcsJXz409piGBQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dmRdLM65; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724654882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9Za28ARncJb1ft6Y96OOTZ2p3gpMLY9nzc40/2R/vK8=; b=En1I5R5HP+hZ4F0VyGZVwqlIz76MKxQ3SOatY8t9UvrXP0hqqMIP+deb3zQ7JT45m9bMnO al/P6ct3G/En4Q6LHBoa5aoPDycbx9HpNblz04Soiv/H6nA4wVc9YmTQPSHH278uzHE0Tf B3s8WL6g0iHaxjEX0DgG3ipVnu11tm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724654944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9Za28ARncJb1ft6Y96OOTZ2p3gpMLY9nzc40/2R/vK8=; b=dmRdLM650qJSRrY+WYWJLjl5+VlIknDZuoRRwCrwVegFJ+NDPUvQrRHIJNNeJxjFEttMWE jZipEdJU6Q4L5RLOaRC7sh2BXkiBjjUqPUkdoct8CS4A/wveYFvfR3/ty9bedbjgB5yELc 9BWggjlrYX2P9buuFjRjA/fM++xkEOw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-tAKqrr2zOnadNT_JzVIk6g-1; Mon, 26 Aug 2024 02:49:02 -0400 X-MC-Unique: tAKqrr2zOnadNT_JzVIk6g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42816096cb8so45001785e9.0 for ; Sun, 25 Aug 2024 23:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724654941; x=1725259741; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9Za28ARncJb1ft6Y96OOTZ2p3gpMLY9nzc40/2R/vK8=; b=qbxI61UaBU+eNcIq0LA+i5v9HIDg5zS0hxPjR+/il0i91kRSofTZOdmhlrq3O644n0 e3DY2VBqRtqLk45hIn4SbyawEVRLPK1mS5Op1BltLgWiC8cgZzzAatgcTkRkaq7V/MIS JaINoGI+9ZzkjEN3cufUCEhcm2/M6LEg3uIMyIjRcct2ekdiJEL1PWs7a8rsA5efOY4a QEdcT6hqO85XrIaYJEBkaoEBDwcd19prLGX8fwyH73R4kJoNs5LflyeFQgRd3QAhRnhq 94OADlDZRnxajq9wkHMhcpV1cHzpgoOtobz91BoXeYjuk0Kh1hLPMnShCU18+oZ6zkaA +L/w== X-Forwarded-Encrypted: i=1; AJvYcCUf33y7xMTvlRjbj/8aCw678P55bvUPWJQz3PcDWZwl3pyRK0dnOscbm/sRwABFYHyYqO+Ue44LqQ==@kvack.org X-Gm-Message-State: AOJu0YzK/Q5YL9G01YblKYBO/arDXfDhiDFzywsXaiqik16ngTaEl348 6DlqKu1+B34fw7eZs0DtrvHW+NC8qdAegHXH2UQGpHFud5YaFzl93tMxNogWvcRF+oMYvO09V2x J7oGuTXjhWJFkbF9eBRhMyZiaeZKqj6yDxz2GuN4c+SchjK8B X-Received: by 2002:a05:600c:450e:b0:426:61fc:fc1a with SMTP id 5b1f17b1804b1-42acd540cbbmr76895765e9.3.1724654941592; Sun, 25 Aug 2024 23:49:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFruCCuhufOKQsvLCK8uxlZk8YfAkrjSPcqh2CDp51XnShl4zepD0E8tfxFKkbWIS54+kVOnQ== X-Received: by 2002:a05:600c:450e:b0:426:61fc:fc1a with SMTP id 5b1f17b1804b1-42acd540cbbmr76895555e9.3.1724654940728; Sun, 25 Aug 2024 23:49:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:c800:cf71:2042:6051:e26? (p200300d82f12c800cf71204260510e26.dip0.t-ipconnect.de. [2003:d8:2f12:c800:cf71:2042:6051:e26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ac935211csm126624775e9.47.2024.08.25.23.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Aug 2024 23:49:00 -0700 (PDT) Message-ID: Date: Mon, 26 Aug 2024 08:48:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: fix minor off-by-one in shrinkable calculation To: Hugh Dickins , Andrew Morton Cc: "Kirill A. Shutemov" , Baolin Wang , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 09AD8A0005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: cgz6o4dd1n9jwdaykptt67g6mx8nymmy X-HE-Tag: 1724654944-316824 X-HE-Meta: U2FsdGVkX1+zKO/7fsw3fNtDu355sE1I+ICtptQzuYQbk5c/PxDFQhmlcM3jHlYrDtKpngX1bUvaJ1SVe9XWqbTcjHUdbZ95j2EExMGuCLzlg1h+114BxHkc8Q5FpYI7pplOA1lSJTq7uDvLEl4RXDnpCrB27U6tDRdDYL5jMLmoEXudQImY1IYzp8N1PtEhf0enbX31RlC/JwF9jBRsR88LanxBoYVVNV03OZcZ7FZ/d6JRe5+zsZG7Oi4PH+z+kwyYaGVgsdJGfMG1wfHBj6NS3b67KVFHy1VA4FHjxGgbPIhkaQc/JZAjo6PPGxPboSgvek7Ocv+AfxpfuNy6M54ZB//nwAPYIcOZiKBwaDD6Dn5Z86pXd50iphQX1heHw2YRMQvwFdjvJE4XLJq2jQNjkSUol7O0HvZskwG8eNwn5f1pPKIvM/horliiGsOBLum9J1kKVFcuHF7+ZYjT9g1IAGU/fjn4qrwt7g2sJ1Ys7A7pqjHechYJpFq/3Eb6C7bUDaQE1tPniSBSZhl5W6EinCeqXFPpzke5TwKsnI66eH9udCKli5R/ipHLbYyVghstKoTnd9/Xmm04rJS3DanG5t6AeuYjRGIcVexeN4dqM4Nb090Cs7CV8ao+LYAbKJVhPf/p6d+/G9C+O0n7NjnhNRlN+C4Y0eOBE7vCLQeSzweXef2cR4YPGLyRG4XAIjlOSEPbO9fpRkf9/lIH522sfi83nSEAXGqCCK2glRzloGLRgZgQIm5p+Wp7r46Cv9GcxYwt2cmSYjl69FEzRmf6Zlwwl3Jr+j0CKpBhTNvzrHL4M/oDa4stBMzAIc4cCquu+Ve/ETlRWnMnnIvknZq4rOyqVUv43K9h5bU4ivwdpu9gAXz5r1PWspVxAbASZEc71+zEPISnPsA6nSKdSkiMxyczbnU4v4Um5rlpfWeoTS/NcQtLGWdY+bggoMR8ac0oV7bOTHTmIM2PIzA VJgVWxqZ xGX4/A5+CVIkzHRHB41da+N4jXiCUD6nOcZjYkeOfb2ImqkFmAKv9XBXuZP/p6b7W1DbO5Tf6/mAllj6Rf23J2kAzgy4zTLtsCgtevTcnYleRdpRQNdNMcaxqH9GCHSpFMszn/OxbVZpZDDyybMVgEG0hIv/uzC3O1jb6zfvtPDiFSQ7Ms36kasobf1bi2EJuM/icqDS/J8+wJ6GgiXtOhMHD6nFg//VgNf313EcZxblcmjqYab/PFrl0MkaVu1SyVasvd0cWgRV9kAEfw3CYsNId0q/MLi5aEvA3NDlYDnlxccWOqVpC5AUh6VmLk6WKNKac7/nwwTmi9vn7RA5oojzRJc2AM6cOSBhfSmkmWOLSvJHT+QWU4TDf28ZEavpODKG+eBdUjwmDHd3Vs4OjrDivSkcFTRsoOaPA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.24 00:42, Hugh Dickins wrote: > There has been a long-standing and very minor off-by-one, where > shmem_get_folio_gfp() decides if a large folio extends beyond i_size > far enough to leave a page or more for freeing later under pressure. > > This is not something needed for stable: but it will be proportionately > more significant as support for smaller large folios is added, and is > best fixed before duplicating the check in other places. > > Fixes: 779750d20b93 ("shmem: split huge pages beyond i_size under memory pressure") > Signed-off-by: Hugh Dickins > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 85e3bd3e709e..37c300f69baf 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2326,7 +2326,7 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index, > alloced = true; > if (folio_test_large(folio) && > DIV_ROUND_UP(i_size_read(inode), PAGE_SIZE) < > - folio_next_index(folio) - 1) { > + folio_next_index(folio)) { > struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); > struct shmem_inode_info *info = SHMEM_I(inode); > /* Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb