From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D502E784AF for ; Mon, 2 Oct 2023 09:28:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E97BF8D0013; Mon, 2 Oct 2023 05:28:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E47928D0001; Mon, 2 Oct 2023 05:28:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F9D8D0013; Mon, 2 Oct 2023 05:28:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BED4F8D0001 for ; Mon, 2 Oct 2023 05:28:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 75752C01AB for ; Mon, 2 Oct 2023 09:28:52 +0000 (UTC) X-FDA: 81299996904.02.DC44CF6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 591CCC0011 for ; Mon, 2 Oct 2023 09:28:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+dSmxnG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696238930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AJJ/7KPwaOb8i7teRUVDmyTyd/EZIX0vx+LShsb9z+w=; b=k/5xbOvJ4dPbGVh0eoNTsu1tOCrpDzubOD7yBuug7qeBHSITtL4kOqndvEy7T9IdJRJWXK Swsqoe+S4DWwBECsZHAm/fMLdT9H+vSNbi6utiT0pSy8qZVCAvi5fDLilkXtV8S60ioXqj 9gfEBRF5XVeXd/ZQ7AlWhcNkDKCs6v4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a+dSmxnG; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696238930; a=rsa-sha256; cv=none; b=dRc/VgmPju0Sq2AdYmIbqSWte9dxvLfEstpzPYcrITpzLt5fJL2MsMnzOwWg6FVVbgzZww QB5TdJR2/xbkYzY/yCyVJeGvB3VCTpuLgPuWm1J9HWMH8/aaYTNMKq0bmASvq2znHMpfil a9VxUBe+k0EowuJ4cZzOB6MJDEOo25M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696238929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AJJ/7KPwaOb8i7teRUVDmyTyd/EZIX0vx+LShsb9z+w=; b=a+dSmxnG21gSW3Ax1FZg4quhY5IOr7PANjy6SuHaAoJX9bk6TeWyU7wGRR2dlYMmmb6xen /aVRcig3zrBcyLGt0g6KwFVmPqWFcDnynEUvCNRj1kLQAX0KvOvKmZZapZEy3eTFjD/9E2 Xucs6FXIlcdi5uH4SRnuEM+b2XJwHMs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-1JiT7cx3NHaY-hMQsEiRMA-1; Mon, 02 Oct 2023 05:28:48 -0400 X-MC-Unique: 1JiT7cx3NHaY-hMQsEiRMA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4066e59840eso6834875e9.1 for ; Mon, 02 Oct 2023 02:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696238927; x=1696843727; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AJJ/7KPwaOb8i7teRUVDmyTyd/EZIX0vx+LShsb9z+w=; b=otZwd158XXbwQfYV/rRVG5ErYeujmdY4ikaq0Jb+xH2DqfHMpkh8up0ca36pqTEEaJ z3xP3cNfawfWmmh7oTGSQA8YecgPym4JkfOuypSnFTXxddMbti32TU8CqEiop13wLmr9 dcKvYcRgXZLzEYP9jeJ59MYlrl9Z+1irdECJwIfBR9KDPyEMlFGl7f50K9qeELVw3L3p +HShyBF6I3plvapqylIPCKNufzKgELt2+PkRptEzmFuuw5aFleMEiMFQTNSP7hSWO+J3 gswWeJkAFM1ocdU7rSywBYad6FjQIZFKiAI506L605s4+W0vYRMhBBH/eaf3MOaKPI34 r2tQ== X-Gm-Message-State: AOJu0YwaWMfnii9fXkGBubFcvPow8wlmZi3dLYFM+qG3hFPw5H5HcTLK FDwJB4LOyESMJWt6GjMBv9v5PqHrd1ljSWg0NbkYst5I9JGvScGz75fMecjpRuGIeLY22Aec6DY DoPNzUKZKJKg= X-Received: by 2002:a7b:cbc8:0:b0:3ff:ca80:eda3 with SMTP id n8-20020a7bcbc8000000b003ffca80eda3mr8982363wmi.10.1696238927129; Mon, 02 Oct 2023 02:28:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmhn8B8uW4T+AICrNUjuxaqcAcDPKrxy0MVMZxpv82pLtYtPKE8QMU+0CJ7y3jMcfBPVswXw== X-Received: by 2002:a7b:cbc8:0:b0:3ff:ca80:eda3 with SMTP id n8-20020a7bcbc8000000b003ffca80eda3mr8982347wmi.10.1696238926766; Mon, 02 Oct 2023 02:28:46 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c489100b003fc16ee2864sm6835636wmp.48.2023.10.02.02.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 02:28:46 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 11:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 1/2] mm/memory_hotplug: split memmap_on_memory requests across memblocks To: Vishal Verma , Andrew Morton , Oscar Salvador , Dan Williams , Dave Jiang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Huang Ying , Dave Hansen , "Aneesh Kumar K.V" , Michal Hocko , Jonathan Cameron , Jeff Moyer References: <20230928-vv-kmem_memmap-v4-0-6ff73fec519a@intel.com> <20230928-vv-kmem_memmap-v4-1-6ff73fec519a@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230928-vv-kmem_memmap-v4-1-6ff73fec519a@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 591CCC0011 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: cy4hektf6qszi3zp6j6w3mooith9r6e9 X-HE-Tag: 1696238930-970856 X-HE-Meta: U2FsdGVkX18W2TBynf4IHQNJSrUlW/J8IofaR6N2YUC2EmOMUKquf9YxOLEplHwDWffvNbQr/nkzvSXCzDWxeAP5VFdiWW7q/KBSjEOlyu1pVRW6zauL+Z8OXPdtJpU0xIXQg5zphq8D/ALZyiCACausoTweVSpAK//1wLeuu1hLj5brpzKNhmUscfy1Y/Ls9ElBldoUMPDdBHUfDt2tdoenf5cfUFvE680B6fVB1kie47cye+EGaR4IodyB/3K7aBaeVdq8xM8LGv30VoHfRnVaWHnsGPLWr4Mg+ztily2qTtL2r99JuvQg5aw4oEmkOlVll2d5zHnh1AbAul8O5dZUkSBMr4XWofcy3xbCPlL5rQaVuC6C4L6rURZ+AE2CQTi9hVJ8TJGkG9+JiWB7seg9lRz4WOerQAK/tchFqQy9jN+dTr5Niv+FtXSnx7xQnxb0qEo3dhMxKpv/BOyEp80gy+C1IKMABvzSUqu2ARJLJi9UDeahBJWPl9l6sUPPjLqqdU1YyvXTZsqB98Qb6ZBWUG5cAlKzzdglXirKATowwCTSlnMXA5NxwK6IWZ0NXf2rJue8OixfrkmPDDB4alPWSl0jGpC5xMjz8Zc+GSaJNNNv+WP2miLDfmu97eArPnQ2U06qmh2RJIxiHUzy+qJIL+3KGVk0nckNnT9EXnaSblfw3CHGJpFJXWTBeczA8Py7vTP7Za0VJYlw3nfP8Q3/S0yfcadigxJbxy1v0aLGJqRv0039zjzNOMLXT5m/40Z4St5MMe4PuBIaXv9GBOBxihqgafbo5OyIpFOq1E6g7r+2ErShVsAU5oYul6ZVfPdhxfaLnGvd/fxJEaNTD0gdSTK/eW+kWFJc9m5Qss7+++4SrIZ5tN9MOUHwp8Ee1tfOHOdTcUXvHvpQCkBOTsH5wEBcZDe0g2nsruMRVi0siqawdhTO/VdvhW/U6UpaReMsPKhgBZjPcTdsVSj dX+mSzhO fJRKeAQwCDH+/JIhzl9uM0PTZcaUkUC8vZMFOJanpU/0a0hiuEZ1oQRInYZAlEMNJfdZRhxNd84pmmCoWddiye6CbKRNvy1eiGfkjzbNMjK7mJi41YIRwJRhh/90RIfG94yPcRItltgBgwR8bJLCk5ny+bpkgZwloniab4/QlYzb8mPgw9VjCRuBxwbuSSvdA3oLMPZhXR0GEGiSZTP72WjlK+gUKnNXBM4xCE8SXHzRXFGMQb0cHv21oXsEkNLZieCq8kW1/z5oBlodwKJBS2DtKB1OO7E1rH5wB/wwq0uQXjsMqpDFs/BaG9a1Wk/6ukDh0w6IV/ZAo0JF26CONKqsAPrqVf470rNPDrDCNKhdtu5OzCVzD4B/W62Q0l+2oEOYNU4AGfpGPodwB26hUSEI4MvI4H3AyYzs4nDjVYiMXiPd24y0GGm8m7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + > +static int __ref try_remove_memory(u64 start, u64 size) > +{ > + int rc, nid = NUMA_NO_NODE; > + > + BUG_ON(check_hotplug_memory_range(start, size)); > + > + /* > + * All memory blocks must be offlined before removing memory. Check > + * whether all memory blocks in question are offline and return error > + * if this is not the case. > + * > + * While at it, determine the nid. Note that if we'd have mixed nodes, > + * we'd only try to offline the last determined one -- which is good > + * enough for the cases we care about. > + */ > + rc = walk_memory_blocks(start, size, &nid, check_memblock_offlined_cb); > + if (rc) > + return rc; > + > + /* > + * For memmap_on_memory, the altmaps could have been added on > + * a per-memblock basis. Loop through the entire range if so, > + * and remove each memblock and its altmap. > + */ > + if (mhp_memmap_on_memory()) { > + unsigned long memblock_size = memory_block_size_bytes(); > + u64 cur_start; > + > + for (cur_start = start; cur_start < start + size; > + cur_start += memblock_size) > + __try_remove_memory(nid, cur_start, memblock_size); > + } else { > + __try_remove_memory(nid, start, size); > + } > + > return 0; > } Why is the firmware, memblock and nid handling not kept in this outer function? We really shouldn't be doing per memory block what needs to be done per memblock: remove_memory_block_devices() and arch_remove_memory(). -- Cheers, David / dhildenb