From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CABDCEB64D9 for ; Mon, 19 Jun 2023 08:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 256CA8D0005; Mon, 19 Jun 2023 04:41:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 206E08D0001; Mon, 19 Jun 2023 04:41:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CFA48D0005; Mon, 19 Jun 2023 04:41:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2BC68D0001 for ; Mon, 19 Jun 2023 04:41:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B0D1C1A053C for ; Mon, 19 Jun 2023 08:41:19 +0000 (UTC) X-FDA: 80918853078.04.34479F8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 2A79D160012 for ; Mon, 19 Jun 2023 08:41:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JZr+TSnb; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687164077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NHYREAceAID4GY6I9tCHjlucH9SzlCuPatShlVuLLv0=; b=eWjxmyqIljJIZazuToFkUWctj6OSrWq2AcdzoI0bVlP6NTcHkL7FvgNi42Ibb3N6C3SvxU 1IUQjdJkTZK8gc2QVGroZtB7ON0TQCfIUmY9ee0xysgqfGszH6Tie5BOcCqfCH+lor/tFC DNlaIzYHxUFvjKHdmWrHUik6MiEebqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687164077; a=rsa-sha256; cv=none; b=4ZHB5VhXnN6MxWBCFmZwepwF/WC5wl1CqOu4+XaIXjtNHnqTMfsiCOtyUdVvk4xJUzsEQI k9nGK6aZHJ0Yst5I+dQDl3UmdYydEXhuQsRt1rlIJ6BZNObeEwD6r2YvcAtfPAB69OrfLa +z5cLUeuEmxkNRIOSXJVJbrMvOt/4oc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JZr+TSnb; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687164076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHYREAceAID4GY6I9tCHjlucH9SzlCuPatShlVuLLv0=; b=JZr+TSnb/snpc+ofaPvY/pLSdQNV5yrESMTqBExaTlH37Q95L5Nuo+q7z0eh+u1O3pYG7E /UTaHtG7/eiolq1apMqrPeEKIn+S2aRffjUvG4BqBTKJAWeMRkgouph83HIzz04OyIMtkz 5SXTnmPMPOOxTcvOzpt8vUknw+pCJLo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-qxRwA4FkPb-GefKjvcTnRA-1; Mon, 19 Jun 2023 04:41:15 -0400 X-MC-Unique: qxRwA4FkPb-GefKjvcTnRA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f9b19cb170so3327135e9.3 for ; Mon, 19 Jun 2023 01:41:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687164074; x=1689756074; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NHYREAceAID4GY6I9tCHjlucH9SzlCuPatShlVuLLv0=; b=CXbK0/c9wxayH0oSxAscUSQO+kXO9K4z0zsLkvDYFi8vWk63BEr8ts2UbaIaTPBwrV K1p4r466tgxJ1p5Ebaxq6J1zogtY/gisxpIWoildKcGTSORVElK001dTk/blJHnVie6f vLRw4j8Kpe2bpKzS+GHvKcelvf1tanypmklFSW5r6Yke0SEa8exgboPIbpDZIrDeWYSK d3GbQfbrLzLJ7xxgHNNcCfArgFJ/MihQyyNizZ8KZtnB3F/OiJ6ms9JcFv+Og4iFWEvm Yf2qinsdZKKN2Anvbj0Yn2ESBbQ9VkENq63SJJ2JyadnLItTpyt5G5SL5O3adzF1F7UD D0XQ== X-Gm-Message-State: AC+VfDxdBXKwYC5cPt2MkAheCbAfoe0ynpKR7LyHVfxRF2shtbSH5Mem UTZX+pZlgloo1YS0ui9aLRIKxtEPfX4azmia39lkvQ1E24gvOiOi13UUnFw3eQoyVuNMEmgSEQ8 eT2vP8LIYoS0= X-Received: by 2002:a1c:750a:0:b0:3f7:cb42:fa28 with SMTP id o10-20020a1c750a000000b003f7cb42fa28mr7260314wmc.28.1687164074151; Mon, 19 Jun 2023 01:41:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5eGrtx5haDfRL+ovx+2RlIaHgzENmMu2m4F1LkVwfdV1RC/TbyevA11DCTgj+s1OBQGlIv9Q== X-Received: by 2002:a1c:750a:0:b0:3f7:cb42:fa28 with SMTP id o10-20020a1c750a000000b003f7cb42fa28mr7260304wmc.28.1687164073738; Mon, 19 Jun 2023 01:41:13 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:7100:cede:6433:a77b:41e9? (p200300cbc72f7100cede6433a77b41e9.dip0.t-ipconnect.de. [2003:cb:c72f:7100:cede:6433:a77b:41e9]) by smtp.gmail.com with ESMTPSA id l20-20020a7bc354000000b003f4248dcfcbsm10051839wmj.30.2023.06.19.01.41.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 01:41:13 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 10:41:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm/sparse: Check the return value of first_present_section_nr() To: Liam Ni , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, rppt@kernel.org References: <20230619044403.1519685-1-zhiguangni01@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230619044403.1519685-1-zhiguangni01@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2A79D160012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gb97qq7bh81g5wnwimhmzdne84myg9bm X-HE-Tag: 1687164076-181142 X-HE-Meta: U2FsdGVkX1+O/nZIT85QKZRenGr/LaxIGE/lF9D5dAle5v64CRvsPUo+9Bu5pqh9n0y+TRBRS5zZEqGtzSmmG0z0p8KPoyalYaNn0B7zZGeHMs1zDpfHdJjtyFqNvB/oPV0Y31pW+3ADkXVZ/7izyswIZwJVEbq3B57/UU/szNRn25eZtPxE7+ZPuJwlKpeXKWExXEd0qJGQZAKKUEfYZMrASd5VO4qRyVsb1j5z/YUJZix9ARIkNW+ENsMZN/0HwrAI7Fqo5QWqatE9vjIs8GAUiTb/unIYvpVNACl8UDyLQ1bdWAe/fNXO2j3vGPb22LHcWa/wA1nN/+I8fJ6eItvD54om0JmItwLko0ASa5sZhQp8i+xTABSo6A2RNNMy8/HWuhmZrF4VeSUKYRPoCh5ADhUvtYkvH3dbJNuggZ2z1VMqT1pBXx+cPpJWNT0Vb2X6ha0wUr27ifW8mA1XgRDBA5tO9jfNZEc15yIsZoYO26qXtzvYDQHibw5N2rBJQvh8/NaxcLFMG0naCu7y2LLjiIGHPgJ76eu5jLUbELXVC/Je84gMcdu+T1VxIs/35IZZqKobq8q9u0pQoaom8KCSXyLH+HjOEez8+DLQtffmWO/+OOn7e1fVat5NdOcYbMk171gVuoEN+be2NjU0lAKQ+TQHXsklh45/XHyUoJvJsxQ1Zh734jk3GLKD9BkQCsALCrIF6YLnAnuxW182jHGfSOv59g+8R7NKXuffXNZiZs5LzBOp/FgamVcrjTLl+UJqhpIE7yDlUfvM1QsXJhjPsktKvgDkzF7u2GuxIEATPjkyD521p7OU1UgFH4QWOp0K9L9y5/NLFI14xZ4T6uhSGY/T2VH9vPxVTeve6xyr7Govmdm/rxuYzIipgGEBTHAEY6tYw0OF3boJZnhKmz7Uh6+Ur5/iqi0OB4VCxMLliQKvUsD6It+RivqLIUwQWBiPAxRAPmXMUvEfJ7e EbRL/xMx DWJ71Q8L7jk02ocjU2pIryUSatLVC5d7PrPfB+DtdjI0tUhaaqppoCcwyq0CKDHbxikDL7qc7y3F1fQ6Jvavd2HQvZJ/SXWYODd47Uz+T0sjNqDI1zBD0kpYyuShSfM+ER+fWkGKpPdDz7AupgIayyAjjrSbzqZxjrDxDcojkuQJhQ9qDG5PDemjI23ORlWfcLtSO7mWb3yAR9/lk64KM4y9vX5mCQLpXmVnV2GI3Ivdh4uDUYxM8OfW6drOqFkjsFBJpurC+aJcgGWhhjJdzKBg9nwLVLQJnnagaNSRaNh4BGX4Umkt59/FDKWv1HeeW8kk2w3FCpJEbCzxKp5HEVAzIscWslofUDOQf7nyx2ap/r9SaPAYs7H6SOxnE51QSRQ/ugxhDzU8gyvk42BkQiJg2kqdOEmjOZ2Ax/EOHwWrjZyqUX7ZAsreiVpEkUslYaazuJFTwF07XmLc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.06.23 06:44, Liam Ni wrote: > first_present_section_nr() may return -1, > which means there is no present section in system,or other errors, > so we cause panic here. > > Signed-off-by: Liam Ni > --- > mm/sparse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/sparse.c b/mm/sparse.c > index b8d5d58fe240..175727e10deb 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -564,6 +564,8 @@ void __init sparse_init(void) > memblocks_present(); > > pnum_begin = first_present_section_nr(); > + if (pnum_begin == -1) > + panic("There is no present section in system\n"); > nid_begin = sparse_early_nid(__nr_to_section(pnum_begin)); > > /* Setup pageblock_order for HUGETLB_PAGE_SIZE_VARIABLE */ That would mean that __section_mark_present() was never called, implying memory_present() / memblocks_present() was never called. ... but sparse_init() calles memblocks_present() itself. So what's left would be, that there is absolutely no memory in the system such that memblocks_present() couldn't mark anything present ... which sound pretty much impossible, unless the arch setup code is deeply flawed such that everything else would be broken as well. Don't think this will ever trigger, and, therefore, this is not really required. -- Cheers, David / dhildenb