From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6D1D2AB3C for ; Tue, 29 Oct 2024 14:04:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93DE46B008A; Tue, 29 Oct 2024 10:04:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED3A6B008C; Tue, 29 Oct 2024 10:04:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 766916B0092; Tue, 29 Oct 2024 10:04:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 58EA26B008A for ; Tue, 29 Oct 2024 10:04:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20D9D1C4B53 for ; Tue, 29 Oct 2024 14:04:09 +0000 (UTC) X-FDA: 82726807800.03.A5E45A3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id D607A1C0028 for ; Tue, 29 Oct 2024 14:03:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZYeWkqJY; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730210487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CYRuefL3VGhq89sC2Hmx1pD6VzbT5PlD0WdjLBsMhds=; b=dpPyscDTmF2BEq2acAxnXyKX3c3likVT+L1GE3MrPJ4HtJJKG/oFl7HFtFvHI2KQlAij/1 Zf3HT25j9dAUrZ4ZwrAiHQVXSU6+9n7xAIGivXTzzzP3UNZZzGHhwhtKp/wu0VOpZbFdKO tBZOuw6Jh8wC5ibx3EpTvlhsW6vtaNE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730210487; a=rsa-sha256; cv=none; b=P0i1Th5hAhsE7PER/aUvI7O8pygwQXlCgbS6sd8a+8U6Fv6Y3BguOcFwFIA7RPn69QKmtw RQvK8ZoJ4RT0v33zJqAe9HI6VaOkgV1+UCjRqCyXVeDemZvDCBmJoNyuab8eXAg8iYbZjN daZJxQsgeXjvQAwnUqImNlbHDuzVAeQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZYeWkqJY; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730210646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CYRuefL3VGhq89sC2Hmx1pD6VzbT5PlD0WdjLBsMhds=; b=ZYeWkqJYWapnhi6qQ3lD3EtBZBTDhrURDsEJmR17og46y40uFWrOQQR2AigbZluLyGIvxg c1WMNmMGhE6Bop3aPlM2eHKQCTjU0/GlqGMsa1nSCqd49txL7C+mPNY8iXU9FVFBRDFv+c r1lG3d/mUw1wKT9CUCh4TAhhCSBRW0Y= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359--uqVrhJgORKeQN65dbWSCA-1; Tue, 29 Oct 2024 10:04:04 -0400 X-MC-Unique: -uqVrhJgORKeQN65dbWSCA-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fb5cdaba8aso56983101fa.1 for ; Tue, 29 Oct 2024 07:04:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730210643; x=1730815443; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CYRuefL3VGhq89sC2Hmx1pD6VzbT5PlD0WdjLBsMhds=; b=e5kli/cC0VVpb8cI06M5sL4sVTME65ot2X4gnZLLpb0MuhyW5afyx5eEBhJ/Uq34oJ 53pm2M/56+sRLvjHLp7SdHhOH2eWtt4/BEsrp8vAAnsBV39qwn3eOv1dyF+26K+Hp88/ ecrHBcjNH7FS3ej1OIjr+yML858CMrRd1SKsXWcKuDmSOolwMxpjkKch8y6pUXT2y5aa oX3Tn+PSVxhk7s8vGkrUSPwpmuarSzd/qHqP4RxAJzedIkUFi91+/MPkPonPXGVr7rOc NF7Drsi+52rUKCdjQvTi4/bLDieNKCJHG6sLFp5RjM3YoC3cuvqC/cBplwMYuORhK4V1 Bztw== X-Forwarded-Encrypted: i=1; AJvYcCXBP75Ynu1khwpYXozqqsLwRqpLhtGskvp8Yr8mJqNxswhkqmXC8IzHgs2vhEd64wa/wfn/gLpz+Q==@kvack.org X-Gm-Message-State: AOJu0YzkHUd0l+4sClup1MsyC72zWtKk6hPGt9UFpvpbesxGMzC/0gtA P2Iih4qg9ddXNZVjxxz6KRYacHvT3b83hRorfjdUcg81yuFl1GbFREABBmCplXETwoUTlBI5beP dYVch8sLnVVUFPlYhdkmi8QrcCozSrdfQZ7PuruSTKGrJ3uJ1 X-Received: by 2002:a2e:be88:0:b0:2fb:cff:b535 with SMTP id 38308e7fff4ca-2fcbdf8df8dmr84969731fa.13.1730210642673; Tue, 29 Oct 2024 07:04:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWVTqCqzLoyRqsLRg3V2K1SAGTFKDrX2noFi1qo0af1NN6prthrYN7WBmLbAFJ70VRzSfpJA== X-Received: by 2002:a2e:be88:0:b0:2fb:cff:b535 with SMTP id 38308e7fff4ca-2fcbdf8df8dmr84968991fa.13.1730210641697; Tue, 29 Oct 2024 07:04:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e? (p200300cbc72d8500d87aed8e1e805a7e.dip0.t-ipconnect.de. [2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b54308bsm176224275e9.4.2024.10.29.07.04.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 07:04:01 -0700 (PDT) Message-ID: Date: Tue, 29 Oct 2024 15:04:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: use aligned address in clear_gigantic_page() To: Kefeng Wang , Andrew Morton Cc: Matthew Wilcox , Muchun Song , "Huang, Ying" , linux-mm@kvack.org, Zi Yan References: <20241026054307.3896926-1-wangkefeng.wang@huawei.com> <54f5f3ee-8442-4c49-ab4e-c46e8db73576@huawei.com> <4219a788-52ad-4d80-82e6-35a64c980d50@redhat.com> <127d4a00-29cc-4b45-aa96-eea4e0adaed2@huawei.com> <9b06805b-4f4f-4b37-861f-681e3ab9d470@huawei.com> <113d3cb9-0391-48ab-9389-f2fd1773ab73@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 4z5xsxc1mes51wp3rzethy9zjz9toojf X-Rspamd-Queue-Id: D607A1C0028 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1730210599-335888 X-HE-Meta: U2FsdGVkX18oDgTPs5J/mOVN6oWK0iap78P8gqfjNqyU+eFkIp289pyF5OM4WI0Xg1oC2OxY0/koLW79Q4Qr4SzRQ2BW2sM0YbfWRPZvomdveTS5zLG0cXHTrAFBkeiso+paAP/mcWnxn/CNVCB8240f6Vvnqkp8yRv48vEJjEoF7COs+6WemDP4ekCerD+f/FBr7bFqRYuVqOCASvrtrS/J1guu3Dzqw6mPD2A8dPVvr9rNCQs947PNXfGlTTCzr53NU60/X8E41auGWmkSDPsom0wlVGMq5hIbztC2RTPcJwsWtKJMtowtQe01pjLnEhwxWrRJb4rD3ryayTNdKe6GCOgihxi0TBlE8A7MTvYJ4snUf7vztzDhODLuOoyFZrKNtANf9dyGJ2hCz41b+0KmqdDGGZZE5utYBCovu2RUUcZf8Q+Zyqbkxaob71JHDJXo6U+Fs9Zi/BmCjH+bDm8ofKUUjLCucWhjgZpP7vHZqUiNrAtJV1iG6lPo8G0+qa7Y0i5aaGaHUmBk/OTSXiBfjz9XDZvpqjqb/ah6tm3pYeydnEDNwH9ZlVhXvkIJf5qrfrJTIw4JP7NaCYhSusR9GCLi4jsrBykAbYeddEJ5zl1I6gjJTL4PoJy+/xrsWsoe22sTXtbad/K3OQTQW65LlH/yM8fmNxVzcpcU0Clhnuzz/AmfpFVUtwpcMUQwGnpqjHWWlznxu06olO/tcRbDKbPcBVaHZw9i3/sz8foLveRby0KxP2UrD0peKUtfmqm4eEaiNI1o5U10BUMkY2SkzBbnhWMohoSBYOfP49uLZsW8PFCxqZiBKO7f54icot0KAFuJoFPHX+ec29FNkBjJgnrLgmuqh1P5n+VXRIHgkVQ6fFVNcc4lsbrErmF7Sb2U0WcAEfWJ68jfLxiYaibiAcGkHeTvWs3MdPgM5bjy0WfOQk7r5saLoS46iL0XGYO689oidYGku1LdAnA MnVQUI/H sD7ulpyQC8Uegk4jlOSpc0Ic5b7JX19enNPsWOTSyPKZj0G0bWGTlj6ZrT0hgkaSBFc62F6gyRKZp3qejaoCTIAXQ89OiVNzLwLnm2aBnBXZt7YCD/EFFwn40QCbgP2FnH+sjBX07R6Ipd+mWZVxNFfks+U17lQ6GW+Y127WCpH/vfAV0AeggY2kBpUafGKyXe9E9HZABnwL/UZheNCpfvzwr+O8zSacQRqHVO+xyjWWlO8vC+xdLmQWR7Wptr69loAgAN3pt1pPNyaRdaYL7h4hnS2rJnC6pKd6lpEemVn2JjU+ZLV3wGtkTc3N9slFWIKn9Z2nvU3YcYSeApsHvIhIzE4iXUFHwZA+8PhIXP464UqbIYYnRyqqlXGew/TY/cJTOTDSKFDOm+Zvw9OJ8QCyYyx5thqzjF38cye0fzK0ZAKw+WxiA2yY1MwWq+iXPzUTEv3GFdWo6kC6UZYTrStFEJnzS8hotLfbPlakyOrOYtlhfR3eSq28XB3gQ8Zj+rA/9blw/gkj7hxnLuM78FhsgD7zwhAdhg3UvJHYOET1oYbtj8pashbkRXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.10.24 14:04, Kefeng Wang wrote: >>>>>>>> >>>>>>>> That should all be cleaned up ... process_huge_page() likely >>>>>>>> shouldn't >>>>>>> >>>>>>> Yes, let's fix the bug firstly, >>>>>>> >>>>>>>> be even consuming "nr_pages". >>>>>>> >>>>>>> No sure about this part, it uses nr_pages as the end and calculate >>>>>>> the >>>>>>> 'base'. >>>>>> >>>>>> It should be using folio_nr_pages(). >>>>> >>>>> But process_huge_page() without an explicit folio argument, I'd like to >>>>> move the aligned address calculate into the folio_zero_user and >>>>> copy_user_large_folio(will rename it to folio_copy_user()) in the >>>>> following cleanup patches, or do it in the fix patches? >>>> >>>> First, why does folio_zero_user() call process_huge_page() for *a small >>>> folio*? Because we like or code to be extra complicated to understand? >>>> Or am I missing something important? >>> >>> The folio_zero_user() used for PMD-sized THP and HugeTLB before, and >>> after anon mTHP supported, it is used for order-2~order-PMD-order THP >>> and HugeTLB, so it won't process a small folio if I understand correctly. >> >> And unfortunately neither the documentation nor the function name >> expresses that :( >> >> I'm happy to review any patches that improve the situation here :) >> > > Actually, could we drop the process_huge_page() totally, from my > testcase[1], process_huge_page() is not better than clear/copy page > from start to last, and sequential clearing/copying maybe more > beneficial to the hardware prefetching, and is there a way to let lkp > to test to check the performance, since the process_huge_page() > was submitted by Ying, what's your opinion? I questioned that just recently [1], and Ying assumed that it still applies [2]. c79b57e462b5 ("mm: hugetlb: clear target sub-page last when clearing huge page”) documents the scenario where this matters -- anon-w-seq which you also run below. If there is no performance benefit anymore, we should rip that out. But likely we should check on multiple micro-architectures with multiple #CPU configs that are relevant. c79b57e462b5 used a Xeon E5 v3 2699 with 72 processes on 2 NUMA nodes, maybe your test environment cannot replicate that? [1] https://lore.kernel.org/linux-mm/b8272cb4-aee8-45ad-8dff-353444b3fa74@redhat.com/ [2] https://lore.kernel.org/linux-mm/878quv9lhf.fsf@yhuang6-desk2.ccr.corp.intel.com/ > > > [1]https://lore.kernel.org/linux-mm/2524689c-08f5-446c-8cb9-924f9db0ee3a@huawei.com/ > case-anon-w-seq-mt (tried 2M PMD THP/ 64K mTHP) > case-anon-w-seq-hugetlb (2M PMD HugeTLB) But these are sequential, not random. I'd have thought access + zeroing would be sequentially either way. Did you run with random access as well> -- Cheers, David / dhildenb