From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E8DC3ABBF for ; Wed, 7 May 2025 20:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 800766B009C; Wed, 7 May 2025 16:49:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 785BD6B009E; Wed, 7 May 2025 16:49:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FFF56B009F; Wed, 7 May 2025 16:49:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F1BF6B009C for ; Wed, 7 May 2025 16:49:29 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00B06CB99B for ; Wed, 7 May 2025 20:49:29 +0000 (UTC) X-FDA: 83417302458.13.D22EA54 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf02.hostedemail.com (Postfix) with ESMTP id DEC5E80008 for ; Wed, 7 May 2025 20:49:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QcPSW2MQ; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746650968; a=rsa-sha256; cv=none; b=xjwA0Ih9/CREsq5YNZNAlcFQ1Y/EVOjr2U+/9umDEtyN4DDeFk7tifqlm1xBofZtHSEy2Y KW7W7bE8MTCUaoO/rTOFGE6BjXWj6Otry4ouRGQ3kJsTKDc4YrTe3xUs9lxRN1+7pOTA50 S5R3QPxr4JWCYMH7dO/fbIlVc8K769o= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=QcPSW2MQ; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.48 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746650968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nbrLfo/HVOEcIGm/SsMmNRXcHh8Er8SMroRu1GzttWY=; b=OIn1TNEPL330v2+ltjTbTrZWG5Vi3C+DNVpY2M6kbp+7oOgNRcderh+B+gr2joxTTc6x7y DAVOAhHql15p+cVloX4tgxTaAAszmovOGeUp69HgOiyUmHpyfglo5CV3yiRbE3tr8m/3/y VGEcY/LMyYxoD9IIKLGtUWsM0CncXBo= Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-864a22fcdf2so13550839f.0 for ; Wed, 07 May 2025 13:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1746650967; x=1747255767; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nbrLfo/HVOEcIGm/SsMmNRXcHh8Er8SMroRu1GzttWY=; b=QcPSW2MQq3K00O/qWxKi7BVxxwrw0syIfN1x9binX1wDzQ7KmguqeEDWPFxK63zEkg FO8ktMN0Qx0KVEzqjBlWzx4lnvh1pSoiHgPjxjGs31i7wo7FrbRo2oE8UGMbkCyGkFK4 E3LtE38o2IoDbVOb9UPBYACNQtbi247a2YiOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746650967; x=1747255767; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nbrLfo/HVOEcIGm/SsMmNRXcHh8Er8SMroRu1GzttWY=; b=hbyOAVok9TEcEFQK1UjvGfDIWk1Bx0q6NwLHVJe2OsaRansAM1zT0q2/O8Ksl3ekvs umzd1n/HdI1AtaSQfq69HQsjqULUQorl/nRsv8heFeJf+YYmVomS60yTTSQ709WGOdog T4LqD/tYeF/XfiyTWr/tZhckMRC5a3E426Znn4ZHYW0EqbFZ7hntUlB2jFzKfpA/kskS kOzQ3R8FPHqMX6uvAGnXXSW3e0VzXs/UJYKTP/+eNbFOxzFUvDJ0wfbXcIk9iWcXTO4k ILIxd3tWHA15rH9rIFMqDfIBFwWiCNXgONoQcZJbMqXN/eAhW3IjUwpLIzOX7n/FCRn3 c7sQ== X-Forwarded-Encrypted: i=1; AJvYcCV1LRgS0HQ/lKflIy8BFiWr0YPer8c73izzyWoS2YaycnjAQ/EhRDXX2zts/zKS7/TXY3/MtTA1rw==@kvack.org X-Gm-Message-State: AOJu0YxjFaBO94qnzGfLeg9P4hH7r+HI9RHkogu0H2lTA/c0XpEmn3d/ e3rf3r8Ve0qfjwWuh5qCDMJZoFVYUdK0b1dTFr9XeztyveyjfEEnaZzTGn1Lkuc= X-Gm-Gg: ASbGncvY8FaSJuidUx/ShtpUvShU7BwAi3GtOgqLVPWjuNvnqtfEPX58BMuMDB7REjd Gb6ks8oPGFVA6rpMiGpyBE91W8T7i6vNkik4/TKnPdPaq0LG97tLrusLiw0WIrC4AMKwRZXiuMU fA525RinF/hd80v/zAcVOVoH57CFMiAKDylRPXzJbf8Kb+iR4ujXobk6du7/2CxglWC/LjTP+W9 ZwP1wkn1AcrkHl3Bn6WDmodA7Lo2kKNsuwU0uVtCUKZEOO570sUMflfW6qg+zbUyHuLuTZPy1Oj 3jlESAXHH3OsiC/9Vi/nAcoDEnjOeQbsMjNjZYHbjqrnjKp++2c= X-Google-Smtp-Source: AGHT+IGX4LIZdxiQGhsPmHJayBQ3t4X15bBVjp4+dG9Yr+NmPEGNWKAvicjiqoIWxW3kT3pxCS3NFg== X-Received: by 2002:a05:6602:29c9:b0:85e:16e9:5e8d with SMTP id ca18e2360f4ac-867550e2fdemr166032339f.7.1746650966768; Wed, 07 May 2025 13:49:26 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-864aa31e07dsm271901639f.21.2025.05.07.13.49.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 13:49:26 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 14:49:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* To: John Hubbard , Peter Zijlstra Cc: Lorenzo Stoakes , Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , seanjc@google.com, Shuah Khan References: <5b0b8e1e-6f50-4e18-bf46-39b00376c26e@nvidia.com> <20250501114235.GP4198@noisy.programming.kicks-ass.net> <17464a97-e7be-49d4-9422-96ff824dba7c@linuxfoundation.org> <8f765dc8-421f-420f-bd3e-1a0d889238a1@nvidia.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <8f765dc8-421f-420f-bd3e-1a0d889238a1@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DEC5E80008 X-Stat-Signature: rp3oxre4oat6q5mmuayu8jhtbs1tq8xq X-Rspam-User: X-HE-Tag: 1746650967-662951 X-HE-Meta: U2FsdGVkX19Kpa788dKwE82QxlpV53t8sBAihNBsWna448MbHB5XZkTWntlgxEVJfotEWBi8EUnV7p9nIgjtrqbCDdzIVRCp+RUcGI+JvZgYNo9qkBRr/sGfVLfmdHsLUpq7rA+FXGt879yphpddsnzUlP58BeWZdP/aKt4IuiHJHP/scu3nRgLEyypXjZtygOOkrwUakBRpGafQU3zFIGbEphx93mcACb62iXH1JizRgcfWB/9ugAsKUyBNHOW35aT4O0UXk1txGILtX2Yth8TsIzzpVhReCUcjTEoJSrkB5NlB39jD9StG2tRqqF+VZ1ycV2VgQihiXC+RpPEDaO0j6nch51pAacZxBsbqegsyVGEsDnUTJzzDmiXImWIj3n2mwHq9QFj2iQ7ieFHuUQ3nWL5b9lwHcIfdIArYi5R6/kd/TN6WS0wV1q1zIfDBwx5AOpossQOmId3WoNTKXHlGH84ZPpsxl8icvYqp1AuVxOWHmQZXGe2d/beMg7dsIYiqQ6NzaYXt01OLrjyFM0R4z9Ckqnh5+hwUHKxRLnhgGeRgykWlJCpzsbTUWMTRrzrUK3FTjuOunPc4+sK+/lq1xMKHeO0AG4bEkDVMM0ZZGb2XcxvWStKm3DP+4l3aPPhNMtq1LSzCf6xOLjGPCJT8lpGTDkgEQ1ZJ6eL8zHhRcVYkSRVb/+/YMxASbJbKOq5oAvcWtX5vRTpgflhZT7/gtdCrc2rV/RM5cW0gQ67Focpjzccf0cuyFohEqICVtW3GDJJ5fZnWT/2aCNuue7NwOFpiJWcBs8oXHOHh7H5m+bV1McVGvw+pE32B80J5rt17lH8Rs8O0/e+2I5QsLgM6vajAnkHuX5S7OcU2Pz4WswiXG4rAwFkvw5uVYOSXViGQKsSMViXFKte4DS6aTf+lX50FaiDTCUBpYme/DKBV7w572LU8TGbgexnl0RM5Nq6ohDZtXkRWpM/vNui XqhhcVf2 H9dDC0VZVj6AzHcoP0K9ZvWKSDyUkAufprPZMnMXEuKEsBhuts7deywJNg71ZEb5cLAZ/QH0hVfkuOlfDMhpVoKCaJRRQt/0dRDMJMMKicJc/ZesmQLVj9B6aPvwLm8d+NbbW7jC7BpVKW+prx1ODZfgdoxxu8U/zkeywOYF5X6aSLA6mNenbGRKeMNpR7WVC6j+ja3o9hwxfV8GnHDhArvLyfMJHsdI30M0fbpWbtj1GJoDWz7x39Nu2Ooj00DOnOtPDYK/T3kjR0+OPnIhVkqyLnDoDcgHm7Q9Zqh6WaMVvdvFizTQI/fDV3/caiQAAmHsQDcCCbVN3gHFrM2CKr1p5Vn7gOui5sZjozlaWCzyhKvyPTdRk8rpNsIRM3l+OVCgeNa9tbKBgwdAqrJaVP4x0w8FHPKT/9AOv7U89D8fTm/GNvsrYsea6Clc1V1Ci6AknWstgLthitwTC8HE1RmmIkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/6/25 15:34, John Hubbard wrote: > On 5/6/25 2:18 PM, Shuah Khan wrote: >> On 5/1/25 05:42, Peter Zijlstra wrote: >>> On Wed, Oct 16, 2024 at 07:14:34PM -0700, John Hubbard wrote: >>>> On 10/16/24 3:06 PM, Lorenzo Stoakes wrote: >>>>> On Wed, Oct 16, 2024 at 02:00:27PM -0600, Shuah Khan wrote: >>>>>> On 10/16/24 04:20, Lorenzo Stoakes wrote: >>>> ... >>> Please fix this fucking selftests shit to just build. This is unusable >>> garbage. >> Peter, John, There seems to be confusion regarding KHDR_INCLUDES. Tests don't have to use KHDR_INCLUDES if they don't want to. There are 4623 test Makefiles (excluding the main Makefile) under selftests/. Out of those 73 Makefiles reference KHDR_INCLUDES exported by lib.mk and selftests/Makefile. The rest are happy with system headers. The support for this KHDR_INCLUDES was added just for the case when a new test depends on header change. This is the reason why only a few test Makefiles use it. When test rings ran into issues related to dependencies between header changes, we recommended installing headers to solve the problem and introduced KHDR_INCLUDES so test Makefiles can use it in their Makefiles overriding the framework defaults. If your test doesn't need it, you can simply stop referencing it or use the approach used in mm test. It is a manual step. Works well for developers who know what they are doing. This isn't ideal for test rings. This isn't an ideal solution really. It works for the mm developers. # In order to use newer items that haven't yet been added to the user's system # header files, add $(TOOLS_INCLUDES) to the compiler invocation in each # each selftest. # You may need to add files to that location, or to refresh an existing file. In # order to do that, run "make headers" from $(top_srcdir), then copy the # header file that you want from $(top_srcdir)/usr/include/... , to the matching # subdir in $(TOOLS_INCLUDE). TOOLS_INCLUDES := -isystem $(top_srcdir)/tools/include/uapi The issues Peter is seeing regarding KHDR_INCLUDES in the following tests can be easily fixed by simply changing the test Makefile. These aren't framework related. kvm/Makefile.kvm: -I ../rseq -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES) x86/Makefile:CFLAGS := -O2 -g -std=gnu99 -pthread -Wall $(KHDR_INCLUDES) futex/functional/Makefile:INCLUDES := -I../include -I../../ $(KHDR_INCLUDES) futex/functional/Makefile:CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES) You can make the change to remove the reference to KHDR_INCLUDES. If don't have the time/bandwidth to do it, I will take care of it. If test build fails, you can then figure out how to address that. Hopefully build issues related to header changes are infrequent. thanks, -- Shuah